fides 1.0.0 → 1.0.1

data/.gitignore

@@ -15,4 +15,5 @@ spec/reports
 test/tmp
 test/version_tmp
 tmp
-database.yml
+database.yml
+*.sqlite3

data/Rakefile

@@ -4,6 +4,9 @@ require "bundler/gem_tasks"
 require 'rake/testtask'
 require 'pg'
 require 'yaml'
+require 'sqlite3'
+
+SQLITE3_FILE_PATH = "test/db/fides_test.sqlite3"
 
 def postgres_db(opts)
   path = File.join(File.dirname(__FILE__), "test", "config", "database.yml")
@@ -23,12 +26,23 @@ def postgres_db(opts)
   end    
 end
 
+def create_sqlite3_db
+  File.delete(SQLITE3_FILE_PATH) if File.exists?(SQLITE3_FILE_PATH)
+  db = SQLite3::Database.new SQLITE3_FILE_PATH
+end
+
+def destroy_sqlite3_db
+  File.delete(SQLITE3_FILE_PATH)
+end
+
 task :create_databases do
   postgres_db(:create => true)
+  create_sqlite3_db
 end
 
 task :destroy_databases do
   postgres_db(:create => false)
+  destroy_sqlite3_db
 end
 
 Rake::TestTask.new do |t|

data/fides.gemspec

@@ -27,4 +27,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake"
   spec.add_development_dependency "minitest", "~> 4.7.0"
   spec.add_development_dependency "pg"
+  spec.add_development_dependency "sqlite3"
 end

data/lib/fides/{postgresql.rb → postgresql_writer.rb}

@@ -1,6 +1,6 @@
 module Fides
 
-  class Postgresql
+  class PostgresqlWriter
     include SqlWriter
 
     def self.executable_add_statements(interface_name, models, polymorphic_model)

data/lib/fides/{sqlite3.rb → sqlite3_writer.rb}

@@ -2,7 +2,7 @@ require 'fides/sql_writer'
 
 module Fides
 
-  class Sqlite3
+  class Sqlite3Writer
     include SqlWriter
 
     def self.executable_add_statements(interface_name, models, polymorphic_model)

data/lib/fides/version.rb

@@ -1,3 +1,3 @@
 module Fides
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

data/lib/fides.rb

@@ -4,8 +4,8 @@ require 'active_support/concern'
 require 'active_support/inflector'
 require 'fides/version'
 require 'fides/sql_writer'
-require 'fides/postgresql'
-require 'fides/sqlite3'
+require 'fides/postgresql_writer'
+require 'fides/sqlite3_writer'
 require 'fides/database_adapter_error'
 
 module Fides
@@ -41,7 +41,7 @@ module Fides
   def get_sql_generator_class
     db_adapter = ActiveRecord::Base.configurations[Rails.env]['adapter']
     raise DatabaseAdapterError.new(db_adapter) unless SUPPORTED_ADAPTERS.include?(db_adapter)
-    return "Fides::#{db_adapter.capitalize}".constantize
+    return "Fides::#{db_adapter.capitalize}Writer".constantize
   end
 
   # TODO: Is it safe to just grab the first polymorphic association?

data/test/config/database.yml.example

@@ -5,10 +5,4 @@ postgresql:
   pool: 5
   username: postgres
   password: sqlsql
-  host: localhost
-
-sqlite3:
-  adapter: sqlite3
-  database: /Users/martykraft/Code/fides/test/db/fides_test.sqlite3
-  pool: 5
-  timeout: 5000
+  host: localhost

data/test/integration/db_test.rb

@@ -0,0 +1,66 @@
+require_relative '../test_helper'
+
+module Fides
+  def self.run_common_tests
+    describe "PostgreSQL database interaction behaviour" do
+      it "raises an exception inserting a polymorphic without a coresponding record" do
+        clothing_article = ClothingArticle.new
+        clothing_article.name = "Jeggings"
+        clothing_article.wearable_id = 123
+        clothing_article.wearable_type = "Teenager"
+        assert_raises(ActiveRecord::StatementInvalid) { clothing_article.save }
+      end
+
+      it "raises an exception deleting a record that is still referenced by the polymorphic table" do
+        senior = Senior.new
+        senior.name = "Mr. John"
+        senior.save
+        senior.reload
+
+        clothing_article = ClothingArticle.new
+        clothing_article.name = "Flood pants"
+        clothing_article.wearable_id = senior.id
+        clothing_article.wearable_type = "Senior"
+        clothing_article.save
+
+        assert_raises(ActiveRecord::StatementInvalid) { Senior.find(senior.id).delete }
+      end
+
+      it "allows an insert of a model type specified in #add_polymorphic_triggers" do
+        baby = Baby.new
+        baby.name = "JJ"
+        baby.save
+        baby.reload
+        
+        clothing_article = ClothingArticle.new
+        clothing_article.name = "Onesie"
+        clothing_article.wearable_id = baby.id
+        clothing_article.wearable_type = "Baby"
+        assert clothing_article.save
+      end
+
+      it "allows a delete of a record NOT referenced by the polymorphic table" do
+        teenager = Teenager.new
+        teenager.name = "Johnny"
+        teenager.save
+        teenager.reload
+
+        assert Teenager.find(teenager.id).delete
+      end
+
+      it "allows an insert of a model type that wasn't specified in #add_polymorphic_triggers" do
+        clothing_article = ClothingArticle.new
+        clothing_article.name = "Nothing"
+        clothing_article.wearable_id = 123
+        clothing_article.wearable_type = "Zygote"
+        assert clothing_article.save
+      end
+    end # describe
+  end # run_common_tests
+
+  connect_and_migrate_database("postgresql")
+  run_common_tests
+
+  connect_and_migrate_database("sqlite3")
+  run_common_tests
+end # Fides

data/test/test_helper.rb

@@ -8,10 +8,13 @@ require_relative 'integration/models/teenager'
 require_relative 'integration/models/senior'
 require_relative 'integration/models/clothing_article'
 
-def migrate_database(adapter_name)
+
+def connect_and_migrate_database(adapter_name)
   path = File.join(File.dirname(__FILE__), "config", "database.yml")      
   yaml = YAML.load_file(path)
+  yaml["sqlite3"] = { :adapter => "sqlite3", :database => File.join(File.dirname(__FILE__), "db", "fides_test.sqlite3") }
   connection_config = yaml[adapter_name]
+
   ActiveRecord::Base.establish_connection(connection_config)
 
   Rails.stub :env, "test" do

data/test/unit/postgresql_test.rb

@@ -1,8 +1,8 @@
 require_relative '../test_helper'
  
-describe Fides::Postgresql do
+describe Fides::PostgresqlWriter do
 
-  let(:subject) { Fides::Postgresql }
+  let(:subject) { Fides::PostgresqlWriter }
 
   it 'responds to #executable_add_statements' do
     assert_respond_to subject, :executable_add_statements

data/test/unit/sqlite3_test.rb

@@ -1,8 +1,8 @@
 require_relative '../test_helper'
  
-describe Fides::Sqlite3 do
+describe Fides::Sqlite3Writer do
 
-  let(:subject) { Fides::Sqlite3 }
+  let(:subject) { Fides::Sqlite3Writer }
 
   it 'responds to #executable_add_statements' do
     assert_respond_to subject, :executable_add_statements

metadata

@@ -1,7 +1,8 @@
 --- !ruby/object:Gem::Specification
 name: fides
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
+  prerelease: 
 platform: ruby
 authors:
 - Martin Kraft
@@ -13,48 +14,55 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -62,6 +70,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -69,20 +78,23 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -90,6 +102,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -97,15 +110,33 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: pg
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: Maintains referential integrity of Rails polymorphic associations.
@@ -124,19 +155,18 @@ files:
 - lib/fides.rb
 - lib/fides/database_adapter.rb
 - lib/fides/database_adapter_error.rb
-- lib/fides/postgresql.rb
+- lib/fides/postgresql_writer.rb
 - lib/fides/sql_writer.rb
-- lib/fides/sqlite3.rb
+- lib/fides/sqlite3_writer.rb
 - lib/fides/version.rb
 - test/config/database.yml.example
-- test/db/fides_test.sqlite3
+- test/db/.gitkeep
+- test/integration/db_test.rb
 - test/integration/migrations/create_test_tables.rb
 - test/integration/models/baby.rb
 - test/integration/models/clothing_article.rb
 - test/integration/models/senior.rb
 - test/integration/models/teenager.rb
-- test/integration/postgresql_db_test.rb
-- test/integration/sqlite3_db_test.rb
 - test/test_helper.rb
 - test/unit/fides_test.rb
 - test/unit/postgresql_test.rb
@@ -146,38 +176,38 @@ files:
 homepage: https://github.com/mkraft/fides
 licenses:
 - MIT
-metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 1.8.25
 signing_key: 
-specification_version: 4
+specification_version: 3
 summary: Creates SQL triggers from Rails migrations to enforce the integrity of  polymorphic
   associations at the database level.
 test_files:
 - test/config/database.yml.example
-- test/db/fides_test.sqlite3
+- test/db/.gitkeep
+- test/integration/db_test.rb
 - test/integration/migrations/create_test_tables.rb
 - test/integration/models/baby.rb
 - test/integration/models/clothing_article.rb
 - test/integration/models/senior.rb
 - test/integration/models/teenager.rb
-- test/integration/postgresql_db_test.rb
-- test/integration/sqlite3_db_test.rb
 - test/test_helper.rb
 - test/unit/fides_test.rb
 - test/unit/postgresql_test.rb

checksums.yaml

@@ -1,7 +0,0 @@
----
-SHA1:
-  metadata.gz: 6fde73e7ab62368ba7a22585c3673a992be3b3e3
-  data.tar.gz: e4f539ce123bd091d1488f7863a02a90ec41c14c
-SHA512:
-  metadata.gz: 0455f24cdc03855dd62b41ec33d33c9000adfbf1ecbf343936147aefa1c0013cc3488af5919e693417fc4d67631def0ad72a20bc7bef0a816493a60d1c9cfcba
-  data.tar.gz: 5c8d63d83bc8f1a1dda968b1fa8840c1a28e5a845abffade3bffb4ff956465c812c84b0019d5adb56ea5ce284d7d56116483c039edd6799994fab55d2c996f34

data/test/integration/postgresql_db_test.rb

@@ -1,56 +0,0 @@
-require_relative '../test_helper'
-
-module Fides
-  migrate_database("postgresql")
-
-  describe "PostgreSQL database interaction behaviour" do
-    it "raises an exception inserting a polymorphic without a coresponding record" do
-      clothing_article = ClothingArticle.new
-      clothing_article.name = "Jeggings"
-      clothing_article.wearable_id = 123
-      clothing_article.wearable_type = "Teenager"
-      assert_raises(ActiveRecord::StatementInvalid) { clothing_article.save }
-    end
-
-    it "raises an exception deleting a record that is still referenced by the polymorphic table" do
-      senior = Senior.new
-      senior.name = "Mr. John"
-      senior.save
-      senior.reload
-
-      clothing_article = ClothingArticle.new
-      clothing_article.name = "Flood pants"
-      clothing_article.wearable_id = senior.id
-      clothing_article.wearable_type = "Senior"
-      clothing_article.save
-
-      assert_raises(ActiveRecord::StatementInvalid) { Senior.find(senior.id).delete }
-    end
-
-    it "allows an insert of a model type specified in #add_polymorphic_triggers" do
-      baby = Baby.new
-      baby.name = "JJ"
-      baby.save
-      baby.reload
-      
-      clothing_article = ClothingArticle.new
-      clothing_article.name = "Onesie"
-      clothing_article.wearable_id = baby.id
-      clothing_article.wearable_type = "Baby"
-      assert clothing_article.save
-    end
-
-    it "allows a delete of a record NOT referenced by the polymorphic table" do
-      teenager = Teenager.new
-      teenager.name = "Johnny"
-      teenager.save
-      teenager.reload
-
-      assert Teenager.find(teenager.id).delete
-    end
-
-    # TODO: Should unspecified model types be rejected?
-    it "allows an insert of a model type NOT specified in #add_polymorphic_triggers"
-  end
-
-end