fides 0.0.11 → 0.0.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 92258eb65e77c3d3fd6881caa7fa5037e9a502d0
-  data.tar.gz: 688bada85c59802fa3d7bb442389f6c3ff47009a
+  metadata.gz: 6730418f04d57da6e4cbd55988a3c508009ee881
+  data.tar.gz: 89a9e627c96a5c215351e9223265c5b249ad88b9
 SHA512:
-  metadata.gz: 24558f5c56565abfe349078dab792678d820569b83430287f56408e159b544fd95ad423eaf71e5baa644dcd3b9885373049de7c4b31a2dc54358c460ff7f7cc8
-  data.tar.gz: 8d0d5c243156a0bd7a3301260097351e0c6b77c215a15fba32dc45ff3009fd43b3a7c84097d114e2f04877be6d1d3c5f09d50fce6a2bdb34afd34cf09b5a852f
+  metadata.gz: 2cccbd5ab8741d65b6bc26540ad1b59f9b0d336ceccb48680041e793ffea21464218a82a22b7a0af74b75e3a0d8a734121f7de4a6fa9965678e16698937436f3
+  data.tar.gz: 2d1c481246449df7bde5418a3f47a980c3b228e887793f6939209dcb01b4806cb9542d6b602c79b674086a346faa6f181e517d96625730a58a10f722a9e3b52e

data/README.md

@@ -71,7 +71,7 @@ If you're using Rails < version 3.1, then use Fides in your migration like this:
 Fides assumes the use of Rails conventions, so if you find a case for something that needs overriding, 
 please feel free to submit a bug or send a pull request.
 
-Fides currently only functions with PostgreSQL. Please feel free to contribute other adapters as desired.
+Fides currently only functions with PostgreSQL and SQLite3. Please feel free to contribute other adapters as desired.
 
 ## Contributing
 

data/lib/fides/postgresql.rb

@@ -3,7 +3,19 @@ module Fides
   class Postgresql
     include SqlWriter
 
-    def self.get_create_function_sql(interface_name, models, polymorphic_model)
+    def self.executable_add_statements(interface_name, models, polymorphic_model)
+      sql = create_and_update_constraint_sql(interface_name, models, polymorphic_model)
+      sql << delete_constraint_sql(interface_name, models, polymorphic_model)
+      return [sql]
+    end
+
+    def self.executable_remove_statements(interface_name)
+      [drop_constraints_sql(interface_name)]
+    end
+
+    private
+
+    def self.create_and_update_constraint_sql(interface_name, models, polymorphic_model)
 
       sql = "DROP FUNCTION IF EXISTS check_#{interface_name}_create_integrity() CASCADE;"
 
@@ -34,12 +46,13 @@ module Fides
           CREATE TRIGGER check_#{interface_name}_create_integrity_trigger 
             BEFORE INSERT OR UPDATE ON #{polymorphic_model.constantize.table_name} 
             FOR EACH ROW EXECUTE PROCEDURE check_#{interface_name}_create_integrity();
+
       }
 
       return strip_non_essential_spaces(sql)
     end
 
-    def self.get_delete_function_sql(interface_name, models, polymorphic_model)
+    def self.delete_constraint_sql(interface_name, models, polymorphic_model)
       polymorphic_model_table_name = polymorphic_model.constantize.table_name
       
       sql = ""
@@ -82,7 +95,7 @@ module Fides
       return strip_non_essential_spaces(sql)
     end
 
-    def self.get_drop_function_sql(interface_name)
+    def self.drop_constraints_sql(interface_name)
       sql = %{
         DROP FUNCTION IF EXISTS check_#{interface_name}_create_integrity() CASCADE;
         DROP FUNCTION IF EXISTS check_#{interface_name}_delete_integrity() CASCADE;

data/lib/fides/sqlite3.rb

@@ -5,12 +5,92 @@ module Fides
   class Sqlite3
     include SqlWriter
 
-    def self.get_create_function_sql(interface_name, models, polymorphic_model)
-      raise "Sqlite3 not yet implemented"
+    def self.executable_add_statements(interface_name, models, polymorphic_model)
+      statements = []
+      statements << drop_constraint_sql(interface_name, "create")
+      statements << create_constraint_sql(interface_name, models, polymorphic_model)
+      models.each do |model|
+        statements << drop_constraint_sql(model.constantize.table_name, "delete")
+        statements << delete_constraint_sql(interface_name, model, polymorphic_model)
+      end
+      statements << drop_constraint_sql(interface_name, "update")
+      statements << update_constraint_sql(interface_name, models, polymorphic_model)
+      return statements
     end
 
-    def self.get_delete_function_sql(interface_name, models, polymorphic_model)
-      raise "Sqlite3 not yet implemented"
+    def self.executable_remove_statements(interface_name)
+      statements = []
+      statements << drop_constraint_sql(interface_name, "create")
+      statements << drop_constraint_sql(interface_name, "delete")
+      return statements
+    end
+
+    private
+
+    def self.drop_constraint_sql(name, drop_type)
+      strip_non_essential_spaces "DROP TRIGGER IF EXISTS check_#{name}_#{drop_type}_integrity;"
+    end
+
+    def self.create_constraint_sql(interface_name, models, polymorphic_model)
+        sql = %{
+
+        CREATE TRIGGER check_#{interface_name}_create_integrity
+          BEFORE INSERT ON #{polymorphic_model.constantize.table_name}
+          BEGIN 
+            SELECT CASE 
+        }
+
+      models.each do |model|
+        sql << %{ 
+          WHEN ((NEW.#{interface_name}_type = '#{model}') AND (SELECT id 
+            FROM #{model.constantize.table_name} WHERE id = NEW.#{interface_name}_id) ISNULL) 
+            THEN RAISE(ABORT, 'There is no #{model} with that id.') 
+        }
+      end
+
+      sql << "END; END;"
+
+      return strip_non_essential_spaces(sql)
+    end
+
+      def self.update_constraint_sql(interface_name, models, polymorphic_model)
+        sql = %{
+
+        CREATE TRIGGER check_#{interface_name}_update_integrity
+          BEFORE UPDATE ON #{polymorphic_model.constantize.table_name}
+          BEGIN 
+            SELECT CASE 
+        }
+
+      models.each do |model|
+        sql << %{ 
+          WHEN ((NEW.#{interface_name}_type = '#{model}') AND (SELECT id 
+            FROM #{model.constantize.table_name} WHERE id = NEW.#{interface_name}_id) ISNULL) 
+            THEN RAISE(ABORT, 'There is no #{model} with that id.') 
+        }
+      end
+
+      sql << "END; END;"
+
+      return strip_non_essential_spaces(sql)
+    end
+
+    def self.delete_constraint_sql(interface_name, associated_model, polymorphic_model)
+      sql = %{
+
+        CREATE TRIGGER check_#{associated_model.constantize.table_name}_delete_integrity
+          BEFORE DELETE ON #{associated_model.constantize.table_name}
+          BEGIN
+            SELECT CASE
+              WHEN ((SELECT id FROM #{polymorphic_model.constantize.table_name} 
+                WHERE #{interface_name}_type = '#{associated_model}' AND #{interface_name}_id = OLD.id) NOTNULL) THEN 
+                  RAISE(ABORT, 'There are records in the #{polymorphic_model.constantize.table_name} table that refer to the #{associated_model.constantize.table_name} record that is attempting to be deleted. Delete the dependent records in the #{polymorphic_model.constantize.table_name} table first.')
+            END;
+          END;
+
+      }
+
+      return strip_non_essential_spaces(sql)
     end
 
   end

data/lib/fides/version.rb

@@ -1,3 +1,3 @@
 module Fides
-  VERSION = "0.0.11"
+  VERSION = "0.0.13"
 end

data/lib/fides.rb

@@ -10,7 +10,7 @@ require 'fides/database_adapter_error'
 
 module Fides
 
-  SUPPORTED_ADAPTERS = ["postgresql"]
+  SUPPORTED_ADAPTERS = ["postgresql", "sqlite3"]
 
   extend ActiveSupport::Concern
 
@@ -24,10 +24,9 @@ module Fides
 
     fides_sql_generator = get_sql_generator_class
 
-    sql = fides_sql_generator.get_create_function_sql(interface, associated_models, polymorphic_model)
-    sql << fides_sql_generator.get_delete_function_sql(interface, associated_models, polymorphic_model)
+    execution_statements = fides_sql_generator.executable_add_statements(interface, associated_models, polymorphic_model)
 
-    execute sql
+    execution_statements.each { |statement| execute statement }
   end
 
   def remove_polymorphic_triggers(opts)
@@ -36,9 +35,9 @@ module Fides
     polymorphic_model = opts[:polymorphic_model]
     interface = opts.has_key?(:interface_name) ? opts[:interface_name] : interface_name(polymorphic_model)
 
-    sql = get_sql_generator_class.get_drop_function_sql(interface)
+    execution_statements = get_sql_generator_class.executable_remove_statements(interface)
 
-    execute sql
+    execution_statements.each { |statement| execute statement }
   end
 
   private
@@ -54,7 +53,6 @@ module Fides
     model_name.constantize.reflect_on_all_associations.select { |r| r if r.options[:polymorphic] }.first.name
   end
 
- 
 end
 
 class ActiveRecord::Migration

data/test/lib/fides/postgresql_test.rb

@@ -4,75 +4,76 @@ describe Fides::Postgresql do
 
   let(:subject) { Fides::Postgresql }
 
-  it 'responds to #get_create_function_sql' do
-    assert_respond_to subject, :get_create_function_sql
+  it 'responds to #executable_add_statements' do
+    assert_respond_to subject, :executable_add_statements
   end
 
-  it 'responds to #get_delete_function_sql' do
-    assert_respond_to subject, :get_delete_function_sql
+  it 'responds to #executable_remove_statements' do
+    assert_respond_to subject, :executable_remove_statements
   end
 
-  it 'returns an expected SQL string' do
-    sql = subject.get_create_function_sql("imageable", ["Product", "Employee"], "Picture")
-    assert_equal subject.strip_non_essential_spaces(CREATE_SQL), sql
+  it 'returns an expected add constraints SQL string' do
+    sql = subject.executable_add_statements("imageable", ["Product", "Employee"], "Picture")[0]
+    assert_equal subject.strip_non_essential_spaces(add_constraints_sql), sql
   end
 
-  it 'returns an expected SQL string' do
-    sql = subject.get_delete_function_sql("imageable", ["Product", "Employee"], "Picture")
-    assert_equal subject.strip_non_essential_spaces(DELETE_SQL), sql 
+  it 'returns an expected drop constraints SQL string' do
+    sql = subject.executable_remove_statements("imageable")[0]
+    assert_equal subject.strip_non_essential_spaces(drop_constraing_sql), sql 
   end
 
-  CREATE_SQL = %{
-
-    DROP FUNCTION IF EXISTS check_imageable_create_integrity() CASCADE;
-
-    CREATE FUNCTION check_imageable_create_integrity() RETURNS TRIGGER AS '
-      BEGIN
-        IF NEW.imageable_type = ''Product'' AND EXISTS (
-          SELECT id FROM products WHERE id = NEW.imageable_id) THEN
-          RETURN NEW;
-        ELSEIF NEW.imageable_type = ''Employee'' AND EXISTS (
-          SELECT id FROM employees WHERE id = NEW.imageable_id) THEN
-          RETURN NEW;
-        ELSE
-          RAISE EXCEPTION ''No % model with id %.'', NEW.imageable_type, NEW.imageable_id;
-          RETURN NULL;
-        END IF;
-      END'
-    LANGUAGE plpgsql;
-
-    CREATE TRIGGER check_imageable_create_integrity_trigger
-      BEFORE INSERT OR UPDATE ON pictures
-      FOR EACH ROW EXECUTE PROCEDURE check_imageable_create_integrity();
-
-  }
-
-  DELETE_SQL = %{
-
-    CREATE FUNCTION check_imageable_delete_integrity() RETURNS TRIGGER AS '
-      BEGIN
-        IF TG_TABLE_NAME = ''products'' AND EXISTS (
-          SELECT id FROM pictures
-          WHERE imageable_type = ''Product'' AND imageable_id = OLD.id) THEN
-          RAISE EXCEPTION ''There are records in pictures that refer to %. You must delete those records first.'', OLD;
-        ELSEIF TG_TABLE_NAME = ''employees'' AND EXISTS (
-          SELECT id FROM pictures
-          WHERE imageable_type = ''Employee'' AND imageable_id = OLD.id) THEN
-          RAISE EXCEPTION ''There are records in pictures that refer to %. You must delete those records first.'', OLD;
-        ELSE
-          RETURN NULL;
-        END IF;
-      END'
-    LANGUAGE plpgsql;
-
-    CREATE TRIGGER check_products_delete_integrity_trigger
-      BEFORE DELETE ON products
-      FOR EACH ROW EXECUTE PROCEDURE check_imageable_delete_integrity();
-
-    CREATE TRIGGER check_employees_delete_integrity_trigger
-      BEFORE DELETE ON employees
-      FOR EACH ROW EXECUTE PROCEDURE check_imageable_delete_integrity();
+  let(:add_constraints_sql) do %{
+
+      DROP FUNCTION IF EXISTS check_imageable_create_integrity() CASCADE;
+
+      CREATE FUNCTION check_imageable_create_integrity() RETURNS TRIGGER AS '
+        BEGIN
+          IF NEW.imageable_type = ''Product'' AND EXISTS (
+            SELECT id FROM products WHERE id = NEW.imageable_id) THEN
+            RETURN NEW;
+          ELSEIF NEW.imageable_type = ''Employee'' AND EXISTS (
+            SELECT id FROM employees WHERE id = NEW.imageable_id) THEN
+            RETURN NEW;
+          ELSE
+            RAISE EXCEPTION ''No % model with id %.'', NEW.imageable_type, NEW.imageable_id;
+            RETURN NULL;
+          END IF;
+        END'
+      LANGUAGE plpgsql;
+
+      CREATE TRIGGER check_imageable_create_integrity_trigger
+        BEFORE INSERT OR UPDATE ON pictures
+        FOR EACH ROW EXECUTE PROCEDURE check_imageable_create_integrity();CREATE FUNCTION check_imageable_delete_integrity() RETURNS TRIGGER AS '
+        BEGIN
+          IF TG_TABLE_NAME = ''products'' AND EXISTS (
+            SELECT id FROM pictures
+            WHERE imageable_type = ''Product'' AND imageable_id = OLD.id) THEN
+            RAISE EXCEPTION ''There are records in pictures that refer to %. You must delete those records first.'', OLD;
+          ELSEIF TG_TABLE_NAME = ''employees'' AND EXISTS (
+            SELECT id FROM pictures
+            WHERE imageable_type = ''Employee'' AND imageable_id = OLD.id) THEN
+            RAISE EXCEPTION ''There are records in pictures that refer to %. You must delete those records first.'', OLD;
+          ELSE
+            RETURN NULL;
+          END IF;
+        END'
+      LANGUAGE plpgsql;
+
+      CREATE TRIGGER check_products_delete_integrity_trigger
+        BEFORE DELETE ON products
+        FOR EACH ROW EXECUTE PROCEDURE check_imageable_delete_integrity();
+
+      CREATE TRIGGER check_employees_delete_integrity_trigger
+        BEFORE DELETE ON employees
+        FOR EACH ROW EXECUTE PROCEDURE check_imageable_delete_integrity();
+
+    }
+  end
 
-  }
+  let(:drop_constraing_sql) do %{
+      DROP FUNCTION IF EXISTS check_imageable_create_integrity() CASCADE;
+      DROP FUNCTION IF EXISTS check_imageable_delete_integrity() CASCADE;
+    }
+  end
 
 end

data/test/lib/fides/sql_writer_test.rb

@@ -0,0 +1,36 @@
+require_relative '../../test_helper'
+
+describe Fides::SqlWriter do
+
+  before do
+    class MyTestClass
+      include Fides::SqlWriter
+    end
+  end
+
+  describe "#strip_non_essential_spaces" do
+    it 'removes newline characters' do
+      dirty_string = "asdjfkals;dfj\n\n\nasdfjkl;asdf\n\n\nasjfklas;fdj"
+      clean_string = "asdjfkals;dfj asdfjkl;asdf asjfklas;fdj"
+      assert_equal clean_string, MyTestClass.strip_non_essential_spaces(dirty_string)
+    end
+
+    it 'turns multiple spaces into 1 space' do
+      dirty_string = "a sdjfkals;dfj            asdfjkl;a     sdfasjfklas; fdj"
+      clean_string = "a sdjfkals;dfj asdfjkl;a sdfasjfklas; fdj"
+      assert_equal clean_string, MyTestClass.strip_non_essential_spaces(dirty_string)
+    end
+
+    it 'removes tabs' do
+      dirty_string = "hel\t\tlowor\t\t\t\tld\t"
+      clean_string = "hel lowor ld"
+      assert_equal clean_string, MyTestClass.strip_non_essential_spaces(dirty_string)
+    end
+
+    it 'trips the string' do
+      dirty_string = "               abc 123       "
+      clean_string = "abc 123"
+      assert_equal clean_string, MyTestClass.strip_non_essential_spaces(dirty_string)
+    end
+  end
+end

data/test/lib/fides/sqlite3_test.rb

@@ -0,0 +1,107 @@
+require_relative '../../test_helper'
+ 
+describe Fides::Sqlite3 do
+
+  let(:subject) { Fides::Sqlite3 }
+
+  it 'responds to #executable_add_statements' do
+    assert_respond_to subject, :executable_add_statements
+  end
+
+  it 'responds to #executable_remove_statements' do
+    assert_respond_to subject, :executable_remove_statements
+  end
+
+  it 'returns expected create constrains statements' do
+    statements = subject.executable_add_statements("imageable", ["Product", "Employee"], "Picture")
+    statements.each_with_index do |statement, index|
+      assert_equal subject.strip_non_essential_spaces( send("add_sql#{index + 1}") ), statement
+    end
+  end
+
+  it 'returns expected drop constrains statements' do
+    sql1 = subject.executable_remove_statements("imageable")[0]
+    sql2 = subject.executable_remove_statements("imageable")[1]
+    assert_equal subject.strip_non_essential_spaces(drop_sql1), sql1
+    assert_equal subject.strip_non_essential_spaces(drop_sql2), sql2
+  end
+
+  let(:add_sql1) do %{
+    DROP TRIGGER IF EXISTS check_imageable_create_integrity;
+    }
+  end
+
+  let(:add_sql2) do %{
+    CREATE TRIGGER check_imageable_create_integrity
+      BEFORE INSERT ON pictures
+      BEGIN 
+        SELECT CASE
+          WHEN ((NEW.imageable_type = 'Product') AND (SELECT id FROM products WHERE id = NEW.imageable_id) ISNULL) THEN RAISE(ABORT, 'There is no Product with that id.')
+          WHEN ((NEW.imageable_type = 'Employee') AND (SELECT id FROM employees WHERE id = NEW.imageable_id) ISNULL) THEN RAISE(ABORT, 'There is no Employee with that id.')
+        END;
+      END;
+    }
+  end
+
+  let(:add_sql3) do %{
+    DROP TRIGGER IF EXISTS check_products_delete_integrity;
+    }
+  end
+  
+  let(:add_sql4) do %{
+    CREATE TRIGGER check_products_delete_integrity
+      BEFORE DELETE ON products
+      BEGIN
+        SELECT CASE
+          WHEN ((SELECT id FROM pictures WHERE imageable_type = 'Product' AND imageable_id = OLD.id) NOTNULL) THEN 
+            RAISE(ABORT, 'There are records in the pictures table that refer to the products record that is attempting to be deleted. Delete the dependent records in the pictures table first.')
+        END;
+      END;
+    }
+  end
+
+  let(:add_sql5) do %{
+    DROP TRIGGER IF EXISTS check_employees_delete_integrity;
+    }
+  end
+
+  let(:add_sql6) do %{
+      CREATE TRIGGER check_employees_delete_integrity
+        BEFORE DELETE ON employees
+        BEGIN
+          SELECT CASE
+            WHEN ((SELECT id FROM pictures WHERE imageable_type = 'Employee' AND imageable_id = OLD.id) NOTNULL) THEN 
+              RAISE(ABORT, 'There are records in the pictures table that refer to the employees record that is attempting to be deleted. Delete the dependent records in the pictures table first.')
+          END;
+        END;
+    }
+  end
+
+  let(:add_sql7) do %{
+    DROP TRIGGER IF EXISTS check_imageable_update_integrity;
+    }
+  end
+
+  let(:add_sql8) do %{
+    CREATE TRIGGER check_imageable_update_integrity
+      BEFORE UPDATE ON pictures
+      BEGIN 
+        SELECT CASE
+          WHEN ((NEW.imageable_type = 'Product') AND (SELECT id FROM products WHERE id = NEW.imageable_id) ISNULL) THEN RAISE(ABORT, 'There is no Product with that id.')
+          WHEN ((NEW.imageable_type = 'Employee') AND (SELECT id FROM employees WHERE id = NEW.imageable_id) ISNULL) THEN RAISE(ABORT, 'There is no Employee with that id.')
+        END;
+      END;
+    }
+  end
+
+  let(:drop_sql1) do %{
+      DROP TRIGGER IF EXISTS check_imageable_create_integrity;
+    }
+  end
+
+  let(:drop_sql2) do %{
+      DROP TRIGGER IF EXISTS check_imageable_delete_integrity;
+    }
+  end
+
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fides
 version: !ruby/object:Gem::Version
-  version: 0.0.11
+  version: 0.0.13
 platform: ruby
 authors:
 - Martin Kraft
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-29 00:00:00.000000000 Z
+date: 2013-03-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -128,10 +128,13 @@ files:
 - lib/fides/sql_writer.rb
 - lib/fides/sqlite3.rb
 - lib/fides/version.rb
-- test/lib/fides/database_adapter_test.rb
 - test/lib/fides/postgresql_test.rb
+- test/lib/fides/sql_writer_test.rb
+- test/lib/fides/sqlite3_test.rb
 - test/lib/fides/version_test.rb
 - test/lib/fides_test.rb
+- test/lib/integration/postgresql_db_test.rb
+- test/lib/integration/sqlite3_db_test.rb
 - test/test_helper.rb
 homepage: https://github.com/mkraft/fides
 licenses:
@@ -159,8 +162,11 @@ specification_version: 4
 summary: Creates SQL triggers from Rails migrations to enforce the integrity of  polymorphic
   associations at the database level.
 test_files:
-- test/lib/fides/database_adapter_test.rb
 - test/lib/fides/postgresql_test.rb
+- test/lib/fides/sql_writer_test.rb
+- test/lib/fides/sqlite3_test.rb
 - test/lib/fides/version_test.rb
 - test/lib/fides_test.rb
+- test/lib/integration/postgresql_db_test.rb
+- test/lib/integration/sqlite3_db_test.rb
 - test/test_helper.rb

data/test/lib/fides/database_adapter_test.rb

@@ -1,4 +0,0 @@
-require_relative '../../test_helper'
-
-describe Fides::SqlWriter do
-end