ficon 0.1 → 0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f38f205039b510b47be5f9a226ebc8680dbd2c97a38cae867c597e02ce6805b4
-  data.tar.gz: edefb06cd24a6091df0e92fe7ac68974cc649e0b4e3b22e73243bbcfe352a838
+  metadata.gz: 97c762adf3cdb126d047b66c426c3f388a3a8c61e2c6c009cff2f0dca3c7f219
+  data.tar.gz: 53a177388f199f7133991f1067ad1a71d747c5d84c99b88d379d7878a3196eb5
 SHA512:
-  metadata.gz: 7d04d8330715b5194af238accadb7ab5513f3a27423ab9feb5634c03b6e5d847841eb29d4ceb85cc71faf6526b16aeaf80c561293f97b76e483789329fe5236f
-  data.tar.gz: 818b27e4318f1c587ed29a9925b66f846644d2cd82378cf1400b1b2e9a9298fc7f091b1981abdbbe51dd598f7b0475b3cef1e1e941ce80b7c14da65a9738bc83
+  metadata.gz: 2af1238cf43c03e84081ddfeeb69a545613e0348b33dab4aa3670d8e152e9ce4089f9b8c892764ecb143cf2aaa90b6afa4fd7b844bb611e98a8b18b27ce161b6
+  data.tar.gz: 6eac859ed1529c3f22fcdaf5634a8e66ae1c625da7fbc0a1bce80afe53fc2a2a15145ac827cf65de414e68b7ea86be6cf25b808102606ab44f77def6a20124c4

data/lib/ficon/version.rb

@@ -1,3 +1,3 @@
 class Ficon
-  VERSION = "0.1"
+  VERSION = "0.2"
 end

data/lib/ficon.rb

@@ -10,9 +10,12 @@ require_relative "ficon/cache"
 
 class Ficon
   attr_reader :site
-  def initialize(uri)
+  attr_accessor :user_agent
+
+  def initialize(uri, user_agent: nil)
     @uri = Addressable::URI.heuristic_parse(uri)
     @site = {}
+    @user_agent = user_agent || "Ficon/#{VERSION} (Ruby icon finder; https://github.com/dkam/ficon)"
     process
   end
 
@@ -24,7 +27,7 @@ class Ficon
     if @data.nil?
       response = fetch_url(@uri)
       return nil unless response
-      
+
       @data = response.body.force_encoding("UTF-8")
       cache.data = @data
       cache.etag = response["etag"] if response["etag"]
@@ -91,7 +94,7 @@ class Ficon
 
   def self.site_images(uri, doc)
     results = []
-    
+
     # Get tile color for Windows tiles
     tile_color = doc.at_xpath("//meta[@name='msapplication-TileColor']/@content")&.value
 
@@ -100,7 +103,7 @@ class Ficon
 
     results.collect { |result| normalise(uri, result) }.uniq.collect do |url|
       # Check if this is a tile image to pass the color
-      is_tile = doc.at_xpath("//meta[@name='msapplication-TileImage' and @content='#{url}' or @content='#{url.sub(uri.to_s, '')}']")
+      is_tile = doc.at_xpath("//meta[@name='msapplication-TileImage' and @content='#{url}' or @content='#{url.sub(uri.to_s, "")}']")
       Image.new(url, is_tile ? tile_color : nil)
     end.sort_by(&:area).reverse
   end
@@ -125,23 +128,16 @@ class Ficon
 
   def fetch_url(uri)
     uri = URI(uri) unless uri.is_a?(URI)
-    
-    Net::HTTP.start(uri.host, uri.port, use_ssl: uri.scheme == 'https') do |http|
+
+    Net::HTTP.start(uri.host, uri.port, use_ssl: uri.scheme == "https") do |http|
       http.read_timeout = 10
       http.open_timeout = 5
       request = Net::HTTP::Get.new(uri)
-      request['User-Agent'] = "Ficon/#{VERSION} (Ruby icon finder; https://github.com/dkam/ficon)"
+      request["User-Agent"] = @user_agent
       http.request(request)
     end
   rescue Net::HTTPError, SocketError, Timeout::Error => e
     puts "Failed to fetch #{uri}: #{e.inspect}"
     nil
   end
-
-  def other_page_data
-    @site[:title] = doc.at_xpath("//meta[@property='og:title']/@content")&.value || @doc.at_xpath("//title")&.text&.strip
-    @site[:description] = doc.at_xpath("//meta[@property='og:description']/@content")&.value
-    canonical = doc.at_xpath("//link[@rel='canonical']/@href")&.value
-    @site[:canonical] = canonical unless canonical == @url
-  end
 end

data/test/ficon_test.rb

@@ -54,4 +54,19 @@ class FiconTest < Minitest::Test
     assert_equal 'https://site.com/win8-tile-144.png', result.url
     assert_equal '#00aced', result.tile_color
   end
+
+  def test_custom_user_agent
+    # Test default user agent
+    ficon_default = Ficon.new('https://example.com')
+    assert_match(/^Ficon\/0\.2/, ficon_default.user_agent)
+    
+    # Test custom user agent
+    custom_agent = 'MyApp/1.0 (Custom Bot)'
+    ficon_custom = Ficon.new('https://example.com', user_agent: custom_agent)
+    assert_equal custom_agent, ficon_custom.user_agent
+    
+    # Test user agent can be changed after initialization
+    ficon_custom.user_agent = 'Changed/2.0'
+    assert_equal 'Changed/2.0', ficon_custom.user_agent
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ficon
 version: !ruby/object:Gem::Version
-  version: '0.1'
+  version: '0.2'
 platform: ruby
 authors:
 - Dan Milne