fgraph 0.3.4 → 0.4.0

data/History

@@ -1,3 +1,9 @@
+v0.3.5
+  * Replace fbs_cookies.gsub! with .gsub
+  * FGraph.get_id now supports :id 
+  * Replace array.count with array.length
+  * Fix client_test failures
+  
 v0.3.4
   * Add FGraph::Client#update_options method
   

data/VERSION.yml

@@ -1,5 +1,5 @@
 --- 
-:patch: 4
+:patch: 0
 :major: 0
 :build: 
-:minor: 3
+:minor: 4

data/lib/fgraph.rb

@@ -114,7 +114,7 @@ module FGraph
       options = args.last.is_a?(Hash) ? args.pop : {}
     
       # If first input before option is an array
-      if args.count == 1 and args.first.is_a?(Array)
+      if args.length == 1 and args.first.is_a?(Array)
         args = args.first.map do |arg|
           self.get_id(arg)
         end
@@ -391,7 +391,7 @@ module FGraph
     #
     def get_id(id)
       return unless id
-      id = id['id'] if id.is_a?(Hash)
+      id = id['id'] || id[:id] if id.is_a?(Hash)
       id
     end
   end

data/lib/fgraph/rails/fgraph_helper.rb

@@ -29,7 +29,7 @@ module FGraph
   			end
 
   			# Parse facebook cookies
-  			fbs_cookies = CGI.parse(fbs_cookies.gsub!(/(^\"|\"$)/, ''))
+  			fbs_cookies = CGI.parse(fbs_cookies.gsub(/(^\"|\"$)/, ''))
   			session_cookies = {}
   			fbs_cookies.each do |key, value|
   				session_cookies[key] = value[0]

data/test/fgraph/client_test.rb

@@ -136,7 +136,7 @@ class ClientTest < Test::Unit::TestCase
   context "FGraph::Client#insights" do
     should "auto populate :client_id and :oauth_app_access_token" do
       client = fb_client 
-      client.options[:app_access_token] = FACEBOOK_OAUTH_APP_ACCESS_TOKEN
+      client.options[:app_access_token] = { 'access_token' => FACEBOOK_OAUTH_APP_ACCESS_TOKEN }
       
       FGraph.expects(:insights).with(FACEBOOK_APP_ID, FACEBOOK_OAUTH_APP_ACCESS_TOKEN, {})
       client.insights
@@ -144,7 +144,7 @@ class ClientTest < Test::Unit::TestCase
     
     should "auto retrieve :oauth_app_access_token option" do
       client = fb_client
-      client.expects(:oauth_app_access_token).returns(FACEBOOK_OAUTH_APP_ACCESS_TOKEN)
+      client.expects(:oauth_app_access_token).returns({ 'access_token' => FACEBOOK_OAUTH_APP_ACCESS_TOKEN })
       FGraph.expects(:insights).with(FACEBOOK_APP_ID, FACEBOOK_OAUTH_APP_ACCESS_TOKEN, {
         :metric_path => 'application_api_calls/day'
       })

data/test/fgraph_test.rb

@@ -253,7 +253,7 @@ class FGraphTest < Test::Unit::TestCase
       
       collection = FGraph.handle_response(fb_response)
       collection.class.should == FGraph::Collection
-      collection.count.should == fb_response['data'].count
+      collection.length.should == fb_response['data'].length
     end
     
     should "raise QueryParseError" do
@@ -295,7 +295,7 @@ class FGraphTest < Test::Unit::TestCase
       }
       
       collection = FGraph::Collection.new(response)
-      collection.count.should == response['data'].count
+      collection.length.should == response['data'].length
       collection.first.should == response['data'].first
       collection.next_url.should == response['paging']['next']
       collection.previous_url.should == response['paging']['previous']

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: fgraph
 version: !ruby/object:Gem::Version 
-  hash: 27
+  hash: 15
   prerelease: false
   segments: 
   - 0
-  - 3
   - 4
-  version: 0.3.4
+  - 0
+  version: 0.4.0
 platform: ruby
 authors: 
 - Herryanto Siatono
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-09-09 00:00:00 +08:00
+date: 2010-09-12 00:00:00 +08:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency