ffsplitter 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 06995073fdeefca7864c22bde674d1e8875dc8f9
-  data.tar.gz: 183886a0825bcf850fb4507a691fa9466c742bf6
+  metadata.gz: acf9900954257651670f15133609d4a7a1ca78c2
+  data.tar.gz: 62e6dca9c7aa87214326423d096298918812e042
 SHA512:
-  metadata.gz: 8e4da0bc89ff46aafe84820de193c9b778a82c89d2a2959ee7b31e45d20cef6170e8506a62d9236b1a598c2bd57b5701065e67dbc22f19fab5c7c5c836eb9a70
-  data.tar.gz: f07368ae40a95c886faa05f4283725b71d0518b36eb02da939383ab761f2b1ec4d87c39252372050a05823fd6d6c286a56658e30d293a68529313f87dcc5fd73
+  metadata.gz: 3dafaed0ded9a9130e8860ef52bd6b9a0b49be6005c01329a0cc6529fc7fab8a4d20aaaa6f9560e3ef1803e6d4a98cfe23f83fc7268760993b2b8ac09ce6923f
+  data.tar.gz: a7a04d0efac73c31472219edf1b58724c03c4b6fd5a605bede4d36481006486374b4961e239b1cd68fd115ccb00670182fb25ef4eeb4e0ce59e577e221bded4c

data/README.md

@@ -7,10 +7,10 @@
 
 ## Usage
 
-Given the video file `my-video.mp4`
-And `my-video.mp4` has embedded chapter markers
-When I execute `ffsplitter my-video.mp4`
-Then `.mp4` files will be created for each chapter
+* Given the video file `my-video.mp4`
+* And `my-video.mp4` has embedded chapter markers
+* When I execute `ffsplitter my-video.mp4`
+* Then `.mp4` files will be created for each chapter
 
 ## Contributing
 

data/lib/ffsplitter/chapter.rb

@@ -38,7 +38,7 @@ module FFSplitter
     end
 
     def filename
-      "#{track} #{title.lstrip}"
+      "#{track} #{title.gsub(/[,';:]/, '').lstrip}"
     end
 
     def index

data/lib/ffsplitter/ffmpeg.rb

@@ -19,7 +19,7 @@ module FFSplitter
 
     def chapter_command(chapter)
       output_file = File.expand_path(chapter.filename, output_directory)
-      "-i '#{filename}' -ss #{chapter.start_time} -to #{chapter.end_time} -c copy -v error '#{output_file}.mp4'"
+      "-i '#{filename}' -ss #{chapter.start_time} -to #{chapter.end_time} -c copy '#{output_file}.mp4'"
     end
   end
 end

data/lib/ffsplitter/version.rb

@@ -1,3 +1,3 @@
 module FFSplitter
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/chapter_spec.rb

@@ -30,10 +30,20 @@ module FFSplitter
       end
     end
 
-    describe "filename" do
-      let(:chapter){ Chapter.new(title: "   test title") }
-      it "prettys up the chapter title" do
-        expect(chapter.filename).to eq("01 test title")
+    describe "#filename" do
+      let(:filename) {""}
+      let(:chapter){ Chapter.new(title: filename) }
+      context "with leading spaces" do
+        let(:filename) { "   test title" }
+        it "removes them" do
+          expect(chapter.filename).to eq("01 test title")
+        end
+      end
+      context "with ';:" do
+        let(:filename) { "what's wrong; with: this" }
+        it "removes them" do
+          expect(chapter.filename).to eq("01 whats wrong with this")
+        end
       end
     end
 

data/spec/end_to_end_spec.rb

@@ -5,7 +5,7 @@ module FFSplitter
     before { Dir.mkdir("tmp") unless Dir.exist?("tmp") }
 
     describe "split" do
-      before { `bundle exec ruby -Ilib bin/ffsplitter 'spec/fixtures/test video.mp4' tmp` }
+      before { `bundle exec ruby -Ilib bin/ffsplitter 'spec/fixtures/test video.mp4' tmp 2>&1` }
       let(:file_list) { Dir.glob("tmp/*")  }
       it "creates files" do
         expect(file_list).to include("tmp/01 Chapter 1.mp4")

data/spec/ffmpeg_spec.rb

@@ -45,7 +45,6 @@ module FFSplitter
           expect(command).to match("-ss 10.0")
           expect(command).to match("-to 20.0")
           expect(command).to match("-c copy")
-          expect(command).to match("-v error")
           expect(command).to match("#{File.expand_path(chapter.filename)}")
         end
       end

data/spec/metadata_parser_spec.rb

@@ -20,19 +20,19 @@ module FFSplitter
         end
 
         it "calculates the timebase" do
-          expect(chapters.first[:timebase]).to eq(0.5)
+          expect(chapters.first.timebase).to eq(0.5)
         end
 
         it "sets the start_frames" do
-          expect(chapters.first[:start_frames]).to eq(100)
+          expect(chapters.first.start_frames).to eq(100)
         end
 
         it "sets the end_frames" do
-          expect(chapters.first[:end_frames]).to eq(200)
+          expect(chapters.first.end_frames).to eq(200)
         end
 
         it "parses the title" do
-          expect(chapters.first[:title]).to eq("Ludwig van Beethoven - Piano Trio in D Major")
+          expect(chapters.first.title).to eq("Ludwig van Beethoven - Piano Trio in D Major")
         end
       end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ffsplitter
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Kevin Rockwood
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-13 00:00:00.000000000 Z
+date: 2013-10-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: virtus