ffmprb 0.11.3 → 0.12.1

data/exp/zip2mp4k60

@@ -0,0 +1,27 @@
+#!/usr/bin/env ruby
+
+gem 'ffmprb'
+require 'ffmprb'
+
+if ARGV.length != 1
+  warn "Usage: zip2mp4k60 <zip-file>"
+  exit 1
+end
+zip_path = File.expand_path(ARGV[0])
+out_path = File.join(File.dirname(zip_path), "#{File.basename zip_path, '.*'}.mp4")
+video_opts = {resolution: '3840x2160', fps: 60}
+
+
+Dir.mktmpdir do |tmp_dir|
+  Dir.chdir tmp_dir do
+    # XXX? this doesn't work as ffmprb input because of the way process do... works
+    system "unzip '#{zip_path}'"
+    Ffmprb.process do
+      output out_path, video: video_opts do
+        Dir['*'].sort.each do |in_path|
+          roll input in_path
+        end
+      end
+    end
+  end
+end

data/ffmprb.gemspec

@@ -6,14 +6,43 @@ require 'ffmprb/version'
 Gem::Specification.new do |spec|
   spec.name          = 'ffmprb'
   spec.version       = Ffmprb::VERSION
-  spec.authors       = ["showbox.com", "Costa Shapiro"]
+  spec.authors       = ["Costa Shapiro"]
   spec.email         = ['costa@mouldwarp.com']
 
-  spec.summary       = "ffmprb is your audio/video montage friend, based on https://ffmpeg.org"
+  spec.summary       = "ffmprb is your audio/video manipulation pal, based on https://ffmpeg.org"
   spec.description   = "A video and audio composing DSL (Damn-Simple Language) and a micro-engine for ffmpeg and ffriends"
   spec.homepage      = Ffmprb::GEM_GITHUB_URL
 
-  spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+  def self.ignore_match(pattern, path)
+    path = '/' + path  unless path =~ %r'^/'
+    if File.directory?(path)
+      path += '/'  unless path =~ %r'/$'
+    end
+    if pattern.is_a?(Array)
+      pattern
+    else
+      [pattern]
+    end.any? do |pattern|
+      pattern = '**/' + pattern  unless pattern =~ %r'^/'
+      pattern += '**'  if pattern =~ %r'/$'
+      File.fnmatch(pattern, path)
+    end
+  end
+
+  pattern =
+    if (ignore_pattern_lines = File.readlines('.gemignore') rescue nil)
+      ignore_pattern_lines.map do |line|
+        stripped = line.split(/(?<!\\)#/)[0].strip
+        stripped  unless stripped.empty?
+      end.compact
+    else
+      %w[test/ spec/ features/]
+    end
+
+  # NOTE dotfiles are ignored by .glob
+  spec.files = Dir['**/*'].reject{|path| ignore_match pattern, path}
+  # TODO:rm spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+
   spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
@@ -23,15 +52,6 @@ Gem::Specification.new do |spec|
   # NOTE make it into an optional dependency? Nah for now
   spec.add_dependency 'thor', '~> 0.19.1'
 
-  spec.add_development_dependency 'bundler', '>= 1.11.2'
-  spec.add_development_dependency 'byebug', '>= 8.2.4'
-  spec.add_development_dependency 'simplecov', '>= 0.11.2'
-  spec.add_development_dependency 'guard-rspec', '>= 4.6.5'
-  spec.add_development_dependency 'guard-bundler', '>= 2.1.0'
-  spec.add_development_dependency 'rake', '>= 11.1.2'
-  spec.add_development_dependency 'rmagick', '>= 2.15.4'
-  spec.add_development_dependency 'ruby-sox', '>= 0.0.3'
-  spec.add_development_dependency 'firebase', '>= 0.2.6'
-
-  spec.post_install_message = "Have fun with your montage! To enable proc visualisation, install firebase gem and set FFMPRB_PROC_VIS_FIREBASE env."  unless Ffmprb::FIREBASE_AVAILABLE
+  spec.post_install_message = "Have fun with your a/v! To enable proc visualisation, install firebase gem and set FFMPRB_PROC_VIS_FIREBASE env."  unless
+    Ffmprb::FIREBASE_AVAILABLE
 end

data/lib/defaults.rb

@@ -19,7 +19,7 @@ module Ffmprb
   Process.input_video_fps = nil  # NOTE the documented ffmpeg default is 25
 
   Process.output_video_resolution = CGA
-  Process.output_video_fps = 16
+  Process.output_video_fps = 16  # NOTE the documented ffmpeg default is 25
   Process.output_audio_encoder = 'libmp3lame'
   Process.output_audio_sampling_freq = nil  # NOTE Use ffmpeg default by default, specify otherwise e.g. 44100
 
@@ -40,16 +40,16 @@ module Ffmprb
 
   # NOTE http://12factor.net etc
 
-  Ffmprb.log_level = Logger::INFO
-  Ffmprb.ffmpeg_debug = ENV.fetch('FFMPRB_FFMPEG_DEBUG', '') !~ Ffmprb::ENV_VAR_FALSE_REGEX
-  Ffmprb.debug = ENV.fetch('FFMPRB_DEBUG', '') !~ Ffmprb::ENV_VAR_FALSE_REGEX
+  self.log_level = Logger::INFO
+  self.ffmpeg_debug = ENV.fetch('FFMPRB_FFMPEG_DEBUG', '') !~ Ffmprb::ENV_VAR_FALSE_REGEX
+  self.debug = ENV.fetch('FFMPRB_DEBUG', '') !~ Ffmprb::ENV_VAR_FALSE_REGEX
 
   proc_vis_firebase = ENV['FFMPRB_PROC_VIS_FIREBASE']
   if Ffmprb::FIREBASE_AVAILABLE
     fail Error, "Please provide just the name of the firebase in FFMPRB_PROC_VIS_FIREBASE (e.g. my-proc-vis-io for https://my-proc-vis-io.firebaseio.com/proc/)"  if proc_vis_firebase =~ /\//
-    Ffmprb.proc_vis_firebase = proc_vis_firebase
+    self.proc_vis_firebase = proc_vis_firebase
   elsif proc_vis_firebase
-    Ffmprb.logger.warn "Firebase unavailable (have firebase gem installed or unset FFMPRB_PROC_VIS_FIREBASE to get rid of this warning)"
+    logger.warn "Firebase unavailable (have firebase gem installed or unset FFMPRB_PROC_VIS_FIREBASE to get rid of this warning)"
   end
 
 end

data/lib/ffmprb/execution.rb

@@ -25,7 +25,7 @@ module Ffmprb
         else
           Logger::WARN
         end
-      Ffmprb.process *ios, ignore_broken_pipes: false, &script
+      Ffmprb.process *ios, &script
     end
 
     # NOTE a hack from http://stackoverflow.com/a/23955971/714287

data/lib/ffmprb/file/sample.rb

@@ -11,7 +11,7 @@ module Ffmprb
       audio = File.temp('.wav')  if audio == true
       video = File.temp('.png')  if video == true
 
-      Ffmprb.logger.debug "Snap shooting files, video path: #{video ? video.path : 'NONE'}, audio path: #{audio ? audio.path : 'NONE'}"
+      Ffmprb.logger.debug{"Snap shooting files, video path: #{video ? video.path : 'NONE'}, audio path: #{audio ? audio.path : 'NONE'}"}
 
       fail Error, "Incorrect output extname (must be image)"  unless !video || video.channel?(:video) && !video.channel?(:audio)
       fail Error, "Incorrect audio extname (must be sound)"  unless !audio || audio.channel?(:audio) && !audio.channel?(:video)
@@ -30,7 +30,7 @@ module Ffmprb
         begin
           video.unlink  if video
           audio.unlink  if audio
-          Ffmprb.logger.debug "Removed sample files"
+          Ffmprb.logger.debug{"Removed sample files"}
         rescue
           Ffmprb.logger.warn "#{$!.class.name} removing sample files: #{$!.message}"
         end

data/lib/ffmprb/file/threaded_buffered.rb

@@ -1,13 +1,13 @@
 module Ffmprb
 
-  class File  # NOTE I would rather rename it to Stream at the moment
+  class File
 
     class << self
 
       def threaded_buffered_fifo(extname='.tmp', reader_open_on_writer_idle_limit: nil, proc_vis: nil)
         input_fifo_file = temp_fifo(extname)
         output_fifo_file = temp_fifo(extname)
-        Ffmprb.logger.debug "Opening #{input_fifo_file.path}>#{output_fifo_file.path} for buffering"
+        Ffmprb.logger.debug{"Opening #{input_fifo_file.path}>#{output_fifo_file.path} for buffering"}
         Util::Thread.new do
           begin
             io_buff = Util::ThreadedIoBuffer.new(opener(input_fifo_file, 'r'), opener(output_fifo_file, 'w'), keep_outputs_open_on_input_idle_limit: reader_open_on_writer_idle_limit)
@@ -20,13 +20,13 @@ module Ffmprb
             ensure
               Util::Thread.join_children!
             end
-            Ffmprb.logger.debug "IoBuffering from #{input_fifo_file.path} to #{output_fifo_file.path} ended"
+            Ffmprb.logger.debug{"IoBuffering from #{input_fifo_file.path} to #{output_fifo_file.path} ended"}
           ensure
             input_fifo_file.unlink  if input_fifo_file
             output_fifo_file.unlink  if output_fifo_file
           end
         end
-        Ffmprb.logger.debug "IoBuffering from #{input_fifo_file.path} to #{output_fifo_file.path} started"
+        Ffmprb.logger.debug{"IoBuffering from #{input_fifo_file.path} to #{output_fifo_file.path} started"}
 
         [input_fifo_file, output_fifo_file]
       end

data/lib/ffmprb/file.rb

@@ -4,7 +4,7 @@ require 'tempfile'
 
 module Ffmprb
 
-  class File  # NOTE I would rather rename it to Stream at the moment
+  class File < ::File
     include Util::ProcVis::Node
 
     class << self
@@ -17,27 +17,27 @@ module Ffmprb
         ->{
           path = file.respond_to?(:path)? file.path : file
           mode ||= file.respond_to?(mode)? file.mode.to_s[0] : 'r'
-          Ffmprb.logger.debug "Trying to open #{path} (for #{mode}-buffering or something)"
-          ::File.open(path, mode)
+          Ffmprb.logger.debug{"Trying to open #{path} (for #{mode}-buffering or something)"}
+          ::File.open path, mode
         }
       end
 
       def create(path)
         new(path: path, mode: :write).tap do |file|
-          Ffmprb.logger.debug "Created file with path: #{file.path}"
+          Ffmprb.logger.debug{"Created file with path: #{file.path}"}
         end
       end
 
-      def open(path)
+      def access(path)
         new(path: path, mode: :read).tap do |file|
-          Ffmprb.logger.debug "Opened file with path: #{file.path}"
+          Ffmprb.logger.debug{"Accessed file with path: #{file.path}"}
         end
       end
 
       def temp(extname)
         file = create(Tempfile.new(['', extname]))
         path = file.path
-        Ffmprb.logger.debug "Created temp file with path: #{path}"
+        Ffmprb.logger.debug{"Created temp file with path: #{path}"}
 
         return file  unless block_given?
 
@@ -49,13 +49,13 @@ module Ffmprb
           rescue
             Ffmprb.logger.warn "#{$!.class.name} removing temp file with path #{path}: #{$!.message}"
           end
-          Ffmprb.logger.debug "Removed temp file with path: #{path}"
+          Ffmprb.logger.debug{"Removed temp file with path: #{path}"}
         end
       end
 
       def temp_fifo(extname='.tmp', &blk)
         path = temp_fifo_path(extname)
-        ::File.mkfifo path
+        mkfifo path
         fifo_file = create(path)
 
         return fifo_file  unless block_given?
@@ -69,24 +69,24 @@ module Ffmprb
           rescue
             Ffmprb.logger.warn "#{$!.class.name} removing temp file with path #{path}: #{$!.message}"
           end
-          Ffmprb.logger.debug "Removed temp file with path: #{path}"
+          Ffmprb.logger.debug{"Removed temp file with path: #{path}"}
         end
       end
 
       def temp_fifo_path(extname)
-        ::File.join Dir.tmpdir, Dir::Tmpname.make_tmpname('', 'p' + extname)
+        join Dir.tmpdir, "#{rand(2**222)}p#{extname}"
       end
 
       def image?(extname)
-        !!(extname =~ File.image_extname_regex)
+        !!(extname =~ image_extname_regex)
       end
 
       def sound?(extname)
-        !!(extname =~ File.sound_extname_regex)
+        !!(extname =~ sound_extname_regex)
       end
 
       def movie?(extname)
-        !!(extname =~ File.movie_extname_regex)
+        !!(extname =~ movie_extname_regex)
       end
 
     end
@@ -112,15 +112,15 @@ module Ffmprb
     # Info
 
     def exist?
-      ::File.exist? path
+      File.exist? path
     end
 
     def basename
-      @basename ||= ::File.basename(path)
+      @basename ||= File.basename(path)
     end
 
     def extname
-      @extname ||= ::File.extname(path)
+      @extname ||= File.extname(path)
     end
 
     def channel?(medium)
@@ -156,10 +156,10 @@ module Ffmprb
     # Manipulation
 
     def read
-      ::File.read path
+      File.read path
     end
     def write(s)
-      ::File.write path, s
+      File.write path, s
     end
 
     def unlink
@@ -168,7 +168,7 @@ module Ffmprb
       else
         FileUtils.remove_entry path
       end
-      Ffmprb.logger.debug "Removed file with path: #{path}"
+      Ffmprb.logger.debug{"Removed file with path: #{path}"}
       @path = nil
     end
 

data/lib/ffmprb/filter.rb

@@ -9,15 +9,15 @@ module Ffmprb
       attr_accessor :silence_noise_max_db
 
       def alphamerge(inputs, output=nil)
-        inout "alphamerge", inputs, output
+        inout 'alphamerge', inputs, output
       end
 
       def afade_in(duration, input=nil, output=nil)
-        inout "afade=in:d=%{duration}:curve=hsin", input, output, duration: duration
+        inout 'afade=in:d=%{duration}:curve=hsin', input, output, duration: duration
       end
 
       def afade_out(duration, input=nil, output=nil)
-        inout "afade=out:d=%{duration}:curve=hsin", input, output, duration: duration
+        inout 'afade=out:d=%{duration}:curve=hsin', input, output, duration: duration
       end
 
       def amix_to_first_same_volume(inputs, output=nil)
@@ -33,24 +33,45 @@ module Ffmprb
           end
         end
         filters +
-          inout("amix=%{inputs_count}:duration=shortest:dropout_transition=0, volume=%{inputs_count}",
+          inout('amix=%{inputs_count}:duration=shortest:dropout_transition=0, volume=%{inputs_count}',
             new_inputs, output, inputs_count: (inputs.empty?? nil : inputs.size))
       end
 
       def anull(input=nil, output=nil)
-        inout "anull", input, output
+        inout 'anull', input, output
       end
 
       def anullsink(input=nil)
-        inout "anullsink", input, nil
+        inout 'anullsink', input, nil
       end
 
       def asplit(inputs=nil, outputs=nil)
-        inout "asplit", inputs, outputs
+        inout 'asplit', inputs, outputs
+      end
+
+      def areverse(input=nil, output=nil)
+        inout 'areverse', input, output
+      end
+
+      def atempo(tempo, input=nil, output=nil)
+        fail Error, "Push the tempo!"  unless
+          tempo > 0
+
+        fil = ''
+        tmp = tempo
+        while tmp > 2.0
+          fil += 'atempo=2.0, '
+          tmp /= 2.0
+        end
+        while tmp < 0.5
+          fil += 'atempo=0.5, '
+          tmp /= 0.5
+        end
+        inout "#{fil}atempo=#{tmp.to_f}", input, output
       end
 
       def atrim(st, en=nil, input=nil, output=nil)
-        inout "atrim=%{start_end}, asetpts=PTS-STARTPTS", input, output,
+        inout 'atrim=%{start_end}, asetpts=PTS-STARTPTS', input, output,
           start_end: [st, en].compact.join(':')
       end
 
@@ -58,45 +79,64 @@ module Ffmprb
         color_source '0x000000@0', duration, resolution, fps, output
       end
 
-      def color_source(color, duration, resolution, fps, output=nil)
-        inout "color=%{color}:d=%{duration}:s=%{resolution}:r=%{fps}", nil, output,
-          color: color, duration: duration, resolution: resolution, fps: fps
+      def blend_a(duration, inputs, output=nil)
+        fail Error, "must be given 2 inputs"  unless inputs.size == 2
+
+        aux_lbl = "blnd#{inputs[0]}"
+        auxx_lbl = "x#{aux_lbl}"
+        [
+          *afade_out(duration, inputs[0], aux_lbl),
+          *afade_in(duration, inputs[1], auxx_lbl),
+          *amix_to_first_same_volume([auxx_lbl, aux_lbl], output)
+        ]
       end
 
-      def fade_out_alpha(duration, input=nil, output=nil)
-        inout "fade=out:d=%{duration}:alpha=1", input, output, duration: duration
+      def blend_v(duration, resolution, fps, inputs, output=nil)
+        fail Error, "must be given 2 inputs"  unless inputs.size == 2
+
+        aux_lbl = "blnd#{inputs[0]}"
+        auxx_lbl = "x#{aux_lbl}"
+        [
+          *white_source(duration, resolution, fps, aux_lbl),
+          *inout([
+                   *alphamerge([inputs[0], aux_lbl]),
+                   *fade_out_alpha(duration)
+                 ].join(', '), nil, auxx_lbl),
+          *overlay(0, 0, [inputs[1], auxx_lbl], output),
+        ]
       end
 
-      def fps(fps, input=nil, output=nil)
-        inout "fps=fps=%{fps}", input, output, fps: fps
+      def color_source(color, duration, resolution, fps, output=nil)
+        inout 'color=%{color}:d=%{duration}:s=%{resolution}:r=%{fps}', nil, output,
+          color: color, duration: duration, resolution: resolution, fps: fps
       end
 
       def concat_v(inputs, output=nil)
         return copy(inputs, output)  if inputs.size == 1
-        inout "concat=#{inputs.size}:v=1:a=0", inputs, output
+        inout 'concat=%{count}:v=1:a=0', inputs, output, count: inputs.size
       end
 
       def concat_a(inputs, output=nil)
         return anull(inputs, output)  if inputs.size == 1
-        inout "concat=#{inputs.size}:v=0:a=1", inputs, output
+        inout 'concat=%{count}:v=0:a=1', inputs, output, count: inputs.size
       end
 
       def concat_av(inputs, output=nil)
         fail Error, "must be given an even number of inputs"  unless inputs.size.even?
-        inout "concat=#{inputs.size/2}:v=1:a=1", inputs, output
+        inout 'concat=%{count}:v=1:a=1', inputs, output, count: inputs.size/2
       end
 
       def copy(input=nil, output=nil)
-        inout "copy", input, output
+        inout 'copy', input, output
       end
 
       # TODO unused at the moment
       def crop(crop, input=nil, output=nil)
-        inout "crop=x=%{left}:y=%{top}:w=%{width}:h=%{height}", input, output, crop
+        inout 'crop=x=%{left}:y=%{top}:w=%{width}:h=%{height}', input, output, crop
       end
 
       def crop_prop(crop, input=nil, output=nil)
-        inout "crop=%{crop_exp}", input, output,
+        inout 'crop=%{crop_exp}', input, output,
           crop_exp: crop_prop_exps(crop).join(':')
       end
 
@@ -136,33 +176,58 @@ module Ffmprb
         exps
       end
 
+      def fade_out_alpha(duration, input=nil, output=nil)
+        inout 'fade=out:d=%{duration}:alpha=1', input, output, duration: duration
+      end
+
+      def fps(fps, input=nil, output=nil)
+        inout 'fps=fps=%{fps}', input, output, fps: fps
+      end
+
+      def interpolate_v(fps, input=nil, output=nil)
+        inout 'framerate=fps=%{fps}', input, output, fps: fps
+      end
+      # TODO other effects like... minterpolate=fps=%{fps}:mi_mode=mci:mc_mode=aobmc:vsbmc=1
+
       # NOTE might be very useful with UGC: def cropdetect
 
       def nullsink(input=nil)
-        inout "nullsink", input, nil
+        inout 'nullsink', input, nil
       end
 
       def overlay(x=0, y=0, inputs=nil, output=nil)
-        inout "overlay=x=%{x}:y=%{y}:eof_action=pass", inputs, output, x: x, y: y
+        inout 'overlay=x=%{x}:y=%{y}:eof_action=pass', inputs, output, x: x, y: y
       end
 
       def pad(resolution, input=nil, output=nil)
         width, height = resolution.to_s.split('x')
         inout [
-          inout("pad=%{width}:%{height}:(%{width}-iw*min(%{width}/iw\\,%{height}/ih))/2:(%{height}-ih*min(%{width}/iw\\,%{height}/ih))/2",
+          inout('pad=%{width}:%{height}:(%{width}-iw*min(%{width}/iw\\,%{height}/ih))/2:(%{height}-ih*min(%{width}/iw\\,%{height}/ih))/2',
             width: width, height: height),
           *setsar(1)  # NOTE the scale & pad formulae damage SAR a little, unfortunately
         ].join(', '), input, output
       end
 
+      def pp(input=nil, output=nil)
+        inout 'pp=hb/vb/dr/al', input, output
+      end
+
+      def reverse(input=nil, output=nil)
+        inout 'reverse', input, output
+      end
+
       def setsar(ratio, input=nil, output=nil)
-        inout "setsar=%{ratio}", input, output, ratio: ratio
+        inout 'setsar=%{ratio}', input, output, ratio: ratio
+      end
+
+      def setpts(ratio, input=nil, output=nil)
+        inout 'setpts=%{r_fps}*PTS', input, output, r_fps: 1.0/ratio
       end
 
       def scale(resolution, input=nil, output=nil)
         width, height = resolution.to_s.split('x')
         inout [
-          inout("scale=iw*min(%{width}/iw\\,%{height}/ih):ih*min(%{width}/iw\\,%{height}/ih)", width: width, height: height),
+          inout('scale=iw*min(%{width}/iw\\,%{height}/ih):ih*min(%{width}/iw\\,%{height}/ih)', width: width, height: height),
           *setsar(1)  # NOTE the scale & pad formulae damage SAR a little, unfortunately
         ].join(', '), input, output
       end
@@ -182,49 +247,22 @@ module Ffmprb
       end
 
       def silencedetect(input=nil, output=nil)
-        inout "silencedetect=d=1:n=%{silence_noise_max_db}dB", input, output,
+        inout 'silencedetect=d=1:n=%{silence_noise_max_db}dB', input, output,
           silence_noise_max_db: silence_noise_max_db
       end
 
       def silent_source(duration, output=nil)
-        inout "aevalsrc=0:d=%{duration}", nil, output, duration: duration
+        inout 'aevalsrc=0:d=%{duration}', nil, output, duration: duration
       end
 
       # NOTE might be very useful with transitions: def smartblur
 
       def split(inputs=nil, outputs=nil)
-        inout "split", inputs, outputs
-      end
-
-      def blend_v(duration, resolution, fps, inputs, output=nil)
-        fail Error, "must be given 2 inputs"  unless inputs.size == 2
-
-        aux_lbl = "blnd#{inputs[0]}"
-        auxx_lbl = "x#{aux_lbl}"
-        [
-          *white_source(duration, resolution, fps, aux_lbl),
-          *inout([
-            *alphamerge([inputs[0], aux_lbl]),
-            *fade_out_alpha(duration)
-          ].join(', '), nil, auxx_lbl),
-          *overlay(0, 0, [inputs[1], auxx_lbl], output),
-        ]
-      end
-
-      def blend_a(duration, inputs, output=nil)
-        fail Error, "must be given 2 inputs"  unless inputs.size == 2
-
-        aux_lbl = "blnd#{inputs[0]}"
-        auxx_lbl = "x#{aux_lbl}"
-        [
-          *afade_out(duration, inputs[0], aux_lbl),
-          *afade_in(duration, inputs[1], auxx_lbl),
-          *amix_to_first_same_volume([auxx_lbl, aux_lbl], output)
-        ]
+        inout 'split', inputs, outputs
       end
 
       def trim(st, en=nil, input=nil, output=nil)
-        inout "trim=%{start_end}, setpts=PTS-STARTPTS", input, output,
+        inout 'trim=%{start_end}, setpts=PTS-STARTPTS', input, output,
           start_end: [st, en].compact.join(':')
       end
 
@@ -261,8 +299,12 @@ module Ffmprb
         color_source '0xFFFFFF@1', duration, resolution, fps, output
       end
 
+
       def complex_args(*filters)
-        ['-filter_complex', filters.join('; ')]  unless filters.empty?
+        [].tap do |args|
+          args << '-filter_complex' << filters.join('; ') unless
+            filters.empty?
+        end
       end
 
       private
@@ -276,9 +318,6 @@ module Ffmprb
         filter = filter + " #{[*outputs].map{|s| "[#{s}]"}.join ' '}"  if outputs
         [filter]
       end
-
     end
-
   end
-
 end

data/lib/ffmprb/find_silence.rb

@@ -5,7 +5,7 @@ module Ffmprb
     # NOTE not for streaming just yet
     def find_silence(input_file, output_file)
       path = "#{input_file.path}->#{output_file.path}"
-      logger.debug "Finding silence (#{path})"
+      logger.debug{"Finding silence (#{path})"}
       silence = []
       Util.ffmpeg('-i', input_file.path, *find_silence_detect_args, output_file.path).
         scan(SILENCE_DETECT_REGEX).each do |mark, time|
@@ -25,7 +25,10 @@ module Ffmprb
           Ffmprb.warn "Unknown silence mark: #{mark}"
         end
       end
-      logger.debug "Found silence (#{path}): [#{silence.map{|t,v| "#{t}: #{v}"}}]"
+      logger.debug{
+        silence_map = silence.map{|t,v| "#{t}: #{v}"}
+        "Found silence (#{path}): [#{silence_map}]"
+      }
       silence
     end
 

data/lib/ffmprb/process/input/chain_base.rb

@@ -14,16 +14,18 @@ module Ffmprb
         def unfiltered=(input); @io = input; end
 
 
-        def chain_copy(src_input)  # XXX SPEC ME
+        def chain_copy(src_input)  # TODO SPEC ME
           dup.tap do |top|
             top.unfiltered = unfiltered.chain_copy(src_input)
           end
         end
 
-      end
+        def filters_for(lbl, video:, audio:)
 
+          # Doing nothing
+          unfiltered.filters_for lbl, video: video, audio: audio
+        end
+      end
     end
-
   end
-
 end

data/lib/ffmprb/process/input/channeled.rb

@@ -25,7 +25,7 @@ module Ffmprb
 
         def filters_for(lbl, video:, audio:)
 
-          # Doing nothing
+          # Doing basically nothing
 
           unfiltered.filters_for lbl,
             video: channel?(:video) && video, audio: channel?(:audio) && audio