ffi-gdal 1.0.0.beta6 → 1.0.0.beta11

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'simplecov'
 SimpleCov.start do
   add_filter '/spec/'
@@ -7,7 +9,7 @@ SimpleCov.start do
   add_group 'ext', 'lib/ext'
 end
 
-$LOAD_PATH.unshift File.expand_path('../lib', __FILE__)
+$LOAD_PATH.unshift File.expand_path('lib', __dir__)
 require 'ffi-gdal'
 require 'byebug'
 

data/spec/support/integration_help.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'fileutils'
 
 # Helper methods for integration specs.

data/spec/support/shared_contexts.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.shared_context 'OGR::Layer, spatial_reference' do
   require 'ogr/driver'
   require 'ogr/spatial_reference'

data/spec/support/shared_examples/gdal/major_object_examples.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.shared_examples 'a major object' do
   describe '#metadata_domain_list' do
     it 'is an Array of Strings' do

data/spec/support/shared_examples/ogr/{a_25D_geometry.rb → a_25d_geometry.rb}

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.shared_examples 'a 2.5D geometry' do
   describe '#flatten_to_2d' do
     it 'drops the z point(s)' do

data/spec/support/shared_examples/ogr/a_container_geometry.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Requirements:
 #   * :child_geometry - one that the described class can
 RSpec.shared_examples 'a container geometry' do

data/spec/support/shared_examples/ogr/a_geometry.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.shared_examples 'a geometry' do
   require 'ogr'
 
@@ -353,7 +355,7 @@ RSpec.shared_examples 'a geometry' do
 
   describe '#wkb_size' do
     it 'returns a non-zero integer' do
-      expect(geometry.wkb_size).to be_a Fixnum
+      expect(geometry.wkb_size).to be_a Integer
 
       if geometry.name == 'LINEARRING'
         expect(geometry.wkb_size).to be_zero

data/spec/support/shared_examples/ogr/a_line_string.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.shared_examples 'a line string' do
   describe '#dimension' do
     subject { geometry.dimension }

data/spec/unit/ext/error_symbols_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'ext/error_symbols'
 

data/spec/unit/ext/numeric_as_data_type_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe Numeric do

data/spec/unit/ffi/gdal_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'fakefs/safe'
 
@@ -9,6 +11,7 @@ RSpec.describe FFI::GDAL do
       end
 
       it 'returns GDAL_LIBRARY_PATH + libgdal file name' do
+        expect(Dir).to receive(:[]).with(%r{/pants/stuff\.+}).and_return '/pants/stuff.dylib'
         expect(described_class.find_lib('stuff')).to match %r{\A/pants/stuff\.+}
       end
     end

data/spec/unit/gdal/color_entry_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'gdal/color_entry'
 

data/spec/unit/gdal/color_interpretation_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'gdal/color_interpretation'
 

data/spec/unit/gdal/color_table_mixins/extensions_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'gdal/color_table'
 

data/spec/unit/gdal/color_table_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'gdal/color_table'
 

data/spec/unit/gdal/data_type_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'gdal/data_type'
 

data/spec/unit/gdal/dataset_mixins/warp_methods_spec.rb

@@ -0,0 +1,55 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'gdal'
+
+RSpec.describe GDAL::Dataset do
+  let(:source_file_path) do
+    File.expand_path('../../../support/images/osgeo/geotiff/GeogToWGS84GeoKey/GeogToWGS84GeoKey5.tif', __dir__)
+  end
+
+  let(:output_dir) { Dir.mktmpdir(File.basename(__FILE__, '.rb')) }
+  let(:output_file) { File.join(output_dir, 'reprojected_image.tif') }
+
+  after { FileUtils.rm_rf(output_dir) if Dir.exist?(output_dir) }
+
+  subject { described_class.open(source_file_path, 'r', false) }
+
+  describe '#reproject_image' do
+    let(:dest_dataset) do
+      dest_width = subject.raster_x_size / 4
+      dest_height = subject.raster_y_size / 4
+      dataset = GDAL::Driver.by_name('GTiff').create_dataset(output_file, dest_width, dest_height,
+        data_type: subject.raster_band(1).data_type)
+      dataset.geo_transform = subject.geo_transform.dup
+      dataset.projection = OGR::SpatialReference.new_from_epsg(3857).to_wkt
+      dataset
+    end
+
+    after { dest_dataset.close }
+
+    it 'creates a valid dataset' do
+      subject.reproject_image(dest_dataset, :GRA_CubicSpline)
+
+      dest_dataset.flush_cache
+      expect(dest_dataset.projection).to match(/AUTHORITY\[\"EPSG\",\"3857\"\]/)
+      expect(dest_dataset.raster_count).to eq(subject.raster_count)
+    end
+  end
+
+  describe '#create_and_reproject_image' do
+    let(:output_projection) { OGR::SpatialReference.new_from_epsg(3857).to_wkt }
+
+    it 'creates a valid dataset' do
+      subject.create_and_reproject_image(output_file, :GRA_NearestNeighbor,
+        OGR::SpatialReference.new_from_epsg(3857).to_wkt, GDAL::Driver.by_name('GTiff'))
+
+      dest_dataset = GDAL::Dataset.open(output_file, 'r')
+      expect(dest_dataset.projection).to match(/AUTHORITY\[\"EPSG\",\"3857\"\]/)
+      expect(dest_dataset.raster_count).to eq(subject.raster_count)
+
+      dest_driver = dest_dataset.driver
+      expect(dest_driver.long_name).to eq 'GeoTIFF'
+    end
+  end
+end

data/spec/unit/gdal/dataset_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'gdal/dataset'
 

data/spec/unit/gdal/driver_mixins/extensions_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'gdal/driver'
 

data/spec/unit/gdal/driver_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'gdal/driver'
 

data/spec/unit/gdal/environment_methods_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'gdal/environment_methods'
 

data/spec/unit/gdal/geo_transform_mixins/extensions_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'gdal/geo_transform'
 require 'gdal/geo_transform_mixins/extensions'

data/spec/unit/gdal/geo_transform_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'gdal/geo_transform'
 
@@ -259,18 +261,5 @@ RSpec.describe GDAL::GeoTransform do
         expect(result).to eq pixel: -9000, line: -19_000
       end
     end
-
-    describe '#as_json' do
-      it 'returns the attributes as a Hash' do
-        expect(subject.as_json).to eq(
-          x_origin: 0.0,
-          x_rotation: 0.0,
-          pixel_width: 0.0,
-          y_origin: 0.0,
-          y_rotation: 0.0,
-          pixel_height: 0.0
-        )
-      end
-    end
   end
 end

data/spec/unit/gdal/grid_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'gdal/grid'
 
@@ -12,6 +14,14 @@ RSpec.describe GDAL::Grid do
     it { is_expected.to respond_to :algorithm_type }
   end
 
+  describe '#create' do
+    context 'no points to grid' do
+      it 'raises a GDAL::NoValuesToGrid' do
+        expect { subject.create([], {}, nil) }.to raise_exception GDAL::NoValuesToGrid
+      end
+    end
+  end
+
   describe '#make_points_pointer' do
     context 'array has values' do
       let(:points) { [1, 2, 3, 4] }

data/spec/unit/gdal/gridder/point_extracting_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'gdal/gridder'
 

data/spec/unit/gdal/gridder_options_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'gdal/gridder_options'
 

data/spec/unit/gdal/gridder_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'gdal/gridder'
 
@@ -137,4 +139,44 @@ RSpec.describe GDAL::Gridder do
       end
     end
   end
+
+  describe '#build_block_count' do
+    it 'builds block sizes for both x and y' do
+      raster_width = 4
+      block_x_size = 2
+      raster_height = 5
+      block_y_size = 3
+
+      expect(subject).to receive(:build_block_size).with(raster_width, block_x_size).
+        and_call_original
+      expect(subject).to receive(:build_block_size).with(raster_height, block_y_size).
+        and_call_original
+
+      subject.send(:build_block_count, block_x_size, block_y_size, raster_width, raster_height)
+    end
+  end
+
+  describe '#build_block_size' do
+    context 'calculation should not be evenly divisible' do
+      it 'returns the floor of the count' do
+        raster_width = 4
+        block_x_size = 2
+
+        result = subject.send(:build_block_size, raster_width, block_x_size)
+
+        expect(result).to eq 2
+      end
+    end
+
+    context 'calculation should be evenly divisible' do
+      it 'returns the floor of the count' do
+        raster_width = 4
+        block_x_size = 1
+
+        result = subject.send(:build_block_size, raster_width, block_x_size)
+
+        expect(result).to eq 4
+      end
+    end
+  end
 end

data/spec/unit/gdal/internal_helpers_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'gdal/internal_helpers'
 require 'ogr/spatial_reference'

data/spec/unit/gdal/major_object_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'gdal/major_object'
 

data/spec/unit/gdal/options_spec.rb

@@ -1,6 +1,33 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'gdal/options'
 
 RSpec.describe GDAL::Options do
-  pending 'Add some tests!'
+  describe '.to_hash' do
+    subject { described_class.to_hash(pointer) }
+
+    context 'options are set' do
+      let(:pointer) { described_class.pointer(hash) }
+
+      let(:hash) do
+        {
+          one: 'ONE',
+          two: 'TWO'
+        }
+      end
+
+      it 'returns the Ruby Hash' do
+        expect(subject).to eq(hash)
+      end
+    end
+
+    context 'pointer is null' do
+      let(:pointer) { FFI::MemoryPointer.new(:string) }
+
+      it 'returns an empty Hash' do
+        expect(subject).to eq({})
+      end
+    end
+  end
 end

data/spec/unit/gdal/raster_attribute_table_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'gdal/raster_attribute_table'
 

data/spec/unit/gdal/raster_band_classifier_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'gdal/driver'
 require 'gdal/raster_band_classifier'
@@ -96,8 +98,8 @@ RSpec.describe GDAL::RasterBandClassifier do
     end
 
     context 'all nodata pixels' do
-      let(:band_narray) { NArray.byte(0) }
-      before { allow(raster_band).to receive(:to_na).and_return(band_narray) }
+      let(:band_narray) { Numo::Int8.new(3, 5).fill(0) }
+      before { allow(raster_band).to receive(:to_nna).and_return(band_narray) }
 
       it 'returns an empty Array' do
         expect(subject.equal_count_ranges(10)).to eq([])
@@ -129,7 +131,7 @@ RSpec.describe GDAL::RasterBandClassifier do
       end
 
       it 'retains its NODATA pixels' do
-        expect { subject.classify! }.to_not change { raster_band.to_na.eq(-9999.0).count_true }
+        expect { subject.classify! }.to_not(change { raster_band.to_na.eq(-9999.0).count_true })
       end
     end
 
@@ -159,7 +161,7 @@ RSpec.describe GDAL::RasterBandClassifier do
       end
 
       it 'retains its NODATA pixels' do
-        expect { subject.classify! }.to_not change { raster_band.to_na.eq(-9999.0).count_true }
+        expect { subject.classify! }.to_not(change { raster_band.to_na.eq(-9999.0).count_true })
         pixels = raster_band.to_na
         expect(pixels.eq(-9999).count_true).to eq 640
         expect(pixels.eq(0).count_true).to eq 0
@@ -190,7 +192,43 @@ RSpec.describe GDAL::RasterBandClassifier do
       end
 
       it 'retains its NODATA pixels' do
-        expect { subject.classify! }.to_not change { raster_band.to_na.eq(-9999.0).count_true }
+        expect { subject.classify! }.to_not(change { raster_band.to_na.eq(-9999.0).count_true })
+      end
+    end
+  end
+
+  describe '#masked_pixels' do
+    let(:pixels) { dataset.raster_band(1).to_nna }
+    let(:raster_band) { double 'Band', no_data_value: { value: nodata_value } }
+
+    before { subject.instance_variable_set(:@raster_band, raster_band) }
+
+    context 'nodata is NaN' do
+      let(:nodata_value) { Float::NAN }
+      let(:pixels) { Numo::DFloat.cast(dataset.raster_band(1).to_nna) }
+
+      before do
+        pixels[pixels.eq(0)] = nodata_value
+      end
+
+      it 'removes all nodata values' do
+        expect(subject.send(:masked_pixels, pixels).isnan.count_true).to eq 0
+      end
+    end
+
+    context 'nodata is a number' do
+      let(:nodata_value) { 0 }
+
+      it 'removes all nodata values' do
+        expect(subject.send(:masked_pixels, pixels).eq(0).count_true).to eq 0
+      end
+    end
+
+    context 'nodata is nil' do
+      let(:nodata_value) { nil }
+
+      it 'returns the original pixels' do
+        expect(subject.send(:masked_pixels, pixels)).to eq pixels
       end
     end
   end