ffaker 2.7.0 → 2.21.0

data/test/test_sport_us.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+require_relative 'helper'
+
+class TestSportUS < Test::Unit::TestCase
+  include DeterministicHelper
+
+  assert_methods_are_deterministic(FFaker::SportUS, :name)
+
+  def setup
+    @tester = FFaker::SportUS
+  end
+
+  def test_name
+    assert_include @tester::NAMES, @tester.name
+  end
+end

data/test/test_sports.rb

@@ -1,6 +1,6 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
-require 'helper'
+require_relative 'helper'
 
 class TestSports < Test::Unit::TestCase
   include DeterministicHelper

data/test/test_ssn.rb

@@ -1,13 +1,27 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
-require 'helper'
+require_relative 'helper'
 
 class TestSSN < Test::Unit::TestCase
   include DeterministicHelper
 
   assert_methods_are_deterministic(FFaker::SSN, :ssn)
 
-  def test_ssn
-    assert_match(/\d{3}-\d{2}-\d{3}/, FFaker::SSN.ssn)
+  def setup
+    @actual_ssn = FFaker::SSN.ssn
+  end
+
+  def test_ssn_format
+    assert_no_match(/\A666/, @actual_ssn)
+    assert_match(/\A[0-8]\d{2}-\d{2}-\d{4}\Z/, @actual_ssn)
+  end
+
+  def test_ssn_groups_non_zero
+    first_group, second_group, third_group = @actual_ssn.split('-')
+    with_all_zeros = /\A0+\Z/
+
+    assert_no_match(with_all_zeros, first_group)
+    assert_no_match(with_all_zeros, second_group)
+    assert_no_match(with_all_zeros, third_group)
   end
 end

data/test/test_ssn_mx.rb

@@ -1,8 +1,7 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
-require 'helper'
+require_relative 'helper'
 
-# Author Guapolo <github.com/guapolo>
 class TestSSNMX < Test::Unit::TestCase
   include DeterministicHelper
 

data/test/test_ssn_se.rb

@@ -1,6 +1,6 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
-require 'helper'
+require_relative 'helper'
 
 class TestSSNSE < Test::Unit::TestCase
   include DeterministicHelper
@@ -12,16 +12,16 @@ class TestSSNSE < Test::Unit::TestCase
     assert_match(/(19|20)\d{10}/, ssn, "With no arguments year should start with 19 or 20, #{ssn}")
   end
 
-  def is_equal?(nbr)
-    nbr % 2
+  def equal?(other)
+    other % 2
   end
 
   def test_ssn_with_gender
     ssn_male = FFaker::SSNSE.ssn(gender: :male)
-    assert is_equal?(ssn_male[10].to_i)
+    assert equal?(ssn_male[10].to_i)
 
     ssn_female = FFaker::SSNSE.ssn(gender: :female)
-    assert is_equal?(ssn_female[10].to_i)
+    assert equal?(ssn_female[10].to_i)
 
     assert_raise ArgumentError do
       FFaker::SSNSE.ssn(gender: :unkown)
@@ -29,17 +29,15 @@ class TestSSNSE < Test::Unit::TestCase
   end
 
   def test_ssn_with_from_to
-    10.times do
-      from = Time.local(1980, 2, 28)
-      to = Time.local(2000, 2, 28)
+    from = Time.local(1980, 2, 28)
+    to = Time.local(2000, 2, 28)
 
+    assert_random_between(from...to) do
       ssn = FFaker::SSNSE.ssn(from: from, to: to)
       year = ssn[0..3].to_i
       month = ssn[4..5].to_i
       day = ssn[6..7].to_i
-      ssn_birth_date = Time.local(year, month, day)
-      assert ssn_birth_date < to
-      assert ssn_birth_date >= from
+      Time.local(year, month, day)
     end
   end
 end

data/test/test_string.rb

@@ -1,6 +1,6 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
-require 'helper'
+require_relative 'helper'
 
 class TestString < Test::Unit::TestCase
   include DeterministicHelper
@@ -30,11 +30,11 @@ class TestString < Test::Unit::TestCase
   def test_dash_character
     assert_match(/\A[a-z-]\z/, FS.from_regexp(/[a-z-]/))
     assert_match(/\A[a-]\z/, FS.from_regexp(/[a-]/))
-    assert_match(/\A[-]\z/, FS.from_regexp(/[-]/))
+    assert_match(/\A-\z/, FS.from_regexp(/-/))
 
     assert_deterministic { FS.from_regexp(/[a-z-]/) }
     assert_deterministic { FS.from_regexp(/[a-]/) }
-    assert_deterministic { FS.from_regexp(/[-]/) }
+    assert_deterministic { FS.from_regexp(/-/) }
   end
 
   def test_spaces
@@ -43,8 +43,8 @@ class TestString < Test::Unit::TestCase
   end
 
   def test_escaped_characters
-    assert_equal '\\/.()[]{}', FS.from_regexp(/\\\/\.\(\)\[\]\{\}/)
-    assert_deterministic { FS.from_regexp(%r|\\\/\.\(\)\[\]\{\}|) }
+    assert_equal '\\/.()[]{}', FS.from_regexp(%r{\\/\.\(\)\[\]\{\}})
+    assert_deterministic { FS.from_regexp(%r|\\/\.\(\)\[\]\{\}|) }
   end
 
   def test_atom_sets
@@ -53,8 +53,8 @@ class TestString < Test::Unit::TestCase
   end
 
   def test_special_sets
-    assert_match(/\A[\w\d]\z/, FS.from_regexp(/[\w\d]/))
-    assert_deterministic { FS.from_regexp(/[\w\d]/) }
+    assert_match(/\A[\s\d]\z/, FS.from_regexp(/[\s\d]/))
+    assert_deterministic { FS.from_regexp(/[\s\d]/) }
   end
 
   def test_atom_question

data/test/test_time.rb

@@ -1,6 +1,7 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
-require 'helper'
+require_relative 'helper'
+require 'date'
 
 class TestFakerTime < Test::Unit::TestCase
   include DeterministicHelper
@@ -12,8 +13,7 @@ class TestFakerTime < Test::Unit::TestCase
   end
 
   def test_date
-    date_regex = /\A\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2} [-|+]\d{4}\z/
-    assert_match(date_regex, @tester.date)
+    assert_instance_of Date, @tester.date
   end
 
   def test_day_of_week
@@ -24,35 +24,78 @@ class TestFakerTime < Test::Unit::TestCase
     assert_deterministic { @tester.day_of_week }
   end
 
-  def test_date_hours_and_minutes
-    assert_match('04:20:00', @tester.date(hours: 4, minutes: 20))
-    assert_deterministic { @tester.date(hours: 4, minutes: 20) }
+  def test_datetime
+    assert_instance_of DateTime, @tester.datetime
   end
 
-  def test_datetime
-    date_regex = /\A\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2} [-|+]\d{4}\z/
-    assert_match(date_regex, @tester.datetime)
+  def test_datetime_random_days_and_months
+    1_000.times do
+      @tester.datetime
+    end
   end
 
   def test_datetime_hours_and_minutes
-    assert_match('04:20:00', @tester.datetime(hours: 4, minutes: 20))
+    assert_equal(4, @tester.datetime(hours: 4, minutes: 20).hour)
+    assert_equal(20, @tester.datetime(hours: 4, minutes: 20).min)
     assert_deterministic { @tester.datetime(hours: 4, minutes: 20) }
   end
 
+  def test_datetime_year_range_and_year_latest
+    current_year = ::DateTime.now.year
+    [[0, 0], [1, 1], [2, 4], [8, 6]].each do |year_range, year_latest|
+      assert_random_between(
+        (current_year - year_range - year_latest)..(current_year - year_latest)
+      ) do
+        @tester.datetime(year_range: year_range, year_latest: year_latest).year
+      end
+    end
+  end
+
   def test_month
     month_regex = /\A(?:January|February|March|April|May|June|July|August|September|October|November|December)\z/
     assert_match(month_regex, @tester.month)
   end
 
-  def test_between
+  def test_between_for_time
     from = Time.local(2015, 1, 1)
     to   = Time.local(2016, 1, 1)
 
-    100.times do
-      random_date = @tester.between(from, to)
-      assert random_date >= from, "Expected >= \"#{from}\", but got #{random_date}"
-      assert random_date <= to, "Expected <= \"#{to}\", but got #{random_date}"
-      assert_deterministic { @tester.between(from, to) }
-    end
+    assert_random_between(from..to) { @tester.between(from, to) }
+  end
+
+  def test_between_for_string
+    from = @tester.datetime
+    to   = @tester.datetime
+    random_date = @tester.between(from, to)
+    assert_instance_of Time, random_date
+  end
+
+  def test_between_for_date
+    from = Date.new(2015, 1, 1)
+    to   = Date.new(2016, 1, 1)
+    random_date = @tester.between(from, to)
+    assert_instance_of Time, random_date
+  end
+
+  def test_between_for_datetime
+    from = DateTime.new(2015, 1, 1, 12, 12)
+    to   = DateTime.new(2016, 1, 1, 12, 12)
+    random_date = @tester.between(from, to)
+    assert_instance_of Time, random_date
+  end
+
+  def test_convert_to_time_string
+    time = @tester.send(:convert_to_time, '2012-12-12 12:12')
+    assert_instance_of Time, time
+  end
+
+  def test_convert_to_time_date
+    time = @tester.send(:convert_to_time, Date.new(2015, 1, 1))
+    assert_instance_of Time, time
+  end
+
+  def test_convert_to_time_datetime
+    time = @tester.send(:convert_to_time, DateTime.new(2015, 1, 1, 12, 12))
+    assert_instance_of Time, time
   end
 end

data/test/test_tweet.rb

@@ -1,6 +1,6 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
-require 'helper'
+require_relative 'helper'
 
 class TestTweet < Test::Unit::TestCase
   include DeterministicHelper
@@ -20,40 +20,40 @@ class TestTweet < Test::Unit::TestCase
   end
 
   def test_mention
-    assert_match(/\@\S*/, FFaker::Tweet.mention)
+    assert_match(/@\S*/, FFaker::Tweet.mention)
   end
 
   def test_mentions_three
-    assert_match(/\@\S*\s\@\S*\s\@\S*/, FFaker::Tweet.mentions(3))
+    assert_match(/@\S*\s@\S*\s@\S*/, FFaker::Tweet.mentions(3))
     assert_deterministic { FFaker::Tweet.mentions(3) }
   end
 
   def test_body
-    assert(FFaker::Tweet.body.size <= 140)
+    assert_less_than_or_equal_to FFaker::Tweet.body.size, 140
   end
 
   def test_shortish_body
-    assert(FFaker::Tweet.body(20).size <= 20)
+    assert_less_than_or_equal_to FFaker::Tweet.body(20).size, 20
   end
 
   def test_short_body
-    assert(FFaker::Tweet.body(2).size.between?(2, 20))
+    assert_between(FFaker::Tweet.body(2).size, 2..20)
   end
 
   def test_tweet
-    100.times { assert(FFaker::Tweet.tweet.size <= 140) }
+    assert_random_less_than_or_equal_to(140) { FFaker::Tweet.tweet.size }
   end
 
   def test_tweet_with_reply
-    assert_match(/^\@/, FFaker::Tweet.tweet(reply: true))
+    assert_match(/^@/, FFaker::Tweet.tweet(reply: true))
     assert_deterministic { FFaker::Tweet.tweet(reply: true) }
   end
 
   def test_oversize_body_length
-    assert(FFaker::Tweet.tweet(body_length: 200).size <= 140)
+    assert_less_than_or_equal_to FFaker::Tweet.tweet(body_length: 200).size, 140
   end
 
   def test_undersize_body_length
-    assert(FFaker::Tweet.tweet(body_length: 2).size <= 140)
+    assert_less_than_or_equal_to FFaker::Tweet.tweet(body_length: 2).size, 140
   end
 end

data/test/test_unique_utils.rb

@@ -1,6 +1,6 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
-require 'helper'
+require_relative 'helper'
 
 class TestUniqueUtils < Test::Unit::TestCase
   def test_generates_unique_values

data/test/test_units.rb

@@ -1,8 +1,8 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
-require 'helper'
+require_relative 'helper'
+require 'ostruct'
 
-# Author: lurraca github.com/lurraca
 class TestUnits < Test::Unit::TestCase
   include DeterministicHelper
 

data/test/test_units_english.rb

@@ -1,8 +1,7 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
-require 'helper'
+require_relative 'helper'
 
-# Author: lurraca github.com/lurraca
 class TestUnitsEnglish < Test::Unit::TestCase
   include DeterministicHelper
 

data/test/test_units_metric.rb

@@ -1,8 +1,7 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
-require 'helper'
+require_relative 'helper'
 
-# Author: lurraca github.com/lurraca
 class TestUnitsMetric < Test::Unit::TestCase
   include DeterministicHelper
 

data/test/test_vehicle.rb

@@ -1,6 +1,6 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
-require 'helper'
+require_relative 'helper'
 
 class TestVehicle < Test::Unit::TestCase
   include DeterministicHelper
@@ -33,7 +33,7 @@ class TestVehicle < Test::Unit::TestCase
   end
 
   def test_model
-    assert_match(/\A[-\. &a-z0-9]+\z/i, FFaker::Vehicle.model)
+    assert_match(/\A[-. &a-z0-9]+\z/i, FFaker::Vehicle.model)
   end
 
   def test_trim
@@ -41,7 +41,12 @@ class TestVehicle < Test::Unit::TestCase
   end
 
   def test_vin
-    assert_match(/\A[A-Z0-9]{17}\z/, FFaker::Vehicle.vin)
+    vin = FFaker::Vehicle.vin
+
+    assert_match(/\A[A-Z0-9]{17}\z/, vin)
+    assert_not_match(/[IOQ]/, vin) # VINs can't have these letters
+    assert_includes(FFaker::Vehicle::VIN::VALID_ALPHA, vin[6]) # passenger vehicle designator
+    assert_includes(FFaker::Vehicle::VIN::VALID_YEAR_CHARS, vin[9]) # check year character
   end
 
   def test_drivetrain
@@ -65,7 +70,7 @@ class TestVehicle < Test::Unit::TestCase
   end
 
   def test_fuel_type
-    assert_match(/\A[ a-z0-9\(\)]+\z/i, FFaker::Vehicle.fuel_type)
+    assert_match(/\A[ a-z0-9()]+\z/i, FFaker::Vehicle.fuel_type)
   end
 
   def test_interior_upholstery

data/test/test_venue.rb

@@ -1,6 +1,6 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
-require 'helper'
+require_relative 'helper'
 
 class TestVenue < Test::Unit::TestCase
   include DeterministicHelper

data/test/test_youtube.rb

@@ -1,6 +1,6 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
-require 'helper'
+require_relative 'helper'
 
 class YoutubeTest < Test::Unit::TestCase
   include DeterministicHelper