ffaker 2.21.0 → 2.23.0

data/lib/ffaker/utils/module_utils.rb

@@ -13,7 +13,7 @@ module FFaker
     end
 
     def const_missing(const_name)
-      if const_name =~ /[a-z]/ # Not a constant, probably a class/module name.
+      if const_name.match?(/[a-z]/) # Not a constant, probably a class/module name.
         super const_name
       else
         mod_name = ancestors.first.to_s.split('::').last
@@ -25,7 +25,7 @@ module FFaker
     end
 
     def underscore(string)
-      string.gsub(/::/, '/')
+      string.gsub('::', '/')
             .gsub(/([A-Z]+)([A-Z][a-z])/, '\1_\2')
             .gsub(/([a-z\d])([A-Z])/, '\1_\2')
             .tr('-', '_')
@@ -33,14 +33,14 @@ module FFaker
     end
 
     def unique(max_retries = 10_000)
-      @unique_generator ||= FFaker::UniqueUtils.new(self, max_retries)
+      FFaker::UniqueUtils.add_instance(self, max_retries)
     end
 
     # http://en.wikipedia.org/wiki/Luhn_algorithm
     def luhn_check(number)
       multiplications = []
 
-      number.split(//).each_with_index do |digit, i|
+      number.chars.each_with_index do |digit, i|
         multiplications << i.even? ? digit.to_i * 2 : digit.to_i
       end
 
@@ -51,9 +51,8 @@ module FFaker
         end
       end
 
-      control_digit = (sum % 10).zero? ? 0 : (sum / 10 + 1) * 10 - sum
+      control_digit = (sum % 10).zero? ? 0 : (((sum / 10) + 1) * 10) - sum
       control_digit.to_s
     end
-
   end
 end

data/lib/ffaker/utils/unique_utils.rb

@@ -1,44 +1,56 @@
 # frozen_string_literal: true
+
 require 'set'
 
 module FFaker
   class UniqueUtils
-    def initialize(generator, max_retries)
-      @generator = generator
-      @max_retries = max_retries
-      @previous_results = Hash.new { |hash, key| hash[key] = Set.new }
-    end
+    RetryLimitExceeded = Class.new(StandardError)
 
-    def method_missing(name, *arguments)
-      @generator.respond_to?(name) ? add_results_to_hash(name, *arguments) : super
-    end
+    class << self
+      def add_instance(generator, max_retries)
+        instances[generator] ||= FFaker::UniqueUtils.new(generator, max_retries)
+      end
 
-    def respond_to_missing?(method_name, include_private = false)
-      super
-    end
+      def instances
+        Thread.current[:ffaker_unique_utils] ||= {}
+      end
 
-    RetryLimitExceeded = Class.new(StandardError)
+      def clear
+        instances.each_value(&:clear)
+        instances.clear
+      end
+    end
 
-    def clear
-      @previous_results.clear
+    def initialize(generator, max_retries)
+      @generator = generator
+      @max_retries = max_retries
     end
 
-    def self.clear
-      ObjectSpace.each_object(self, &:clear)
+    def clear
+      previous_results.clear
     end
 
     private
 
-    def add_results_to_hash(name, *arguments)
+    def method_missing(name, *args, **kwargs)
       @max_retries.times do
-        result = @generator.send(name, *arguments)
+        result = @generator.public_send(name, *args, **kwargs)
 
-        next if @previous_results[[name, arguments]].include?(result)
+        next if previous_results[[name, args, kwargs]].include?(result)
 
-        @previous_results[[name, arguments]] << result
+        previous_results[[name, args, kwargs]] << result
         return result
       end
-      raise RetryLimitExceeded
+
+      raise RetryLimitExceeded, "Retry limit exceeded for #{name}"
+    end
+
+    def respond_to_missing?(name, *args)
+      @generator.respond_to?(name, *args) || super
+    end
+
+    def previous_results
+      @previous_results ||= Hash.new { |hash, key| hash[key] = Set.new }
     end
   end
 end

data/lib/ffaker/vehicle.rb

@@ -7,7 +7,7 @@ module FFaker
       extend self
 
       # https://en.wikibooks.org/wiki/Vehicle_Identification_Numbers_(VIN_codes)/World_Manufacturer_Identifier_(WMI)
-      VALID_WMI_REGIONS = [*'A'..'C', *'J'..'Z', *'1'..'9'].freeze
+      VALID_WMI_REGIONS = [*'A'..'C', *'J'..'N', 'P', *'R'..'Z', *'1'..'9'].freeze
 
       VALID_YEAR_CHARS = %w[
         5 6 7 8 9 A B C D E F G H J K L M N P R S T V W X Y 1 2 3 4 5 6 7 8 9
@@ -53,7 +53,7 @@ module FFaker
 
         # Calculate the Check Digit
         weighted_sum = generated_vin.chars.each_with_index.sum do |char, idx|
-          (TRANSLITERATION_VALUES[char.to_sym] || char).to_i * POSITION_WEIGHTS[idx]
+          (TRANSLITERATION_VALUES[char] || char).to_i * POSITION_WEIGHTS[idx]
         end
 
         check_digit = weighted_sum % 11

data/lib/{version.rb → ffaker/version.rb}

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FFaker
-  VERSION = '2.21.0'
+  VERSION = '2.23.0'
 end

data/lib/ffaker.rb

@@ -1,5 +1,8 @@
 # frozen_string_literal: true
 
+require_relative 'ffaker/version'
+require 'pathname'
+
 module FFaker
   require_relative 'ffaker/utils/array_utils'
   require_relative 'ffaker/utils/module_utils'
@@ -13,209 +16,78 @@ module FFaker
   HEX = %w[0 1 2 3 4 5 6 7 8 9 A B C D E F].freeze
 
   def self.hexify(*masks)
-    fetch_sample(masks.flatten).gsub(/#/) { fetch_sample(HEX) }
+    fetch_sample(masks.flatten).gsub('#') { fetch_sample(HEX) }
   end
 
   def self.numerify(*masks)
-    fetch_sample(masks.flatten).gsub(/#/) { rand(0..9).to_s }
+    fetch_sample(masks.flatten).gsub('#') { rand(0..9).to_s }
   end
 
   def self.letterify(*masks)
-    fetch_sample(masks.flatten).gsub(/\?/) { fetch_sample(LETTERS) }
+    fetch_sample(masks.flatten).gsub('?') { fetch_sample(LETTERS) }
   end
 
   def self.bothify(masks)
     letterify(numerify(masks))
   end
 
-  autoload :Address, 'ffaker/address'
-  autoload :AddressAU, 'ffaker/address_au'
-  autoload :AddressBR, 'ffaker/address_br'
-  autoload :AddressCA, 'ffaker/address_ca'
-  autoload :AddressCH, 'ffaker/address_ch'
-  autoload :AddressCHDE, 'ffaker/address_ch_de'
-  autoload :AddressCHFR, 'ffaker/address_ch_fr'
-  autoload :AddressCHIT, 'ffaker/address_ch_it'
-  autoload :AddressDA, 'ffaker/address_da'
-  autoload :AddressDE, 'ffaker/address_de'
-  autoload :AddressFI, 'ffaker/address_fi'
-  autoload :AddressFR, 'ffaker/address_fr'
-  autoload :AddressGR, 'ffaker/address_gr'
-  autoload :AddressID, 'ffaker/address_id'
-  autoload :AddressIN, 'ffaker/address_in'
-  autoload :AddressIT, 'ffaker/address_it'
-  autoload :AddressJA, 'ffaker/address_ja'
-  autoload :AddressKR, 'ffaker/address_kr'
-  autoload :AddressMX, 'ffaker/address_mx'
-  autoload :AddressNL, 'ffaker/address_nl'
-  autoload :AddressPL, 'ffaker/address_pl'
-  autoload :AddressRU, 'ffaker/address_ru'
-  autoload :AddressSE, 'ffaker/address_se'
-  autoload :AddressSN, 'ffaker/address_sn'
-  autoload :AddressUA, 'ffaker/address_ua'
-  autoload :AddressUK, 'ffaker/address_uk'
-  autoload :AddressUS, 'ffaker/address_us'
-  autoload :Airline, 'ffaker/airline'
-  autoload :Animal, 'ffaker/animal'
-  autoload :AnimalBR, 'ffaker/animal_br'
-  autoload :AnimalCN, 'ffaker/animal_cn'
-  autoload :AnimalES, 'ffaker/animal_es'
-  autoload :AnimalPL, 'ffaker/animal_pl'
-  autoload :AnimalUS, 'ffaker/animal_us'
-  autoload :Avatar, 'ffaker/avatar'
-  autoload :AWS, 'ffaker/aws'
-  autoload :BaconIpsum, 'ffaker/bacon_ipsum'
-  autoload :Bank, 'ffaker/bank'
-  autoload :Book, 'ffaker/book'
-  autoload :Boolean, 'ffaker/boolean'
-  autoload :CheesyLingo, 'ffaker/cheesy_lingo'
-  autoload :Code, 'ffaker/code'
-  autoload :Color, 'ffaker/color'
-  autoload :ColorPL, 'ffaker/color_pl'
-  autoload :ColorUA, 'ffaker/color_ua'
-  autoload :Company, 'ffaker/company'
-  autoload :CompanyCN, 'ffaker/company_cn'
-  autoload :CompanyFR, 'ffaker/company_fr'
-  autoload :CompanyIT, 'ffaker/company_it'
-  autoload :CompanyJA, 'ffaker/company_ja'
-  autoload :CompanySE, 'ffaker/company_se'
-  autoload :Conference, 'ffaker/conference'
-  autoload :CoursesFR, 'ffaker/courses_fr'
-  autoload :Currency, 'ffaker/currency'
-  autoload :DizzleIpsum, 'ffaker/dizzle_ipsum'
-  autoload :Education, 'ffaker/education'
-  autoload :EducationCN, 'ffaker/education_cn'
-  autoload :Filesystem, 'ffaker/filesystem'
-  autoload :Food, 'ffaker/food'
-  autoload :FoodPL, 'ffaker/food_pl'
-  autoload :FreedomIpsum, 'ffaker/freedom_ipsum'
-  autoload :Game, 'ffaker/game'
-  autoload :Gender, 'ffaker/gender'
-  autoload :GenderBR, 'ffaker/gender_br'
-  autoload :GenderCN, 'ffaker/gender_cn'
-  autoload :GenderID, 'ffaker/gender_id'
-  autoload :GenderIT, 'ffaker/gender_it'
-  autoload :GenderJA, 'ffaker/gender_ja'
-  autoload :GenderJP, 'ffaker/gender_jp'
-  autoload :GenderKR, 'ffaker/gender_kr'
-  autoload :GenderPL, 'ffaker/gender_pl'
-  autoload :GenderRU, 'ffaker/gender_ru'
-  autoload :Geolocation, 'ffaker/geolocation'
-  autoload :Guid, 'ffaker/guid'
-  autoload :HealthcareIpsum, 'ffaker/healthcare_ipsum'
-  autoload :HealthcareRU, 'ffaker/healthcare_ru'
-  autoload :HipsterIpsum, 'ffaker/hipster_ipsum'
-  autoload :HTMLIpsum, 'ffaker/html_ipsum'
-  autoload :Identification, 'ffaker/identification'
-  autoload :IdentificationBR, 'ffaker/identification_br'
-  autoload :IdentificationES, 'ffaker/identification_es'
-  autoload :IdentificationESCL, 'ffaker/identification_es_cl'
-  autoload :IdentificationESCO, 'ffaker/identification_es_co'
-  autoload :IdentificationIN, 'ffaker/identification_in'
-  autoload :IdentificationIT, 'ffaker/identification_it'
-  autoload :IdentificationKr, 'ffaker/identification_kr'
-  autoload :IdentificationMX, 'ffaker/identification_mx'
-  autoload :IdentificationPL, 'ffaker/identification_pl'
-  autoload :IdentificationTW, 'ffaker/identification_tw'
-  autoload :Image, 'ffaker/image'
-  autoload :Internet, 'ffaker/internet'
-  autoload :InternetSE, 'ffaker/internet_se'
-  autoload :Job, 'ffaker/job'
-  autoload :JobBR, 'ffaker/job_br'
-  autoload :JobCN, 'ffaker/job_cn'
-  autoload :JobFR, 'ffaker/job_fr'
-  autoload :JobIT, 'ffaker/job_it'
-  autoload :JobJA, 'ffaker/job_ja'
-  autoload :JobKR, 'ffaker/job_kr'
-  autoload :JobVN, 'ffaker/job_vn'
-  autoload :Locale, 'ffaker/locale'
-  autoload :Lorem, 'ffaker/lorem'
-  autoload :LoremAR, 'ffaker/lorem_ar'
-  autoload :LoremBR, 'ffaker/lorem_br'
-  autoload :LoremCN, 'ffaker/lorem_cn'
-  autoload :LoremFR, 'ffaker/lorem_fr'
-  autoload :LoremIE, 'ffaker/lorem_ie'
-  autoload :LoremIT, 'ffaker/lorem_it'
-  autoload :LoremJA, 'ffaker/lorem_ja'
-  autoload :LoremKR, 'ffaker/lorem_kr'
-  autoload :LoremPL, 'ffaker/lorem_pl'
-  autoload :LoremRU, 'ffaker/lorem_ru'
-  autoload :LoremUA, 'ffaker/lorem_ua'
-  autoload :Movie, 'ffaker/movie'
-  autoload :Music, 'ffaker/music'
-  autoload :Name, 'ffaker/name'
-  autoload :NameAR, 'ffaker/name_ar'
-  autoload :NameBR, 'ffaker/name_br'
-  autoload :NameCN, 'ffaker/name_cn'
-  autoload :NameCS, 'ffaker/name_cs'
-  autoload :NameDA, 'ffaker/name_da'
-  autoload :NameDE, 'ffaker/name_de'
-  autoload :NameES, 'ffaker/name_es'
-  autoload :NameFR, 'ffaker/name_fr'
-  autoload :NameGA, 'ffaker/name_ga'
-  autoload :NameGR, 'ffaker/name_gr'
-  autoload :NameID, 'ffaker/name_id'
-  autoload :NameIN, 'ffaker/name_in'
-  autoload :NameIT, 'ffaker/name_it'
-  autoload :NameJA, 'ffaker/name_ja'
-  autoload :NameKH, 'ffaker/name_kh'
-  autoload :NameKR, 'ffaker/name_kr'
-  autoload :NameMX, 'ffaker/name_mx'
-  autoload :NameNB, 'ffaker/name_nb'
-  autoload :NameNL, 'ffaker/name_nl'
-  autoload :NamePH, 'ffaker/name_ph'
-  autoload :NamePL, 'ffaker/name_pl'
-  autoload :NameRU, 'ffaker/name_ru'
-  autoload :NameSE, 'ffaker/name_se'
-  autoload :NameSN, 'ffaker/name_sn'
-  autoload :NameTH, 'ffaker/name_th'
-  autoload :NameTW, 'ffaker/name_tw'
-  autoload :NameTHEN, 'ffaker/name_th_en'
-  autoload :NameUA, 'ffaker/name_ua'
-  autoload :NameVN, 'ffaker/name_vn'
-  autoload :NatoAlphabet, 'ffaker/nato_alphabet'
-  autoload :Number, 'ffaker/number'
-  autoload :PhoneNumber, 'ffaker/phone_number'
-  autoload :PhoneNumberAU, 'ffaker/phone_number_au'
-  autoload :PhoneNumberBR, 'ffaker/phone_number_br'
-  autoload :PhoneNumberCH, 'ffaker/phone_number_ch'
-  autoload :PhoneNumberCU, 'ffaker/phone_number_cu'
-  autoload :PhoneNumberDA, 'ffaker/phone_number_da'
-  autoload :PhoneNumberDE, 'ffaker/phone_number_de'
-  autoload :PhoneNumberFR, 'ffaker/phone_number_fr'
-  autoload :PhoneNumberID, 'ffaker/phone_number_id'
-  autoload :PhoneNumberIT, 'ffaker/phone_number_it'
-  autoload :PhoneNumberJA, 'ffaker/phone_number_ja'
-  autoload :PhoneNumberKR, 'ffaker/phone_number_kr'
-  autoload :PhoneNumberMX, 'ffaker/phone_number_mx'
-  autoload :PhoneNumberNL, 'ffaker/phone_number_nl'
-  autoload :PhoneNumberPL, 'ffaker/phone_number_pl'
-  autoload :PhoneNumberSE, 'ffaker/phone_number_se'
-  autoload :PhoneNumberSG, 'ffaker/phone_number_sg'
-  autoload :PhoneNumberSN, 'ffaker/phone_number_sn'
-  autoload :PhoneNumberTW, 'ffaker/phone_number_tw'
-  autoload :PhoneNumberUA, 'ffaker/phone_number_ua'
-  autoload :PhoneNumberRU, 'ffaker/phone_number_ru'
-  autoload :Product, 'ffaker/product'
-  autoload :SemVer, 'ffaker/sem_ver'
-  autoload :Skill, 'ffaker/skill'
-  autoload :Sport, 'ffaker/sport'
-  autoload :SportPL, 'ffaker/sport_pl'
-  autoload :SportUS, 'ffaker/sport_us'
-  autoload :SportRU, 'ffaker/sport_ru'
-  autoload :SSN, 'ffaker/ssn'
-  autoload :SSNMX, 'ffaker/ssn_mx'
-  autoload :SSNSE, 'ffaker/ssn_se'
-  autoload :String, 'ffaker/string'
-  autoload :Time, 'ffaker/time'
-  autoload :Tweet, 'ffaker/tweet'
-  autoload :Unit, 'ffaker/unit'
-  autoload :UnitEnglish, 'ffaker/unit_english'
-  autoload :UnitMetric, 'ffaker/unit_metric'
-  autoload :VERSION, 'version'
-  autoload :Vehicle, 'ffaker/vehicle'
-  autoload :Venue, 'ffaker/venue'
-  autoload :Youtube, 'ffaker/youtube'
+  autoload_acronyms = {
+    'ar' => 'AR',
+    'au' => 'AU',
+    'aws' => 'AWS',
+    'br' => 'BR',
+    'ca' => 'CA',
+    'ch' => 'CH',
+    'cl' => 'CL',
+    'cn' => 'CN',
+    'co' => 'CO',
+    'cs' => 'CS',
+    'cu' => 'CU',
+    'da' => 'DA',
+    'de' => 'DE',
+    'ec' => 'EC',
+    'en' => 'EN',
+    'es' => 'ES',
+    'fi' => 'FI',
+    'fr' => 'FR',
+    'ga' => 'GA',
+    'gr' => 'GR',
+    'html' => 'HTML',
+    'id' => 'ID',
+    'ie' => 'IE',
+    'in' => 'IN',
+    'it' => 'IT',
+    'ja' => 'JA',
+    'jp' => 'JP',
+    'kh' => 'KH',
+    'kr' => 'KR',
+    'mx' => 'MX',
+    'nb' => 'NB',
+    'nl' => 'NL',
+    'ph' => 'PH',
+    'pl' => 'PL',
+    'ru' => 'RU',
+    'se' => 'SE',
+    'sg' => 'SG',
+    'sn' => 'SN',
+    'ssn' => 'SSN',
+    'th' => 'TH',
+    'tw' => 'TW',
+    'ua' => 'UA',
+    'uk' => 'UK',
+    'us' => 'US',
+    'vn' => 'VN'
+  }
+
+  directory = "#{__dir__}/ffaker"
+  Dir["#{directory}/*.rb"].each do |file_name|
+    relative_file_path = Pathname.new(file_name).relative_path_from(directory).to_s.chomp('.rb')
+    ## Don't consider files in sub-directories
+    constant_name = relative_file_path.split('_').map do |part|
+      autoload_acronyms.fetch(part) { part.capitalize }
+    end.join
+    autoload constant_name, file_name
+  end
 
   # Random Number Generator (RNG) used with ModuleUtils#fetch, #shuffle, #rand
   # in order to provide deterministic repeatability.

data/scripts/reference.rb

@@ -11,8 +11,8 @@ ICONS = {
   warning: '❗'
 }.freeze
 
-UTILS_MODULES = %i[ArrayUtils ModuleUtils RandomUtils Random]
-UTILS_METHODS = %i[k underscore fetch_sample rand shuffle unique luhn_check]
+UTILS_MODULES = %i[ArrayUtils ModuleUtils RandomUtils Random Version].freeze
+UTILS_METHODS = %i[k underscore fetch_sample rand shuffle unique luhn_check].freeze
 
 # Get a list of sections
 def faker_modules
@@ -36,12 +36,14 @@ end
 # Catch deprecation warnings.
 # This `#warn` overrides Kernel#warn
 def warn(msg)
-  $warnings << msg if $warnings
+  return unless Kernel.instance_variable_get(:@ffaker_warnings)
+
+  Kernel.instance_variable_set(:@ffaker_warnings, Kernel.instance_variable_get(:@ffaker_warnings) << msg)
 end
 
 def catch_warnings
-  $warnings = []
-  [yield, $warnings]
+  Kernel.instance_variable_set(:@ffaker_warnings, [])
+  [yield, Kernel.instance_variable_get(:@ffaker_warnings)]
 end
 
 def escape(str)
@@ -70,11 +72,7 @@ sections = faker_modules.map do |mod|
         examples, warnings = catch_warnings do
           Array.new(3) { mod.unique.send meth }
         end
-        right = if warnings.any?
-                  "#{ICONS[:warning]} *#{warnings.first}*"
-                else
-                  (escape examples.join(', ')).to_s
-                end
+        right = warnings.any? ? "#{ICONS[:warning]} *#{warnings.first}*" : (escape examples.join(', ')).to_s
       rescue StandardError => e
         right = "#{ICONS[:error]} #{e.class}: #{e.message}"
       end

data/test/helper.rb

@@ -13,16 +13,14 @@ module DeterministicHelper
   # Accepts a block. Executes the block multiple times after resetting
   # the internal Random Number Generator state and compared the results of
   # each execution to make sure they are the same.
-  def assert_deterministic(options = {})
-    raise ArgumentError, 'Must pass a block' unless block_given?
+  def assert_deterministic(options = {}, &block)
+    raise ArgumentError, 'Must pass a block' unless block
 
     options = { message: 'Results are not repeatable' }.merge(options)
 
     returns = Array.new(2) do
       FFaker::Random.reset!
-      Array.new(5) do
-        yield
-      end
+      Array.new(5, &block)
     end
 
     assert(returns.uniq.length == 1, options[:message])

data/test/test_address_da.rb

@@ -20,11 +20,11 @@ class TestAddressDA < Test::Unit::TestCase
   end
 
   def test_state
-    assert_match(/\A[-ÆØÅæøåa-z-]+\z/i, FFaker::AddressDA.state)
+    assert_match(/\A[-ÆØÅæøåa-z]+\z/i, FFaker::AddressDA.state)
   end
 
   def test_kommune
-    assert_match(/\A[-ÆØÅæøåa-z-]+\z/i, FFaker::AddressDA.kommune)
+    assert_match(/\A[-ÆØÅæøåa-z]+\z/i, FFaker::AddressDA.kommune)
   end
 
   def test_region
@@ -32,7 +32,7 @@ class TestAddressDA < Test::Unit::TestCase
   end
 
   def test_city
-    assert_match(/\A[- ÆØÅæøåla-z-]+\z/i, FFaker::AddressDA.city)
+    assert_match(/\A[- ÆØÅæøåla-z]+\z/i, FFaker::AddressDA.city)
   end
 
   def test_street_name

data/test/test_address_fi.rb

@@ -5,8 +5,8 @@ require_relative 'helper'
 class TestAddressFI < Test::Unit::TestCase
   include DeterministicHelper
 
-  ALPHA = /\A\p{Alpha}+/.freeze
-  DIGIT = /\d{1}/.freeze
+  ALPHA = /\A\p{Alpha}+/
+  DIGIT = /\d{1}/
 
   assert_methods_are_deterministic(
     FFaker::AddressFI,

data/test/test_address_se.rb

@@ -5,8 +5,8 @@ require_relative 'helper'
 class TestAddressSE < Test::Unit::TestCase
   include DeterministicHelper
 
-  ALPHA = /\A\p{Alpha}+/.freeze
-  DIGIT = /\d{1}/.freeze
+  ALPHA = /\A\p{Alpha}+/
+  DIGIT = /\d{1}/
 
   assert_methods_are_deterministic(
     FFaker::AddressSE,

data/test/test_avatar.rb

@@ -18,40 +18,63 @@ class TestAvatar < Test::Unit::TestCase
                  @tester.image)
   end
 
+  def test_image_output_with_keyword_arguments
+    output = capture_output do
+      @tester.image(format: 'jpg')
+    end
+
+    assert_equal ['', ''], output
+  end
+
+  def test_image_with_slug_as_positional_argument
+    assert_equal("#{ROBOHASH}/foobar.png?size=300x300", @tester.image('foobar'))
+  end
+
+  def test_image_output_with_positional_arguments
+    output = capture_output do
+      @tester.image('foobar')
+    end
+
+    assert_equal(
+      ['', "Positional arguments for Avatar#image are deprecated. Please use keyword arguments.\n"],
+      output
+    )
+  end
+
   def test_avatar_with_param
-    assert_equal("#{ROBOHASH}/faker.png?size=300x300", @tester.image('faker'))
+    assert_equal("#{ROBOHASH}/faker.png?size=300x300", @tester.image(slug: 'faker'))
   end
 
   def test_avatar_with_correct_size
     assert_equal("#{ROBOHASH}/faker.png?size=150x320",
-                 @tester.image('faker', '150x320'))
+                 @tester.image(slug: 'faker', size: '150x320'))
   end
 
   def test_avatar_with_incorrect_size
     assert_raise ArgumentError do
-      @tester.image(nil, '150x320z')
+      @tester.image(size: '150x320z')
     end
   end
 
   def test_avatar_with_supported_format
     assert_equal("#{ROBOHASH}/faker.jpg?size=300x300",
-                 @tester.image('faker', '300x300', 'jpg'))
+                 @tester.image(slug: 'faker', size: '300x300', format: 'jpg'))
   end
 
   def test_avatar_with_incorrect_format
     assert_raise ArgumentError do
-      @tester.image(nil, '300x300', 'wrong_format')
+      @tester.image(size: '300x300', format: 'wrong_format')
     end
   end
 
   def test_avatar_with_correct_background
     assert_equal("#{ROBOHASH}/faker.png?size=300x300&bgset=bg1",
-                 @tester.image('faker', '300x300', 'png', '1'))
+                 @tester.image(slug: 'faker', size: '300x300', format: 'png', bgset: '1'))
   end
 
   def test_avatar_with_incorrect_background
     assert_raise ArgumentError do
-      @tester.image('faker', '300x300', 'png', 'not_a_number')
+      @tester.image(slug: 'faker', size: '300x300', format: 'png', bgset: 'not_a_number')
     end
   end
 end

data/test/test_bank_us.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+require_relative 'helper'
+
+class TestBankUS < Test::Unit::TestCase
+  include DeterministicHelper
+
+  assert_methods_are_deterministic(
+    FFaker::BankUS,
+    :account_number, :routing_number
+  )
+
+  def setup
+    @tester = FFaker::BankUS
+  end
+
+  def test_account_number
+    assert_instance_of String, @tester.account_number
+    assert_match(/\A\d{8}\z/, @tester.account_number(min_digits: 8, max_digits: 8))
+    assert_match(/\A\d{12}\z/, @tester.account_number(min_digits: 12, max_digits: 12))
+  end
+
+  def test_routing_number
+    routing_number = @tester.routing_number
+    assert_match(/\A\d{9}\z/, routing_number)
+
+    checksum = (
+      (7 * (routing_number[0].to_i + routing_number[3].to_i + routing_number[6].to_i)) +
+        (3 * (routing_number[1].to_i + routing_number[4].to_i + routing_number[7].to_i)) +
+        (9 * (routing_number[2].to_i + routing_number[5].to_i + routing_number[8].to_i))
+    )
+
+    assert_equal(0, checksum % 10, 'The routing number\'s checksum is not a multiple of ten')
+  end
+end