ffaker 2.20.0 → 2.25.0

data/lib/ffaker/date.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+require 'date'
+
+module FFaker
+  module Date
+    extend FFaker::ModuleUtils
+    extend self
+
+    # Generates a random date between 2 dates
+    def between(from, to)
+      FFaker::Time.between(from, to).to_date
+    end
+
+    # Generates a random date up to `days` days in the past
+    def backward(days = 365)
+      from = ::Date.today - days
+      to   = ::Date.today - 1
+
+      between(from, to)
+    end
+
+    # Generates a random date up to `days` days in the future
+    def forward(days = 365)
+      from = ::Date.today + 1
+      to   = ::Date.today + days
+
+      between(from, to)
+    end
+
+    # Random birthday date (maximum age between 18 and 65)
+    # Keyword arguments: min_age, max_age
+    def birthday(min_age: 18, max_age: 65)
+      from = ::Date.today.prev_year(max_age + 1).next_day
+      to = ::Date.today.prev_year(min_age)
+
+      between(from, to)
+    end
+  end
+end

data/lib/ffaker/filesystem.rb

@@ -17,8 +17,18 @@ module FFaker
       Lorem.words.join(directory_separator)
     end
 
-    def file_name(dir = directory, name = Lorem.word.downcase,
-                  ext = extension, directory_separator = File::SEPARATOR)
+    def file_name(
+      *args,
+      dir: directory, name: Lorem.word.downcase, ext: extension, directory_separator: File::SEPARATOR
+    )
+      if args.any?
+        warn "Positional arguments for Filesystem##{__method__} are deprecated. Please use keyword arguments."
+        dir = args[0]
+        name = args[1] if args.size > 1
+        ext = args[2] if args.size > 2
+        directory_separator = args[3] if args.size > 3
+      end
+
       "#{dir}#{directory_separator}#{name}.#{ext}"
     end
   end

data/lib/ffaker/geolocation.rb

@@ -51,8 +51,8 @@ module FFaker
       latitude_range = [upper_left[0], lower_right[0]].sort
       longitude_range = [upper_left[1], lower_right[1]].sort
 
-      latitude = latitude_range[0] + rand * (latitude_range[1] - latitude_range[0])
-      longitude = longitude_range[0] + rand * (longitude_range[1] - longitude_range[0])
+      latitude = latitude_range[0] + (rand * (latitude_range[1] - latitude_range[0]))
+      longitude = longitude_range[0] + (rand * (longitude_range[1] - longitude_range[0]))
 
       [latitude, longitude]
     end

data/lib/ffaker/guid.rb

@@ -5,8 +5,14 @@ module FFaker
     extend ModuleUtils
     extend self
 
+    # Because this method uses arbitrary hexadecimal characters it is likely to
+    # generate invalid UUIDs--UUIDs must have a version (1-8) at bits 48-51,
+    # and bits 64-65 must be 0b10.
+    #
+    # @deprecated Often generates invalid UUIDs. Use {UUID} instead.
     def guid
-      FFaker.hexify('########-####-####-####-############')
+      warn '[guid] is deprecated. Use the UUID.uuidv4 method instead.'
+      FFaker::UUID.uuidv4.upcase
     end
   end
 end

data/lib/ffaker/html_ipsum.rb

@@ -134,9 +134,15 @@ module FFaker
       a = k([
         content_tag_for(:strong, words(2).capitalize!),
         content_tag_for(:em, paragraph),
+        content_tag_for(:mark, paragraph),
+        content_tag_for(:del, words(2)),
+        content_tag_for(:ins, words(2)),
+        content_tag_for(:sub, words(2)),
+        content_tag_for(:sup, words(2)),
         content_tag_for(:code, words(2)),
+        content_tag_for(:small, words(2)),
         (a 2).to_s
-      ] + FFaker::Lorem.paragraphs(count))
+      ] + FFaker::Lorem.paragraphs(count - 1))
       fetch_sample(a, count: count).join(sep)
     end
 

data/lib/ffaker/identification_br.rb

@@ -17,11 +17,7 @@ module FFaker
 
     def pretty_cpf
       cpf_numbers = cpf
-      format('%s.%s.%s-%s',
-             cpf_numbers[0..2],
-             cpf_numbers[3..5],
-             cpf_numbers[6..8],
-             cpf_numbers[9..10])
+      "#{cpf_numbers[0..2]}.#{cpf_numbers[3..5]}.#{cpf_numbers[6..8]}-#{cpf_numbers[9..10]}"
     end
 
     def cnpj
@@ -32,12 +28,7 @@ module FFaker
 
     def pretty_cnpj
       cnpj_numbers = cnpj.to_s.rjust(14, '0')
-      format('%s.%s.%s/%s-%s',
-             cnpj_numbers[0..1],
-             cnpj_numbers[2..4],
-             cnpj_numbers[5..7],
-             cnpj_numbers[8..11],
-             cnpj_numbers[12..14])
+      "#{cnpj_numbers[0..1]}.#{cnpj_numbers[2..4]}.#{cnpj_numbers[5..7]}/#{cnpj_numbers[8..11]}-#{cnpj_numbers[12..14]}"
     end
 
     def rg
@@ -71,7 +62,7 @@ module FFaker
       if document_digits.size + 1 == verification_multipliers.size && document_digits.uniq.size > 1
         0.upto(1) do |i|
           sum = verification_multipliers.drop(1 - i).each_with_index.inject(0) do |val, (value, j)|
-            val + document_digits[j] * value
+            val + (document_digits[j] * value)
           end
           validation_digits[i] = (sum %= 11) < 2 ? 0 : 11 - sum
           document_digits.push(validation_digits[i])

data/lib/ffaker/identification_ec.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+module FFaker
+  module IdentificationEC
+    extend ModuleUtils
+    extend self
+
+    # https://medium.com/@bryansuarez/c%C3%B3mo-validar-c%C3%A9dula-y-ruc-en-ecuador-b62c5666186f
+    # Cedula de Identificacion
+    def ci
+      first_digits = ci_digits
+      "#{first_digits}#{last_digit(first_digits)}"
+    end
+
+    private
+
+    def ci_digits
+      "#{FFaker.numerify('##')}#{rand(0..5)}#{FFaker.numerify('######')}"
+    end
+
+    def last_digit(digits)
+      mod = digits_sum(digits) % 10
+      10 - mod if mod.positive?
+    end
+
+    def digits_sum(digits)
+      sum = 0
+      digits.chars.each_with_index do |char, index|
+        if index.even?
+          multiple = char.to_i * 2
+          sum += multiple > 9 ? multiple - 9 : multiple
+        else
+          sum += char.to_i
+        end
+      end
+      sum
+    end
+  end
+end

data/lib/ffaker/identification_es_cl.rb

@@ -20,10 +20,10 @@ module FFaker
     private
 
     def dv(rut)
-      total = rut.to_s.rjust(8, '0').split(//).zip(%w[3 2 7 6 5 4 3 2]).sum do |a, b|
+      total = rut.to_s.rjust(8, '0').chars.zip(%w[3 2 7 6 5 4 3 2]).sum do |a, b|
         a.to_i * b.to_i
       end
-      (11 - total % 11).to_s.gsub(/10/, 'k').gsub(/11/, '0')
+      (11 - (total % 11)).to_s.gsub('10', 'k').gsub('11', '0')
     end
   end
 end

data/lib/ffaker/identification_es_co.rb

@@ -32,7 +32,7 @@ module FFaker
     end
 
     def expedition_date
-      today = Date.today
+      today = ::Date.today
       today - rand(today.year)
     end
   end

data/lib/ffaker/identification_fi.rb

@@ -0,0 +1,73 @@
+# frozen_string_literal: true
+
+module FFaker
+  module IdentificationFI
+    extend ModuleUtils
+    extend self
+
+    CHECK_DIGITS = '0123456789ABCDEFHJKLMNPRSTUVWXY'
+    # Number ranges in real use
+    POSSIBLY_REAL_FEMALE_INDIVIDUAL_NUMBERS = (2..898).step(2).to_a.freeze
+    POSSIBLY_REAL_MALE_INDIVIDUAL_NUMBERS = (3..899).step(2).to_a.freeze
+    # Number ranges not in real use
+    FAKE_FEMALE_INDIVIDUAL_NUMBERS = (900..998).step(2).to_a.freeze
+    FAKE_MALE_INDIVIDUAL_NUMBERS = (901..999).step(2).to_a.freeze
+
+    def identity_number(gender: FFaker::Gender.binary, birthday: FFaker::Date.birthday, fake: true)
+      day = fetch_formatted_day(birthday)
+      month = fetch_formatted_month(birthday)
+      year = fetch_formatted_year(birthday)
+      separator = fetch_separator(birthday)
+      individual_number = fetch_individual_number(gender, fake)
+      check_digit = calculate_check_digit(birthday, individual_number)
+      "#{day}#{month}#{year}#{separator}#{individual_number}#{check_digit}"
+    end
+
+    private
+
+    def fetch_formatted_day(birthday)
+      format('%.2d', birthday.day)
+    end
+
+    def fetch_formatted_month(birthday)
+      format('%.2d', birthday.month)
+    end
+
+    def fetch_formatted_year(birthday)
+      check_birth_year(birthday.year)
+      birthday.strftime('%y')
+    end
+
+    def fetch_separator(birthday)
+      case birthday.year
+      when ..1899
+        '+'
+      when 1900..1999
+        '-'
+      else
+        'A'
+      end
+    end
+
+    def fetch_individual_number(gender, fake)
+      numbers_range = if gender == 'female'
+                        fake ? FAKE_FEMALE_INDIVIDUAL_NUMBERS : POSSIBLY_REAL_FEMALE_INDIVIDUAL_NUMBERS
+                      else
+                        fake ? FAKE_MALE_INDIVIDUAL_NUMBERS : POSSIBLY_REAL_MALE_INDIVIDUAL_NUMBERS
+                      end
+      format('%.3d', fetch_sample(numbers_range))
+    end
+
+    def calculate_check_digit(birthday, individual_number)
+      digit = "#{birthday.day}#{fetch_formatted_month(birthday)}#{fetch_formatted_year(birthday)}#{individual_number}"
+              .to_i % 31
+      CHECK_DIGITS[digit]
+    end
+
+    def check_birth_year(birth_year)
+      return if birth_year.between?(1799, 2100)
+
+      raise ArgumentError, "Birth year: #{birth_year} is not between supported 1799 and 2100 range"
+    end
+  end
+end

data/lib/ffaker/identification_kr.rb

@@ -1,18 +1,25 @@
 # frozen_string_literal: true
 
 module FFaker
-  module IdentificationKr
+  module IdentificationKR
     extend ModuleUtils
     extend self
 
     # Resident Registration Number
     # http://ko.wikipedia.org/wiki/%EC%A3%BC%EB%AF%BC%EB%93%B1%EB%A1%9D%EB%B2%88%ED%98%B8
     def rrn
-      birth = fetch_sample(Date.new(1970, 1, 1)..Date.new(1999, 12, 31)).strftime('%y%d%m')
+      birth = fetch_sample(::Date.new(1970, 1, 1)..::Date.new(1999, 12, 31)).strftime('%y%d%m')
       sex = fetch_sample([1, 2])
       loc = FFaker.numerify("#{fetch_sample(Array('00'..'95'))}###")
-      a, b, c, d, e, f, g, h, i, j, k, l = "#{birth}#{sex}#{loc}".split(//).map(&:to_i)
-      checksum = (11 - (2 * a + 3 * b + 4 * c + 5 * d + 6 * e + 7 * f + 8 * g + 9 * h + 2 * i + 3 * j + 4 * k + 5 * l) % 11) % 10
+      a, b, c, d, e, f, g, h, i, j, k, l = "#{birth}#{sex}#{loc}".chars.map(&:to_i)
+      checksum = (
+        11 - (
+          (
+            (2 * a) + (3 * b) + (4 * c) + (5 * d) + (6 * e) + (7 * f) + (8 * g) + (9 * h) +
+              (2 * i) + (3 * j) + (4 * k) + (5 * l)
+          ) % 11
+        )
+      ) % 10
       "#{birth}-#{sex}#{loc}#{checksum}"
     end
   end

data/lib/ffaker/identification_mx.rb

@@ -27,7 +27,7 @@ module FFaker
     def rfc_persona_moral
       consonants_n_amp = CONSONANTS + ['Ñ', '&']
       all_letters = consonants_n_amp + VOWELS
-      [fetch_sample(all_letters, count: 3), date, fetch_sample(HOMOCLAVE, count: 3)].flatten.join
+      [*fetch_sample(all_letters, count: 3), date, *fetch_sample(HOMOCLAVE, count: 3)].join
     end
 
     # http://es.wikipedia.org/wiki/Registro_Federal_de_Contribuyentes_(M%C3%A9xico)

data/lib/ffaker/identification_pl.rb

@@ -37,8 +37,8 @@ module FFaker
     private
 
     def generate_valid_pesel_date
-      from = Date.new(1800, 1, 1)
-      to = [Date.today, Date.new(2299, 12, 31)].min
+      from = ::Date.new(1800, 1, 1)
+      to = [::Date.today, ::Date.new(2299, 12, 31)].min
       fetch_sample(from..to)
     end
 
@@ -63,15 +63,15 @@ module FFaker
     end
 
     def pesel_checksum(date, serial_number)
-      pesel_digits = "#{date}#{serial_number}".split('').map(&:to_i)
+      pesel_digits = "#{date}#{serial_number}".chars.map(&:to_i)
       a, b, c, d, e, f, g, h, i, j = pesel_digits
-      (a * 9 + b * 7 + c * 3 + d + e * 9 + f * 7 + g * 3 + h + i * 9 + j * 7) % 10
+      ((a * 9) + (b * 7) + (c * 3) + d + (e * 9) + (f * 7) + (g * 3) + h + (i * 9) + (j * 7)) % 10
     end
 
     def identity_card_checksum(letter_part, number_part)
       a, b, c = letter_part.codepoints.map { |codepoints| codepoints - 55 }
-      d, e, f, g, h = number_part.split('').map(&:to_i)
-      (a * 7 + b * 3 + c + 7 * d + 3 * e + f + 7 * g + 3 * h) % 10
+      d, e, f, g, h = number_part.chars.map(&:to_i)
+      ((a * 7) + (b * 3) + c + (7 * d) + (3 * e) + f + (7 * g) + (3 * h)) % 10
     end
   end
 end

data/lib/ffaker/identification_tw.rb

@@ -5,7 +5,8 @@ module FFaker
     extend ModuleUtils
     extend self
 
-    AREA_CODE = { a: 10, b: 11, c: 12, d: 13, e: 14, f: 15, g: 16, h: 17, i: 34, j: 18, k: 19, l: 20, m: 21, n: 22, o: 35, p: 23, q: 24, r: 25, s: 26, t: 27, u: 28, v: 29, w: 30, x: 31, y: 32, z: 33 }.freeze
+    AREA_CODE = { a: 10, b: 11, c: 12, d: 13, e: 14, f: 15, g: 16, h: 17, i: 34, j: 18, k: 19, l: 20, m: 21, n: 22,
+                  o: 35, p: 23, q: 24, r: 25, s: 26, t: 27, u: 28, v: 29, w: 32, x: 30, y: 31, z: 33 }.freeze
 
     # Identity Card Number
     # https://en.wikipedia.org/wiki/National_identification_card_(Taiwan)#Identity_card_number
@@ -14,9 +15,9 @@ module FFaker
       code = AREA_CODE[letter.to_sym]
       gender = fetch_sample([1, 2])
       serial = FFaker.numerify('#######')
-      a, b, c, d, e, f, g, h, i, j = "#{code}#{gender}#{serial}".split(//).map(&:to_i)
+      a, b, c, d, e, f, g, h, i, j = "#{code}#{gender}#{serial}".chars.map(&:to_i)
 
-      checksum = (9 * a + b + 2 * c + 3 * d + 4 * e + 5 * f + 6 * g + 7 * h + 8 * i + 9 * j) % 10
+      checksum = ((9 * a) + b + (2 * c) + (3 * d) + (4 * e) + (5 * f) + (6 * g) + (7 * h) + (8 * i) + (9 * j)) % 10
       "#{letter.upcase}#{gender}#{serial}#{checksum}"
     end
   end

data/lib/ffaker/image.rb

@@ -11,7 +11,18 @@ module FFaker
 
     SUPPORTED_FORMATS = %w[png jpg jpeg gif].freeze
 
-    def url(size = '300x300', format = 'png', bg_color = :random, text_color = :random, text = nil)
+    ## `*args` for old format support, it will be removed with deprecation
+    # rubocop:disable Metrics/ParameterLists
+    def url(*args, size: '300x300', format: 'png', bg_color: :random, text_color: :random, text: nil)
+      if args.any?
+        warn "Positional arguments for Image##{__method__} are deprecated. Please use keyword arguments."
+        size = args[0]
+        format = args[1] if args.size > 1
+        bg_color = args[2] if args.size > 2
+        text_color = args[3] if args.size > 3
+        text = args[4] if args.size > 4
+      end
+
       check_size!(size)
       check_format!(format)
 
@@ -21,20 +32,33 @@ module FFaker
 
       "https://dummyimage.com/#{size}/#{bg_color}/#{text_color}.#{format}?text=#{text}"
     end
+    # rubocop:enable Metrics/ParameterLists
+
+    ## `*args` for old format support, it will be removed with deprecation
+    # rubocop:disable Metrics/ParameterLists
+    def file(*args, size: '300x300', format: 'png', bg_color: :random, text_color: :random, text: nil)
+      if args.any?
+        warn "Positional arguments for Image##{__method__} are deprecated. Please use keyword arguments."
+        size = args[0]
+        format = args[1] if args.size > 1
+        bg_color = args[2] if args.size > 2
+        text_color = args[3] if args.size > 3
+        text = args[4] if args.size > 4
+      end
 
-    def file(size = '300x300', format = 'png', bg_color = :random, text_color = :random, text = nil)
-      uri = URI.parse(url(size, format, bg_color, text_color, text))
+      uri = URI.parse(url(size: size, format: format, bg_color: bg_color, text_color: text_color, text: text))
       file = Tempfile.new('ffaker_image')
       file.binmode
       file << uri.open.read
       file.close
       File.new(file.path)
     end
+    # rubocop:enable Metrics/ParameterLists
 
     private
 
     def check_size!(size)
-      return true if size =~ /\A\d+x\d+\z/
+      return true if size.match?(/\A\d+x\d+\z/)
 
       raise ArgumentError, 'Size should be specified in format 300x300'
     end

data/lib/ffaker/jo_jo.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+module FFaker
+  module JoJo
+    extend ModuleUtils
+    extend self
+
+    def full_name
+      fetch_sample(FULL_NAMES)
+    end
+
+    def first_name
+      fetch_sample(FIRST_NAMES)
+    end
+
+    def last_name
+      fetch_sample(LAST_NAMES)
+    end
+
+    def stand
+      fetch_sample(STANDS)
+    end
+  end
+end

data/lib/ffaker/job_tw.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+module FFaker
+  module JobTW
+    extend ModuleUtils
+    extend self
+
+    def title
+      fetch_sample(JOB_NOUNS)
+    end
+  end
+end

data/lib/ffaker/lorem_ja.rb

@@ -30,7 +30,7 @@ module FFaker
     end
 
     def paragraph(sentence_count = 3)
-      sentences(sentence_count).join('、') + '、' + fetch_sample(SENTENCES_END) + '。'
+      "#{sentences(sentence_count).join('、')}、#{fetch_sample(SENTENCES_END)}。"
     end
 
     def paragraphs(count = 3)

data/lib/ffaker/lorem_ru.rb

@@ -50,7 +50,7 @@ module FFaker
       if CAPITAL_CHARS.include?(string[0])
         string
       else
-        CAPITAL_CHARS[CHARS.index(string[0])] + string[1..-1]
+        CAPITAL_CHARS[CHARS.index(string[0])] + string[1..]
       end
     end
   end

data/lib/ffaker/lorem_tw.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+module FFaker
+  module LoremTW
+    extend ModuleUtils
+    extend self
+
+    def word
+      fetch_sample(WORDS)
+    end
+
+    def words(num = 3)
+      fetch_sample(WORDS, count: num)
+    end
+
+    def sentence(word_count = 4)
+      s = words(word_count + rand(0..5))
+      s = s.join
+      "#{s},"
+    end
+
+    def sentences(sentence_count = 3)
+      s = (1..sentence_count).map { sentence }
+      def s.to_s
+        result = join(' ')
+        result[-1] = '。'
+        result
+      end
+      s
+    end
+
+    def paragraph(sentence_count = 3)
+      sentences(sentence_count + rand(0..2)).to_s
+    end
+
+    def paragraphs(paragraph_count = 3)
+      (1..paragraph_count).map { paragraph }
+    end
+  end
+end

data/lib/ffaker/movie.rb

@@ -37,7 +37,7 @@ module FFaker
     end
 
     def maybe_adj_or_adv
-      fetch_sample(ADJ_AND_ADV) + ' ' if rand(0..1) == 1
+      "#{fetch_sample(ADJ_AND_ADV)} " if rand(0..1) == 1
     end
 
     def simple_title

data/lib/ffaker/name_fr.rb

@@ -25,9 +25,10 @@ module FFaker
 
     def name
       case rand(0..9)
-      when 7 then "#{first_name} #{prefix} #{last_name}"
-      when 5 then "#{first_name} #{prefix} #{last_name}"
-      else        "#{first_name} #{last_name}"
+      when 5, 7
+        "#{first_name} #{prefix} #{last_name}"
+      else
+        "#{first_name} #{last_name}"
       end
     end
   end

data/lib/ffaker/name_pl.rb

@@ -11,7 +11,7 @@ module FFaker
     GENDERS = %i[random female male].freeze
     MALE_PREFIXES = %w[Pan].freeze
     FEMALE_PREFIXES = %w[Pani].freeze
-    ACADEMIC_DEGREE_PREFIXES = %w[lic. inż. mgr mgr\ inż. dr dr\ hab. prof.].freeze
+    ACADEMIC_DEGREE_PREFIXES = ['lic.', 'inż.', 'mgr', 'mgr inż.', 'dr', 'dr hab.', 'prof.'].freeze
     PREFIXES = (MALE_PREFIXES + FEMALE_PREFIXES + ACADEMIC_DEGREE_PREFIXES).freeze
 
     # Generates a random full name for a given gender (random by default).
@@ -90,9 +90,9 @@ module FFaker
 
     def name_for_gender(name_type, gender) # :nodoc:
       raise(ArgumentError, "Gender must be one of: #{GENDERS}") unless GENDERS.include?(gender)
-      return send("#{gender}_#{name_type}") unless gender == :random
+      return send(:"#{gender}_#{name_type}") unless gender == :random
 
-      fetch_sample([send("female_#{name_type}"), send("male_#{name_type}")])
+      fetch_sample([send(:"female_#{name_type}"), send(:"male_#{name_type}")])
     end
   end
 end

data/lib/ffaker/number.rb

@@ -15,12 +15,16 @@ module FFaker
       FFaker.numerify("#{whole_part_pattern}.#{fractional_part_pattern}").to_f
     end
 
+    def between(from: 1.00, to: 5000.00)
+      fetch_sample(from..to)
+    end
+
     private
 
     def generate_pattern(digits)
-      raise ArgumentError.new('Digits cannot be less than 1') if digits < 1
+      raise ArgumentError, 'Digits cannot be less than 1' if digits < 1
 
-      "#{fetch_sample(1..9)}#{"#" * (digits - 1)}"
+      "#{fetch_sample(1..9)}#{'#' * (digits - 1)}"
     end
   end
 end

data/lib/ffaker/phone_number_de.rb

@@ -7,15 +7,15 @@ module FFaker
 
     # Mobile prefixes are in the 015x, 016x, 017x ranges
     def mobile_prefix(leading_zero = true)
-      mobile_prefix = '1' + rand(5..7).to_s + rand(0..9).to_s
-      mobile_prefix = '0' + mobile_prefix if leading_zero
+      mobile_prefix = "1#{rand(5..7)}#{rand(0..9)}"
+      mobile_prefix = "0#{mobile_prefix}" if leading_zero
       mobile_prefix
     end
 
     # Region prefixes are in range 02..09 with length of 3 to 5 digits
     def region_prefix(leading_zero = true)
       region_prefix = rand(2..9).to_s + FFaker.numerify('#' * rand(1..3)).to_s
-      region_prefix = '0' + region_prefix if leading_zero
+      region_prefix = "0#{region_prefix}" if leading_zero
       region_prefix
     end
 

data/lib/ffaker/skill.rb

@@ -14,7 +14,7 @@ module FFaker
     end
 
     def specialty
-      format('%s %s', fetch_sample(SPECIALTY_START), fetch_sample(SPECIALTY_END))
+      "#{fetch_sample(SPECIALTY_START)} #{fetch_sample(SPECIALTY_END)}"
     end
 
     def specialties(num = 3)

data/lib/ffaker/ssn.rb

@@ -15,8 +15,10 @@ module FFaker
       second_group = rand(1..99)
       third_group  = rand(1..9999)
 
-      group_numbers = [first_group, second_group, third_group]
-      format('%.3d-%.2d-%.4d', *group_numbers)
+      format(
+        '%<first_group>.3d-%<second_group>.2d-%<third_group>.4d',
+        first_group: first_group, second_group: second_group, third_group: third_group
+      )
     end
   end
 end

data/lib/ffaker/ssn_se.rb

@@ -54,7 +54,7 @@ module FFaker
     end
 
     def random_birth_time_between(from = ::Time.local(1940, 1, 1), to = ::Time.now)
-      ::Time.at(from + rand * (to.to_f - from.to_f))
+      ::Time.at(from + (rand * (to.to_f - from.to_f)))
     end
 
     def random_region_for(gender)
@@ -70,7 +70,7 @@ module FFaker
     end
 
     def random_region_odd
-      rand(0..498) * 2 + 1
+      (rand(0..498) * 2) + 1
     end
 
     def three_character_string(number)