ffaker 2.10.0 → 2.23.0

data/test/test_units_english.rb

@@ -1,8 +1,7 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
-require 'helper'
+require_relative 'helper'
 
-# Author: lurraca github.com/lurraca
 class TestUnitsEnglish < Test::Unit::TestCase
   include DeterministicHelper
 
@@ -15,50 +14,50 @@ class TestUnitsEnglish < Test::Unit::TestCase
 
   def setup
     @tester = FFaker::UnitEnglish
-    @length_units = @tester::LENGTH_UNITS.map { |u| OpenStruct.new u }
-    @mass_units = @tester::MASS_UNITS.map { |u| OpenStruct.new u }
-    @liquid_units = @tester::LIQUID_UNITS.map { |u| OpenStruct.new u }
-    @volume_units = @tester::VOLUME_UNITS.map { |u| OpenStruct.new u }
-    @area_units = @tester::AREA_UNITS.map { |u| OpenStruct.new u }
+    @length_units = @tester::LENGTH_UNITS
+    @mass_units = @tester::MASS_UNITS
+    @liquid_units = @tester::LIQUID_UNITS
+    @volume_units = @tester::VOLUME_UNITS
+    @area_units = @tester::AREA_UNITS
   end
 
   def test_length_name
-    assert_include @length_units.map(&:name), @tester.length_name
+    assert_include @length_units.map { |unit| unit[:name] }, @tester.length_name
   end
 
   def test_length_abbrev
-    assert_include @length_units.map(&:abbreviation), @tester.length_abbr
+    assert_include @length_units.map { |unit| unit[:abbreviation] }, @tester.length_abbr
   end
 
   def test_mass_name
-    assert_include @mass_units.map(&:name), @tester.mass_name
+    assert_include @mass_units.map { |unit| unit[:name] }, @tester.mass_name
   end
 
   def test_mass_abbr
-    assert_include @mass_units.map(&:abbreviation), @tester.mass_abbr
+    assert_include @mass_units.map { |unit| unit[:abbreviation] }, @tester.mass_abbr
   end
 
   def test_liquid_name
-    assert_include @liquid_units.map(&:name), @tester.liquid_name
+    assert_include @liquid_units.map { |unit| unit[:name] }, @tester.liquid_name
   end
 
   def test_liquid_abbr
-    assert_include @liquid_units.map(&:abbreviation), @tester.liquid_abbr
+    assert_include @liquid_units.map { |unit| unit[:abbreviation] }, @tester.liquid_abbr
   end
 
   def test_volume_name
-    assert_include @volume_units.map(&:name), @tester.volume_name
+    assert_include @volume_units.map { |unit| unit[:name] }, @tester.volume_name
   end
 
   def test_volume_abbr
-    assert_include @volume_units.map(&:abbreviation), @tester.volume_abbr
+    assert_include @volume_units.map { |unit| unit[:abbreviation] }, @tester.volume_abbr
   end
 
   def test_area_name
-    assert_include @area_units.map(&:name), @tester.area_name
+    assert_include @area_units.map { |unit| unit[:name] }, @tester.area_name
   end
 
   def test_area_abbr
-    assert_include @area_units.map(&:abbreviation), @tester.area_abbr
+    assert_include @area_units.map { |unit| unit[:abbreviation] }, @tester.area_abbr
   end
 end

data/test/test_units_metric.rb

@@ -1,8 +1,7 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
-require 'helper'
+require_relative 'helper'
 
-# Author: lurraca github.com/lurraca
 class TestUnitsMetric < Test::Unit::TestCase
   include DeterministicHelper
 
@@ -15,50 +14,50 @@ class TestUnitsMetric < Test::Unit::TestCase
 
   def setup
     @tester = FFaker::UnitMetric
-    @length_units = @tester::LENGTH_UNITS.map { |u| OpenStruct.new u }
-    @mass_units = @tester::MASS_UNITS.map { |u| OpenStruct.new u }
-    @liquid_units = @tester::LIQUID_UNITS.map { |u| OpenStruct.new u }
-    @volume_units = @tester::VOLUME_UNITS.map { |u| OpenStruct.new u }
-    @area_units = @tester::AREA_UNITS.map { |u| OpenStruct.new u }
+    @length_units = @tester::LENGTH_UNITS
+    @mass_units = @tester::MASS_UNITS
+    @liquid_units = @tester::LIQUID_UNITS
+    @volume_units = @tester::VOLUME_UNITS
+    @area_units = @tester::AREA_UNITS
   end
 
   def test_length_name
-    assert_include @length_units.map(&:name), @tester.length_name
+    assert_include @length_units.map { |unit| unit[:name] }, @tester.length_name
   end
 
   def test_length_abbrev
-    assert_include @length_units.map(&:abbreviation), @tester.length_abbr
+    assert_include @length_units.map { |unit| unit[:abbreviation] }, @tester.length_abbr
   end
 
   def test_mass_name
-    assert_include @mass_units.map(&:name), @tester.mass_name
+    assert_include @mass_units.map { |unit| unit[:name] }, @tester.mass_name
   end
 
   def test_mass_abbr
-    assert_include @mass_units.map(&:abbreviation), @tester.mass_abbr
+    assert_include @mass_units.map { |unit| unit[:abbreviation] }, @tester.mass_abbr
   end
 
   def test_liquid_name
-    assert_include @liquid_units.map(&:name), @tester.liquid_name
+    assert_include @liquid_units.map { |unit| unit[:name] }, @tester.liquid_name
   end
 
   def test_liquid_abbr
-    assert_include @liquid_units.map(&:abbreviation), @tester.liquid_abbr
+    assert_include @liquid_units.map { |unit| unit[:abbreviation] }, @tester.liquid_abbr
   end
 
   def test_volume_name
-    assert_include @volume_units.map(&:name), @tester.volume_name
+    assert_include @volume_units.map { |unit| unit[:name] }, @tester.volume_name
   end
 
   def test_volume_abbr
-    assert_include @volume_units.map(&:abbreviation), @tester.volume_abbr
+    assert_include @volume_units.map { |unit| unit[:abbreviation] }, @tester.volume_abbr
   end
 
   def test_area_name
-    assert_include @area_units.map(&:name), @tester.area_name
+    assert_include @area_units.map { |unit| unit[:name] }, @tester.area_name
   end
 
   def test_area_abbr
-    assert_include @area_units.map(&:abbreviation), @tester.area_abbr
+    assert_include @area_units.map { |unit| unit[:abbreviation] }, @tester.area_abbr
   end
 end

data/test/test_vehicle.rb

@@ -1,10 +1,18 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
-require 'helper'
+require_relative 'helper'
 
 class TestVehicle < Test::Unit::TestCase
   include DeterministicHelper
 
+  # https://en.wikibooks.org/wiki/Vehicle_Identification_Numbers_(VIN_codes)/Check_digit
+  VIN_TRANSLITERATION_VALUES = {
+    'A' => 1, 'B' => 2, 'C' => 3, 'D' => 4, 'E' => 5, 'F' => 6, 'G' => 7, 'H' => 8,
+    'J' => 1, 'K' => 2, 'L' => 3, 'M' => 4, 'N' => 5, 'P' => 7, 'R' => 9,
+    'S' => 2, 'T' => 3, 'U' => 4, 'V' => 5, 'W' => 6, 'X' => 7, 'Y' => 8, 'Z' => 9
+  }.freeze
+  VIN_POSITION_WEIGHTS = [8, 7, 6, 5, 4, 3, 2, 10, 0, 9, 8, 7, 6, 5, 4, 3, 2].freeze
+
   assert_methods_are_deterministic(
     FFaker::Vehicle,
     :base_color, :drivetrain, :engine_cylinders, :engine_displacement,
@@ -33,7 +41,7 @@ class TestVehicle < Test::Unit::TestCase
   end
 
   def test_model
-    assert_match(/\A[-\. &a-z0-9]+\z/i, FFaker::Vehicle.model)
+    assert_match(/\A[-. &a-z0-9]+\z/i, FFaker::Vehicle.model)
   end
 
   def test_trim
@@ -41,7 +49,13 @@ class TestVehicle < Test::Unit::TestCase
   end
 
   def test_vin
-    assert_match(/\A[A-Z0-9]{17}\z/, FFaker::Vehicle.vin)
+    vin = FFaker::Vehicle.vin
+
+    assert_match(/\A[A-Z0-9]{17}\z/, vin)
+    assert_not_match(/[IOQ]/, vin) # VINs can't have these letters
+    assert_includes(FFaker::Vehicle::VIN::VALID_ALPHA, vin[6]) # passenger vehicle designator
+    assert_includes(FFaker::Vehicle::VIN::VALID_YEAR_CHARS, vin[9]) # check year character
+    assert_equal(vin_checksum_digit(vin), vin[8])
   end
 
   def test_drivetrain
@@ -65,10 +79,23 @@ class TestVehicle < Test::Unit::TestCase
   end
 
   def test_fuel_type
-    assert_match(/\A[ a-z0-9\(\)]+\z/i, FFaker::Vehicle.fuel_type)
+    assert_match(/\A[ a-z0-9()]+\z/i, FFaker::Vehicle.fuel_type)
   end
 
   def test_interior_upholstery
     assert_match(/\A[ a-z0-9]+\z/i, FFaker::Vehicle.interior_upholstery)
   end
+
+  private
+
+  def vin_checksum_digit(vin)
+    weighted_sum = vin.chars.each_with_index.sum do |char, idx|
+      (VIN_TRANSLITERATION_VALUES[char] || char).to_i * VIN_POSITION_WEIGHTS[idx]
+    end
+
+    check_digit = weighted_sum % 11
+    check_digit == '10' ? 'X' : check_digit
+    check_digit = 'X' if check_digit == 10
+    check_digit.to_s
+  end
 end

data/test/test_venue.rb

@@ -1,6 +1,6 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
-require 'helper'
+require_relative 'helper'
 
 class TestVenue < Test::Unit::TestCase
   include DeterministicHelper

data/test/test_youtube.rb

@@ -1,6 +1,6 @@
-# encoding: utf-8
+# frozen_string_literal: true
 
-require 'helper'
+require_relative 'helper'
 
 class YoutubeTest < Test::Unit::TestCase
   include DeterministicHelper