ff1 1.1.0 → 1.2.3

data/lib/generators/ff1/templates/initializer.rb

@@ -0,0 +1,55 @@
+# frozen_string_literal: true
+
+# FF1 Format Preserving Encryption Configuration
+FF1::ActiveRecord.configure do |config|
+  # Global encryption key - REQUIRED
+  # Should be 16, 24, or 32 bytes for AES-128/192/256
+  # Store securely using Rails credentials or environment variables
+  # 
+  # Example using Rails credentials:
+  # config.global_key = Rails.application.credentials.ff1_encryption_key
+  # 
+  # Example using environment variable:
+  # config.global_key = ENV['FF1_ENCRYPTION_KEY']&.b
+  # 
+  # For development/testing only (DO NOT use in production):
+  config.global_key = SecureRandom.bytes(32) if Rails.env.development? || Rails.env.test?
+
+  # Default encryption mode for all models
+  # :reversible - can decrypt data (default)
+  # :irreversible - cannot decrypt data (for GDPR compliance)
+  config.default_mode = FF1::Modes::REVERSIBLE
+
+  # Column names for soft delete functionality
+  config.deleted_at_column = :deleted_at
+  config.ff1_deleted_column = :ff1_deleted
+
+  # Hide soft-deleted records from default queries (default: true)
+  # Set to false to include soft-deleted records in queries by default
+  config.hide_deleted_by_default = true
+end
+
+# Example model integration:
+#
+# class User < ApplicationRecord
+#   include FF1::ActiveRecord
+#   
+#   # Encrypt email and phone with reversible encryption
+#   ff1_encrypt :email, :phone, mode: :reversible
+#   
+#   # Encrypt SSN with irreversible encryption
+#   ff1_encrypt :ssn, mode: :irreversible
+# end
+#
+# Usage:
+#   user = User.create(email: 'user@example.com', ssn: '123-45-6789')
+#   puts user.email  # Automatically decrypted for reversible columns
+#   puts user.ssn    # Shows "[ENCRYPTED]" for irreversible columns
+#   
+#   # GDPR compliant deletion
+#   user.destroy     # Soft deletes with irreversible encryption
+#   
+#   # Query scopes
+#   User.ff1_active    # Non-deleted users
+#   User.ff1_deleted   # Soft-deleted users
+#   User.ff1_all       # All users (active + deleted)

data/lib/generators/ff1/templates/migration.rb.erb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+class <%= migration_class %> < ActiveRecord::Migration[<%= ActiveRecord::Migration.current_version %>]
+  def change
+    add_column :<%= table_name %>, :<%= deleted_at_column %>, :datetime, null: true
+    add_column :<%= table_name %>, :<%= ff1_deleted_column %>, :boolean, null: false, default: false
+
+    <% if add_indexes? %>
+    add_index :<%= table_name %>, :<%= deleted_at_column %>
+    add_index :<%= table_name %>, :<%= ff1_deleted_column %>
+    add_index :<%= table_name %>, [:<%= ff1_deleted_column %>, :<%= deleted_at_column %>], 
+              name: 'index_<%= table_name %>_on_ff1_deletion'
+    <% end %>
+  end
+end

data/spec/ff1_active_record_spec.rb

@@ -0,0 +1,382 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+begin
+  require 'active_record'
+  require 'sqlite3'
+  # Explicitly load FF1 ActiveRecord integration
+  FF1.load_active_record_integration!
+rescue LoadError => e
+  puts "Skipping ActiveRecord tests: #{e.message}"
+  return
+end
+
+# Setup in-memory SQLite database for testing
+begin
+  ActiveRecord::Base.establish_connection(
+    adapter: 'sqlite3',
+    database: ':memory:'
+  )
+rescue => e
+  puts "Skipping ActiveRecord tests due to connection error: #{e.message}"
+  return
+end
+
+# Define test schema
+ActiveRecord::Schema.define do
+  create_table :users do |t|
+    t.string :name
+    t.string :email
+    t.string :phone
+    t.string :ssn
+    t.datetime :deleted_at
+    t.boolean :ff1_deleted, default: false
+    t.timestamps
+  end
+
+  create_table :posts do |t|
+    t.string :title
+    t.text :content
+    t.integer :user_id
+    t.datetime :deleted_at
+    t.boolean :ff1_deleted, default: false
+    t.timestamps
+  end
+end
+
+# Test models
+class User < ActiveRecord::Base
+  include FF1::ActiveRecord
+  
+  ff1_encrypt :email, :phone, mode: :reversible
+  ff1_encrypt :ssn, mode: :irreversible
+  
+  has_many :posts, dependent: :destroy
+end
+
+class Post < ActiveRecord::Base
+  include FF1::ActiveRecord
+  
+  ff1_encrypt :content, mode: :reversible
+  
+  belongs_to :user
+end
+
+RSpec.describe FF1::ActiveRecord do
+  let(:encryption_key) { SecureRandom.bytes(32) }
+  
+  before(:all) do
+    FF1::ActiveRecord.configure do |config|
+      config.global_key = SecureRandom.bytes(32)
+      config.default_mode = FF1::Modes::REVERSIBLE
+    end
+  end
+
+  before(:each) do
+    # Recreate database schema for each test to ensure clean state
+    begin
+      ActiveRecord::Schema.define do
+        drop_table :users if table_exists? :users
+        drop_table :posts if table_exists? :posts
+        
+        create_table :users do |t|
+          t.string :name
+          t.string :email
+          t.string :phone
+          t.string :ssn
+          t.datetime :deleted_at
+          t.boolean :ff1_deleted, default: false
+          t.timestamps
+        end
+
+        create_table :posts do |t|
+          t.string :title
+          t.text :content
+          t.integer :user_id
+          t.datetime :deleted_at
+          t.boolean :ff1_deleted, default: false
+          t.timestamps
+        end
+      end
+    rescue => e
+      puts "Schema setup error: #{e.message}"
+    end
+  end
+
+  describe 'configuration' do
+    it 'allows global configuration' do
+      FF1::ActiveRecord.configure do |config|
+        config.global_key = encryption_key
+        config.default_mode = FF1::Modes::IRREVERSIBLE
+      end
+
+      expect(FF1::ActiveRecord.configuration.global_key).to eq(encryption_key)
+      expect(FF1::ActiveRecord.configuration.default_mode).to eq(FF1::Modes::IRREVERSIBLE)
+    end
+  end
+
+  describe 'column encryption configuration' do
+    it 'configures encrypted columns correctly' do
+      expect(User.ff1_encrypted_columns[:email][:mode]).to eq(FF1::Modes::REVERSIBLE)
+      expect(User.ff1_encrypted_columns[:phone][:mode]).to eq(FF1::Modes::REVERSIBLE)
+      expect(User.ff1_encrypted_columns[:ssn][:mode]).to eq(FF1::Modes::IRREVERSIBLE)
+    end
+
+    it 'identifies encrypted columns' do
+      expect(User.ff1_encrypted_column?(:email)).to be true
+      expect(User.ff1_encrypted_column?(:name)).to be false
+    end
+  end
+
+  describe 'automatic encryption/decryption' do
+    let(:user_data) do
+      {
+        name: 'John Doe',
+        email: 'john@example.com',
+        phone: '555-1234',
+        ssn: '123-45-6789'
+      }
+    end
+
+    it 'encrypts data on save' do
+      user = User.new(user_data)
+      user.save!
+
+      # Check that data is encrypted in database
+      raw_user = User.connection.select_one("SELECT * FROM users WHERE id = #{user.id}")
+      expect(raw_user['email']).not_to eq('john@example.com')
+      expect(raw_user['phone']).not_to eq('555-1234')
+      expect(raw_user['ssn']).not_to eq('123-45-6789')
+      
+      # But name should not be encrypted
+      expect(raw_user['name']).to eq('John Doe')
+    end
+
+    it 'decrypts reversible data on access' do
+      user = User.create!(user_data)
+
+      # Reversible columns should decrypt correctly
+      expect(user.email).to eq('john@example.com')
+      expect(user.phone).to eq('555-1234')
+    end
+
+    it 'returns placeholder for irreversible data' do
+      user = User.create!(user_data)
+
+      # Irreversible columns should return placeholder
+      expect(user.ssn).to eq('[ENCRYPTED]')
+    end
+
+    it 'handles text columns correctly' do
+      post = Post.create!(title: 'Test Post', content: 'This is secret content')
+      
+      # Text content should be encrypted/decrypted properly
+      expect(post.content).to eq('This is secret content')
+      
+      # Check encryption in database
+      raw_post = Post.connection.select_one("SELECT * FROM posts WHERE id = #{post.id}")
+      expect(raw_post['content']).not_to eq('This is secret content')
+      expect(raw_post['content']).to match(/\A[A-Za-z0-9+\/]+=*\z/) # Base64 pattern
+    end
+
+    it 'handles nil and empty values' do
+      user = User.create!(name: 'Test User', email: nil, phone: '', ssn: '123-45-6789')
+      
+      expect(user.email).to be_nil
+      expect(user.phone).to eq('')
+      expect(user.ssn).to eq('[ENCRYPTED]')
+    end
+
+    it 'detects attribute changes correctly' do
+      user = User.create!(user_data)
+      
+      expect(user.ff1_attribute_changed?('email')).to be false
+      
+      user.email = 'newemail@example.com'
+      expect(user.ff1_attribute_changed?('email')).to be true
+      
+      user.save!
+      expect(user.ff1_attribute_changed?('email')).to be false
+    end
+  end
+
+  describe 'soft delete functionality' do
+    let(:user) { User.create!(name: 'John Doe', email: 'john@example.com', ssn: '123-45-6789') }
+
+    it 'performs soft delete instead of hard delete' do
+      user # force creation of user before the expectation
+      expect { user.destroy }.not_to change { User.ff1_all.count }
+      
+      user.reload
+      expect(user.ff1_deleted?).to be true
+      expect(user.ff1_deleted_at).to be_within(1.second).of(Time.current)
+    end
+
+    it 'irreversibly encrypts data during soft delete' do
+      original_email = user.email
+      user.destroy
+      
+      # Email should now be encrypted differently (irreversibly)
+      raw_user = User.connection.select_one("SELECT * FROM users WHERE id = #{user.id}")
+      expect(raw_user['email']).not_to eq(original_email)
+      
+      # Even after reload, should not be able to decrypt
+      user.reload
+      expect(user.email).to eq('[ENCRYPTED]')
+    end
+
+    it 'can restore soft-deleted records' do
+      user.destroy
+      expect(user.ff1_deleted?).to be true
+      
+      user.ff1_restore
+      expect(user.ff1_deleted?).to be false
+      expect(user.ff1_deleted_at).to be_nil
+    end
+
+    it 'supports hard destroy when needed' do
+      user_id = user.id
+      user.ff1_hard_destroy!
+      
+      expect { User.find(user_id) }.to raise_error(ActiveRecord::RecordNotFound)
+    end
+  end
+
+  describe 'query scopes' do
+    let!(:active_user) { User.create!(name: 'Active User', email: 'active@example.com') }
+    let!(:deleted_user) { User.create!(name: 'Deleted User', email: 'deleted@example.com') }
+
+    before do
+      deleted_user.destroy
+    end
+
+    it 'ff1_active scope returns only active records' do
+      expect(User.ff1_active).to include(active_user)
+      expect(User.ff1_active).not_to include(deleted_user)
+    end
+
+    it 'ff1_deleted scope returns only deleted records' do
+      expect(User.ff1_deleted).not_to include(active_user)
+      expect(User.ff1_deleted).to include(deleted_user)
+    end
+
+    it 'ff1_all scope returns all records' do
+      expect(User.ff1_all).to include(active_user)
+      expect(User.ff1_all).to include(deleted_user)
+    end
+
+    it 'ff1_recently_deleted scope works with time ranges' do
+      expect(User.ff1_recently_deleted(within: 1.hour)).to include(deleted_user)
+      
+      # Sleep to ensure the deletion was more than 1 second ago
+      sleep(1.1)
+      
+      expect(User.ff1_recently_deleted(within: 1.second)).not_to include(deleted_user)
+    end
+
+    it 'provides count methods' do
+      expect(User.ff1_active_count).to eq(1)
+      expect(User.ff1_deleted_count).to eq(1)
+    end
+
+    it 'provides find methods' do
+      expect(User.ff1_find_active(active_user.id)).to eq(active_user)
+      expect(User.ff1_find_deleted(deleted_user.id)).to eq(deleted_user)
+      expect { User.ff1_find_active(deleted_user.id) }.to raise_error(ActiveRecord::RecordNotFound)
+    end
+
+    it 'provides statistics' do
+      stats = User.ff1_stats
+      
+      expect(stats[:total_records]).to eq(2)
+      expect(stats[:active_records]).to eq(1)
+      expect(stats[:deleted_records]).to eq(1)
+      expect(stats[:deletion_rate]).to eq(50.0)
+      expect(stats[:encrypted_columns]).to include(:email, :phone, :ssn)
+    end
+  end
+
+  describe 'bulk operations' do
+    let!(:users) do
+      3.times.map do |i|
+        User.create!(name: "User #{i}", email: "user#{i}@example.com")
+      end
+    end
+
+    it 'supports bulk soft delete' do
+      count = User.ff1_destroy_all(name: ['User 0', 'User 1'])
+      
+      expect(count).to eq(2)
+      expect(User.ff1_active_count).to eq(1)
+      expect(User.ff1_deleted_count).to eq(2)
+    end
+
+    it 'supports purging old deleted records' do
+      # Soft delete all users
+      users.each(&:destroy)
+      
+      # Simulate old deletion by updating timestamps
+      User.ff1_deleted.update_all(deleted_at: 2.months.ago)
+      
+      purged_count = User.ff1_purge_deleted(older_than: 1.month)
+      expect(purged_count).to eq(3)
+      expect(User.ff1_all.count).to eq(0)
+    end
+
+    it 'supports batch processing' do
+      processed = []
+      User.ff1_find_each(batch_size: 2) do |user|
+        processed << user.id
+      end
+      
+      expect(processed.length).to eq(3)
+    end
+  end
+
+  describe 'error handling' do
+    before do
+      # Temporarily break the global key to test error handling
+      allow(FF1::ActiveRecord.configuration).to receive(:global_key).and_return(nil)
+    end
+
+    it 'raises appropriate errors for missing keys' do
+      expect {
+        User.new(email: 'test@example.com').save!
+      }.to raise_error(FF1::Error, /No encryption key provided/)
+    end
+  end
+
+  describe 'thread safety' do
+    it 'handles concurrent access safely' do
+      # SQLite in-memory databases don't work well with threading
+      # This test verifies that our encryption logic is thread-safe
+      # by creating users sequentially but with concurrent-like operations
+      
+      users = []
+      errors = []
+      
+      10.times do |i|
+        begin
+          user = User.create!(
+            name: "User #{i}",
+            email: "user#{i}@example.com",
+            phone: "555-000#{i}"
+          )
+          users << user
+        rescue => e
+          errors << "User #{i} failed: #{e.message}"
+        end
+      end
+      
+      # All users should be created successfully
+      expect(errors).to be_empty, "Errors occurred: #{errors.join(', ')}"
+      expect(users.length).to eq(10)
+      
+      users.each do |user|
+        expect(user.email).to match(/user\d+@example\.com/)
+        expect(user.phone).to match(/555-000\d/)
+      end
+    end
+  end
+end

data/spec/generators/ff1/install_generator_spec.rb

@@ -0,0 +1,250 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+begin
+  require 'rails/generators'
+  require 'generators/ff1/install_generator'
+  require 'tempfile'
+  require 'fileutils'
+  # Explicitly load FF1 ActiveRecord integration
+  FF1.load_active_record_integration!
+rescue LoadError => e
+  puts "Skipping generator tests: #{e.message}"
+  return
+end
+
+RSpec.describe FF1::Generators::InstallGenerator, type: :generator do
+  include FileUtils
+
+  let(:temp_dir) { Dir.mktmpdir }
+  let(:destination_root) { temp_dir }
+
+  before do
+    # Save current directory first
+    @original_dir = Dir.pwd
+    
+    # Setup Rails-like directory structure
+    mkdir_p File.join(temp_dir, 'config', 'initializers')
+    mkdir_p File.join(temp_dir, 'db', 'migrate')
+    mkdir_p File.join(temp_dir, 'app', 'models')
+
+    # Create a more complete Rails mock with Generators module
+    actions_mock = Module.new do
+      def template(source, destination, config = {})
+        # Simple template method - just copy content with basic ERB processing
+        source_path = File.join(File.expand_path('../../../lib/generators/ff1/templates', __dir__), source)
+        if File.exist?(source_path)
+          content = File.read(source_path)
+          # Basic ERB processing for migration templates
+          if source.end_with?('.erb')
+            content = content.gsub(/<%= migration_class %>/, config[:migration_class] || 'TestMigration')
+            content = content.gsub(/<%= table_name %>/, config[:table_name] || 'test_table')
+            content = content.gsub(/<%= deleted_at_column %>/, config[:deleted_at_column] || 'deleted_at')
+            content = content.gsub(/<%= ff1_deleted_column %>/, config[:ff1_deleted_column] || 'ff1_deleted')
+            
+            # Handle conditional blocks - check if indexes should be added
+            should_add_indexes = config.key?(:add_indexes) ? config[:add_indexes] : true
+            
+            if should_add_indexes
+              content = content.gsub(/<% if add_indexes\? %>/, '')
+              content = content.gsub(/<% end %>/, '')
+            else
+              # Remove the index section if add_indexes? is false
+              content = content.gsub(/<% if add_indexes\? %>.*?<% end %>/m, '')
+            end
+            
+            # Handle ActiveRecord version
+            content = content.gsub(/<%= ActiveRecord::Migration\.current_version %>/, '7.0')
+          end
+          File.write(destination, content)
+        else
+          # Fallback for missing templates
+          File.write(destination, "# Generated migration\n")
+        end
+      end
+      
+      def migration_template(source, destination, config = {})
+        template(source, destination, config)
+      end
+    end
+    
+    migration_mock = Module.new
+    
+    generators_mock = Module.new do
+      const_set('Migration', migration_mock)
+      const_set('Actions', actions_mock)
+    end
+    
+    rails_mock = Module.new do
+      def self.root
+        Pathname.new(Dir.pwd)
+      end
+      
+      const_set('Generators', generators_mock)
+    end
+    
+    # Replace Rails constant for the duration of the test
+    stub_const('Rails', rails_mock)
+    
+    # Extend the generator class with our mocked Actions module
+    FF1::Generators::InstallGenerator.send(:include, actions_mock)
+    
+    # Change to temp directory for generator
+    Dir.chdir(temp_dir)
+  end
+
+  after do
+    Dir.chdir(@original_dir) if @original_dir
+    FileUtils.rm_rf(temp_dir) if temp_dir && Dir.exist?(temp_dir)
+  end
+
+  describe 'initializer generation' do
+    it 'generates initializer when no models specified' do
+      generator = described_class.new([])
+      
+      expect { generator.generate_migration }.not_to raise_error
+      
+      initializer_path = File.join('config', 'initializers', 'ff1.rb')
+      expect(File.exist?(initializer_path)).to be true
+      
+      content = File.read(initializer_path)
+      expect(content).to include('FF1::ActiveRecord.configure')
+      expect(content).to include('config.global_key')
+      expect(content).to include('SecureRandom.bytes(32)')
+    end
+  end
+
+  describe 'model migration generation' do
+    before do
+      # Create a mock User model
+      user_model = <<~RUBY
+        class User < ApplicationRecord
+          include FF1::ActiveRecord
+          ff1_encrypt :email, :phone
+        end
+      RUBY
+      
+      File.write(File.join('app', 'models', 'user.rb'), user_model)
+      
+      # Mock the User class
+      stub_const('User', Class.new)
+    end
+
+    it 'generates migration for specified model' do
+      generator = described_class.new(['User'])
+      
+      expect { generator.generate_migration }.not_to raise_error
+      
+      # Check migration file was created
+      migration_files = Dir.glob(File.join('db', 'migrate', '*_add_ff1_columns_to_users.rb'))
+      expect(migration_files).not_to be_empty
+      
+      migration_content = File.read(migration_files.first)
+      expect(migration_content).to include('add_column :users, :deleted_at, :datetime')
+      expect(migration_content).to include('add_column :users, :ff1_deleted, :boolean')
+      expect(migration_content).to include('add_index :users, :deleted_at')
+      expect(migration_content).to include('add_index :users, :ff1_deleted')
+    end
+
+    it 'generates migrations for multiple models' do
+      generator = described_class.new(['User', 'Post'])
+      
+      expect { generator.generate_migration }.not_to raise_error
+      
+      user_migration = Dir.glob(File.join('db', 'migrate', '*_add_ff1_columns_to_users.rb'))
+      post_migration = Dir.glob(File.join('db', 'migrate', '*_add_ff1_columns_to_posts.rb'))
+      
+      expect(user_migration).not_to be_empty
+      expect(post_migration).not_to be_empty
+    end
+
+    it 'respects custom column names' do
+      generator = described_class.new(
+        ['User'],
+        deleted_at_column: 'removed_at',
+        ff1_deleted_column: 'is_encrypted'
+      )
+      
+      expect { generator.generate_migration }.not_to raise_error
+      
+      migration_files = Dir.glob(File.join('db', 'migrate', '*_add_ff1_columns_to_users.rb'))
+      migration_content = File.read(migration_files.first)
+      
+      expect(migration_content).to include('add_column :users, :removed_at, :datetime')
+      expect(migration_content).to include('add_column :users, :is_encrypted, :boolean')
+    end
+
+    it 'can skip indexes when requested' do
+      generator = described_class.new(['User'], add_indexes: false)
+      
+      expect { generator.generate_migration }.not_to raise_error
+      
+      migration_files = Dir.glob(File.join('db', 'migrate', '*_add_ff1_columns_to_users.rb'))
+      migration_content = File.read(migration_files.first)
+      
+      expect(migration_content).not_to include('add_index')
+    end
+
+    it 'handles non-existent models gracefully' do
+      generator = described_class.new(['NonExistentModel'])
+      
+      expect { generator.generate_migration }.not_to raise_error
+      
+      migration_files = Dir.glob(File.join('db', 'migrate', '*_add_ff1_columns_to_non_existent_models.rb'))
+      expect(migration_files).not_to be_empty
+    end
+  end
+
+  describe 'migration template' do
+    it 'generates valid ActiveRecord migration' do
+      generator = described_class.new(['TestModel'])
+      generator.generate_migration
+      
+      migration_files = Dir.glob(File.join('db', 'migrate', '*_add_ff1_columns_to_test_models.rb'))
+      migration_content = File.read(migration_files.first)
+      
+      # Should be valid Ruby code
+      expect { eval(migration_content) }.not_to raise_error
+      
+      # Should include proper migration structure
+      expect(migration_content).to include('class AddFf1ColumnsToTestModels < ActiveRecord::Migration')
+      expect(migration_content).to include('def change')
+    end
+
+    it 'includes proper timestamp in filename' do
+      generator = described_class.new(['User'])
+      
+      # Mock timestamp
+      fixed_time = Time.new(2023, 1, 1, 12, 0, 0)
+      allow(Time).to receive(:now).and_return(fixed_time)
+      
+      generator.generate_migration
+      
+      migration_files = Dir.glob(File.join('db', 'migrate', '20230101120000_add_ff1_columns_to_users.rb'))
+      expect(migration_files).not_to be_empty
+    end
+  end
+
+  describe 'initializer template' do
+    it 'includes comprehensive configuration examples' do
+      generator = described_class.new([])
+      generator.generate_migration
+      
+      initializer_content = File.read(File.join('config', 'initializers', 'ff1.rb'))
+      
+      expect(initializer_content).to include('Rails.application.credentials.ff1_encryption_key')
+      expect(initializer_content).to include("ENV['FF1_ENCRYPTION_KEY']")
+      expect(initializer_content).to include('config.default_mode = FF1::Modes::REVERSIBLE')
+      expect(initializer_content).to include('config.deleted_at_column = :deleted_at')
+      expect(initializer_content).to include('config.ff1_deleted_column = :ff1_deleted')
+      
+      # Should include usage examples
+      expect(initializer_content).to include('class User < ApplicationRecord')
+      expect(initializer_content).to include('include FF1::ActiveRecord')
+      expect(initializer_content).to include('ff1_encrypt :email, :phone')
+      expect(initializer_content).to include('user.destroy     # Soft deletes')
+      expect(initializer_content).to include('User.ff1_active')
+    end
+  end
+end