fetch 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2f7ab6433f70dc724bd8e7640a072ee3ca26555c
-  data.tar.gz: f25919595f00945f1bb6b1b41e40ca1940ac2421
+  metadata.gz: a10520fb3d8cc9508aef80fe19c88dd4b5b72a71
+  data.tar.gz: cc19fba644b2236f5833f312bf002b495258caf7
 SHA512:
-  metadata.gz: cf303622302ebf70d0f071fc14d99f55dc8b748aae0789397c4afc09c76c1eb5a1c2c60332d28e742f6f9c504ff240d79415dc7122432c3f11d70b4497653e06
-  data.tar.gz: 41b866ef62c1d97f23b2f634b384898023aee0ee61f3caac231d4d11971e34b91b558b812bdf5564018a5dc7b8df75e4a2ab74cd741fc1a8701e9e34a1164c64
+  metadata.gz: 4b23e3bb9c6e49e85d07e37791d46343d5f36467dc279498a9da855ff8580ce3e0df3515bbf58b17222b7b013ee1be5619ec6af746fc7607c573ced140abc07b
+  data.tar.gz: 3239bdfb8eb3ce1855efcad29227fa59ff0c23893781da47b85cae867440edc1e99d35188777e482b3764ec5853b81313b0d604a61e0324d0dae52dc2b192111

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## Version 0.0.4
+
+* Exceptions are raised after the general `Fetch::Base` `error` callback is
+  run.
+
 ## Version 0.0.3
 
 * Adds an general `error` callback to `Fetch::Base` for catching any unhandled

data/README.md

@@ -225,20 +225,27 @@ whole fetch to fail. So please add error handling :blush:
 
 ### General error handling
 
-You add a "catch all" `error` callback to your fetcher subclassed from
-`Fetch::Base`. This enables you to handle any unhandled errors, including errors
-in your fetcher callbacks.
+If you need to ensure that something is run, even if anything in the fetch
+fails, you can add an `error` callback to your `Fetch::Base` subclass.
 
 ```ruby
 class UserFetcher < Fetch::Base
   modules Facebook::UserInfoFetch,
           Github::UserInfoFetch
 
+  before_fetch do
+    this_fails!
+  end
+
   error do |e|
     # Do something that must be done,
     # even if the fetch fails.
   end
 end
+
+user = User.find(123)
+UserFetcher.new(user).fetch
+# => raises an exception, but the error callback will be run before that.
 ```
 
 ### Parsing JSON

data/lib/fetch/base.rb

@@ -47,9 +47,8 @@ module Fetch
 
       true
     rescue => e
-      raise e unless callback?(:error)
       error(e)
-      false
+      raise e
     end
 
     private

data/lib/fetch/version.rb

@@ -1,3 +1,3 @@
 module Fetch
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/test/error_test.rb

@@ -17,23 +17,10 @@ class ErrorTest < Minitest::Test
         actions << "got #{e.message}"
       end
     end
-    klass.new.fetch
-    assert_match /got undefined method `this_wont_work!'/, actions.first
-  end
-
-  def test_exception_is_raised_if_no_error_callback_specified
-    stub_request(:get, "http://test.com/one").to_return(body: "got one")
-    mod = Class.new(Fetch::Module) do
-      request do |req|
-        req.url = "http://test.com/one"
-        req.process do |body|
-          this_wont_work!
-        end
-      end
-    end
     assert_raises NoMethodError do
-      MockFetcher(mod).new.fetch
+      klass.new.fetch
     end
+    assert_match /got undefined method `this_wont_work!'/, actions.first
   end
 
   [:modules, :load, :init, :before_fetch, :after_fetch, :progress].each do |callback|
@@ -54,7 +41,9 @@ class ErrorTest < Minitest::Test
           actions << "got #{e.message}"
         end
       end
-      klass.new.fetch
+      assert_raises NoMethodError do
+        klass.new.fetch
+      end
       assert_match /got undefined method `this_#{callback}_fails!'/, actions.first
     end
   end
@@ -68,9 +57,7 @@ class ErrorTest < Minitest::Test
         req.process do |body|
           this_wont_work!
         end
-      end
-
-      error do |e|
+        req.error {}
       end
     end
     klass = Class.new(MockFetcher(mod)) do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fetch
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Lasse Bunk