fetch 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1f2e34b25ea8efe2d5681328da56ba8d5141775b
-  data.tar.gz: 582f71ff59b4e30b02733a5f777096e4ac785aad
+  metadata.gz: 2f7ab6433f70dc724bd8e7640a072ee3ca26555c
+  data.tar.gz: f25919595f00945f1bb6b1b41e40ca1940ac2421
 SHA512:
-  metadata.gz: 750a2cbaca8debe5512947da70ae5c01a35eb72e71873390013f059ce9694d7777fc3978d224b4292c7039900673c171842438df1c3c15524f584e64f03b3bd3
-  data.tar.gz: 1da726ec7708099401e988d66702f37d4b49ba90b0d80be9dcbdfe667808d49f16e1e37b361a9b04c890b9eb910b4c9e7512269325db9b25ba648d5d60957439
+  metadata.gz: cf303622302ebf70d0f071fc14d99f55dc8b748aae0789397c4afc09c76c1eb5a1c2c60332d28e742f6f9c504ff240d79415dc7122432c3f11d70b4497653e06
+  data.tar.gz: 41b866ef62c1d97f23b2f634b384898023aee0ee61f3caac231d4d11971e34b91b558b812bdf5564018a5dc7b8df75e4a2ab74cd741fc1a8701e9e34a1164c64

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## Version 0.0.3
+
+* Adds an general `error` callback to `Fetch::Base` for catching any unhandled
+  errors that might occur.
+
 ## Version 0.0.2
 
 * Sends fetchable to fetch modules by default.

data/README.md

@@ -177,7 +177,7 @@ callback isn't called.
 **Note:** If you don't specify a `failure` callback at all, HTTP failures are ignored,
 and processing skipped for the failed request.
 
-### Handling errors
+### Handling fetch errors
 
 Sometimes a URL will return something that potentially makes your processing
 code fail. To prevent this from breaking your whole fetch, you can handle
@@ -223,6 +223,24 @@ isn't run.
 above, any exceptions that occur when processing will be raised, causing the
 whole fetch to fail. So please add error handling :blush:
 
+### General error handling
+
+You add a "catch all" `error` callback to your fetcher subclassed from
+`Fetch::Base`. This enables you to handle any unhandled errors, including errors
+in your fetcher callbacks.
+
+```ruby
+class UserFetcher < Fetch::Base
+  modules Facebook::UserInfoFetch,
+          Github::UserInfoFetch
+
+  error do |e|
+    # Do something that must be done,
+    # even if the fetch fails.
+  end
+end
+```
+
 ### Parsing JSON
 
 Fetch has a module for automatically parsing the request body as JSON before

data/lib/fetch/base.rb

@@ -21,7 +21,8 @@ module Fetch
                     :init,
                     :before_fetch,
                     :after_fetch,
-                    :progress
+                    :progress,
+                    :error
 
     def initialize(fetchable = nil)
       @fetchable = fetchable
@@ -45,6 +46,10 @@ module Fetch
       after_fetch
 
       true
+    rescue => e
+      raise e unless callback?(:error)
+      error(e)
+      false
     end
 
     private

data/lib/fetch/version.rb

@@ -1,3 +1,3 @@
 module Fetch
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/test/error_test.rb

@@ -0,0 +1,84 @@
+require "test_helper"
+
+class ErrorTest < Minitest::Test
+  def test_error_callback_gets_run_for_unhandled_fetch_module_errors
+    actions = []
+    stub_request(:get, "http://test.com/one").to_return(body: "got one")
+    mod = Class.new(Fetch::Module) do
+      request do |req|
+        req.url = "http://test.com/one"
+        req.process do |body|
+          this_wont_work!
+        end
+      end
+    end
+    klass = Class.new(MockFetcher(mod)) do
+      error do |e|
+        actions << "got #{e.message}"
+      end
+    end
+    klass.new.fetch
+    assert_match /got undefined method `this_wont_work!'/, actions.first
+  end
+
+  def test_exception_is_raised_if_no_error_callback_specified
+    stub_request(:get, "http://test.com/one").to_return(body: "got one")
+    mod = Class.new(Fetch::Module) do
+      request do |req|
+        req.url = "http://test.com/one"
+        req.process do |body|
+          this_wont_work!
+        end
+      end
+    end
+    assert_raises NoMethodError do
+      MockFetcher(mod).new.fetch
+    end
+  end
+
+  [:modules, :load, :init, :before_fetch, :after_fetch, :progress].each do |callback|
+    define_method "test_error_gets_run_when_#{callback}_callback_fails" do
+      actions = []
+      stub_request(:get, "http://test.com/one").to_return(body: "got one")
+      mod = Class.new(Fetch::Module) do
+        request do |req|
+          req.url = "http://test.com/one"
+        end
+      end
+      klass = Class.new(MockFetcher(mod)) do
+        send(callback) do
+          send "this_#{callback}_fails!"
+        end
+
+        error do |e|
+          actions << "got #{e.message}"
+        end
+      end
+      klass.new.fetch
+      assert_match /got undefined method `this_#{callback}_fails!'/, actions.first
+    end
+  end
+
+  def test_error_callback_doesnt_run_for_handled_fetch_module_errors
+    actions = []
+    stub_request(:get, "http://test.com/one").to_return(body: "got one")
+    mod = Class.new(Fetch::Module) do
+      request do |req|
+        req.url = "http://test.com/one"
+        req.process do |body|
+          this_wont_work!
+        end
+      end
+
+      error do |e|
+      end
+    end
+    klass = Class.new(MockFetcher(mod)) do
+      error do |e|
+        actions << "got #{e.message}"
+      end
+    end
+    klass.new.fetch
+    assert_equal [], actions
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fetch
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Lasse Bunk
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-04 00:00:00.000000000 Z
+date: 2014-11-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: typhoeus
@@ -110,6 +110,7 @@ files:
 - lib/fetch/version.rb
 - test/callbacks_test.rb
 - test/defaults_test.rb
+- test/error_test.rb
 - test/fetch_test.rb
 - test/init_test.rb
 - test/json_test.rb
@@ -144,6 +145,7 @@ summary: Coming
 test_files:
 - test/callbacks_test.rb
 - test/defaults_test.rb
+- test/error_test.rb
 - test/fetch_test.rb
 - test/init_test.rb
 - test/json_test.rb