ferto 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7c778310b7f3bba9e3d6984c185b7c61ed475e398a38924c34ccecbf490ddb8d
-  data.tar.gz: 3f027ed81e81275682260282b1b72c09a0469ebb7d026864105a79e3bb0c6ad8
+  metadata.gz: c80bb0d54c8592f31f6ea01de91ea12d83f546ab8bf097b130a5a197161705d3
+  data.tar.gz: 169b822ff83c13a9be069436c3ae45a62af82eda65fdb7c8b57b3ecccc44ca62
 SHA512:
-  metadata.gz: 2745ec8da102954efe1eb8e6682290ca56ab9970816f1411e5e01947d9d61b4fcd69efbc4d329af567dc7f04ff1d9d590a845c245b30bac67bb78633ebabc3bb
-  data.tar.gz: e3d558ff92fd5bcd542f56a7a924b77119ddaae6bcb4887f966fe34c0c39b221a0d29bac848d16db1793005d90a92aff6b21afc50626e5693cbb7750dc63a0e3
+  metadata.gz: 0cd88c6be7c4bf31a98c9cf45b90271ad011411f4136940fd7011548e938e3be0919d12cddcd8389b401b95e26d63d631df9be7aea8f218c8f6a8ce29ef83cc3
+  data.tar.gz: 7a94067053ecebe87069bd3a63a5effc0a98748c030981f7d98edb1350fb0cb1310a737420c60900a949028c5517124c47bc96bd2c6ff9bbe90481d7b2857ce9

data/.github/workflows/CI.yml

@@ -13,14 +13,16 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby-version: ['2.7', '3.2']
+        ruby-version: ['2.7', '3.2', '3.4', '3.5']
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
       - name: Install dependencies
-        run: sudo apt install -y libcurl4-openssl-dev
+        run: |
+          sudo apt update
+          sudo apt install -y libcurl4-openssl-dev
       - name: Set up Ruby ${{ matrix.ruby-version }}
-        uses: ruby/setup-ruby@v1
+        uses: ruby/setup-ruby@d45b1a4e94b71acab930e56e79c6aa188764e7f9 # v1.316.0
         with:
           ruby-version: ${{ matrix.ruby-version }}
       - name: Install dependencies

data/CHANGELOG.md

@@ -4,6 +4,27 @@ Breaking changes are prefixed with a "[BREAKING]" label.
 
 ## master (unreleased)
 
+## 0.1.1 (2026-07-11)
+
+- Manage a per-thread `Curl::Easy` handle in `Client#download` instead of
+  relying on `Curl.post`, whose per-thread handle cache was removed in curb
+  1.3.6. Restores keep-alive connection reuse towards the downloader and
+  prevents open-connection pile-up in long-lived workers.
+  Note: like every setup before curb 1.3.6, the long-lived cached handle is
+  only safe under GC compaction with curb >= 1.3.7 (or a build carrying the
+  `curl_easy_mark` pin fix). The gemspec intentionally leaves curb
+  unconstrained — the consuming app owns the curb version.
+- [BREAKING] `Ferto::Response` is now a plain snapshot object instead of a
+  `SimpleDelegator` around the `Curl::Easy` handle: `response_code` and `body`
+  (aliased as `body_str`) are captured when the response is built, so a
+  response held across `download` calls keeps its own data instead of
+  exposing the reused handle's next request. Other `Curl::Easy` methods are
+  no longer forwarded.
+- [BREAKING] `Ferto::ResponseError#response` now returns a `Ferto::Response`
+  snapshot instead of the live `Curl::Easy` handle, which a subsequent
+  `download` on the same thread would have reset.
+- Add compatibility for Ruby 3.4 and 3.5
+
 ## 0.1.0 (2023-06-16)
 
  - Add compatibility for Ruby 3

data/ferto.gemspec

@@ -30,4 +30,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "webmock", "~> 3.5"
   spec.add_development_dependency "factory_bot", "~> 4.10"
   spec.add_development_dependency "faker"
+  spec.add_development_dependency "observer"
+  spec.add_development_dependency "ostruct"
 end

data/lib/ferto/client.rb

@@ -109,26 +109,32 @@ module Ferto
         mime_type, extra, request_headers,
         s3_bucket, s3_region, subpath
       )
-      # Curl.post reuses the same handler
       begin
-        res = Curl.post(uri.to_s, body.to_json) do |handle|
-          handle.headers = build_header(aggr_id)
-          handle.connect_timeout = connect_timeout
-          handle.timeout = timeout
-        end
-
-        case res.response_code
+        # Inlines what the Curl.post shortcut did internally (url, post_body,
+        # perform) plus the options previously passed in its block, on a
+        # handle we manage ourselves.
+        handle = curl_handle
+        handle.url = uri.to_s
+        handle.headers = build_header(aggr_id)
+        handle.connect_timeout = connect_timeout
+        handle.timeout = timeout
+        handle.post_body = body.to_json
+        handle.http(:POST)
+
+        response = Ferto::Response.new(handle)
+
+        case response.response_code
         when 400..599
           error_msg = ("An error occured during the download call. "  \
-            "Received a #{res.response_code} response code and body " \
-            "#{res.body_str}")
-          raise Ferto::ResponseError.new(error_msg, res)
+            "Received a #{response.response_code} response code and body " \
+            "#{response.body}")
+          raise Ferto::ResponseError.new(error_msg, response)
         end
       rescue Curl::Err::ConnectionFailedError => e
         raise Ferto::ConnectionError.new(e)
       end
 
-      Ferto::Response.new res
+      response
     end
 
     private
@@ -140,6 +146,17 @@ module Ferto
       }
     end
 
+    # One handle per thread: curl_easy_reset keeps live connections, so the
+    # keep-alive connection to the downloader is reused across calls.
+    # Deliberately fiber-local (Thread.current[]): sharing a handle across
+    # fibers could let two fibers of one thread enter the same handle
+    # mid-transfer under a fiber scheduler; less reuse beats corruption.
+    def curl_handle
+      handle = Thread.current[:ferto_curl] ||= Curl::Easy.new
+      handle.reset
+      handle
+    end
+
     def build_body(aggr_id, aggr_limit, url, callback_url, callback_type,
                    callback_dst, callback_error_type, callback_error_dst,
                    aggr_proxy, download_timeout, user_agent,

data/lib/ferto/response.rb

@@ -1,5 +1,17 @@
 module Ferto
-  class Response < SimpleDelegator
+  # A point-in-time snapshot of a download response. The underlying
+  # Curl::Easy handle is reused by the thread's next download, so every
+  # field is captured eagerly here and the handle is not retained.
+  class Response
+    attr_reader :response_code, :body
+
+    alias body_str body
+
+    def initialize(handle)
+      @response_code = handle.response_code
+      @body = handle.body
+    end
+
     def job_id
       @job_id ||= body.nil? ? nil : JSON.parse(body)['id']
     end

data/lib/ferto/version.rb

@@ -1,3 +1,3 @@
 module Ferto
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/lib/ferto.rb

@@ -23,8 +23,8 @@ module Ferto
     # Initialize a Ferto::ResponseError
     #
     # @param [String] err A string describing the error occured
-    # @param [Curl::Easy | nil] response a Curl::Easy object
-    #   that represents the response returned by the download method.
+    # @param [Ferto::Response | nil] response a snapshot of the
+    #   response returned by the download method.
     #   Default: nil
     def initialize(err, response=nil)
       super(err)

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: ferto
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Aggelos Avgerinos
-autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-06-16 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: curb
@@ -94,6 +93,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: observer
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: ostruct
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Ruby API client for Downloader service
 email:
 - avgerinos@skroutz.gr
@@ -121,7 +148,6 @@ homepage: https://github.com/skroutz/ferto
 licenses:
 - GPL-3.0
 metadata: {}
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -136,8 +162,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.14
-signing_key:
+rubygems_version: 4.0.3
 specification_version: 4
 summary: Ruby API client for Downloader
 test_files: []