ferrum_pdf 3.1.0 → 3.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '09655ccad2a5a6cbf6fa1d2d2e4bb34443a0bf29501265571207079b7a689482'
-  data.tar.gz: 06f33b09c785e64e1c99dd68ef98ae2d7ea28b9460350d5d6d34e54efce3e1d0
+  metadata.gz: 768ac72c382db28aed8f4d0957053bfe432bbdcf6d418f98a6a2940c6b0998cc
+  data.tar.gz: 23902eae3d0173d8db1a165f796d0e9a8437ebf037c623ad5b504d776a523343
 SHA512:
-  metadata.gz: '09d27b9a48ef1c126b473930e300b8ae62339404a1a7593910eae32a679106c0a9b5479d8d66ec101ca6ce7a62741665a7d350527f6990600e12181b38544c35'
-  data.tar.gz: e0d5644936b52536b70c39c96d42e7a73f4548096797bab50d076fca3dd4068fad3fa7b03c54249d87f01c3c3ca5faa03d85ba28643fff1111f38fb8dfe4a355
+  metadata.gz: 31fa1ab95de7c58f4fb4b2c1afb35b2f8d982302656321c8916429260dc3a2e6d11aa128700e4ea52d602a7c0b15da8a7be263058a23893852b58b395c5f94b1
+  data.tar.gz: 1197dc9b1332b9e3eed2b0a9f5d1536ba426c1eaab2978594b4b97f5311a41521515dc0adf98be18d3f4c471ed25a15fa8785ad848a84c9773754f63002837da

data/README.md

@@ -70,12 +70,13 @@ FerrumPdf.render_pdf(
   url: "https://example.com/page", # Provide a URL to the content
 
   html: content, # or provide HTML
-  display_url: request.original_url, # When supplying content via :html its best to give Chrome a hint of the current url so that it can process relative paths in the document. If you don't provide this, http://example.com will be used instead.
+  display_url: request.original_url, # Base URL for resolving relative paths in :html. Defaults to FerrumPdf.config.page_options.display_url.
 
   authorize: { user: "username", password: "password" }, # Used for authenticating with basic auth
   wait_for_idle_options: { connections: 0, duration: 0.05, timeout: 5 }, # Used for setting network wait_for_idle options
   timeout_if_open_connections: true,
-  viewport: { width: 1200, height: 800, scale_factor: 3 } # Used for setting the viewport dimensions and device scale factor (DPR) when rendering the page
+  viewport: { width: 1200, height: 800, scale_factor: 3 }, # Used for setting the viewport dimensions and device scale factor (DPR) when rendering the page
+  javascript_enabled: true, # Set to false to prevent scripts in the page from running. Note: this does not block network requests (images, stylesheets, iframes) or meta refresh redirects.
 
   pdf_options: {
     landscape: false, # paper orientation
@@ -108,7 +109,7 @@ FerrumPdf.render_pdf(
 )
 ```
 
-See [Chrome DevTools Protocol docs](https://chromedevtools.github.io/devtools-protocol/tot/Page/#method-printToPDF) and [Ferrum's `#pdf` docs](https://github.com/rubycdp/ferrum?tab=readme-ov-file#pdfoptions--string--boolean) for the full set of options.
+See [Chrome DevTools Protocol docs](https://chromedevtools.github.io/devtools-protocol/tot/Page/#method-printToPDF) and [Ferrum's pdf docs](https://docs.rubycdp.com/docs/ferrum/screenshots/#pdfoptions--string--boolean) for the full set of options.
 
 ### 🎆 Screenshots
 
@@ -150,7 +151,7 @@ def show
 end
 ```
 
-See [Ferrum screenshot docs](https://github.com/rubycdp/ferrum?tab=readme-ov-file#screenshotoptions--string--integer) for the full set of options.
+See [Ferrum's screenshot docs](https://docs.rubycdp.com/docs/ferrum/screenshots/#screenshotoptions--string--integer) for the full set of options.
 
 #### Render Screenshots
 
@@ -168,7 +169,7 @@ FerrumPdf.render_screenshot(
   url: "https://example.com/page", # Provide a URL to the content
 
   html: content, # or provide HTML
-  display_url: request.original_url, # When supplying content via :html its best to give Chrome a hint of the current url so that it can process relative paths in the document. If you don't provide this, http://example.com will be used instead.
+  display_url: request.original_url, # Base URL for resolving relative paths in :html. Defaults to FerrumPdf.config.page_options.display_url.
 
   screenshot_options: {
     format: "png" # or "jpeg"
@@ -192,6 +193,8 @@ FerrumPdf.configure do |config|
   config.page_options.wait_for_idle_options = { timeout: 90 }
   config.page_options.retries = 3
   config.page_options.viewport = { width: 1200, height: 800, scale_factor: 3 }
+  config.page_options.javascript_enabled = false
+  config.page_options.display_url = "https://example.org"
 
   config.pdf_options.margin_top = 0.2
   config.pdf_options.margin_bottom = 0.2
@@ -207,7 +210,7 @@ end
 
 You can set the default browser options with the configure block.
 
-See [Ferrum's Customization docs](https://github.com/rubycdp/ferrum?tab=readme-ov-file#customization) for a full list of options.
+See [Ferrum's Customization docs](https://docs.rubycdp.com/docs/ferrum/customization) for a full list of options.
 
 ```ruby
 FerrumPdf.configure do |config|

data/lib/ferrum_pdf/version.rb

@@ -1,3 +1,3 @@
 module FerrumPdf
-  VERSION = "3.1.0"
+  VERSION = "3.2.0"
 end

data/lib/ferrum_pdf.rb

@@ -5,6 +5,9 @@ require "ferrum_pdf/renderers"
 require "ferrum_pdf/version"
 
 module FerrumPdf
+  # Reserved .invalid TLD so relative paths fail fast on DNS instead of hanging
+  # against a domain we don't control.
+  DEFAULT_DISPLAY_URL = "http://ferrum-pdf.invalid"
   DEFAULT_HEADER_TEMPLATE = "<div class='date text left'></div><div class='title text center'></div>"
   DEFAULT_FOOTER_TEMPLATE = <<~HTML
     <div class='url text left grow'></div>
@@ -44,8 +47,9 @@ module FerrumPdf
         yield browser
       else
         browser_mutex.synchronize do
+          discard_unusable_browser
           @@browser ||= Ferrum::Browser.new(config.except(:page_options, :pdf_options, :screenshot_options))
-          @@browser.restart unless @@browser.client.present?
+          @@browser.restart if @@browser.client.nil?
           yield @@browser
         end
       end
@@ -85,15 +89,31 @@ module FerrumPdf
 
     private
 
+    # A browser whose start died between Client.new and Contexts.new keeps a client but no
+    # contexts, and #restart cannot repair it: quit dereferences the nil contexts. Drop it and
+    # release the process and socket it still holds, so the next call builds a fresh browser.
+    def discard_unusable_browser
+      return if @@browser.nil? || @@browser.client.nil? || !@@browser.contexts.nil?
+
+      begin
+        @@browser.process&.stop
+        @@browser.client&.close
+      ensure
+        @@browser = nil
+      end
+    end
+
     # Loads page into the browser to be used for rendering PDFs or screenshots
     #
-    def load_page(url: nil, html: nil, display_url: nil, authorize: nil, wait_for_idle_options: nil, timeout_if_open_connections: nil, browser: nil, retries: nil, viewport: nil)
+    def load_page(url: nil, html: nil, display_url: nil, authorize: nil, wait_for_idle_options: nil, timeout_if_open_connections: nil, browser: nil, retries: nil, viewport: nil, javascript_enabled: nil)
       try ||= 0
       authorize ||= config.dig(:page_options, :authorize)
       retries ||= config.page_options.fetch(:retries, 1)
       wait_for_idle_options = config.page_options.fetch(:wait_for_idle_options, {}).merge(wait_for_idle_options || {})
       timeout_if_open_connections = config.page_options.fetch(:timeout_if_open_connections, true) if timeout_if_open_connections.nil?
       viewport ||= config.dig(:page_options, :viewport)
+      display_url ||= config.dig(:page_options, :display_url)
+      javascript_enabled = config.page_options.fetch(:javascript_enabled, true) if javascript_enabled.nil?
 
       with_browser(browser) do |browser|
         # Closes page automatically after block finishes
@@ -102,6 +122,9 @@ module FerrumPdf
           page.network.authorize(**authorize) { |req| req.continue } if authorize
           page.set_viewport(**viewport) if viewport
 
+          # Has to happen before #go_to, otherwise inline scripts have already run.
+          page.disable_javascript unless javascript_enabled
+
           # Load content
           if html
             html_intercepted = false
@@ -114,7 +137,7 @@ module FerrumPdf
                 request.respond(body: html.blank? ? " " : html)
               end
             end
-            page.go_to(display_url || "http://example.com")
+            page.go_to(display_url || DEFAULT_DISPLAY_URL)
           else
             page.go_to(url)
           end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ferrum_pdf
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 3.2.0
 platform: ruby
 authors:
 - Chris Oliver
@@ -72,7 +72,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.2
+rubygems_version: 4.0.18
 specification_version: 4
 summary: PDFs & screenshots for Rails using Ferrum & headless Chrome
 test_files: []