feidee_utils 0.0.4.1 → 0.0.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 293b859c218934656fc1b096076284f44fe7e17b
-  data.tar.gz: bf5e50c65f90d910f75b39bc667f63d9ff61fbf3
+  metadata.gz: f30f41d070995fbe8c9f6b7de1b2d777f3a6e674
+  data.tar.gz: 82c6dbf50bf2922e6852304e0ecd699139413a64
 SHA512:
-  metadata.gz: 30ee3bc1c7e4b1fa59ec6a2a5e29b5750261f08f2f335e0dbf3fc6e3fd462c5958803df7e07fc04c162750dcee5a8482dd16ce851bc5533a63363fda0613286f
-  data.tar.gz: 101e8d20b5db4048f9f9f994d35fe285f65d0f0b2881a7e236f5fc16e9fbc6fbb7fa2afbc5f58a80643c6794931e05b999624ca0f2e675c07f0df3dd9958787f
+  metadata.gz: 374fe584c1e52e9f0afde15512f1c1b476a8c37a3b5fbeed640e1f3058216709e5a228417196a137d32e364f1da23b789b30b3503a7dcc690d3611461109635b
+  data.tar.gz: bacc8d82f893a130eef2a84d2ce5e4ffd07b606881a90c270343812b587d0a6be6d32ec7a124380101be599b1bbf7f491291e149ce66bf6d894202a9e7db75ef

data/lib/feidee_utils/account.rb

@@ -5,7 +5,7 @@ require 'bigdecimal'
 module FeideeUtils
   class Account < Record
     def validate_integrity
-      raise "Account type should always be 0, but it's #{field["type"]}.\n" + inspect unless field["type"] == 0
+      raise "Account type should always be 0, but it's #{field["type"]}.\n" + inspect unless not field["type"] or field["type"] == 0
       raise "Account usedCount should always be 0, but it's #{field["usedCount"]}.\n" + inspect unless field["usedCount"] == 0
       raise "Account uuid should always be empty, but it's #{field["uuid"]}.\n" + inspect unless field["uuid"].to_s.empty?
       raise "Account hierachy contains more than 2 levels.\n" + inspect unless flat_parent_hierachy?
@@ -19,6 +19,8 @@ module FeideeUtils
       end
     end
 
+    NullPOID = 0
+
     FieldMappings = {
       name:                 "name",
       raw_balance:          "balance",
@@ -35,9 +37,12 @@ module FeideeUtils
 
     IgnoredFields = [
       "tradingEntityPOID",
+      # TODO: Field type is removed from database_version 73. Not sure about
+      # earlier versions.
       "type",             # Always 0
       "usedCount",        # Always 0
       "uuid",             # Always empty.
+      # TODO: code is also removed.
       "code",             # WTF
       "clientID",         # WTF
     ].freeze
@@ -75,7 +80,7 @@ module FeideeUtils
     end
 
     def has_parent?
-      parent_poid != 0 && !flagged_as_parent?
+      parent_poid != NullPOID && !flagged_as_parent?
     end
 
     def flagged_as_parent?

data/lib/feidee_utils/mixins/parent_and_path.rb

@@ -4,6 +4,8 @@ module FeideeUtils
     #   instance methods: poid, parent_poid, raw_path
     #   class methods: find_by_id
     module ParentAndPath
+      NullPOID = 0
+
       class InconsistentDepthException < Exception
       end
 
@@ -62,7 +64,7 @@ module FeideeUtils
       end
 
       def has_parent?
-        parent_poid != 0
+        parent_poid != NullPOID
       end
     end
   end

data/lib/feidee_utils/record/accessors.rb

@@ -16,6 +16,24 @@ module FeideeUtils
             define_method name do field[key] end
           end
         end
+
+        def define_entity_accessor poid_callback_name, target_class_name = nil
+          accessor_name = poid_callback_name.to_s.chomp!("_poid")
+          if accessor_name == nil
+            raise "No trailing 'poid' in callback name #{poid_callback_name}."
+          end
+
+          if not target_class_name
+            target_class_name = accessor_name
+          end
+          target_class_name = target_class_name.to_s.clone
+          target_class_name.gsub!(/(^|_)(.)/) { $2.upcase }
+
+          define_method accessor_name do
+            poid = method(poid_callback_name).call
+            self.class.environment.const_get(target_class_name).find(poid)
+          end
+        end
       end
     end
   end

data/lib/feidee_utils/record/persistent.rb

@@ -14,7 +14,9 @@ module FeideeUtils
             end
 
           id_field_name = entity_name.sub(/^[A-Z]/) { $&.downcase } + "POID"
-          table_name = "t_" + entity_name.gsub(/([a-z\d])([A-Z\d])/, '\1_\2').downcase
+          entity_name_underscore =
+              entity_name.gsub(/([a-z\d])([A-Z\d])/, '\1_\2').downcase
+          table_name = "t_" + entity_name_underscore
           subclass.class_exec do
             define_singleton_method :entity_name do entity_name end
             define_singleton_method :id_field_name do id_field_name end

data/lib/feidee_utils/transaction.rb

@@ -11,7 +11,7 @@ module FeideeUtils
     class TransferWithCategoryException < Exception
     end
 
-    class InconsistentBuyerAndSellerSetException < Exception
+    class InconsistentBuyerAndSellerException < Exception
     end
 
     class InconsistentCategoryException < Exception
@@ -36,7 +36,7 @@ module FeideeUtils
         end
       else
         unless (buyer_account_poid == 0) ^ (seller_account_poid == 0)
-          raise InconsistentBuyerAndSellerSetException,
+          raise InconsistentBuyerAndSellerException,
             "Exactly one of buyer and seller should be set in a non-transfer transaction. " +
             "Buyer account POID: #{buyer_account_poid}. Seller account POID: #{seller_account_poid}.\n" +
             inspect
@@ -98,6 +98,8 @@ module FeideeUtils
       raw_seller_addition:    "sellerMoney",
       uuid:                   "relation",
     }.freeze
+    define_entity_accessor :buyer_account_poid, :account
+    define_entity_accessor :seller_account_poid, :account
 
     IgnoredFields = [
       "creatorTradingEntityPOID",
@@ -141,6 +143,7 @@ module FeideeUtils
       # At least one of those two must be 0.
       buyer_category_poid + seller_category_poid
     end
+    define_entity_accessor :category_poid
 
     # Amount accessors
 
@@ -174,6 +177,7 @@ module FeideeUtils
         buyer_account_poid + seller_account_poid
       end
     end
+    define_entity_accessor :revised_account_poid, :account
 
     def revised_amount
       account_poid = revised_account_poid
@@ -202,6 +206,14 @@ module FeideeUtils
 
     private
     def sign_by_type num
+      # This is awkward. For transactions of type positive_initial_balance, the
+      # buyer is always 0, but the seller have to **add** the amount shown as
+      # sellerMoney, which is consistent with other type of transactions.
+      #
+      # Whereas for transactions of type negative_initial_balance (9),  the
+      # buyer is always 0, and the seller will have to **deduct** the amount
+      # shown as sellerMoney from balance. Here the sign of
+      # negative_initial_balance is reversed to reflect this awkwardness.
       raw_type == 9 ? -num : num
     end
 

data/lib/feidee_utils/version.rb

@@ -1,3 +1,3 @@
 module FeideeUtils
-    VERSION = '0.0.4.1'
+    VERSION = '0.0.4.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: feidee_utils
 version: !ruby/object:Gem::Version
-  version: 0.0.4.1
+  version: 0.0.4.2
 platform: ruby
 authors:
 - Liqing Muyi