feedzirra 0.0.19 → 0.0.20

data/lib/feedzirra.rb

@@ -30,5 +30,5 @@ require 'feedzirra/parser/atom'
 require 'feedzirra/parser/atom_feed_burner'
 
 module Feedzirra
-  VERSION = "0.0.19"
+  VERSION = "0.0.20"
 end

data/lib/feedzirra/feed_utilities.rb

@@ -1,7 +1,7 @@
 module Feedzirra
   module FeedUtilities
-    UPDATABLE_ATTRIBUTES = %w(title feed_url url last_modified)
-    
+    UPDATABLE_ATTRIBUTES = %w(title feed_url url last_modified etag)
+
     attr_writer   :new_entries, :updated, :last_modified
     attr_accessor :etag
 
@@ -11,50 +11,50 @@ module Feedzirra
         entry ? entry.published : nil
       end
     end
-    
+
     def updated?
       @updated
     end
-    
+
     def new_entries
       @new_entries ||= []
     end
-    
+
     def has_new_entries?
       new_entries.size > 0
     end
-    
+
     def update_from_feed(feed)
       self.new_entries += find_new_entries_for(feed)
       self.entries.unshift(*self.new_entries)
-      
-      updated! if UPDATABLE_ATTRIBUTES.any? { |name| update_attribute(feed, name) }
+
+      @updated = false
+      UPDATABLE_ATTRIBUTES.each do |name|
+        @updated ||= update_attribute(feed, name)
+      end
     end
-    
+
     def update_attribute(feed, name)
       old_value, new_value = send(name), feed.send(name)
-      
+
       if old_value != new_value
         send("#{name}=", new_value)
       end
     end
-    
+
     def sanitize_entries!
       entries.each {|entry| entry.sanitize!}
     end
-    
+
     private
-    
-    def updated!
-      @updated = true
-    end
-    
+
     def find_new_entries_for(feed)
       # this implementation is a hack, which is why it's so ugly.
       # it's to get around the fact that not all feeds have a published date.
       # however, they're always ordered with the newest one first.
       # So we go through the entries just parsed and insert each one as a new entry
       # until we get to one that has the same url as the the newest for the feed
+      return feed.entries if self.entries.length == 0
       latest_entry = self.entries.first
       found_new_entries = []
       feed.entries.each do |entry|
@@ -63,7 +63,7 @@ module Feedzirra
       end
       found_new_entries
     end
-    
+
     def existing_entry?(test_entry)
       entries.any? { |entry| entry.url == test_entry.url }
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: feedzirra
 version: !ruby/object:Gem::Version 
-  version: 0.0.19
+  version: 0.0.20
 platform: ruby
 authors: 
 - Paul Dix