feedjira 3.2.2 → 3.2.4

data/spec/sample_feeds.rb

@@ -10,6 +10,7 @@ module SampleFeeds
     sample_atom_feed_line_breaks: "AtomFeedWithSpacesAroundEquals.xml",
     sample_atom_entry_content: "AmazonWebServicesBlogFirstEntryContent.xml",
     sample_itunes_feed: "itunes.xml",
+    sample_itunes_feedburner_feed: "itunes_feedburner.xml",
     sample_itunes_feed_with_single_quotes: "ITunesWithSingleQuotedAttributes.xml",
     sample_itunes_feed_with_spaces: "ITunesWithSpacesInAttributes.xml",
     sample_podlove_feed: "CRE.xml",
@@ -31,6 +32,7 @@ module SampleFeeds
     sample_youtube_atom_feed: "youtube_atom.xml",
     sample_atom_xhtml_with_escpaed_html_in_pre_tag_feed: "AtomEscapedHTMLInPreTag.xml",
     sample_json_feed: "json_feed.json",
+    sample_json_feed_with_escaped_uris: "json_feed_with_escaped_uris.json",
     sample_rss_feed_huffpost_ca: "HuffPostCanada.xml",
     sample_invalid_date_format_feed: "InvalidDateFormat.xml",
     sample_rss_feed_permalinks: "Permalinks.xml",

data/spec/spec_helper.rb

@@ -1,5 +1,8 @@
 # frozen_string_literal: true
 
+# coverage setup must come before loading lib/ code
+require "support/coverage"
+
 require File.expand_path("#{File.dirname(__FILE__)}/../lib/feedjira")
 require "sample_feeds"
 

data/spec/support/coverage.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+require "simplecov"
+
+SimpleCov.start do
+  enable_coverage :branch
+  add_filter "_spec.rb"
+end
+
+SimpleCov.minimum_coverage(line: 98, branch: 75)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: feedjira
 version: !ruby/object:Gem::Version
-  version: 3.2.2
+  version: 3.2.4
 platform: ruby
 authors:
 - Adam Hess
@@ -14,7 +14,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-10-19 00:00:00.000000000 Z
+date: 2025-01-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: loofah
@@ -23,6 +23,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 2.3.1
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -30,6 +33,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 2.3.1
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
 - !ruby/object:Gem::Dependency
   name: sax-machine
   requirement: !ruby/object:Gem::Requirement
@@ -37,6 +43,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '1.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -44,118 +53,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '1.0'
-- !ruby/object:Gem::Dependency
-  name: faraday
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: pry
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rubocop-performance
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rubocop-rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rubocop-rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: yard
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2'
 description:
 email:
 executables: []
@@ -164,6 +64,7 @@ extra_rdoc_files: []
 files:
 - ".github/ISSUE_TEMPLATE/feed-parsing.md"
 - ".github/ISSUE_TEMPLATE/general-issue.md"
+- ".github/dependabot.yml"
 - ".github/workflows/ruby.yml"
 - ".gitignore"
 - ".rspec"
@@ -183,10 +84,6 @@ files:
 - lib/feedjira/core_ext/date.rb
 - lib/feedjira/core_ext/string.rb
 - lib/feedjira/core_ext/time.rb
-- lib/feedjira/date_time_utilities.rb
-- lib/feedjira/date_time_utilities/date_time_epoch_parser.rb
-- lib/feedjira/date_time_utilities/date_time_language_parser.rb
-- lib/feedjira/date_time_utilities/date_time_pattern_parser.rb
 - lib/feedjira/feed.rb
 - lib/feedjira/feed_entry_utilities.rb
 - lib/feedjira/feed_utilities.rb
@@ -218,8 +115,8 @@ files:
 - lib/feedjira/rss_entry_utilities.rb
 - lib/feedjira/version.rb
 - spec/feedjira/configuration_spec.rb
+- spec/feedjira/core_ext/time_spec.rb
 - spec/feedjira/feed_spec.rb
-- spec/feedjira/feed_utilities_date_time_spec.rb
 - spec/feedjira/feed_utilities_entry_spec.rb
 - spec/feedjira/feed_utilities_spec.rb
 - spec/feedjira/parser/atom_entry_spec.rb
@@ -282,17 +179,20 @@ files:
 - spec/sample_feeds/atom_with_link_tag_for_url_unmarked.xml
 - spec/sample_feeds/google_alerts_atom.xml
 - spec/sample_feeds/itunes.xml
+- spec/sample_feeds/itunes_feedburner.xml
 - spec/sample_feeds/json_feed.json
+- spec/sample_feeds/json_feed_with_escaped_uris.json
 - spec/sample_feeds/pet_atom.xml
 - spec/sample_feeds/youtube_atom.xml
 - spec/spec_helper.rb
+- spec/support/coverage.rb
 homepage: https://github.com/feedjira/feedjira
 licenses:
 - MIT
 metadata:
   homepage_uri: https://github.com/feedjira/feedjira
   source_code_uri: https://github.com/feedjira/feedjira
-  changelog_uri: https://github.com/feedjira/feedjira/blob/master/CHANGELOG.md
+  changelog_uri: https://github.com/feedjira/feedjira/blob/main/CHANGELOG.md
   rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
@@ -309,7 +209,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.0.dev
+rubygems_version: 3.4.10
 signing_key:
 specification_version: 4
 summary: A feed parsing library

data/lib/feedjira/date_time_utilities/date_time_epoch_parser.rb

@@ -1,14 +0,0 @@
-# frozen_string_literal: true
-
-module Feedjira
-  module DateTimeUtilities
-    class DateTimeEpochParser
-      def self.parse(string)
-        epoch_time = string.to_i
-        return Time.at(epoch_time).to_datetime if epoch_time.to_s == string
-
-        raise "#{string} is not a valid epoch time"
-      end
-    end
-  end
-end

data/lib/feedjira/date_time_utilities/date_time_language_parser.rb

@@ -1,24 +0,0 @@
-# frozen_string_literal: true
-
-module Feedjira
-  module DateTimeUtilities
-    class DateTimeLanguageParser
-      MONTHS_ENGLISH =
-        %w[Jan Feb Mar Apr May Jun Jul Aug Sep Oct Nov Dec].freeze
-      MONTHS_SPANISH =
-        %w[Ene Feb Mar Abr May Jun Jul Ago Sep Oct Nov Dic].freeze
-
-      def self.parse(string)
-        DateTime.parse(translate(string))
-      end
-
-      def self.translate(string)
-        MONTHS_SPANISH.each_with_index do |m, i|
-          rgx = Regexp.new("\s#{m}\s", Regexp::IGNORECASE)
-          return string.gsub(rgx, MONTHS_ENGLISH[i]) if string&.match?(rgx)
-        end
-        raise "No translation found for #{string}"
-      end
-    end
-  end
-end

data/lib/feedjira/date_time_utilities/date_time_pattern_parser.rb

@@ -1,30 +0,0 @@
-# frozen_string_literal: true
-
-module Feedjira
-  module DateTimeUtilities
-    class DateTimePatternParser
-      # Japanese Symbols are required for strange Date Strings like
-      # '水, 31 8 2016 07:37:00 PDT'
-      JAPANESE_SYMBOLS = %w[日 月 火 水 木 金 土].freeze
-      PATTERNS = ["%m/%d/%Y %T %p", "%d %m %Y %T %Z"].freeze
-
-      def self.parse(string)
-        PATTERNS.each do |p|
-          datetime = DateTime.strptime(prepare(string), p)
-          return datetime
-        rescue StandardError => e
-          Feedjira.logger.debug("Failed to parse date #{string}")
-          Feedjira.logger.debug(e)
-          nil
-        end
-        raise "No pattern matched #{string}"
-      end
-
-      def self.prepare(string)
-        rgx = Regexp.new("^(#{JAPANESE_SYMBOLS.join('|')}),\s")
-        string.gsub(rgx, "")
-      end
-      private_class_method :prepare
-    end
-  end
-end

data/lib/feedjira/date_time_utilities.rb

@@ -1,30 +0,0 @@
-# frozen_string_literal: true
-
-module Feedjira
-  module DateTimeUtilities
-    # This is our date parsing heuristic.
-    # Date Parsers are attempted in order.
-    DATE_PARSERS = [
-      DateTimePatternParser,
-      DateTimeLanguageParser,
-      DateTimeEpochParser,
-      DateTime
-    ].freeze
-
-    # Parse the given string starting with the most common parser (default ruby)
-    # and going over all other available parsers
-    def parse_datetime(string)
-      res = DATE_PARSERS.detect do |parser|
-        return parser.parse(string).feed_utils_to_gm_time
-      rescue StandardError => e
-        Feedjira.logger.debug { "Failed to parse date #{string}" }
-        Feedjira.logger.debug(e)
-        nil
-      end
-
-      Feedjira.logger.warn { "Failed to parse date #{string}" } if res.nil?
-
-      res
-    end
-  end
-end

data/spec/feedjira/feed_utilities_date_time_spec.rb

@@ -1,49 +0,0 @@
-# frozen_string_literal: true
-
-require "spec_helper"
-
-describe Feedjira::FeedUtilities do
-  before do
-    @klass = Class.new do
-      include Feedjira::DateTimeUtilities
-    end
-  end
-
-  describe "handling dates" do
-    it "parses an ISO 8601 formatted datetime into Time" do
-      time = @klass.new.parse_datetime("2008-02-20T8:05:00-010:00")
-      expect(time.class).to eq Time
-      expect(time).to eq Time.parse_safely("Wed Feb 20 18:05:00 UTC 2008")
-    end
-
-    it "parses a ISO 8601 with milliseconds into Time" do
-      time = @klass.new.parse_datetime("2013-09-17T08:20:13.931-04:00")
-      expect(time.class).to eq Time
-      expect(time).to eq Time.strptime("Tue Sep 17 12:20:13.931 UTC 2013", "%a %b %d %H:%M:%S.%N %Z %Y")
-    end
-
-    it "parses a US Format into Time" do
-      time = @klass.new.parse_datetime("8/23/2016 12:29:58 PM")
-      expect(time.class).to eq Time
-      expect(time).to eq Time.parse_safely("Wed Aug 23 12:29:58 UTC 2016")
-    end
-
-    it "parses a Spanish Format into Time" do
-      time = @klass.new.parse_datetime("Wed, 31 Ago 2016 11:08:22 GMT")
-      expect(time.class).to eq Time
-      expect(time).to eq Time.parse_safely("Wed Aug 31 11:08:22 UTC 2016")
-    end
-
-    it "parses Format with japanese symbols into Time" do
-      time = @klass.new.parse_datetime("水, 31 8 2016 07:37:00 PDT")
-      expect(time.class).to eq Time
-      expect(time).to eq Time.parse_safely("Wed Aug 31 14:37:00 UTC 2016")
-    end
-
-    it "parses epoch into Time" do
-      time = @klass.new.parse_datetime("1472654220")
-      expect(time.class).to eq Time
-      expect(time).to eq Time.parse_safely("Wed Aug 31 14:37:00 UTC 2016")
-    end
-  end
-end