feedjira 3.2.1 → 3.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b6930aadfe8b2a06d65aa2a8dfaad0d8fcc4f34356a3c3646cf75ef70a753a8d
-  data.tar.gz: 00a921f06c7542ca84d552a6f680e56d99f4b0b3aa830113b75c0545f6fdbcf7
+  metadata.gz: 12ef7af9ab5efeab944facbebb844c347458d7cc422927f0971f74606a0a57a3
+  data.tar.gz: 1d3c99b6799f173aaeea41b8e91f1e28c68cebfe59af92da0c32320c90d8ff20
 SHA512:
-  metadata.gz: 5970d946d3673ff856f95bef75e09b4cc0b6dbc3b8b9ba66a3ebade66d93fd894b23e784d8e9c3ab345eb6deae2094878e60be2164aae46623e2159bcf4530c0
-  data.tar.gz: ae1466452711a547ec9f2ad42ab34b11a8ce03a1886e6ddeb56f3a8723c3d1ab6f1a0b22461c339a0a5c490e64965a37da9329bcd701fd4d10117c8b9e28fbe1
+  metadata.gz: 5c8527d5cfdc791d27cc970223575cdd4a75831d1665f63b7f650b733f4c9f7dadbd071ea3403c97a107d8cfbb930abc631a9428acadd3316f22e46802b7f2a2
+  data.tar.gz: b2710b27a649c0544e7f4f71a05117e96bc63c4fff9c3be0a7273ea4a173063b963e59dae9ed1c59aace5ca6319cb56f7012e994c9cecd8b2158f8931299bfbe

data/.github/dependabot.yml

@@ -0,0 +1,17 @@
+# To get started with Dependabot version updates, you'll need to specify which
+# package ecosystems to update and where the package manifests are located.
+# Please see the documentation for all configuration options:
+# https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
+
+version: 2
+updates:
+  - package-ecosystem: "bundler" # See documentation for possible values
+    directory: "/" # Location of package manifests
+    schedule:
+      interval: "weekly"
+    assignees:
+      - "mockdeep"
+    groups:
+      all:
+        patterns:
+          - "*"

data/.github/workflows/ruby.yml

@@ -3,7 +3,7 @@ name: Ruby
 on:
   push:
     branches:
-      - master
+      - main
   pull_request:
 
 jobs:
@@ -12,7 +12,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu]
-        ruby: [2.5, 2.6, 2.7, 3.0]
+        ruby: [2.7, 3.0, 3.1, 3.2, 3.3]
         handler: [nokogiri, ox, oga]
         exclude:
           - { ruby: jruby, handler: ox }

data/.gitignore

@@ -7,3 +7,4 @@ doc/
 .yardoc/
 pkg/
 rdoc/
+coverage/

data/.rubocop.yml

@@ -6,7 +6,7 @@ require:
   - rubocop-performance
 
 AllCops:
-  TargetRubyVersion: 2.5
+  TargetRubyVersion: 2.7
   NewCops: enable
 
 # Offense count: 3
@@ -29,9 +29,6 @@ Layout/LineLength:
   Exclude:
     - 'spec/**/*.rb'
 
-Style/AsciiComments:
-  Enabled: false
-
 Style/IfUnlessModifier:
   Enabled: false
 
@@ -59,8 +56,5 @@ RSpec/MultipleMemoizedHelpers:
 RSpec/BeforeAfterAll:
   Enabled: false
 
-RSpec/VerifiedDoubles:
-  Enabled: false
-
 RSpec/RepeatedExample:
   Enabled: false

data/.rubocop_todo.yml

@@ -1,11 +1,35 @@
 # This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2020-09-02 20:02:06 UTC using RuboCop version 0.90.0.
+# `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 400`
+# on 2023-12-16 21:24:13 UTC using RuboCop version 1.59.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 20
+# Offense count: 16
+# Configuration parameters: AllowedConstants.
 Style/Documentation:
-  Enabled: false
+  Exclude:
+    - 'spec/**/*'
+    - 'test/**/*'
+    - 'lib/feedjira/atom_entry_utilities.rb'
+    - 'lib/feedjira/core_ext/string.rb'
+    - 'lib/feedjira/core_ext/time.rb'
+    - 'lib/feedjira/feed.rb'
+    - 'lib/feedjira/feed_entry_utilities.rb'
+    - 'lib/feedjira/feed_utilities.rb'
+    - 'lib/feedjira/parser.rb'
+    - 'lib/feedjira/parser/atom_youtube_entry.rb'
+    - 'lib/feedjira/parser/globally_unique_identifier.rb'
+    - 'lib/feedjira/parser/google_docs_atom.rb'
+    - 'lib/feedjira/parser/google_docs_atom_entry.rb'
+    - 'lib/feedjira/parser/itunes_rss_owner.rb'
+    - 'lib/feedjira/parser/podlove_chapter.rb'
+    - 'lib/feedjira/preprocessor.rb'
+    - 'lib/feedjira/rss_entry_utilities.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Style/SuperWithArgsParentheses:
+  Exclude:
+    - 'lib/feedjira/feed_utilities.rb'

data/CHANGELOG.md

@@ -1,5 +1,22 @@
 # Feedjira Changelog
 
+## 3.2.3
+
+* Switch date parse error to debug (#492)
+
+## 3.2.2
+
+* Fix time handling again usec is not a timezone
+
+* Update rubocop * drop official support for eol Ruby
+
+
+## 3.2.1
+
+* Fix time handling in ruby 3.1
+
+* Atom feeds now have an icon field via https://github.com/feedjira/feedjira/pull/452 (@jswanner)
+
 ## 3.2.0
 
 * Atom `feed_url` no longer falls back to `url` via https://github.com/feedjira/feedjira/pull/451 (@frederfred)

data/Gemfile

@@ -4,8 +4,18 @@ source "https://rubygems.org/"
 
 gemspec
 
+gem "faraday", "~> 2.8.1"
+gem "pry", "~> 0.14.2"
+gem "rspec", "~> 3.13.0"
+gem "rubocop", "~> 1.60.1"
+gem "rubocop-performance", "~> 1.20.0"
+gem "rubocop-rake", "~> 0.6.0"
+gem "rubocop-rspec", "~> 2.26.1"
+gem "simplecov", "~> 0.22.0"
+gem "yard", "~> 0.9.34"
+
 group :test do
-  gem "oga"
-  gem "ox", platforms: %i[mri rbx]
-  gem "rake"
+  gem "oga", "~> 3.4"
+  gem "ox", "~> 2.14.17", platforms: %i[mri rbx]
+  gem "rake", "~> 13.1.0"
 end

data/README.md

@@ -1,13 +1,12 @@
 # Feedjira
 
-[![Build Status][travis-badge]][travis] [![Code Climate][code-climate-badge]][code-climate] [![Gitter][gitter-badge]][gitter]
+[![Build Status][actions-badge]][actions] [![Code Climate][code-climate-badge]][code-climate]
 
-[travis-badge]: https://travis-ci.org/feedjira/feedjira.svg?branch=master
-[travis]: http://travis-ci.org/feedjira/feedjira
+[actions-badge]: https://github.com/feedjira/feedjira/actions/workflows/ruby.yml/badge.svg?branch=main
+[actions]: https://github.com/feedjira/feedjira/actions?query=branch%3Amain
 [code-climate-badge]: https://codeclimate.com/github/feedjira/feedjira/badges/gpa.svg
 [code-climate]: https://codeclimate.com/github/feedjira/feedjira
 [gitter-badge]: https://badges.gitter.im/feedjira/feedjira.svg
-[gitter]: https://gitter.im/feedjira/feedjira?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge
 
 Feedjira is a Ruby library designed to parse feeds.
 

data/feedjira.gemspec

@@ -22,25 +22,15 @@ Gem::Specification.new do |s|
   s.metadata = {
     "homepage_uri" => "https://github.com/feedjira/feedjira",
     "source_code_uri" => "https://github.com/feedjira/feedjira",
-    "changelog_uri" => "https://github.com/feedjira/feedjira/blob/master/CHANGELOG.md",
+    "changelog_uri" => "https://github.com/feedjira/feedjira/blob/main/CHANGELOG.md",
     "rubygems_mfa_required" => "true"
   }
 
   s.files         = `git ls-files`.split("\n")
   s.require_paths = ["lib"]
-  s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
 
-  s.required_ruby_version = ">=2.5"
+  s.required_ruby_version = ">=2.7"
 
-  s.add_dependency "loofah",             ">= 2.3.1"
-  s.add_dependency "sax-machine",        ">= 1.0"
-
-  s.add_development_dependency "faraday"
-  s.add_development_dependency "pry"
-  s.add_development_dependency "rspec"
-  s.add_development_dependency "rubocop"
-  s.add_development_dependency "rubocop-performance"
-  s.add_development_dependency "rubocop-rake"
-  s.add_development_dependency "rubocop-rspec"
-  s.add_development_dependency "yard"
+  s.add_runtime_dependency "loofah", ">= 2.3.1", "< 3"
+  s.add_runtime_dependency "sax-machine", ">= 1.0", "< 2"
 end

data/lib/feedjira/configuration.rb

@@ -59,13 +59,13 @@ module Feedjira
     # @private
     def default_parsers
       [
+        Feedjira::Parser::ITunesRSS,
         Feedjira::Parser::RSSFeedBurner,
         Feedjira::Parser::GoogleDocsAtom,
         Feedjira::Parser::AtomYoutube,
         Feedjira::Parser::AtomFeedBurner,
         Feedjira::Parser::AtomGoogleAlerts,
         Feedjira::Parser::Atom,
-        Feedjira::Parser::ITunesRSS,
         Feedjira::Parser::RSS,
         Feedjira::Parser::JSONFeed
       ]

data/lib/feedjira/core_ext/date.rb

@@ -9,14 +9,11 @@ class Date
     feed_utils_to_time(new_offset, :gm)
   end
 
-  def feed_utils_to_local_time
-    feed_utils_to_time(new_offset(DateTime.now.offset - offset), :local)
-  end
-
   private
 
   def feed_utils_to_time(dest, method)
-    Time.send(method, dest.year, dest.month, dest.day, dest.hour, dest.min,
-              dest.sec, dest.offset)
+    # Convert a fraction of a day to a number of microseconds
+    usec = (dest.sec_fraction * (10**6)).to_i
+    Time.send(method, dest.year, dest.month, dest.day, dest.hour, dest.min, dest.sec, usec)
   end
 end

data/lib/feedjira/core_ext/time.rb

@@ -16,12 +16,12 @@ class Time
     if datetime.is_a?(Time)
       datetime.utc
     elsif datetime.respond_to?(:to_datetime)
-      datetime.to_datetime.utc
-    elsif datetime.respond_to? :to_s
+      datetime.to_time.utc
+    else
       parse_string_safely datetime.to_s
     end
   rescue StandardError => e
-    Feedjira.logger.debug { "Failed to parse time #{datetime}" }
+    Feedjira.logger.debug("Failed to parse time #{datetime}")
     Feedjira.logger.debug(e)
     nil
   end

data/lib/feedjira/feed_entry_utilities.rb

@@ -3,7 +3,6 @@
 module Feedjira
   module FeedEntryUtilities
     include Enumerable
-    include DateTimeUtilities
 
     def published
       @published ||= @updated
@@ -12,8 +11,8 @@ module Feedjira
     def parse_datetime(string)
       DateTime.parse(string).feed_utils_to_gm_time
     rescue StandardError => e
-      Feedjira.logger.warn { "Failed to parse date #{string.inspect}" }
-      Feedjira.logger.warn(e)
+      Feedjira.logger.debug("Failed to parse date #{string.inspect}")
+      Feedjira.logger.debug(e)
       nil
     end
 
@@ -64,11 +63,11 @@ module Feedjira
     end
 
     def [](field)
-      instance_variable_get("@#{field}")
+      instance_variable_get(:"@#{field}")
     end
 
     def []=(field, value)
-      instance_variable_set("@#{field}", value)
+      instance_variable_set(:"@#{field}", value)
     end
   end
 end

data/lib/feedjira/feed_utilities.rb

@@ -41,11 +41,7 @@ module Feedjira
     end
 
     def last_modified
-      @last_modified ||= begin
-        published = entries.reject { |e| e.published.nil? }
-        entry = published.max_by(&:published)
-        entry ? entry.published : nil
-      end
+      @last_modified ||= entries.reject { |e| e.published.nil? }.max_by(&:published)&.published
     end
 
     def updated?
@@ -78,7 +74,7 @@ module Feedjira
       if old_value == new_value
         false
       else
-        send("#{name}=", new_value)
+        send(:"#{name}=", new_value)
         true
       end
     end
@@ -95,7 +91,7 @@ module Feedjira
     # entries just parsed and insert each one as a new entry until we get to
     # one that has the same id as the the newest for the feed.
     def find_new_entries_for(feed)
-      return feed.entries if entries.length.zero?
+      return feed.entries if entries.empty?
 
       latest_entry = entries.first
       found_new_entries = []

data/lib/feedjira/parser/json_feed.rb

@@ -15,8 +15,8 @@ module Feedjira
         new(JSON.parse(json))
       end
 
-      attr_reader :json, :version, :title, :url, :feed_url, :description,
-                  :expired, :entries
+      attr_reader :json, :version, :title, :description, :url, :feed_url, :icon, :favicon,
+                  :language, :expired, :entries
 
       def initialize(json)
         @json = json
@@ -24,7 +24,10 @@ module Feedjira
         @title = json.fetch("title")
         @url = json.fetch("home_page_url", nil)
         @feed_url = json.fetch("feed_url", nil)
+        @icon = json.fetch("icon", nil)
+        @favicon = json.fetch("favicon", nil)
         @description = json.fetch("description", nil)
+        @language = json.fetch("language", nil)
         @expired = json.fetch("expired", nil)
         @entries = parse_items(json["items"])
       end

data/lib/feedjira/rss_entry_utilities.rb

@@ -2,7 +2,8 @@
 
 module Feedjira
   module RSSEntryUtilities
-    def self.included(mod)
+    # rubocop:todo Metrics/MethodLength
+    def self.included(mod) # rubocop:todo Metrics/AbcSize, Metrics/MethodLength
       mod.class_exec do
         element :title
 
@@ -34,9 +35,12 @@ module Feedjira
         element :"media:content", as: :image, value: :url
         element :enclosure, as: :image, value: :url
 
+        element :comments
+
         elements :category, as: :categories
       end
     end
+    # rubocop:enable Metrics/MethodLength
 
     def entry_id
       @entry_id&.guid

data/lib/feedjira/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Feedjira
-  VERSION = "3.2.1"
+  VERSION = "3.2.3"
 end

data/lib/feedjira.rb

@@ -8,10 +8,6 @@ require "json"
 
 require "feedjira/core_ext"
 require "feedjira/configuration"
-require "feedjira/date_time_utilities/date_time_epoch_parser"
-require "feedjira/date_time_utilities/date_time_language_parser"
-require "feedjira/date_time_utilities/date_time_pattern_parser"
-require "feedjira/date_time_utilities"
 require "feedjira/feed_entry_utilities"
 require "feedjira/feed_utilities"
 require "feedjira/feed"

data/spec/feedjira/core_ext/time_spec.rb

@@ -0,0 +1,57 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+RSpec.describe Time do
+  describe "#parse_safely" do
+    it "returns the datetime in utc when given a Time" do
+      time = described_class.now
+
+      expect(described_class.parse_safely(time)).to eq(time.utc)
+    end
+
+    it "returns the datetime in utc when given a Date" do
+      date = Date.today
+
+      expect(described_class.parse_safely(date)).to eq(date.to_time.utc)
+    end
+
+    it "returns the datetime in utc when given a String" do
+      timestamp = "2016-01-01 00:00:00"
+
+      expect(described_class.parse_safely(timestamp)).to eq(described_class.parse(timestamp).utc)
+    end
+
+    it "returns nil when given an empty String" do
+      timestamp = ""
+
+      expect(described_class.parse_safely(timestamp)).to be_nil
+    end
+
+    it "returns the the datetime in utc given a 14-digit time" do
+      time = described_class.now.utc
+      timestamp = time.strftime("%Y%m%d%H%M%S")
+
+      expect(described_class.parse_safely(timestamp)).to eq(time.floor)
+    end
+
+    context "when given an invalid time string" do
+      it "returns nil" do
+        timestamp = "2016-51-51 00:00:00"
+
+        expect(described_class.parse_safely(timestamp)).to be_nil
+      end
+
+      it "logs an error" do
+        timestamp = "2016-51-51 00:00:00"
+
+        expect(Feedjira.logger)
+          .to receive(:debug).with("Failed to parse time #{timestamp}")
+        expect(Feedjira.logger)
+          .to receive(:debug).with(an_instance_of(ArgumentError))
+
+        described_class.parse_safely(timestamp)
+      end
+    end
+  end
+end

data/spec/feedjira/feed_spec.rb

@@ -2,17 +2,8 @@
 
 require "spec_helper"
 
-class Hell < StandardError; end
-
-class FailParser
-  def self.parse(_xml)
-    yield "this parser always fails."
-    # on_failure.call
-  end
-end
-
 describe Feedjira::Feed do
-  describe "#add_common_feed_element" do
+  describe ".add_common_feed_element" do
     before(:all) do
       described_class.add_common_feed_element("generator")
     end
@@ -30,7 +21,25 @@ describe Feedjira::Feed do
     end
   end
 
-  describe "#add_common_feed_entry_element" do
+  describe ".add_common_feed_elements" do
+    before do
+      described_class.add_common_feed_elements(:foos)
+    end
+
+    it "parses the added element out of Atom feeds" do
+      expect(Feedjira.parse(sample_wfw_feed).foos).to eq []
+    end
+
+    it "parses the added element out of Atom Feedburner feeds" do
+      expect(Feedjira::Parser::Atom.new).to respond_to(:foos)
+    end
+
+    it "parses the added element out of RSS feeds" do
+      expect(Feedjira::Parser::RSS.new).to respond_to(:foos)
+    end
+  end
+
+  describe ".add_common_feed_entry_element" do
     before(:all) do
       tag = "wfw:commentRss"
       described_class.add_common_feed_entry_element tag, as: :comment_rss
@@ -49,4 +58,23 @@ describe Feedjira::Feed do
       expect(Feedjira::Parser::RSSEntry.new).to respond_to(:comment_rss)
     end
   end
+
+  describe ".add_common_feed_entry_elements" do
+    before do
+      described_class.add_common_feed_entry_elements(:things)
+    end
+
+    it "parses the added element out of Atom feeds entries" do
+      entry = Feedjira.parse(sample_wfw_feed).entries.first
+      expect(entry.things).to eq []
+    end
+
+    it "parses the added element out of Atom Feedburner feeds entries" do
+      expect(Feedjira::Parser::AtomEntry.new).to respond_to(:things)
+    end
+
+    it "parses the added element out of RSS feeds entries" do
+      expect(Feedjira::Parser::RSSEntry.new).to respond_to(:things)
+    end
+  end
 end

data/spec/feedjira/feed_utilities_entry_spec.rb

@@ -19,7 +19,7 @@ describe Feedjira::FeedUtilities do
     it "parses a ISO 8601 with milliseconds into Time" do
       time = @klass.new.parse_datetime("2013-09-17T08:20:13.931-04:00")
       expect(time.class).to eq Time
-      expect(time).to eq Time.parse_safely("Tue Sep 17 12:20:13 UTC 2013")
+      expect(time).to eq Time.strptime("Tue Sep 17 12:20:13.931 UTC 2013", "%a %b %d %H:%M:%S.%N %Z %Y")
     end
   end
 

data/spec/feedjira/feed_utilities_spec.rb

@@ -20,7 +20,7 @@ describe Feedjira::FeedUtilities do
     end
 
     context "when the flag is set" do
-      it "calls the preprocessing method" do
+      it "calls the preprocessing method" do # rubocop:todo RSpec/NoExpectationExample
         @klass.preprocess_xml = true
         allow(@klass).to receive(:preprocess).and_return sample_rss_feed
         @klass.parse sample_rss_feed
@@ -78,7 +78,7 @@ describe Feedjira::FeedUtilities do
     it "returns new_entries? as true when entries are put into new_entries" do
       feed = @klass.new
       feed.new_entries << :foo
-      expect(feed.new_entries?).to eq true
+      expect(feed.new_entries?).to be true
     end
 
     it "returns a last_modified value from the entry with the most recent published date if the last_modified date hasn't been set" do
@@ -116,6 +116,7 @@ describe Feedjira::FeedUtilities do
       it "updates the title if changed" do
         @updated_feed.title = "new title"
         @feed.update_from_feed(@updated_feed)
+
         expect(@feed.title).to eq @updated_feed.title
         expect(@feed).to be_updated
       end
@@ -252,11 +253,12 @@ describe Feedjira::FeedUtilities do
       let(:url_one) { "http://example.com/post_one.html" }
       let(:url_two) { "http://example.com/post_two.html" }
 
-      let(:entry_one) { double "Entry One", entry_id: id_one, url: url_one }
-      let(:entry_two) { double "Entry Two", entry_id: id_two, url: url_two }
+      let(:entry_one) { object_double(Feedjira::Parser::AtomEntry.new, entry_id: id_one, url: url_one) }
+
+      let(:entry_two) { object_double(Feedjira::Parser::AtomEntry.new, entry_id: id_two, url: url_two) }
 
       let(:feed_one) { Feedjira::Parser::Atom.new }
-      let(:feed_two) { double "Feed Two", entries: [entry_two] }
+      let(:feed_two) { object_double(Feedjira::Parser::Atom.new, entries: [entry_two]) }
 
       before do
         stub_const("Feedjira::FeedUtilities::UPDATABLE_ATTRIBUTES", [])

data/spec/feedjira/parser/json_feed_spec.rb

@@ -43,8 +43,20 @@ module Feedjira
         expect(@feed.description).to eq "Brent Simmons’s weblog."
       end
 
+      it "parses the favicon" do
+        expect(@feed.favicon).to eq "http://inessential.com/favicon.ico"
+      end
+
+      it "parses the icon" do
+        expect(@feed.icon).to eq "http://inessential.com/icon.png"
+      end
+
+      it "parses the language" do
+        expect(@feed.language).to eq "en-US"
+      end
+
       it "parses expired and return default (nil)" do
-        expect(@feed.expired).to be nil
+        expect(@feed.expired).to be_nil
       end
 
       it "parses entries" do

data/spec/feedjira/parser/rss_entry_spec.rb

@@ -72,6 +72,7 @@ describe Feedjira::Parser::RSSEntry do
       author
       categories
       comment_rss
+      comments
       content
       entry_id
       published
@@ -99,7 +100,7 @@ describe Feedjira::Parser::RSSEntry do
 
   it "ignores urls from guids with isPermaLink='false'" do
     feed = Feedjira.parse(sample_rss_feed_permalinks)
-    expect(feed.entries[0].url).to eq nil
+    expect(feed.entries[0].url).to be_nil
   end
 
   it "gets urls from guids with isPermaLink='true'" do
@@ -116,4 +117,9 @@ describe Feedjira::Parser::RSSEntry do
     feed = Feedjira.parse(sample_rss_feed_permalinks)
     expect(feed.entries[3].url).to eq "http://example.com/4"
   end
+
+  it "exposes comments URL" do
+    feed = Feedjira.parse(sample_rss_feed_with_comments)
+    expect(feed.entries[0].comments).to eq "https://news.ycombinator.com/item?id=30937433"
+  end
 end

data/spec/feedjira/parser/rss_feed_burner_entry_spec.rb

@@ -75,6 +75,7 @@ describe Feedjira::Parser::RSSFeedBurnerEntry do
       author
       categories
       comment_rss
+      comments
       content
       entry_id
       image

data/spec/feedjira/parser/rss_spec.rb

@@ -14,7 +14,7 @@ describe Feedjira::Parser::RSS do
 
     it "returns false for an rss feedburner feed" do
       able = described_class.able_to_parse? sample_rss_feed_burner_feed
-      expect(able).to eq false
+      expect(able).to be false
     end
   end