feedjira 3.0.0.beta1 → 3.2.0

data/spec/feedjira/date_time_utilities_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Feedjira::FeedUtilities do

data/spec/feedjira/feed_entry_utilities_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Feedjira::FeedUtilities do
@@ -32,14 +34,14 @@ describe Feedjira::FeedUtilities do
     end
 
     it "should provide a sanitized title" do
-      new_title = "<script>this is not safe</script>" + @entry.title
+      new_title = "<script>this is not safe</script>#{@entry.title}"
       @entry.title = new_title
       scrubbed_title = Loofah.scrub_fragment(new_title, :prune).to_s
       expect(@entry.title.sanitize).to eq scrubbed_title
     end
 
     it "should sanitize content in place" do
-      new_content = "<script>" + @entry.content
+      new_content = "<script>#{@entry.content}"
       @entry.content = new_content.dup
 
       scrubbed_content = Loofah.scrub_fragment(new_content, :prune).to_s

data/spec/feedjira/feed_spec.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 class Hell < StandardError; end
 
 class FailParser
-  def self.parse(_, &on_failure)
+  def self.parse(_xml, &on_failure)
     on_failure.call "this parser always fails."
   end
 end

data/spec/feedjira/feed_utilities_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Feedjira::FeedUtilities do
@@ -73,13 +75,13 @@ describe Feedjira::FeedUtilities do
       expect(feed.last_modified.class).to eq Time
     end
 
-    it "should return new_entries? as true when entries are put into new_entries" do # rubocop:disable Metrics/LineLength
+    it "should return new_entries? as true when entries are put into new_entries" do
       feed = @klass.new
       feed.new_entries << :foo
       expect(feed.new_entries?).to eq true
     end
 
-    it "should return a last_modified value from the entry with the most recent published date if the last_modified date hasn't been set" do # rubocop:disable Metrics/LineLength
+    it "should return a last_modified value from the entry with the most recent published date if the last_modified date hasn't been set" do
       feed = Feedjira::Parser::Atom.new
       entry = Feedjira::Parser::AtomEntry.new
       entry.published = Time.now.to_s
@@ -87,7 +89,7 @@ describe Feedjira::FeedUtilities do
       expect(feed.last_modified).to eq entry.published
     end
 
-    it "should not throw an error if one of the entries has published date of nil" do # rubocop:disable Metrics/LineLength
+    it "should not throw an error if one of the entries has published date of nil" do
       feed = Feedjira::Parser::Atom.new
       entry = Feedjira::Parser::AtomEntry.new
       entry.published = Time.now.to_s

data/spec/feedjira/parser/atom_entry_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Feedjira::Parser::AtomEntry do
@@ -32,7 +34,7 @@ describe Feedjira::Parser::AtomEntry do
   end
 
   it "should provide a summary" do
-    summary = "Late last year an entrepreneur from Turkey visited me at Amazon HQ in Seattle. We talked about his plans to use AWS as part of his new social video portal startup. I won't spill any beans before he's ready to..." # rubocop:disable Metrics/LineLength
+    summary = "Late last year an entrepreneur from Turkey visited me at Amazon HQ in Seattle. We talked about his plans to use AWS as part of his new social video portal startup. I won't spill any beans before he's ready to..."
     expect(@entry.summary).to eq summary
   end
 
@@ -42,7 +44,7 @@ describe Feedjira::Parser::AtomEntry do
   end
 
   it "should parse the categories" do
-    expect(@entry.categories).to eq %w(Turkey Seattle)
+    expect(@entry.categories).to eq %w[Turkey Seattle]
   end
 
   it "should parse the updated date" do
@@ -69,7 +71,7 @@ describe Feedjira::Parser::AtomEntry do
 
     expect(title_value).to eq "AWS Job: Architect & Designer Position in Turkey"
 
-    expected_fields = %w(
+    expected_fields = %w[
       author
       categories
       content
@@ -78,9 +80,10 @@ describe Feedjira::Parser::AtomEntry do
       published
       summary
       title
+      title_type
       updated
       url
-    )
+    ]
     expect(all_fields.sort).to eq expected_fields
   end
 

data/spec/feedjira/parser/atom_feed_burner_entry_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Feedjira::Parser::AtomFeedBurnerEntry do
@@ -14,10 +16,10 @@ describe Feedjira::Parser::AtomFeedBurnerEntry do
     expect(@entry.title).to eq "Making a Ruby C library even faster"
   end
 
-  it "should be able to fetch a url via the 'alternate' rel if no origLink exists" do # rubocop:disable Metrics/LineLength
-    xml = File.read("#{File.dirname(__FILE__)}/../../sample_feeds/PaulDixExplainsNothingAlternate.xml") # rubocop:disable Metrics/LineLength
+  it "should be able to fetch a url via the 'alternate' rel if no origLink exists" do
+    xml = File.read("#{File.dirname(__FILE__)}/../../sample_feeds/PaulDixExplainsNothingAlternate.xml")
     entry = Feedjira::Parser::AtomFeedBurner.parse(xml).entries.first
-    expect(entry.url).to eq("http://feeds.feedburner.com/~r/PaulDixExplainsNothing/~3/519925023/making-a-ruby-c-library-even-faster.html") # rubocop:disable Metrics/LineLength
+    expect(entry.url).to eq("http://feeds.feedburner.com/~r/PaulDixExplainsNothing/~3/519925023/making-a-ruby-c-library-even-faster.html")
   end
 
   it "should parse the url" do
@@ -25,7 +27,7 @@ describe Feedjira::Parser::AtomFeedBurnerEntry do
   end
 
   it "should parse the url when there is no alternate" do
-    xml = File.read("#{File.dirname(__FILE__)}/../../sample_feeds/FeedBurnerUrlNoAlternate.xml") # rubocop:disable Metrics/LineLength
+    xml = File.read("#{File.dirname(__FILE__)}/../../sample_feeds/FeedBurnerUrlNoAlternate.xml")
     entry = Feedjira::Parser::AtomFeedBurner.parse(xml).entries.first
     expect(entry.url).to eq "http://example.com/QQQQ.html"
   end
@@ -39,7 +41,7 @@ describe Feedjira::Parser::AtomFeedBurnerEntry do
   end
 
   it "should provide a summary" do
-    summary = "Last week I released the first version of a SAX based XML parsing library called SAX-Machine. It uses Nokogiri, which uses libxml, so it's pretty fast. However, I felt that it could be even faster. The only question was how..." # rubocop:disable Metrics/LineLength
+    summary = "Last week I released the first version of a SAX based XML parsing library called SAX-Machine. It uses Nokogiri, which uses libxml, so it's pretty fast. However, I felt that it could be even faster. The only question was how..."
     expect(@entry.summary).to eq summary
   end
 

data/spec/feedjira/parser/atom_feed_burner_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 module Feedjira
@@ -30,7 +32,7 @@ module Feedjira
       end
 
       it "should parse the description" do
-        description = "Entrepreneurship, programming, software development, politics, NYC, and random thoughts." # rubocop:disable Metrics/LineLength
+        description = "Entrepreneurship, programming, software development, politics, NYC, and random thoughts."
         expect(@feed.description).to eq description
       end
 
@@ -119,7 +121,7 @@ module Feedjira
         feed = AtomFeedBurner.parse sample_feed_burner_atom_xhtml_feed
         entry = feed.entries.first
 
-        expect(entry.content).to match(/\A\<p/)
+        expect(entry.content).to match(/\A<p/)
       end
     end
   end

data/spec/feedjira/parser/atom_google_alerts_entry_spec.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe Feedjira::Parser::AtomGoogleAlertsEntry do
+  before(:each) do
+    feed = Feedjira::Parser::AtomGoogleAlerts.parse sample_google_alerts_atom_feed
+    @entry = feed.entries.first
+  end
+
+  it "should parse the title" do
+    expect(@entry.title).to eq "Report offers Prediction of Automotive Slack Market by Top key players like Haldex, Meritor, Bendix ..."
+    expect(@entry.raw_title).to eq "Report offers Prediction of Automotive <b>Slack</b> Market by Top key players like Haldex, Meritor, Bendix ..."
+    expect(@entry.title_type).to eq "html"
+  end
+
+  it "should parse the url" do
+    expect(@entry.url).to eq "https://www.aglobalmarketresearch.com/report-offers-prediction-of-automotive-slack-market-by-top-key-players-like-haldex-meritor-bendix-mei-wabco-accuride-stemco-tbk-febi-aydinsan/"
+  end
+
+  it "should parse the content" do
+    expect(@entry.content).to eq "Automotive <b>Slack</b> Market reports provides a comprehensive overview of the global market size and share. It provides strategists, marketers and senior&nbsp;..."
+  end
+
+  it "should parse the published date" do
+    published = Time.parse_safely "2019-07-10T11:53:37Z"
+    expect(@entry.published).to eq published
+  end
+
+  it "should parse the updated date" do
+    updated = Time.parse_safely "2019-07-10T11:53:37Z"
+    expect(@entry.updated).to eq updated
+  end
+end

data/spec/feedjira/parser/atom_google_alerts_spec.rb

@@ -0,0 +1,62 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Feedjira
+  module Parser
+    describe "#able_to_parse?" do
+      it "should return true for a Google Alerts atom feed" do
+        expect(AtomGoogleAlerts).to be_able_to_parse(sample_google_alerts_atom_feed)
+      end
+
+      it "should return false for an rdf feed" do
+        expect(AtomGoogleAlerts).to_not be_able_to_parse(sample_rdf_feed)
+      end
+
+      it "should return false for a regular atom feed" do
+        expect(AtomGoogleAlerts).to_not be_able_to_parse(sample_atom_feed)
+      end
+
+      it "should return false for a feedburner atom feed" do
+        expect(AtomGoogleAlerts).to_not be_able_to_parse(sample_feedburner_atom_feed)
+      end
+    end
+
+    describe "parsing" do
+      before(:each) do
+        @feed = AtomGoogleAlerts.parse(sample_google_alerts_atom_feed)
+      end
+
+      it "should parse the title" do
+        expect(@feed.title).to eq "Google Alert - Slack"
+      end
+
+      it "should parse the descripton" do
+        expect(@feed.description).to be_nil
+      end
+
+      it "should parse the url" do
+        expect(@feed.url).to eq "https://www.google.com/alerts/feeds/04175468913983673025/4428013283581841004"
+      end
+
+      it "should parse the feed_url" do
+        expect(@feed.feed_url).to eq "https://www.google.com/alerts/feeds/04175468913983673025/4428013283581841004"
+      end
+
+      it "should parse entries" do
+        expect(@feed.entries.size).to eq 20
+      end
+    end
+
+    describe "preprocessing" do
+      it "retains markup in xhtml content" do
+        AtomGoogleAlerts.preprocess_xml = true
+
+        feed = AtomGoogleAlerts.parse sample_google_alerts_atom_feed
+        entry = feed.entries.first
+
+        expect(entry.content).to include("<b>Slack</b>")
+      end
+    end
+  end
+end

data/spec/feedjira/parser/atom_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 module Feedjira
@@ -15,7 +17,7 @@ module Feedjira
         expect(Atom).to_not be_able_to_parse(sample_rss_feed_burner_feed)
       end
 
-      it "should return true for an atom feed that has line breaks in between attributes in the <feed> node" do # rubocop:disable Metrics/LineLength
+      it "should return true for an atom feed that has line breaks in between attributes in the <feed> node" do
         expect(Atom).to be_able_to_parse(sample_atom_feed_line_breaks)
       end
     end
@@ -30,21 +32,26 @@ module Feedjira
       end
 
       it "should parse the description" do
-        description = "Amazon Web Services, Products, Tools, and Developer Information..." # rubocop:disable Metrics/LineLength
+        description = "Amazon Web Services, Products, Tools, and Developer Information..."
         expect(@feed.description).to eq description
       end
 
+      it "should parse the icon url" do
+        feed_with_icon = Atom.parse(load_sample("SamRuby.xml"))
+        expect(feed_with_icon.icon).to eq "../favicon.ico"
+      end
+
       it "should parse the url" do
         expect(@feed.url).to eq "http://aws.typepad.com/aws/"
       end
 
-      it "should parse the url even when it doesn't have the type='text/html' attribute" do # rubocop:disable Metrics/LineLength
+      it "should parse the url even when it doesn't have the type='text/html' attribute" do
         xml = load_sample "atom_with_link_tag_for_url_unmarked.xml"
         feed = Atom.parse xml
         expect(feed.url).to eq "http://www.innoq.com/planet/"
       end
 
-      it "should parse the feed_url even when it doesn't have the type='application/atom+xml' attribute" do # rubocop:disable Metrics/LineLength
+      it "should parse the feed_url even when it doesn't have the type='application/atom+xml' attribute" do
         feed = Atom.parse(load_sample("atom_with_link_tag_for_url_unmarked.xml"))
         expect(feed.feed_url).to eq "http://www.innoq.com/planet/atom.xml"
       end
@@ -75,9 +82,11 @@ module Feedjira
         feed = Atom.parse sample_atom_xhtml_feed
         entry = feed.entries.first
 
-        expect(entry.title).to match(/\<i/)
-        expect(entry.summary).to match(/\<b/)
-        expect(entry.content).to match(/\A\<p/)
+        expect(entry.raw_title).to match(/<i/)
+        expect(entry.title).to eq("Sentry Calming Collar for dogs")
+        expect(entry.title_type).to eq("xhtml")
+        expect(entry.summary).to match(/<b/)
+        expect(entry.content).to match(/\A<p/)
       end
 
       it "should not duplicate content when there are divs in content" do
@@ -89,7 +98,7 @@ module Feedjira
       end
     end
 
-    describe "parsing url and feed url based on rel attribute" do
+    describe "parsing url and feed_url" do
       before :each do
         @feed = Atom.parse(sample_atom_middleman_feed)
       end
@@ -98,9 +107,21 @@ module Feedjira
         expect(@feed.url).to eq "http://feedjira.com/blog"
       end
 
-      it "should parse feed url" do
+      it "should parse feed_url" do
         expect(@feed.feed_url).to eq "http://feedjira.com/blog/feed.xml"
       end
+
+      it "should not parse links without the rel='self' attribute as feed_url" do
+        xml = load_sample "atom_simple_single_entry.xml"
+        feed = Atom.parse xml
+        expect(feed.feed_url).to be_nil
+      end
+
+      it "should not parse links with the rel='self' attribute as url" do
+        xml = load_sample "atom_simple_single_entry_link_self.xml"
+        feed = Atom.parse xml
+        expect(feed.url).to be_nil
+      end
     end
   end
 end

data/spec/feedjira/parser/atom_youtube_entry_spec.rb

@@ -1,4 +1,6 @@
-require File.join(File.dirname(__FILE__), %w(.. .. spec_helper))
+# frozen_string_literal: true
+
+require File.join(File.dirname(__FILE__), %w[.. .. spec_helper])
 
 describe Feedjira::Parser::AtomYoutubeEntry do
   describe "parsing" do
@@ -20,15 +22,15 @@ describe Feedjira::Parser::AtomYoutubeEntry do
     end
 
     it "should have the published date" do
-      expect(@entry.published).to eq Time.parse_safely("2015-05-04T00:01:27+00:00") # rubocop:disable Metrics/LineLength
+      expect(@entry.published).to eq Time.parse_safely("2015-05-04T00:01:27+00:00")
     end
 
     it "should have the updated date" do
-      expect(@entry.updated).to eq Time.parse_safely("2015-05-13T17:38:30+00:00") # rubocop:disable Metrics/LineLength
+      expect(@entry.updated).to eq Time.parse_safely("2015-05-13T17:38:30+00:00")
     end
 
     it "should have the content populated from the media:description element" do
-      expect(@entry.content).to eq "A question is the most powerful force in the world. It can start you on an adventure or spark a connection. See where a question can take you. The Google app is available on iOS and Android. Download the app here: http://www.google.com/search/about/download" # rubocop:disable Metrics/LineLength
+      expect(@entry.content).to eq "A question is the most powerful force in the world. It can start you on an adventure or spark a connection. See where a question can take you. The Google app is available on iOS and Android. Download the app here: http://www.google.com/search/about/download"
     end
 
     it "should have the summary but blank" do
@@ -44,7 +46,7 @@ describe Feedjira::Parser::AtomYoutubeEntry do
     end
 
     it "should have the custom media url" do
-      expect(@entry.media_url).to eq "https://www.youtube.com/v/5shykyfmb28?version=3" # rubocop:disable Metrics/LineLength
+      expect(@entry.media_url).to eq "https://www.youtube.com/v/5shykyfmb28?version=3"
     end
 
     it "should have the custom media type" do
@@ -60,7 +62,7 @@ describe Feedjira::Parser::AtomYoutubeEntry do
     end
 
     it "should have the custom media thumbnail url" do
-      expect(@entry.media_thumbnail_url).to eq "https://i2.ytimg.com/vi/5shykyfmb28/hqdefault.jpg" # rubocop:disable Metrics/LineLength
+      expect(@entry.media_thumbnail_url).to eq "https://i2.ytimg.com/vi/5shykyfmb28/hqdefault.jpg"
     end
 
     it "should have the custom media thumbnail width" do

data/spec/feedjira/parser/atom_youtube_spec.rb

@@ -1,17 +1,19 @@
-require File.join(File.dirname(__FILE__), %w(.. .. spec_helper))
+# frozen_string_literal: true
+
+require File.join(File.dirname(__FILE__), %w[.. .. spec_helper])
 
 describe Feedjira::Parser::AtomYoutube do
   describe "#will_parse?" do
     it "should return true for an atom youtube feed" do
-      expect(Feedjira::Parser::AtomYoutube).to be_able_to_parse(sample_youtube_atom_feed) # rubocop:disable Metrics/LineLength
+      expect(Feedjira::Parser::AtomYoutube).to be_able_to_parse(sample_youtube_atom_feed)
     end
 
     it "should return fase for an atom feed" do
-      expect(Feedjira::Parser::AtomYoutube).to_not be_able_to_parse(sample_atom_feed) # rubocop:disable Metrics/LineLength
+      expect(Feedjira::Parser::AtomYoutube).to_not be_able_to_parse(sample_atom_feed)
     end
 
     it "should return false for an rss feedburner feed" do
-      expect(Feedjira::Parser::AtomYoutube).to_not be_able_to_parse(sample_rss_feed_burner_feed) # rubocop:disable Metrics/LineLength
+      expect(Feedjira::Parser::AtomYoutube).to_not be_able_to_parse(sample_rss_feed_burner_feed)
     end
   end
 

data/spec/feedjira/parser/google_docs_atom_entry_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Feedjira::Parser::GoogleDocsAtomEntry do