feedjira 3.0.0.beta1 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: b128986f5aba338178d635d04c7c76a6bf4786c9
-  data.tar.gz: d812e34dcf097bd6cc3d5d6b299337898eb119ec
+SHA256:
+  metadata.gz: 49efb7655e500df91c7119e3afbb2b91fab6d0a8282703fecb69f24d15f54357
+  data.tar.gz: ea6fc3b58be4968be8c8561b6e8c2720b5732882ff2556fe6966583df9bcf130
 SHA512:
-  metadata.gz: e199341333e63c4b11fd65532c41d8efd9d7236bd264e21edd9795f1fcbe8b79e35a122534f1b0ee61a0e76fade5364e70a032e142da63589e3158c4fa78440a
-  data.tar.gz: bcddaf13bdc6214acb552dadfe23f481a2e0d6e7da99b3e182e9bb067f1e0f70e93f80d62b75e02f52304c5cf4b47252c6a9ee55f6c1c697e9c9800acf230e07
+  metadata.gz: dd52aec9d212c0428095c3adee3cbfd1115d53a54ac2281bf7ce7f4142ace6659e658658097e43edb3c90deec583941ed220aea1fe1709f66110adb79c471620
+  data.tar.gz: d39bfe14c74a642311d55369498195e588beec99e5bfb897b0f00c5019f1985f89c1280b8c8eaafb3d36f55b9558b04c9037ccc8710c34c4bad2cb6127702d61

data/.rubocop.yml

@@ -1,4 +1,7 @@
+inherit_from: .rubocop_todo.yml
+
 AllCops:
+  TargetRubyVersion: 2.2
   Exclude:
     - db/schema.rb
     - vendor/**/*
@@ -360,7 +363,7 @@ Style/TrailingCommaInArguments:
     - no_comma
   Enabled: true
 
-Style/TrailingCommaInLiteral:
+Style/TrailingCommaInArrayLiteral:
   Description: 'Checks for trailing comma in array and hash literals.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-trailing-array-commas'
   EnforcedStyleForMultiline: comma
@@ -527,7 +530,7 @@ Lint/UnderscorePrefixedVariableName:
   Description: 'Do not use prefix `_` for a variable that is used.'
   Enabled: false
 
-Lint/UnneededDisable:
+Lint/UnneededCopDisableDirective:
   Description: >-
                  Checks for rubocop:disable comments that can be removed.
                  Note: this cop is not disabled when disabling all cops.

data/.rubocop_todo.yml

@@ -0,0 +1,36 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2018-10-08 04:14:19 +0900 using RuboCop version 0.59.2.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 7
+# Cop supports --auto-correct.
+Layout/EmptyLineAfterGuardClause:
+  Exclude:
+    - 'lib/feedjira/date_time_utilities/date_time_epoch_parser.rb'
+    - 'lib/feedjira/feed_utilities.rb'
+    - 'lib/feedjira/parser/json_feed_item.rb'
+    - 'lib/feedjira/parser/podlove_chapter.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Performance/UnneededSort:
+  Exclude:
+    - 'lib/feedjira/feed_utilities.rb'
+
+# Offense count: 3
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: inline, group
+Style/AccessModifierDeclarations:
+  Exclude:
+    - 'lib/feedjira.rb'
+    - 'lib/feedjira/parser/itunes_rss.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/UnneededCondition:
+  Exclude:
+    - 'lib/feedjira/feed_utilities.rb'

data/.travis.yml

@@ -32,6 +32,3 @@ script:
 
 notifications:
   email: false
-  webhooks:
-    urls:
-      secure: XjoUz2rPXFHnitw//jN4qA92jq7bH19iOI/5KnuptLzz5HrWq1VAXxAr/Fh0KxYZT29G/9i5szaHX1QacfO7he4xa2tZKudRL70Dw3KRLgqLi70G6kFuZYlh+MgMHZy6KwZ/4/250wO31fpv24PCb2M56iTsev2g2uporeobO0Q=

data/Gemfile

@@ -3,6 +3,7 @@ source "https://rubygems.org/"
 gemspec
 
 gem "pry"
+gem "rubocop", "~> 0.59.2"
 
 group :test do
   gem "oga"

data/README.md

@@ -143,6 +143,8 @@ add-ons and everything in between. Here are some of them:
 
 * [Solve for All][solve]: Solve for All combines search engine and feed parsing
   while protecting your privacy. It's even extendable by the community!
+  
+* [Feedi API][feedi]: Feedi simplifies how you handle RSS, Atom, or JSON feeds. You can add and keep track of your favourite           feed data with a simple and clean REST API. All entries are enriched by Machine Learning and Semantic engines.
 
 [Feedbin]: https://feedbin.com/
 [Stringer]: https://github.com/swanson/stringer
@@ -150,6 +152,7 @@ add-ons and everything in between. Here are some of them:
 [Feedbunch]: https://github.com/amatriain/feedbunch
 [old]: http://theoldreader.com/
 [solve]: https://solveforall.com/
+[feedi]: https://github.com/davidesantangelo/feedi
 
 Note: to get your project on this list, simply [send an email](mailto:feedjira@gmail.com)
 with your project's details.

data/feedjira.gemspec

@@ -1,6 +1,6 @@
 # -*- encoding: utf-8 -*-
 
-require File.expand_path("../lib/feedjira/version", __FILE__)
+require File.expand_path("lib/feedjira/version", __dir__)
 
 # rubocop:disable Metrics/BlockLength
 Gem::Specification.new do |s|
@@ -20,13 +20,19 @@ Gem::Specification.new do |s|
   s.summary  = "A feed parsing library"
   s.version  = Feedjira::VERSION
 
+  s.metadata = {
+    "homepage_uri"    => "http://feedjira.com",
+    "source_code_uri" => "https://github.com/feedjira/feedjira",
+    "changelog_uri"   => "https://github.com/feedjira/feedjira/blob/master/CHANGELOG.md"
+  }
+
   s.files         = `git ls-files`.split("\n")
   s.require_paths = ["lib"]
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
 
-  s.required_ruby_version = ">=1.9.3"
+  s.required_ruby_version = ">=2.2"
 
-  s.add_dependency "loofah",             ">= 2.0"
+  s.add_dependency "loofah",             ">= 2.2.1"
   s.add_dependency "sax-machine",        ">= 1.0"
 
   s.add_development_dependency "danger"

data/lib/feedjira.rb

@@ -14,6 +14,8 @@ require "feedjira/date_time_utilities"
 require "feedjira/feed_entry_utilities"
 require "feedjira/feed_utilities"
 require "feedjira/feed"
+require "feedjira/rss_entry_utilities"
+require "feedjira/atom_entry_utilities"
 require "feedjira/parser"
 require "feedjira/parser/rss_entry"
 require "feedjira/parser/rss_image"

data/lib/feedjira/atom_entry_utilities.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+module Feedjira
+  module AtomEntryUtilities
+    def self.included(mod)
+      mod.class_exec do
+        element :title
+        element :name, as: :author
+        element :content
+        element :summary
+        element :enclosure, as: :image, value: :href
+
+        element :published
+        element :id, as: :entry_id
+        element :created, as: :published
+        element :issued, as: :published
+        element :updated
+        element :modified, as: :updated
+
+        elements :category, as: :categories, value: :term
+
+        element :link, as: :url, value: :href, with: {
+          type: "text/html",
+          rel: "alternate"
+        }
+
+        elements :link, as: :links, value: :href
+      end
+    end
+
+    def url
+      @url ||= links.first
+    end
+  end
+end

data/lib/feedjira/core_ext/date.rb

@@ -2,7 +2,6 @@
 # Ruby Cookbook by Lucas Carlson and Leonard Richardson
 # Published by O'Reilly
 # ISBN: 0-596-52369-6
-# rubocop:disable Style/DocumentationMethod
 class Date
   def feed_utils_to_gm_time
     feed_utils_to_time(new_offset, :gm)

data/lib/feedjira/core_ext/string.rb

@@ -1,4 +1,3 @@
-# rubocop:disable Style/DocumentationMethod Style/Documentation
 class String
   def sanitize!
     replace(sanitize)

data/lib/feedjira/core_ext/time.rb

@@ -1,7 +1,6 @@
 require "time"
 require "date"
 
-# rubocop:disable Style/DocumentationMethod
 class Time
   # Parse a time string and convert it to UTC without raising errors.
   # Parses a flattened 14-digit time (YYYYmmddHHMMMSS) as UTC.
@@ -11,17 +10,16 @@ class Time
   #
   # === Returns
   # A Time instance in UTC or nil if there were errors while parsing.
-  # rubocop:disable Metrics/MethodLength
-  def self.parse_safely(dt)
-    if dt.is_a?(Time)
-      dt.utc
-    elsif dt.respond_to?(:to_datetime)
-      dt.to_datetime.utc
-    elsif dt.respond_to? :to_s
-      parse_string_safely dt.to_s
+  def self.parse_safely(datetime)
+    if datetime.is_a?(Time)
+      datetime.utc
+    elsif datetime.respond_to?(:to_datetime)
+      datetime.to_datetime.utc
+    elsif datetime.respond_to? :to_s
+      parse_string_safely datetime.to_s
     end
   rescue StandardError => e
-    Feedjira.logger.debug { "Failed to parse time #{dt}" }
+    Feedjira.logger.debug { "Failed to parse time #{datetime}" }
     Feedjira.logger.debug(e)
     nil
   end

data/lib/feedjira/date_time_utilities.rb

@@ -1,4 +1,3 @@
-# rubocop:disable Style/Documentation
 module Feedjira
   module DateTimeUtilities
     # This is our date parsing heuristic.
@@ -12,7 +11,6 @@ module Feedjira
 
     # Parse the given string starting with the most common parser (default ruby)
     # and going over all other available parsers
-    # rubocop:disable Metrics/MethodLength
     def parse_datetime(string)
       res = DATE_PARSERS.detect do |parser|
         begin

data/lib/feedjira/date_time_utilities/date_time_epoch_parser.rb

@@ -1,5 +1,3 @@
-# rubocop:disable Style/Documentation
-# rubocop:disable Style/DocumentationMethod
 module Feedjira
   module DateTimeUtilities
     class DateTimeEpochParser

data/lib/feedjira/date_time_utilities/date_time_language_parser.rb

@@ -1,5 +1,3 @@
-# rubocop:disable Style/Documentation
-# rubocop:disable Style/DocumentationMethod
 module Feedjira
   module DateTimeUtilities
     class DateTimeLanguageParser

data/lib/feedjira/date_time_utilities/date_time_pattern_parser.rb

@@ -1,15 +1,11 @@
-# rubocop:disable Style/Documentation
-# rubocop:disable Style/DocumentationMethod
 module Feedjira
   module DateTimeUtilities
     class DateTimePatternParser
-      # rubocop:disable Style/AsciiComments
       # Japanese Symbols are required for strange Date Strings like
       # '水, 31 8 2016 07:37:00 PDT'
       JAPANESE_SYMBOLS = %w(日 月 火 水 木 金 土).freeze
       PATTERNS = ["%m/%d/%Y %T %p", "%d %m %Y %T %Z"].freeze
 
-      # rubocop:disable Metrics/MethodLength
       def self.parse(string)
         PATTERNS.each do |p|
           begin

data/lib/feedjira/feed.rb

@@ -1,5 +1,3 @@
-# rubocop:disable Style/Documentation
-# rubocop:disable Style/DocumentationMethod
 module Feedjira
   class Feed
     class << self

data/lib/feedjira/feed_entry_utilities.rb

@@ -1,5 +1,3 @@
-# rubocop:disable Style/Documentation
-# rubocop:disable Style/DocumentationMethod
 module Feedjira
   module FeedEntryUtilities
     include Enumerable
@@ -20,22 +18,24 @@ module Feedjira
     ##
     # Returns the id of the entry or its url if not id is present, as some
     # formats don't support it
+    # rubocop:disable Naming/MemoizedInstanceVariableName
     def id
       @entry_id ||= @url
     end
+    # rubocop:enable Naming/MemoizedInstanceVariableName
 
     ##
     # Writer for published. By default, we keep the "oldest" publish time found.
     def published=(val)
       parsed = parse_datetime(val)
-      @published = parsed if !@published || parsed < @published
+      @published = parsed if parsed && (!@published || parsed < @published)
     end
 
     ##
     # Writer for updated. By default, we keep the most recent update time found.
     def updated=(val)
       parsed = parse_datetime(val)
-      @updated = parsed if !@updated || parsed > @updated
+      @updated = parsed if parsed && (!@updated || parsed > @updated)
     end
 
     def sanitize!
@@ -49,10 +49,15 @@ module Feedjira
     alias last_modified published
 
     def each
-      @rss_fields ||= instance_variables
+      @rss_fields ||= instance_variables.map do |ivar|
+        ivar.to_s.sub("@", "")
+      end.select do |field|
+        # select callable (public) methods only
+        respond_to?(field)
+      end
 
       @rss_fields.each do |field|
-        yield(field.to_s.sub("@", ""), instance_variable_get(field))
+        yield(field, instance_variable_get(:"@#{field}"))
       end
     end
 

data/lib/feedjira/feed_utilities.rb

@@ -1,5 +1,3 @@
-# rubocop:disable Style/Documentation
-# rubocop:disable Style/DocumentationMethod
 module Feedjira
   module FeedUtilities
     UPDATABLE_ATTRIBUTES = %w(title feed_url url last_modified etag).freeze

data/lib/feedjira/parser/atom.rb

@@ -1,4 +1,3 @@
-# rubocop:disable Style/DocumentationMethod
 module Feedjira
   module Parser
     # Parser for dealing with Atom feeds.

data/lib/feedjira/parser/atom_entry.rb

@@ -1,32 +1,13 @@
-# rubocop:disable Style/DocumentationMethod
 module Feedjira
   module Parser
     # Parser for dealing with Atom feed entries.
     class AtomEntry
       include SAXMachine
       include FeedEntryUtilities
+      include AtomEntryUtilities
 
-      element :title
-      element :link, as: :url, value: :href, with: { type: "text/html", rel: "alternate" } # rubocop:disable Metrics/LineLength
-      element :name, as: :author
-      element :content
-      element :summary
-
+      element :"media:thumbnail", as: :image, value: :url
       element :"media:content", as: :image, value: :url
-      element :enclosure, as: :image, value: :href
-
-      element :published
-      element :id, as: :entry_id
-      element :created, as: :published
-      element :issued, as: :published
-      element :updated
-      element :modified, as: :updated
-      elements :category, as: :categories, value: :term
-      elements :link, as: :links, value: :href
-
-      def url
-        @url ||= links.first
-      end
     end
   end
 end

data/lib/feedjira/parser/atom_feed_burner.rb

@@ -1,4 +1,3 @@
-# rubocop:disable Style/DocumentationMethod
 module Feedjira
   module Parser
     # Parser for dealing with Feedburner Atom feeds.
@@ -20,7 +19,7 @@ module Feedjira
       attr_writer :url, :feed_url
 
       def self.able_to_parse?(xml)
-        ((/Atom/ =~ xml) && (/feedburner/ =~ xml) && !(/\<rss|\<rdf/ =~ xml)) || false # rubocop:disable Metrics/LineLength
+        ((/<feed/ =~ xml) && (/Atom/ =~ xml) && (/feedburner/ =~ xml) && !(/\<rss|\<rdf/ =~ xml)) || false # rubocop:disable Metrics/LineLength
       end
 
       # Feed url is <link> with type="text/html" if present,

data/lib/feedjira/parser/atom_feed_burner_entry.rb

@@ -1,32 +1,21 @@
-# rubocop:disable Style/DocumentationMethod
 module Feedjira
   module Parser
     # Parser for dealing with Feedburner Atom feed entries.
     class AtomFeedBurnerEntry
       include SAXMachine
       include FeedEntryUtilities
+      include AtomEntryUtilities
 
-      element :title
-      element :name, as: :author
-      element :link, as: :url, value: :href, with: { type: "text/html", rel: "alternate" } # rubocop:disable Metrics/LineLength
-      element :"feedburner:origLink", as: :url
-      element :summary
-      element :content
+      element :"feedburner:origLink", as: :orig_link
+      # rubocop:disable Style/AccessModifierDeclarations
+      private :orig_link
+      # rubocop:enable Style/AccessModifierDeclarations
 
+      element :"media:thumbnail", as: :image, value: :url
       element :"media:content", as: :image, value: :url
-      element :enclosure, as: :image, value: :href
-
-      element :published
-      element :id, as: :entry_id
-      element :issued, as: :published
-      element :created, as: :published
-      element :updated
-      element :modified, as: :updated
-      elements :category, as: :categories, value: :term
-      elements :link, as: :links, value: :href
 
       def url
-        @url ||= links.first
+        orig_link || super
       end
     end
   end

data/lib/feedjira/parser/atom_youtube.rb

@@ -1,4 +1,3 @@
-# rubocop:disable Style/DocumentationMethod
 module Feedjira
   module Parser
     # Parser for dealing with RSS feeds.

data/lib/feedjira/parser/atom_youtube_entry.rb

@@ -1,19 +1,18 @@
-# rubocop:disable Style/Documentation
 module Feedjira
   module Parser
     class AtomYoutubeEntry
       include SAXMachine
       include FeedEntryUtilities
+      include AtomEntryUtilities
+
+      sax_config.top_level_elements["link"].clear
+      sax_config.collection_elements["link"].clear
 
-      element :title
       element :link, as: :url, value: :href, with: { rel: "alternate" }
-      element :name, as: :author
+
       element :"media:description", as: :content
-      element :summary
-      element :published
-      element :id, as: :entry_id
-      element :updated
       element :"yt:videoId", as: :youtube_video_id
+      element :"yt:channelId", as: :youtube_channel_id
       element :"media:title", as: :media_title
       element :"media:content", as: :media_url, value: :url
       element :"media:content", as: :media_type, value: :type

data/lib/feedjira/parser/google_docs_atom.rb

@@ -1,6 +1,4 @@
 require File.expand_path("./atom", File.dirname(__FILE__))
-# rubocop:disable Style/Documentation
-# rubocop:disable Style/DocumentationMethod
 module Feedjira
   module Parser
     class GoogleDocsAtom

data/lib/feedjira/parser/google_docs_atom_entry.rb

@@ -1,31 +1,13 @@
-# rubocop:disable Style/Documentation
-# rubocop:disable Style/DocumentationMethod
 module Feedjira
   module Parser
     class GoogleDocsAtomEntry
       include SAXMachine
       include FeedEntryUtilities
+      include AtomEntryUtilities
 
-      element :title
-      element :link, as: :url, value: :href, with: { type: "text/html", rel: "alternate" } # rubocop:disable Metrics/LineLength
-      element :name, as: :author
-      element :content
-      element :summary
-      element :published
-      element :id, as: :entry_id
-      element :created, as: :published
-      element :issued, as: :published
-      element :updated
-      element :modified, as: :updated
-      elements :category, as: :categories, value: :term
-      elements :link, as: :links, value: :href
       element :"docs:md5Checksum", as: :checksum
       element :"docs:filename", as: :original_filename
       element :"docs:suggestedFilename", as: :suggested_filename
-
-      def url
-        @url ||= links.first
-      end
     end
   end
 end

data/lib/feedjira/parser/itunes_rss.rb

@@ -1,4 +1,3 @@
-# rubocop:disable Style/DocumentationMethod
 module Feedjira
   module Parser
     # iTunes is RSS 2.0 + some apple extensions

data/lib/feedjira/parser/itunes_rss_category.rb

@@ -1,4 +1,3 @@
-# rubocop:disable Style/DocumentationMethod
 module Feedjira
   module Parser
     # iTunes extensions to the standard RSS2.0 item

data/lib/feedjira/parser/itunes_rss_item.rb

@@ -5,14 +5,9 @@ module Feedjira
     class ITunesRSSItem
       include SAXMachine
       include FeedEntryUtilities
+      include RSSEntryUtilities
 
-      element :author
-      element :guid, as: :entry_id
-      element :title
-      element :link, as: :url
-      element :description, as: :summary
-      element :"content:encoded", as: :content
-      element :pubDate, as: :published
+      sax_config.top_level_elements["enclosure"].clear
 
       # If author is not present use author tag on the item
       element :"itunes:author", as: :itunes_author

data/lib/feedjira/parser/itunes_rss_owner.rb

@@ -1,4 +1,3 @@
-# rubocop:disable Style/Documentation
 module Feedjira
   module Parser
     class ITunesRSSOwner

data/lib/feedjira/parser/podlove_chapter.rb

@@ -1,5 +1,3 @@
-# rubocop:disable Style/Documentation
-# rubocop:disable Style/DocumentationMethod
 module Feedjira
   module Parser
     class PodloveChapter

data/lib/feedjira/parser/rss.rb

@@ -1,4 +1,3 @@
-# rubocop:disable Style/DocumentationMethod
 module Feedjira
   module Parser
     # Parser for dealing with RSS feeds.

data/lib/feedjira/parser/rss_entry.rb

@@ -4,34 +4,7 @@ module Feedjira
     class RSSEntry
       include SAXMachine
       include FeedEntryUtilities
-
-      element :title
-      element :link, as: :url
-
-      element :"dc:creator", as: :author
-      element :author, as: :author
-      element :"content:encoded", as: :content
-      element :description, as: :summary
-
-      element :"media:content", as: :image, value: :url
-      element :enclosure, as: :image, value: :url
-
-      element :pubDate, as: :published
-      element :pubdate, as: :published
-      element :"dc:date", as: :published
-      element :"dc:Date", as: :published
-      element :"dcterms:created", as: :published
-
-      element :"dcterms:modified", as: :updated
-      element :issued, as: :published
-      elements :category, as: :categories
-
-      element :guid, as: :entry_id
-      element :"dc:identifier", as: :dc_identifier
-
-      def id
-        @entry_id ||= @dc_identifier || @url
-      end
+      include RSSEntryUtilities
     end
   end
 end

data/lib/feedjira/parser/rss_feed_burner.rb

@@ -1,4 +1,3 @@
-# rubocop:disable Style/DocumentationMethod
 module Feedjira
   module Parser
     # Parser for dealing with RSS feeds.

data/lib/feedjira/parser/rss_feed_burner_entry.rb

@@ -1,38 +1,18 @@
-# rubocop:disable Style/DocumentationMethod
 module Feedjira
   module Parser
     # Parser for dealing with RDF feed entries.
     class RSSFeedBurnerEntry
       include SAXMachine
       include FeedEntryUtilities
+      include RSSEntryUtilities
 
-      element :title
-
-      element :"feedburner:origLink", as: :url
-      element :link, as: :url
-
-      element :"dc:creator", as: :author
-      element :author, as: :author
-      element :"content:encoded", as: :content
-      element :description, as: :summary
-
-      element :"media:content", as: :image, value: :url
-      element :enclosure, as: :image, value: :url
-
-      element :pubDate, as: :published
-      element :pubdate, as: :published
-      element :"dc:date", as: :published
-      element :"dc:Date", as: :published
-      element :"dcterms:created", as: :published
-
-      element :"dcterms:modified", as: :updated
-      element :issued, as: :published
-      elements :category, as: :categories
-
-      element :guid, as: :entry_id
+      element :"feedburner:origLink", as: :orig_link
+      # rubocop:disable Style/AccessModifierDeclarations
+      private :orig_link
+      # rubocop:enable Style/AccessModifierDeclarations
 
       def url
-        @url || @link
+        orig_link || super
       end
     end
   end

data/lib/feedjira/preprocessor.rb

@@ -1,5 +1,3 @@
-# rubocop:disable Style/Documentation
-# rubocop:disable Style/DocumentationMethod
 module Feedjira
   class Preprocessor
     def initialize(xml)

data/lib/feedjira/rss_entry_utilities.rb

@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+module Feedjira
+  module RSSEntryUtilities
+    def self.included(mod)
+      mod.class_exec do
+        element :title
+
+        element :"content:encoded", as: :content
+        element :description, as: :summary
+
+        element :link, as: :url
+
+        element :author
+        element :"dc:creator", as: :author
+
+        element :pubDate, as: :published
+        element :pubdate, as: :published
+        element :issued, as: :published
+        element :"dc:date", as: :published
+        element :"dc:Date", as: :published
+        element :"dcterms:created", as: :published
+
+        element :"dcterms:modified", as: :updated
+
+        element :guid, as: :entry_id
+        element :"dc:identifier", as: :dc_identifier
+
+        element :"media:thumbnail", as: :image, value: :url
+        element :"media:content", as: :image, value: :url
+        element :enclosure, as: :image, value: :url
+
+        elements :category, as: :categories
+      end
+    end
+
+    attr_reader :url
+
+    # rubocop:disable Naming/MemoizedInstanceVariableName
+    def id
+      @entry_id ||= @dc_identifier || @url
+    end
+    # rubocop:enable Naming/MemoizedInstanceVariableName
+  end
+end

data/lib/feedjira/version.rb

@@ -1,3 +1,3 @@
 module Feedjira
-  VERSION = "3.0.0.beta1".freeze
+  VERSION = "3.0.0".freeze
 end

data/spec/feedjira/feed_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 class Hell < StandardError; end
 
 class FailParser
-  def self.parse(_, &on_failure)
+  def self.parse(_xml, &on_failure)
     on_failure.call "this parser always fails."
   end
 end

data/spec/feedjira/parser/atom_youtube_entry_spec.rb

@@ -20,11 +20,11 @@ describe Feedjira::Parser::AtomYoutubeEntry do
     end
 
     it "should have the published date" do
-      expect(@entry.published).to eq Time.parse_safely("2015-05-04T00:01:27+00:00") # rubocop:disable Metrics/LineLength
+      expect(@entry.published).to eq Time.parse_safely("2015-05-04T00:01:27+00:00")
     end
 
     it "should have the updated date" do
-      expect(@entry.updated).to eq Time.parse_safely("2015-05-13T17:38:30+00:00") # rubocop:disable Metrics/LineLength
+      expect(@entry.updated).to eq Time.parse_safely("2015-05-13T17:38:30+00:00")
     end
 
     it "should have the content populated from the media:description element" do

data/spec/feedjira_spec.rb

@@ -62,6 +62,16 @@ RSpec.describe Feedjira do
         expect(feed.entries.first.id).to eq "23246627"
         expect(feed.entries.last.id.strip).to eq "1"
       end
+
+      it "does not fail if multiple published dates exist and some are unparseable" do
+        expect(Feedjira.logger).to receive(:warn).twice
+
+        feed = Feedjira.parse(sample_invalid_date_format_feed)
+        expect(feed.title).to eq "Invalid date format feed"
+        published = Time.parse_safely "Mon, 16 Oct 2017 15:10:00 GMT"
+        expect(feed.entries.first.published).to eq published
+        expect(feed.entries.size).to eq 2
+      end
     end
 
     context "when there's no available parser" do
@@ -128,7 +138,7 @@ RSpec.describe Feedjira do
       it "does not use default parsers" do
         xml = "Atom asdf"
         new_parser = Class.new do
-          def self.able_to_parse?(_)
+          def self.able_to_parse?(_xml)
             true
           end
         end

data/spec/sample_feeds.rb

@@ -1,5 +1,3 @@
-# rubocop:disable Metrics/LineLength
-
 module SampleFeeds
   FEEDS = {
     sample_atom_feed: "AmazonWebServicesBlog.xml",
@@ -29,6 +27,7 @@ module SampleFeeds
     sample_atom_xhtml_with_escpaed_html_in_pre_tag_feed: "AtomEscapedHTMLInPreTag.xml",
     sample_json_feed: "json_feed.json",
     sample_rss_feed_huffpost_ca: "HuffPostCanada.xml",
+    sample_invalid_date_format_feed: "InvalidDateFormat.xml"
   }.freeze
 
   FEEDS.each do |method, filename|
@@ -39,5 +38,3 @@ module SampleFeeds
     File.read("#{File.dirname(__FILE__)}/sample_feeds/#{filename}")
   end
 end
-
-# rubocop:enable Metrics/LineLength

data/spec/sample_feeds/InvalidDateFormat.xml

@@ -0,0 +1,20 @@
+<?xml version="1.0" encoding="UTF-8"?><rss version="2.0"
+  xmlns:dc="http://purl.org/dc/elements/1.1/">
+
+<channel>
+  <title>Invalid date format feed</title>
+  <link>http://example.com/feed</link>
+  <language>en-US</language>
+  <item>
+    <title>Item 0 with an invalid date</title>
+    <link>http://example.com/item0</link>
+    <pubDate>Mon, 16 Oct 2017 15:10:00 +0000</pubDate>
+    <dc:date>1518478934</dc:date>
+  </item>
+  <item>
+    <title>Item 1 with all valid dates</title>
+    <link>http://example.com/item1</link>
+    <pubDate>Tue, 17 Oct 2017 12:17:00 +0000</pubDate>
+    <dc:date>Tue, 17 Oct 2017 22:17:00 +0000</dc:date>
+  </item>
+</channel>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: feedjira
 version: !ruby/object:Gem::Version
-  version: 3.0.0.beta1
+  version: 3.0.0
 platform: ruby
 authors:
 - Adam Hess
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-22 00:00:00.000000000 Z
+date: 2019-07-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: loofah
@@ -21,14 +21,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: 2.2.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: 2.2.1
 - !ruby/object:Gem::Dependency
   name: sax-machine
   requirement: !ruby/object:Gem::Requirement
@@ -136,6 +136,7 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".travis.yml"
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
@@ -146,6 +147,7 @@ files:
 - Rakefile
 - feedjira.gemspec
 - lib/feedjira.rb
+- lib/feedjira/atom_entry_utilities.rb
 - lib/feedjira/configuration.rb
 - lib/feedjira/core_ext.rb
 - lib/feedjira/core_ext/date.rb
@@ -180,6 +182,7 @@ files:
 - lib/feedjira/parser/rss_feed_burner_entry.rb
 - lib/feedjira/parser/rss_image.rb
 - lib/feedjira/preprocessor.rb
+- lib/feedjira/rss_entry_utilities.rb
 - lib/feedjira/version.rb
 - spec/feedjira/configuration_spec.rb
 - spec/feedjira/date_time_utilities_spec.rb
@@ -223,6 +226,7 @@ files:
 - spec/sample_feeds/HuffPostCanada.xml
 - spec/sample_feeds/ITunesWithSingleQuotedAttributes.xml
 - spec/sample_feeds/ITunesWithSpacesInAttributes.xml
+- spec/sample_feeds/InvalidDateFormat.xml
 - spec/sample_feeds/PaulDixExplainsNothing.xml
 - spec/sample_feeds/PaulDixExplainsNothingAlternate.xml
 - spec/sample_feeds/PaulDixExplainsNothingFirstEntryContent.xml
@@ -244,7 +248,10 @@ files:
 homepage: http://feedjira.com
 licenses:
 - MIT
-metadata: {}
+metadata:
+  homepage_uri: http://feedjira.com
+  source_code_uri: https://github.com/feedjira/feedjira
+  changelog_uri: https://github.com/feedjira/feedjira/blob/master/CHANGELOG.md
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -253,15 +260,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.3
+      version: '2.2'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 3.0.1
 signing_key: 
 specification_version: 4
 summary: A feed parsing library
@@ -308,6 +314,7 @@ test_files:
 - spec/sample_feeds/HuffPostCanada.xml
 - spec/sample_feeds/ITunesWithSingleQuotedAttributes.xml
 - spec/sample_feeds/ITunesWithSpacesInAttributes.xml
+- spec/sample_feeds/InvalidDateFormat.xml
 - spec/sample_feeds/PaulDixExplainsNothing.xml
 - spec/sample_feeds/PaulDixExplainsNothingAlternate.xml
 - spec/sample_feeds/PaulDixExplainsNothingFirstEntryContent.xml