feedjira 2.2.0 → 3.1.2

data/spec/feedjira/parser/json_feed_item_spec.rb

@@ -0,0 +1,81 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe Feedjira::Parser::JSONFeedItem do
+  before(:each) do
+    # I don't really like doing it this way because these unit test should only
+    # rely on JSONFeed, but this is actually how it should work. You would
+    # never just pass entry json straight to the JSONFeedItem
+    @entry = Feedjira::Parser::JSONFeed.parse(sample_json_feed).entries.first
+  end
+
+  it "should parse the id" do
+    expect(@entry.id).to eq "http://inessential.com/2017/06/02/james_dempsey_and_the_breakpoints_benefi"
+  end
+
+  it "should parse the url" do
+    expect(@entry.url).to eq "http://inessential.com/2017/06/02/james_dempsey_and_the_breakpoints_benefi"
+  end
+
+  it "should parse the title" do
+    expect(@entry.title).to eq "James Dempsey and the Breakpoints Benefit App Camp for Girls"
+  end
+
+  it "should parse the content" do
+    content = "<p>On Wednesday night I know where I’ll be — playing keyboard for a few songs at the James Dempsey and the Breakpoints concert benefitting App Camp for Girls.</p>\n\n<p><a href=\"https://www.classy.org/events/-/e126329\">You should get tickets</a>. It’s a fun time for a great cause.</p>\n\n<p>Bonus: James writes about how <a href=\"http://jamesdempsey.net/2017/06/02/wwdc-in-san-jose-full-circle/\">this concert is full circle for him</a>. It’s a special night.</p>"
+    expect(@entry.content).to eq content
+  end
+
+  it "should parse the published date" do
+    published = Time.parse_safely "2017-06-02T22:05:47-07:00"
+    expect(@entry.published).to eq published
+  end
+
+  it "should support each" do
+    expect(@entry).to respond_to :each
+  end
+
+  it "should be able to list out all the fields with each" do
+    all_fields = []
+    title_value = ""
+    @entry.each do |field, value|
+      all_fields << field
+      title_value = value if field == "title"
+    end
+
+    expect(title_value).to eq "James Dempsey and the Breakpoints Benefit App Camp for Girls"
+
+    expected_fields = %w[
+      author
+      banner_image
+      categories
+      content
+      entry_id
+      external_url
+      image
+      json
+      published
+      summary
+      title
+      updated
+      url
+    ]
+    expect(all_fields).to match_array expected_fields
+  end
+
+  it "should support checking if a field exists in the entry" do
+    expect(@entry).to include "title"
+    expect(@entry).to include "url"
+  end
+
+  it "should allow access to fields with hash syntax" do
+    expect(@entry["title"]).to eq "James Dempsey and the Breakpoints Benefit App Camp for Girls"
+    expect(@entry["url"]).to eq "http://inessential.com/2017/06/02/james_dempsey_and_the_breakpoints_benefi"
+  end
+
+  it "should allow setting field values with hash syntax" do
+    @entry["title"] = "Foobar"
+    expect(@entry.title).to eq "Foobar"
+  end
+end

data/spec/feedjira/parser/json_feed_spec.rb

@@ -0,0 +1,55 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+module Feedjira
+  module Parser
+    describe ".able_to_parse?" do
+      it "should return true for a JSON feed" do
+        expect(JSONFeed).to be_able_to_parse(sample_json_feed)
+      end
+
+      it "should return false for an RSS feed" do
+        expect(JSONFeed).to_not be_able_to_parse(sample_rss_feed)
+      end
+
+      it "should return false for an Atom feed" do
+        expect(JSONFeed).to_not be_able_to_parse(sample_atom_feed)
+      end
+    end
+
+    describe "parsing" do
+      before(:each) do
+        @feed = JSONFeed.parse(sample_json_feed)
+      end
+
+      it "should parse the version" do
+        expect(@feed.version).to eq "https://jsonfeed.org/version/1"
+      end
+
+      it "should parse the title" do
+        expect(@feed.title).to eq "inessential.com"
+      end
+
+      it "should parse the url" do
+        expect(@feed.url).to eq "http://inessential.com/"
+      end
+
+      it "should parse the feed_url" do
+        expect(@feed.feed_url).to eq "http://inessential.com/feed.json"
+      end
+
+      it "should parse the description" do
+        expect(@feed.description).to eq "Brent Simmons’s weblog."
+      end
+
+      it "should parse expired and return default (nil)" do
+        expect(@feed.expired).to be nil
+      end
+
+      it "should parse entries" do
+        expect(@feed.entries.size).to eq 20
+      end
+    end
+  end
+end

data/spec/feedjira/parser/podlove_chapter_spec.rb

@@ -1,4 +1,6 @@
-require 'spec_helper'
+# frozen_string_literal: true
+
+require "spec_helper"
 
 describe Feedjira::Parser::PodloveChapter do
   before(:each) do
@@ -6,16 +8,16 @@ describe Feedjira::Parser::PodloveChapter do
     @chapter = @item.chapters.first
   end
 
-  it 'should parse chapters' do
+  it "should parse chapters" do
     expect(@item.chapters.size).to eq 15
   end
 
-  it 'should sort chapters by time' do
-    expect(@item.chapters.last.title).to eq 'Abschied'
+  it "should sort chapters by time" do
+    expect(@item.chapters.last.title).to eq "Abschied"
   end
 
-  it 'should parse the start time' do
-    expect(@chapter.start_ntp).to eq '00:00:26.407'
+  it "should parse the start time" do
+    expect(@chapter.start_ntp).to eq "00:00:26.407"
     expect(@chapter.start).to eq 26.407
     expect(@item.chapters[1].start).to eq 50
     expect(@item.chapters[2].start).to eq 59.12
@@ -23,15 +25,15 @@ describe Feedjira::Parser::PodloveChapter do
     expect(@item.chapters.last.start).to eq 5700.034
   end
 
-  it 'should parse the title' do
-    expect(@chapter.title).to eq 'Neil DeGrasse Tyson on Science'
+  it "should parse the title" do
+    expect(@chapter.title).to eq "Neil DeGrasse Tyson on Science"
   end
 
-  it 'should parse the link' do
-    expect(@chapter.url).to eq 'https://example.com'
+  it "should parse the link" do
+    expect(@chapter.url).to eq "https://example.com"
   end
 
-  it 'should parse the image' do
-    expect(@chapter.image).to eq 'https://pics.example.com/pic.png'
+  it "should parse the image" do
+    expect(@chapter.image).to eq "https://pics.example.com/pic.png"
   end
 end

data/spec/feedjira/parser/rss_entry_spec.rb

@@ -1,4 +1,6 @@
-require 'spec_helper'
+# frozen_string_literal: true
+
+require "spec_helper"
 
 describe Feedjira::Parser::RSSEntry do
   before(:each) do
@@ -6,67 +8,67 @@ describe Feedjira::Parser::RSSEntry do
     # rely on RSSEntry, but this is actually how it should work. You would
     # never just pass entry xml straight to the AtomEnry
     @entry = Feedjira::Parser::RSS.parse(sample_rss_feed).entries.first
-    tag = 'wfw:commentRss'
+    tag = "wfw:commentRss"
     Feedjira::Feed.add_common_feed_entry_element tag, as: :comment_rss
   end
 
   after(:each) do
     # We change the title in one or more specs to test []=
-    if @entry.title != 'Nokogiri’s Slop Feature'
+    if @entry.title != "Nokogiri’s Slop Feature"
       feed = Feedjira::Parser::RSS.parse sample_rss_feed
       @entry.title = feed.entries.first.title
     end
   end
 
-  it 'should parse the title' do
-    expect(@entry.title).to eq 'Nokogiri’s Slop Feature'
+  it "should parse the title" do
+    expect(@entry.title).to eq "Nokogiri’s Slop Feature"
   end
 
-  it 'should parse the url' do
-    expect(@entry.url).to eq 'http://tenderlovemaking.com/2008/12/04/nokogiris-slop-feature/'
+  it "should parse the url" do
+    expect(@entry.url).to eq "http://tenderlovemaking.com/2008/12/04/nokogiris-slop-feature/"
   end
 
-  it 'should parse the author' do
-    expect(@entry.author).to eq 'Aaron Patterson'
+  it "should parse the author" do
+    expect(@entry.author).to eq "Aaron Patterson"
   end
 
-  it 'should parse the content' do
+  it "should parse the content" do
     expect(@entry.content).to eq sample_rss_entry_content
   end
 
-  it 'should provide a summary' do
-    summary = "Oops!  When I released nokogiri version 1.0.7, I totally forgot to talk about Nokogiri::Slop() feature that was added.  Why is it called \"slop\"?  It lets you sloppily explore documents.  Basically, it decorates your document with method_missing() that allows you to search your document via method calls.\nGiven this document:\n\ndoc = Nokogiri::Slop(<<-eohtml)\n<html>\n  <body>\n  [...]" # rubocop:disable Metrics/LineLength
+  it "should provide a summary" do
+    summary = "Oops!  When I released nokogiri version 1.0.7, I totally forgot to talk about Nokogiri::Slop() feature that was added.  Why is it called \"slop\"?  It lets you sloppily explore documents.  Basically, it decorates your document with method_missing() that allows you to search your document via method calls.\nGiven this document:\n\ndoc = Nokogiri::Slop(<<-eohtml)\n<html>\n  <body>\n  [...]"
     expect(@entry.summary).to eq summary
   end
 
-  it 'should parse the published date' do
-    published = Time.parse_safely 'Thu Dec 04 17:17:49 UTC 2008'
+  it "should parse the published date" do
+    published = Time.parse_safely "Thu Dec 04 17:17:49 UTC 2008"
     expect(@entry.published).to eq published
   end
 
-  it 'should parse the categories' do
-    expect(@entry.categories).to eq %w(computadora nokogiri rails)
+  it "should parse the categories" do
+    expect(@entry.categories).to eq %w[computadora nokogiri rails]
   end
 
-  it 'should parse the guid as id' do
-    expect(@entry.id).to eq 'http://tenderlovemaking.com/?p=198'
+  it "should parse the guid as id" do
+    expect(@entry.id).to eq "http://tenderlovemaking.com/?p=198"
   end
 
-  it 'should support each' do
+  it "should support each" do
     expect(@entry).to respond_to :each
   end
 
-  it 'should be able to list out all fields with each' do
+  it "should be able to list out all fields with each" do
     all_fields = []
-    title_value = ''
+    title_value = ""
     @entry.each do |field, value|
       all_fields << field
-      title_value = value if field == 'title'
+      title_value = value if field == "title"
     end
 
-    expect(title_value).to eq 'Nokogiri’s Slop Feature'
+    expect(title_value).to eq "Nokogiri’s Slop Feature"
 
-    expected_fields = %w(
+    expected_fields = %w[
       author
       categories
       comment_rss
@@ -76,22 +78,42 @@ describe Feedjira::Parser::RSSEntry do
       summary
       title
       url
-    )
+    ]
     expect(all_fields.sort).to eq expected_fields
   end
 
-  it 'should support checking if a field exists in the entry' do
-    expect(@entry).to include 'title'
-    expect(@entry).to include 'author'
+  it "should support checking if a field exists in the entry" do
+    expect(@entry).to include "title"
+    expect(@entry).to include "author"
+  end
+
+  it "should allow access to fields with hash syntax" do
+    expect(@entry["title"]).to eq "Nokogiri’s Slop Feature"
+    expect(@entry["author"]).to eq "Aaron Patterson"
+  end
+
+  it "should allow setting field values with hash syntax" do
+    @entry["title"] = "Foobar"
+    expect(@entry.title).to eq "Foobar"
+  end
+
+  it "should ignore urls from guids with isPermaLink='false'" do
+    feed = Feedjira.parse(sample_rss_feed_permalinks)
+    expect(feed.entries[0].url).to eq nil
+  end
+
+  it "should get urls from guids with isPermaLink='true'" do
+    feed = Feedjira.parse(sample_rss_feed_permalinks)
+    expect(feed.entries[1].url).to eq "http://example.com/2"
   end
 
-  it 'should allow access to fields with hash syntax' do
-    expect(@entry['title']).to eq 'Nokogiri’s Slop Feature'
-    expect(@entry['author']).to eq 'Aaron Patterson'
+  it "should get urls from guid where isPermaLink is unspecified" do
+    feed = Feedjira.parse(sample_rss_feed_permalinks)
+    expect(feed.entries[2].url).to eq "http://example.com/3"
   end
 
-  it 'should allow setting field values with hash syntax' do
-    @entry['title'] = 'Foobar'
-    expect(@entry.title).to eq 'Foobar'
+  it "should prefer urls from <link> when both guid and link are specified" do
+    feed = Feedjira.parse(sample_rss_feed_permalinks)
+    expect(feed.entries[3].url).to eq "http://example.com/4"
   end
 end

data/spec/feedjira/parser/rss_feed_burner_entry_spec.rb

@@ -1,8 +1,10 @@
-require 'spec_helper'
+# frozen_string_literal: true
+
+require "spec_helper"
 
 describe Feedjira::Parser::RSSFeedBurnerEntry do
   before(:each) do
-    tag = 'wfw:commentRss'
+    tag = "wfw:commentRss"
     Feedjira::Feed.add_common_feed_entry_element(tag, as: :comment_rss)
     # I don't really like doing it this way because these unit test should only
     # rely on RSSEntry, but this is actually how it should work. You would
@@ -13,63 +15,63 @@ describe Feedjira::Parser::RSSFeedBurnerEntry do
 
   after(:each) do
     # We change the title in one or more specs to test []=
-    if @entry.title != 'Angie’s List Sets Price Range IPO At $11 To $13 Per Share; Valued At Over $600M' # rubocop:disable Metrics/LineLength
+    if @entry.title != "Angie’s List Sets Price Range IPO At $11 To $13 Per Share; Valued At Over $600M"
       feed = Feedjira::Parser::RSS.parse sample_rss_feed_burner_feed
       @entry.title = feed.entries.first.title
     end
   end
 
-  it 'should parse the title' do
-    title = 'Angie’s List Sets Price Range IPO At $11 To $13 Per Share; Valued At Over $600M' # rubocop:disable Metrics/LineLength
+  it "should parse the title" do
+    title = "Angie’s List Sets Price Range IPO At $11 To $13 Per Share; Valued At Over $600M"
     expect(@entry.title).to eq title
   end
 
-  it 'should parse the original url' do
-    expect(@entry.url).to eq 'http://techcrunch.com/2011/11/02/angies-list-prices-ipo-at-11-to-13-per-share-valued-at-over-600m/'
+  it "should parse the original url" do
+    expect(@entry.url).to eq "http://techcrunch.com/2011/11/02/angies-list-prices-ipo-at-11-to-13-per-share-valued-at-over-600m/"
   end
 
-  it 'should parse the author' do
-    expect(@entry.author).to eq 'Leena Rao'
+  it "should parse the author" do
+    expect(@entry.author).to eq "Leena Rao"
   end
 
-  it 'should parse the content' do
+  it "should parse the content" do
     expect(@entry.content).to eq sample_rss_feed_burner_entry_content
   end
 
-  it 'should provide a summary' do
+  it "should provide a summary" do
     expect(@entry.summary).to eq sample_rss_feed_burner_entry_description
   end
 
-  it 'should parse the published date' do
-    published = Time.parse_safely 'Wed Nov 02 17:25:27 UTC 2011'
+  it "should parse the published date" do
+    published = Time.parse_safely "Wed Nov 02 17:25:27 UTC 2011"
     expect(@entry.published).to eq published
   end
 
-  it 'should parse the categories' do
-    expect(@entry.categories).to eq ['TC', "angie\\'s list"]
+  it "should parse the categories" do
+    expect(@entry.categories).to eq ["TC", "angie\\'s list"]
   end
 
-  it 'should parse the guid as id' do
-    expect(@entry.id).to eq 'http://techcrunch.com/?p=446154'
+  it "should parse the guid as id" do
+    expect(@entry.id).to eq "http://techcrunch.com/?p=446154"
   end
 
-  it 'should support each' do
+  it "should support each" do
     expect(@entry).to respond_to :each
   end
 
-  it 'should be able to list out all fields with each' do
+  it "should be able to list out all fields with each" do
     all_fields = []
-    title_value = ''
+    title_value = ""
 
     @entry.each do |field, value|
       all_fields << field
-      title_value = value if field == 'title'
+      title_value = value if field == "title"
     end
 
-    title = 'Angie’s List Sets Price Range IPO At $11 To $13 Per Share; Valued At Over $600M' # rubocop:disable Metrics/LineLength
+    title = "Angie’s List Sets Price Range IPO At $11 To $13 Per Share; Valued At Over $600M"
     expect(title_value).to eq title
 
-    expected_fields = %w(
+    expected_fields = %w[
       author
       categories
       comment_rss
@@ -80,23 +82,23 @@ describe Feedjira::Parser::RSSFeedBurnerEntry do
       summary
       title
       url
-    )
+    ]
     expect(all_fields.sort).to eq expected_fields
   end
 
-  it 'should support checking if a field exists in the entry' do
-    expect(@entry).to include 'author'
-    expect(@entry).to include 'title'
+  it "should support checking if a field exists in the entry" do
+    expect(@entry).to include "author"
+    expect(@entry).to include "title"
   end
 
-  it 'should allow access to fields with hash syntax' do
-    expect(@entry['author']).to eq 'Leena Rao'
-    title = 'Angie’s List Sets Price Range IPO At $11 To $13 Per Share; Valued At Over $600M' # rubocop:disable Metrics/LineLength
-    expect(@entry['title']).to eq title
+  it "should allow access to fields with hash syntax" do
+    expect(@entry["author"]).to eq "Leena Rao"
+    title = "Angie’s List Sets Price Range IPO At $11 To $13 Per Share; Valued At Over $600M"
+    expect(@entry["title"]).to eq title
   end
 
-  it 'should allow setting field values with hash syntax' do
-    @entry['title'] = 'Foobar'
-    expect(@entry.title).to eq 'Foobar'
+  it "should allow setting field values with hash syntax" do
+    @entry["title"] = "Foobar"
+    expect(@entry.title).to eq "Foobar"
   end
 end