feedjira 2.0.0 → 2.2.0

data/spec/feedjira/parser/itunes_rss_spec.rb

@@ -1,62 +1,119 @@
-require File.join(File.dirname(__FILE__), %w[.. .. spec_helper])
+require 'spec_helper'
 
-describe Feedjira::Parser::ITunesRSS do
-  describe "#will_parse?" do
-    it "should return true for an itunes RSS feed" do
-      expect(Feedjira::Parser::ITunesRSS).to be_able_to_parse(sample_itunes_feed)
+module Feedjira::Parser
+  describe '#will_parse?' do
+    it 'should return true for an itunes RSS feed' do
+      expect(ITunesRSS).to be_able_to_parse(sample_itunes_feed)
     end
 
-    it "should return true for an itunes RSS feed with spaces between attribute names, equals sign, and values" do
-      expect(Feedjira::Parser::ITunesRSS).to be_able_to_parse(sample_itunes_feed_with_spaces)
+    it 'should return true for an itunes RSS feed with spaces between attribute names, equals sign, and values' do # rubocop:disable Metrics/LineLength
+      expect(ITunesRSS).to be_able_to_parse(sample_itunes_feed_with_spaces)
     end
 
-    it "should return fase for an atom feed" do
-      expect(Feedjira::Parser::ITunesRSS).to_not be_able_to_parse(sample_atom_feed)
+    it 'should return true for an itunes RSS feed with single-quoted attributes' do # rubocop:disable Metrics/LineLength
+      expect(ITunesRSS).to be_able_to_parse(sample_itunes_feed_with_single_quotes)  # rubocop:disable Metrics/LineLength
     end
 
-    it "should return false for an rss feedburner feed" do
-      expect(Feedjira::Parser::ITunesRSS).to_not be_able_to_parse(sample_rss_feed_burner_feed)
+    it 'should return fase for an atom feed' do
+      expect(ITunesRSS).to_not be_able_to_parse(sample_atom_feed)
+    end
+
+    it 'should return false for an rss feedburner feed' do
+      expect(ITunesRSS).to_not be_able_to_parse(sample_rss_feed_burner_feed)
     end
   end
 
-  describe "parsing" do
+  describe 'parsing' do
     before(:each) do
-      @feed = Feedjira::Parser::ITunesRSS.parse(sample_itunes_feed)
+      @feed = ITunesRSS.parse(sample_itunes_feed)
+    end
+
+    it 'should parse the ttl' do
+      expect(@feed.ttl).to eq '60'
+    end
+
+    it 'should parse the last build date' do
+      expect(@feed.last_built).to eq 'Sat, 07 Sep 2002 09:42:31 GMT'
     end
 
-    it "should parse the subtitle" do
-      expect(@feed.itunes_subtitle).to eq "A show about everything"
+    it 'should parse the subtitle' do
+      expect(@feed.itunes_subtitle).to eq 'A show about everything'
     end
 
-    it "should parse the author" do
-      expect(@feed.itunes_author).to eq "John Doe"
+    it 'should parse the author' do
+      expect(@feed.itunes_author).to eq 'John Doe'
     end
 
-    it "should parse an owner" do
+    it 'should parse an owner' do
       expect(@feed.itunes_owners.size).to eq 1
     end
 
-    it "should parse an image" do
-      expect(@feed.itunes_image).to eq "http://example.com/podcasts/everything/AllAboutEverything.jpg"
+    it 'should parse an image' do
+      expect(@feed.itunes_image).to eq 'http://example.com/podcasts/everything/AllAboutEverything.jpg'
+    end
+
+    it 'should parse the image url' do
+      expect(@feed.image.url).to eq 'http://example.com/podcasts/everything/AllAboutEverything.jpg'
+    end
+
+    it 'should parse the image title' do
+      expect(@feed.image.title).to eq 'All About Everything'
+    end
+
+    it 'should parse the image link' do
+      expect(@feed.image.link).to eq 'http://www.example.com/podcasts/everything/index.html'
+    end
+
+    it 'should parse the image width' do
+      expect(@feed.image.width).to eq '88'
+    end
+
+    it 'should parse the image height' do
+      expect(@feed.image.height).to eq '31'
+    end
+
+    it 'should parse the image description' do
+      description = 'All About Everything is a show about everything. Each week we dive into any subject known to man and talk about it as much as we can. Look for our Podcast in the iTunes Music Store' # rubocop:disable Metrics/LineLength
+      expect(@feed.image.description).to eq description
+    end
+
+    it 'should parse categories' do
+      expect(@feed.itunes_categories).to eq [
+        'Technology',
+        'Gadgets',
+        'TV & Film',
+        'Arts',
+        'Design',
+        'Food'
+      ]
+
+      expect(@feed.itunes_category_paths).to eq [
+        %w(Technology Gadgets),
+        ['TV & Film'],
+        %w(Arts Design),
+        %w(Arts Food)
+      ]
+    end
+
+    it 'should parse the itunes type' do
+      expect(@feed.itunes_type).to eq 'episodic'
     end
 
-    it "should parse categories" do
-      expect(@feed.itunes_categories.size).to eq 3
-      expect(@feed.itunes_categories[0]).to eq "Technology"
-      expect(@feed.itunes_categories[1]).to eq "Gadgets"
-      expect(@feed.itunes_categories[2]).to eq "TV & Film"
+    it 'should parse the summary' do
+      summary = 'All About Everything is a show about everything. Each week we dive into any subject known to man and talk about it as much as we can. Look for our Podcast in the iTunes Music Store' # rubocop:disable Metrics/LineLength
+      expect(@feed.itunes_summary).to eq summary
     end
 
-    it "should parse the summary" do
-      expect(@feed.itunes_summary).to eq "All About Everything is a show about everything. Each week we dive into any subject known to man and talk about it as much as we can. Look for our Podcast in the iTunes Music Store"
+    it 'should parse the complete tag' do
+      expect(@feed.itunes_complete).to eq 'yes'
     end
 
-    it "should parse entries" do
+    it 'should parse entries' do
       expect(@feed.entries.size).to eq 3
     end
 
-    it "should parse the new-feed-url" do
-      expect(@feed.itunes_new_feed_url).to eq "http://example.com/new.xml"
+    it 'should parse the new-feed-url' do
+      expect(@feed.itunes_new_feed_url).to eq 'http://example.com/new.xml'
     end
   end
 end

data/spec/feedjira/parser/podlove_chapter_spec.rb

@@ -0,0 +1,37 @@
+require 'spec_helper'
+
+describe Feedjira::Parser::PodloveChapter do
+  before(:each) do
+    @item = Feedjira::Parser::ITunesRSS.parse(sample_podlove_feed).entries.first
+    @chapter = @item.chapters.first
+  end
+
+  it 'should parse chapters' do
+    expect(@item.chapters.size).to eq 15
+  end
+
+  it 'should sort chapters by time' do
+    expect(@item.chapters.last.title).to eq 'Abschied'
+  end
+
+  it 'should parse the start time' do
+    expect(@chapter.start_ntp).to eq '00:00:26.407'
+    expect(@chapter.start).to eq 26.407
+    expect(@item.chapters[1].start).to eq 50
+    expect(@item.chapters[2].start).to eq 59.12
+    expect(@item.chapters[3].start).to eq 89.201
+    expect(@item.chapters.last.start).to eq 5700.034
+  end
+
+  it 'should parse the title' do
+    expect(@chapter.title).to eq 'Neil DeGrasse Tyson on Science'
+  end
+
+  it 'should parse the link' do
+    expect(@chapter.url).to eq 'https://example.com'
+  end
+
+  it 'should parse the image' do
+    expect(@chapter.image).to eq 'https://pics.example.com/pic.png'
+  end
+end

data/spec/feedjira/parser/rss_entry_spec.rb

@@ -1,80 +1,97 @@
-# coding: utf-8
-require File.join(File.dirname(__FILE__), %w[.. .. spec_helper])
+require 'spec_helper'
 
 describe Feedjira::Parser::RSSEntry do
   before(:each) do
-    # I don't really like doing it this way because these unit test should only rely on RSSEntry,
-    # but this is actually how it should work. You would never just pass entry xml straight to the AtomEnry
+    # I don't really like doing it this way because these unit test should only
+    # rely on RSSEntry, but this is actually how it should work. You would
+    # never just pass entry xml straight to the AtomEnry
     @entry = Feedjira::Parser::RSS.parse(sample_rss_feed).entries.first
-    Feedjira::Feed.add_common_feed_entry_element("wfw:commentRss", :as => :comment_rss)
+    tag = 'wfw:commentRss'
+    Feedjira::Feed.add_common_feed_entry_element tag, as: :comment_rss
   end
 
   after(:each) do
     # We change the title in one or more specs to test []=
-    if @entry.title != "Nokogiri’s Slop Feature"
-      @entry.title = Feedjira::Parser::RSS.parse(sample_rss_feed).entries.first.title
+    if @entry.title != 'Nokogiri’s Slop Feature'
+      feed = Feedjira::Parser::RSS.parse sample_rss_feed
+      @entry.title = feed.entries.first.title
     end
   end
 
-  it "should parse the title" do
-    expect(@entry.title).to eq "Nokogiri’s Slop Feature"
+  it 'should parse the title' do
+    expect(@entry.title).to eq 'Nokogiri’s Slop Feature'
   end
 
-  it "should parse the url" do
-    expect(@entry.url).to eq "http://tenderlovemaking.com/2008/12/04/nokogiris-slop-feature/"
+  it 'should parse the url' do
+    expect(@entry.url).to eq 'http://tenderlovemaking.com/2008/12/04/nokogiris-slop-feature/'
   end
 
-  it "should parse the author" do
-    expect(@entry.author).to eq "Aaron Patterson"
+  it 'should parse the author' do
+    expect(@entry.author).to eq 'Aaron Patterson'
   end
 
-  it "should parse the content" do
+  it 'should parse the content' do
     expect(@entry.content).to eq sample_rss_entry_content
   end
 
-  it "should provide a summary" do
-    expect(@entry.summary).to eq "Oops!  When I released nokogiri version 1.0.7, I totally forgot to talk about Nokogiri::Slop() feature that was added.  Why is it called \"slop\"?  It lets you sloppily explore documents.  Basically, it decorates your document with method_missing() that allows you to search your document via method calls.\nGiven this document:\n\ndoc = Nokogiri::Slop(<<-eohtml)\n<html>\n  <body>\n  [...]"
+  it 'should provide a summary' do
+    summary = "Oops!  When I released nokogiri version 1.0.7, I totally forgot to talk about Nokogiri::Slop() feature that was added.  Why is it called \"slop\"?  It lets you sloppily explore documents.  Basically, it decorates your document with method_missing() that allows you to search your document via method calls.\nGiven this document:\n\ndoc = Nokogiri::Slop(<<-eohtml)\n<html>\n  <body>\n  [...]" # rubocop:disable Metrics/LineLength
+    expect(@entry.summary).to eq summary
   end
 
-  it "should parse the published date" do
-    expect(@entry.published).to eq Time.parse_safely("Thu Dec 04 17:17:49 UTC 2008")
+  it 'should parse the published date' do
+    published = Time.parse_safely 'Thu Dec 04 17:17:49 UTC 2008'
+    expect(@entry.published).to eq published
   end
 
-  it "should parse the categories" do
-    expect(@entry.categories).to eq ['computadora', 'nokogiri', 'rails']
+  it 'should parse the categories' do
+    expect(@entry.categories).to eq %w(computadora nokogiri rails)
   end
 
-  it "should parse the guid as id" do
-    expect(@entry.id).to eq "http://tenderlovemaking.com/?p=198"
+  it 'should parse the guid as id' do
+    expect(@entry.id).to eq 'http://tenderlovemaking.com/?p=198'
   end
 
-  it "should support each" do
+  it 'should support each' do
     expect(@entry).to respond_to :each
   end
 
-  it "should be able to list out all fields with each" do
+  it 'should be able to list out all fields with each' do
     all_fields = []
     title_value = ''
     @entry.each do |field, value|
       all_fields << field
       title_value = value if field == 'title'
     end
-    expect(all_fields.sort).to eq ["author", "categories", "comment_rss", "content", "entry_id", "published", "summary", "title", "url"]
-    expect(title_value).to eq "Nokogiri’s Slop Feature"
+
+    expect(title_value).to eq 'Nokogiri’s Slop Feature'
+
+    expected_fields = %w(
+      author
+      categories
+      comment_rss
+      content
+      entry_id
+      published
+      summary
+      title
+      url
+    )
+    expect(all_fields.sort).to eq expected_fields
   end
 
-  it "should support checking if a field exists in the entry" do
+  it 'should support checking if a field exists in the entry' do
     expect(@entry).to include 'title'
     expect(@entry).to include 'author'
   end
 
-  it "should allow access to fields with hash syntax" do
-    expect(@entry['title']).to eq "Nokogiri’s Slop Feature"
-    expect(@entry['author']).to eq "Aaron Patterson"
+  it 'should allow access to fields with hash syntax' do
+    expect(@entry['title']).to eq 'Nokogiri’s Slop Feature'
+    expect(@entry['author']).to eq 'Aaron Patterson'
   end
 
-  it "should allow setting field values with hash syntax" do
-    @entry['title'] = "Foobar"
-    expect(@entry.title).to eq "Foobar"
+  it 'should allow setting field values with hash syntax' do
+    @entry['title'] = 'Foobar'
+    expect(@entry.title).to eq 'Foobar'
   end
 end

data/spec/feedjira/parser/rss_feed_burner_entry_spec.rb

@@ -1,80 +1,102 @@
-# coding: utf-8
-require File.join(File.dirname(__FILE__), %w[.. .. spec_helper])
+require 'spec_helper'
 
 describe Feedjira::Parser::RSSFeedBurnerEntry do
   before(:each) do
-    # I don't really like doing it this way because these unit test should only rely on RSSEntry,
-    # but this is actually how it should work. You would never just pass entry xml straight to the AtomEnry
-    @entry = Feedjira::Parser::RSSFeedBurner.parse(sample_rss_feed_burner_feed).entries.first
-    Feedjira::Feed.add_common_feed_entry_element("wfw:commentRss", :as => :comment_rss)
+    tag = 'wfw:commentRss'
+    Feedjira::Feed.add_common_feed_entry_element(tag, as: :comment_rss)
+    # I don't really like doing it this way because these unit test should only
+    # rely on RSSEntry, but this is actually how it should work. You would
+    # never just pass entry xml straight to the AtomEnry
+    feed = Feedjira::Parser::RSSFeedBurner.parse sample_rss_feed_burner_feed
+    @entry = feed.entries.first
   end
 
   after(:each) do
     # We change the title in one or more specs to test []=
-    if @entry.title != "Angie’s List Sets Price Range IPO At $11 To $13 Per Share; Valued At Over $600M"
-      @entry.title = Feedjira::Parser::RSS.parse(sample_rss_feed_burner_feed).entries.first.title
+    if @entry.title != 'Angie’s List Sets Price Range IPO At $11 To $13 Per Share; Valued At Over $600M' # rubocop:disable Metrics/LineLength
+      feed = Feedjira::Parser::RSS.parse sample_rss_feed_burner_feed
+      @entry.title = feed.entries.first.title
     end
   end
 
-  it "should parse the title" do
-    expect(@entry.title).to eq "Angie’s List Sets Price Range IPO At $11 To $13 Per Share; Valued At Over $600M"
+  it 'should parse the title' do
+    title = 'Angie’s List Sets Price Range IPO At $11 To $13 Per Share; Valued At Over $600M' # rubocop:disable Metrics/LineLength
+    expect(@entry.title).to eq title
   end
 
-  it "should parse the original url" do
-    expect(@entry.url).to eq "http://techcrunch.com/2011/11/02/angies-list-prices-ipo-at-11-to-13-per-share-valued-at-over-600m/"
+  it 'should parse the original url' do
+    expect(@entry.url).to eq 'http://techcrunch.com/2011/11/02/angies-list-prices-ipo-at-11-to-13-per-share-valued-at-over-600m/'
   end
 
-  it "should parse the author" do
-    expect(@entry.author).to eq "Leena Rao"
+  it 'should parse the author' do
+    expect(@entry.author).to eq 'Leena Rao'
   end
 
-  it "should parse the content" do
+  it 'should parse the content' do
     expect(@entry.content).to eq sample_rss_feed_burner_entry_content
   end
 
-  it "should provide a summary" do
+  it 'should provide a summary' do
     expect(@entry.summary).to eq sample_rss_feed_burner_entry_description
   end
 
-  it "should parse the published date" do
-    expect(@entry.published).to eq Time.parse_safely("Wed Nov 02 17:25:27 UTC 2011")
+  it 'should parse the published date' do
+    published = Time.parse_safely 'Wed Nov 02 17:25:27 UTC 2011'
+    expect(@entry.published).to eq published
   end
 
-  it "should parse the categories" do
-    expect(@entry.categories).to eq ["TC", "angie\\'s list"]
+  it 'should parse the categories' do
+    expect(@entry.categories).to eq ['TC', "angie\\'s list"]
   end
 
-  it "should parse the guid as id" do
-    expect(@entry.id).to eq "http://techcrunch.com/?p=446154"
+  it 'should parse the guid as id' do
+    expect(@entry.id).to eq 'http://techcrunch.com/?p=446154'
   end
 
-  it "should support each" do
+  it 'should support each' do
     expect(@entry).to respond_to :each
   end
 
-  it "should be able to list out all fields with each" do
+  it 'should be able to list out all fields with each' do
     all_fields = []
     title_value = ''
+
     @entry.each do |field, value|
       all_fields << field
       title_value = value if field == 'title'
     end
-    expect(all_fields.sort).to eq ["author", "categories", "comment_rss", "content", "entry_id", "image", "published", "summary", "title", "url"]
-    expect(title_value).to eq "Angie’s List Sets Price Range IPO At $11 To $13 Per Share; Valued At Over $600M"
+
+    title = 'Angie’s List Sets Price Range IPO At $11 To $13 Per Share; Valued At Over $600M' # rubocop:disable Metrics/LineLength
+    expect(title_value).to eq title
+
+    expected_fields = %w(
+      author
+      categories
+      comment_rss
+      content
+      entry_id
+      image
+      published
+      summary
+      title
+      url
+    )
+    expect(all_fields.sort).to eq expected_fields
   end
 
-  it "should support checking if a field exists in the entry" do
+  it 'should support checking if a field exists in the entry' do
     expect(@entry).to include 'author'
     expect(@entry).to include 'title'
   end
 
-  it "should allow access to fields with hash syntax" do
-    expect(@entry['author']).to eq "Leena Rao"
-    expect(@entry['title']).to eq "Angie’s List Sets Price Range IPO At $11 To $13 Per Share; Valued At Over $600M"
+  it 'should allow access to fields with hash syntax' do
+    expect(@entry['author']).to eq 'Leena Rao'
+    title = 'Angie’s List Sets Price Range IPO At $11 To $13 Per Share; Valued At Over $600M' # rubocop:disable Metrics/LineLength
+    expect(@entry['title']).to eq title
   end
 
-  it "should allow setting field values with hash syntax" do
-    @entry['title'] = "Foobar"
-    expect(@entry.title).to eq "Foobar"
+  it 'should allow setting field values with hash syntax' do
+    @entry['title'] = 'Foobar'
+    expect(@entry.title).to eq 'Foobar'
   end
 end

data/spec/feedjira/parser/rss_feed_burner_spec.rb

@@ -1,56 +1,61 @@
-require File.join(File.dirname(__FILE__), %w[.. .. spec_helper])
+require 'spec_helper'
 
-describe Feedjira::Parser::RSSFeedBurner do
-  describe "#will_parse?" do
-    it "should return true for a feedburner rss feed" do
-      expect(Feedjira::Parser::RSSFeedBurner).to be_able_to_parse(sample_rss_feed_burner_feed)
+module Feedjira::Parser
+  describe '#will_parse?' do
+    it 'should return true for a feedburner rss feed' do
+      expect(RSSFeedBurner).to be_able_to_parse sample_rss_feed_burner_feed
     end
 
-    it "should return false for a regular RSS feed" do
-       expect(Feedjira::Parser::RSSFeedBurner).to_not be_able_to_parse(sample_rss_feed)
-     end
+    it 'should return false for a regular RSS feed' do
+      expect(RSSFeedBurner).to_not be_able_to_parse sample_rss_feed
+    end
 
-    it "should return false for a feedburner atom feed" do
-      expect(Feedjira::Parser::RSSFeedBurner).to_not be_able_to_parse(sample_feedburner_atom_feed)
+    it 'should return false for a feedburner atom feed' do
+      expect(RSSFeedBurner).to_not be_able_to_parse sample_feedburner_atom_feed
     end
 
-    it "should return false for an rdf feed" do
-      expect(Feedjira::Parser::RSSFeedBurner).to_not be_able_to_parse(sample_rdf_feed)
+    it 'should return false for an rdf feed' do
+      expect(RSSFeedBurner).to_not be_able_to_parse sample_rdf_feed
     end
 
-    it "should return false for a regular atom feed" do
-      expect(Feedjira::Parser::RSSFeedBurner).to_not be_able_to_parse(sample_atom_feed)
+    it 'should return false for a regular atom feed' do
+      expect(RSSFeedBurner).to_not be_able_to_parse sample_atom_feed
     end
   end
 
-  describe "parsing" do
+  describe 'parsing' do
     before(:each) do
-      @feed = Feedjira::Parser::RSSFeedBurner.parse(sample_rss_feed_burner_feed)
+      @feed = RSSFeedBurner.parse(sample_rss_feed_burner_feed)
+    end
+
+    it 'should parse the title' do
+      expect(@feed.title).to eq 'TechCrunch'
     end
 
-    it "should parse the title" do
-      expect(@feed.title).to eq "TechCrunch"
+    it 'should parse the description' do
+      description = 'TechCrunch is a group-edited blog that profiles the companies, products and events defining and transforming the new web.' # rubocop:disable Metrics/LineLength
+      expect(@feed.description).to eq description
     end
 
-    it "should parse the description" do
-      expect(@feed.description).to eq "TechCrunch is a group-edited blog that profiles the companies, products and events defining and transforming the new web."
+    it 'should parse the url' do
+      expect(@feed.url).to eq 'http://techcrunch.com'
     end
 
-    it "should parse the url" do
-      expect(@feed.url).to eq "http://techcrunch.com"
+    it 'should parse the last build date' do
+      expect(@feed.last_built).to eq 'Wed, 02 Nov 2011 17:29:59 +0000'
     end
 
-    it "should parse the hub urls" do
+    it 'should parse the hub urls' do
       expect(@feed.hubs.count).to eq 2
-      expect(@feed.hubs.first).to eq "http://pubsubhubbub.appspot.com/"
+      expect(@feed.hubs.first).to eq 'http://pubsubhubbub.appspot.com/'
     end
 
-    it "should provide an accessor for the feed_url" do
+    it 'should provide an accessor for the feed_url' do
       expect(@feed).to respond_to :feed_url
       expect(@feed).to respond_to :feed_url=
     end
 
-    it "should parse entries" do
+    it 'should parse entries' do
       expect(@feed.entries.size).to eq 20
     end
   end