feedjira 1.3.1 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cb898f19dc7be13765ab349587164a43dafcfd02
-  data.tar.gz: 863ea9ce83f9389dd075e851a00e9e330aa0ea6b
+  metadata.gz: b88451721d838b83ae68e58043481e104794532a
+  data.tar.gz: 21e9e6e48a552ced54dd1e8129b4cf10d7e64659
 SHA512:
-  metadata.gz: 5566f914b0fb53b972f71eb4d3d78b0b42a0f04fca73b9166b4477e3a1324a897275654b363bbb23d3a1330688b44841a380804ebaad6dd04599ac4e21de5f44
-  data.tar.gz: a3d0592700a2529aaf3602659e556ce809395042d4d3b92332454bf102238fed5ed0f44b026ff29a99341297bda19aa0cbdc33d72595f5bd7858fb9d8e8dcb05
+  metadata.gz: f2fc99f45a03df848dc588481d75a84963a782f8555fb3a321397c6f12a67cc66b2bbde226c46a34fb9fcedf9b197d7d23933b6e5fc89ba80fd29f31ccd4c374
+  data.tar.gz: f5492b704021be34b4ea414c1b7697aa3b0fd72a18e26eee887c58d65a3322afac186daba0d786929011f92f8c3537df60c1b2047736a91b1aa78a519e495cad

data/.travis.yml

@@ -11,3 +11,8 @@ rvm:
   - 2.0.0
   - 2.1.0
   - rbx-2
+
+env:
+  matrix:
+    - HANDLER="nokogiri"
+    - HANDLER="ox"

data/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Feedjira Changelog
 
+## 1.4.0
+
+* General
+  * Test OX on Travis
+  * Loosen dependency requirements
+
+* Enhancements
+  * Upgrade to SaxMachine 1 [#234][]
+  * Upgrade to Rspec 3
+  * Move lstrip before preprocess [#216][]
+
+[#216]: https://github.com/feedjira/feedjira/pull/216
+[#234]: https://github.com/feedjira/feedjira/pull/234
+
 ## 1.3.1
 
 * Bug fixes

data/Gemfile

@@ -6,4 +6,5 @@ gem 'pry'
 
 group :test do
   gem 'rake'
+  gem 'ox'
 end

data/feedjira.gemspec

@@ -19,9 +19,9 @@ Gem::Specification.new do |s|
 
   s.platform = Gem::Platform::RUBY
 
-  s.add_dependency 'sax-machine', '~> 0.2.1'
-  s.add_dependency 'curb',        '~> 0.8.1'
-  s.add_dependency 'loofah',      '~> 2.0.0'
+  s.add_dependency 'sax-machine', '~> 1.0'
+  s.add_dependency 'curb',        '~> 0.8'
+  s.add_dependency 'loofah',      '~> 2.0'
 
-  s.add_development_dependency 'rspec', '~> 2.14.0'
+  s.add_development_dependency 'rspec', '~> 3.0'
 end

data/lib/feedjira/feed_utilities.rb

@@ -11,8 +11,9 @@ module Feedjira
 
     module ClassMethods
       def parse(xml, &block)
+        xml = xml.lstrip
         xml = preprocess(xml) if preprocess_xml
-        super xml.lstrip, &block
+        super xml, &block
       end
 
       def preprocess(xml)

data/lib/feedjira/version.rb

@@ -1,3 +1,3 @@
 module Feedjira
-  VERSION = '1.3.1'
+  VERSION = '1.4.0'
 end

data/spec/feedjira/feed_entry_utilities_spec.rb

@@ -10,14 +10,14 @@ describe Feedjira::FeedUtilities do
   describe "handling dates" do
     it "should parse an ISO 8601 formatted datetime into Time" do
       time = @klass.new.parse_datetime("2008-02-20T8:05:00-010:00")
-      time.class.should == Time
-      time.should == Time.parse_safely("Wed Feb 20 18:05:00 UTC 2008")
+      expect(time.class).to eq Time
+      expect(time).to eq Time.parse_safely("Wed Feb 20 18:05:00 UTC 2008")
     end
 
     it "should parse a ISO 8601 with milliseconds into Time" do
       time = @klass.new.parse_datetime("2013-09-17T08:20:13.931-04:00")
-      time.class.should == Time
-      time.should == Time.parse_safely("Tue Sep 17 12:20:13 UTC 2013")
+      expect(time.class).to eq Time
+      expect(time).to eq Time.parse_safely("Tue Sep 17 12:20:13 UTC 2013")
     end
   end
 
@@ -28,20 +28,20 @@ describe Feedjira::FeedUtilities do
     end
 
     it "doesn't fail when no elements are defined on includer" do
-      expect { @klass.new.sanitize!  }.to_not raise_error
+      expect { @klass.new.sanitize! }.to_not raise_error
     end
 
     it "should provide a sanitized title" do
       new_title = "<script>this is not safe</script>" + @entry.title
       @entry.title = new_title
-      @entry.title.sanitize.should == Loofah.scrub_fragment(new_title, :prune).to_s
+      expect(@entry.title.sanitize).to eq Loofah.scrub_fragment(new_title, :prune).to_s
     end
 
     it "should sanitize content in place" do
       new_content = "<script>" + @entry.content
       @entry.content = new_content.dup
-      @entry.content.sanitize!.should == Loofah.scrub_fragment(new_content, :prune).to_s
-      @entry.content.should == Loofah.scrub_fragment(new_content, :prune).to_s
+      expect(@entry.content.sanitize!).to eq Loofah.scrub_fragment(new_content, :prune).to_s
+      expect(@entry.content).to eq Loofah.scrub_fragment(new_content, :prune).to_s
     end
 
     it "should sanitize things in place" do
@@ -54,9 +54,9 @@ describe Feedjira::FeedUtilities do
       cleaned_content = Loofah.scrub_fragment(@entry.content, :prune).to_s
 
       @entry.sanitize!
-      @entry.title.should   == cleaned_title
-      @entry.author.should  == cleaned_author
-      @entry.content.should == cleaned_content
+      expect(@entry.title).to   eq cleaned_title
+      expect(@entry.author).to  eq cleaned_author
+      expect(@entry.content).to eq cleaned_content
     end
   end
 end