feeder 0.3.0 → 0.5.1

data/spec/factories/feeder/items.rb

@@ -0,0 +1,10 @@
+FactoryGirl.define do
+
+  factory :feeder_item, class: 'Feeder::Item' do
+    feedable nil
+
+    trait(:published) { published_at 1.day.ago }
+    trait(:sticky)    { sticky true }
+  end
+
+end

data/spec/lib/feeder/concerns/feedable_spec.rb

@@ -0,0 +1,33 @@
+require 'spec_helper'
+
+describe Feeder::Concerns::Feedable do
+  subject { Message.new }
+
+  it 'responds to sticky' do
+    expect(subject).to respond_to :sticky
+  end
+
+  it 'responds to sticky='  do
+    expect(subject).to respond_to :sticky=
+  end
+
+  context 'with a feeder item' do
+    before do
+      expect(subject).to receive(:feeder_item).and_return(double sticky: true).at_least(1).times
+    end
+
+    it 'delegates sticky to it' do
+      expect(subject.sticky).to eq true
+    end
+  end
+
+  context 'without a feeder item' do
+    before do
+      expect(subject).to receive(:feeder_item).and_return(nil).at_least(1).times
+    end
+
+    it 'mainstains state internally' do
+      expect(subject.sticky).to eq false
+    end
+  end
+end

data/spec/lib/feeder/configuration_spec.rb

@@ -2,18 +2,18 @@ require 'spec_helper'
 
 describe Feeder::Configuration do
   it "sets the observers to an empty array upon initialization" do
-    expect(subject.observables).to eq [ ]
+    expect(subject.observables).to eq({})
   end
 
-  it "sets a default sort order upon initialization" do
-    expect(subject.sort_order).to eq({ created_at: :desc })
+  it "sets default scopes order upon initialization" do
+    expect(subject.scopes.count).to eq 1
   end
 
-  describe "#add_observable" do
+  describe ".observe" do
     it "adds an observable to @observables" do
-      subject.add_observable "SomeObservable"
+      subject.observe "SomeObservable"
 
-      expect(subject.observables).to match_array [ "SomeObservable" ]
+      expect(subject.observables).to eq({ "SomeObservable" => {} })
     end
   end
 end

data/spec/lib/feeder_spec.rb

@@ -7,8 +7,8 @@ describe Feeder do
 
   describe ".configure" do
     context "when no block is given" do
-      it "raises an error" do
-        expect { subject.configure }.to raise_error ArgumentError
+      it "does nothing" do
+        expect(subject.configure).to be nil
       end
     end
 
@@ -20,4 +20,16 @@ describe Feeder do
       end
     end
   end
+
+  describe '.temporarily' do
+    it 'sets temporary configuration options' do
+      expect(Feeder.config.scopes.count).to eq 1
+
+      Feeder.temporarily scopes: [] do
+        expect(Feeder.config.scopes.count).to eq 0
+      end
+
+      expect(Feeder.config.scopes.count).to eq 1
+    end
+  end
 end

data/spec/models/feeder/feedable_observer_spec.rb

@@ -0,0 +1,95 @@
+require 'spec_helper'
+
+describe Feeder::FeedableObserver do
+  subject { described_class.instance }
+
+  let(:message) { create :message }
+
+  around do |example|
+    Timecop.freeze Time.now do
+      example.run
+    end
+  end
+
+  describe '.after_save' do
+    context 'with a message that is no longer sticky' do
+      let(:message) { create :message, sticky: true }
+
+      before do
+        subject.after_create message
+
+        message.update sticky: false
+
+        subject.after_save message
+      end
+
+      it 'should update the feeder item to no longer be sticky' do
+        expect(message.feeder_item.sticky).to eq false
+      end
+    end
+  end
+
+  describe '.after_create' do
+    before do
+      subject.after_create message
+    end
+
+    it 'creates a new feed item' do
+      expect(Feeder::Item.count).to eq 1
+    end
+
+    it 'refers to the feedable' do
+      expect(Feeder::Item.last.feedable).to eq message
+    end
+
+    it 'mirrors the created time' do
+      expect(Feeder::Item.last.created_at.to_i).to eq message.created_at.to_i
+    end
+
+    it 'sets published_at to the current time' do
+      expect(Feeder::Item.last.published_at.to_i).to eq Time.zone.now.to_i
+    end
+
+    context 'when the feedable is sticky' do
+      let(:message) { create :message, sticky: true }
+
+      it 'stickies' do
+        expect(Feeder::Item.last.sticky).to eq true
+      end
+    end
+
+    context 'when the feedable is not sticky' do
+      let(:message) { create :message, sticky: false }
+
+      it 'does not sticky' do
+        expect(Feeder::Item.last.sticky).to eq false
+      end
+    end
+
+    context 'when the feedable is configured to not feed' do
+      context 'with a lambda' do
+        around do |example|
+          Feeder.temporarily observables: { Message => { if: -> message { message.nil? }} } do
+            example.run
+          end
+        end
+
+        it 'does not create a feed item' do
+          expect(Feeder::Item.count).to eq 0
+        end
+      end
+
+      context 'with a symbol' do
+        around do |example|
+          Feeder.temporarily observables: { Message => { if: :nil? } } do
+            example.run
+          end
+        end
+
+        it 'does not create a feed item' do
+          expect(Feeder::Item.count).to eq 0
+        end
+      end
+    end
+  end
+end

data/spec/models/feeder/item_spec.rb

@@ -2,6 +2,8 @@ require 'spec_helper'
 
 module Feeder
   describe Item do
+    it_behaves_like "a filterable"
+
     describe "#type" do
       it "returns the lowercase version of the feedable's type, separating words with an underscore" do
         subject.stub(:feedable_type).and_return "SomeFeedable"
@@ -15,5 +17,41 @@ module Feeder
         end
       end
     end
+
+    describe "#report" do
+      subject { create :feeder_item, reported: false }
+
+      it "ensures the item is reported" do
+        subject.report
+        expect(subject).to be_reported
+      end
+    end
+
+    describe "#block" do
+      subject { create :feeder_item, blocked: false }
+
+      it "ensures the item is blocked" do
+        subject.block
+        expect(subject).to be_blocked
+      end
+    end
+
+    describe "#unreport" do
+      subject { create :feeder_item, reported: true }
+
+      it "ensures the item is not reported" do
+        subject.unreport
+        expect(subject).not_to be_reported
+      end
+    end
+
+    describe "#unblock" do
+      subject { create :feeder_item, blocked: true }
+
+      it "ensures the item is not blocked" do
+        subject.unblock
+        expect(subject).not_to be_blocked
+      end
+    end
   end
 end

data/spec/spec_helper.rb

@@ -4,12 +4,16 @@ require File.expand_path("../dummy/config/environment.rb",  __FILE__)
 require 'rspec/rails'
 require 'rspec/autorun'
 require 'factory_girl_rails'
+require 'timecop'
 
 Rails.backtrace_cleaner.remove_silencers!
 
 # Load support files
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
 
+# Load dummy files
+Dir["#{File.dirname(__FILE__)}/dummy/spec/factories/**/*.rb"].each { |f| require f }
+
 RSpec.configure do |config|
   config.mock_with :rspec
   config.use_transactional_fixtures = true

data/spec/support/shared_examples/filterable.rb

@@ -0,0 +1,48 @@
+require 'spec_helper'
+
+shared_examples "a filterable" do
+  subject { described_class }
+
+  describe "::filter" do
+    context "when provided a hash" do
+      let(:left) { create_list :feeder_item, 1 }
+      let(:arguments) { { Feeder::Item => right } }
+
+      context "and the value being a list of IDs" do
+        let(:right) { left.map &:id }
+
+        let!(:expected) do
+          left.each.map do |feedable|
+            create :feeder_item, feedable: feedable
+          end
+        end
+
+        before do
+          others = create_list :feeder_item, 1
+          others.each { |feedable| create :feeder_item, feedable: feedable }
+        end
+
+        it "fetches only items based on the filter" do
+          expect(subject.filter arguments).to match_array expected
+        end
+      end
+
+      context "and the value being :all" do
+        let(:right) { :all }
+
+        let!(:expected) do
+          Feeder::Item.where feedable_type: "Feeder::Item"
+        end
+
+        before do
+          others = create_list :feeder_item, 1
+          others.each { |feedable| create :feeder_item, feedable: feedable }
+        end
+
+        it "fetches only items based on the filter" do
+          expect(subject.filter arguments).to match_array expected
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: feeder
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Sindre Moen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-17 00:00:00.000000000 Z
+date: 2014-06-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -38,6 +38,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: kaminari
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -108,6 +122,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: timecop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: |
   Feeder gives you a mountable engine that provides a route to a feed page in your
   Ruby on Rails application.
@@ -122,22 +150,36 @@ files:
 - app/assets/javascripts/feeder/application.js
 - app/assets/stylesheets/feeder/application.css
 - app/controllers/feeder/application_controller.rb
-- app/controllers/feeder/feeds_controller.rb
+- app/controllers/feeder/items_controller.rb
 - app/helpers/feeder/application_helper.rb
 - app/helpers/feeder/feeds_helper.rb
 - app/models/feeder/feedable_observer.rb
 - app/models/feeder/item.rb
-- app/views/feeder/feeds/index.html.erb
 - app/views/feeder/items/_item.html.erb
-- app/views/layouts/feeder/application.html.erb
+- app/views/feeder/items/_item.json.jbuilder
+- app/views/feeder/items/index.html.erb
+- app/views/feeder/items/index.json.jbuilder
 - config/routes.rb
 - db/migrate/20140317150822_create_feeder_items.rb
 - db/migrate/20140317152137_add_polymorphic_feedable_reference_to_feeder_items.rb
+- db/migrate/20140321085409_add_sticky_to_feeder_items.rb
+- db/migrate/20140401131911_prohibit_null_on_feeder_item_stickies.rb
+- db/migrate/20140526110451_add_blocked_to_feeder_items.rb
+- db/migrate/20140526110501_add_reported_to_feeder_items.rb
 - lib/feeder.rb
+- lib/feeder/active_record.rb
+- lib/feeder/concerns.rb
+- lib/feeder/concerns/controllers.rb
+- lib/feeder/concerns/controllers/items_controller.rb
+- lib/feeder/concerns/feedable.rb
+- lib/feeder/concerns/helpers.rb
+- lib/feeder/concerns/helpers/filter.rb
+- lib/feeder/concerns/models.rb
+- lib/feeder/concerns/models/item.rb
 - lib/feeder/configuration.rb
 - lib/feeder/engine.rb
 - lib/feeder/version.rb
-- spec/controllers/feeder/feeds_controller_spec.rb
+- spec/controllers/feeder/items_controller_spec.rb
 - spec/dummy/README.md
 - spec/dummy/Rakefile
 - spec/dummy/app/assets/javascripts/application.js
@@ -169,19 +211,27 @@ files:
 - spec/dummy/config/initializers/wrap_parameters.rb
 - spec/dummy/config/locales/en.yml
 - spec/dummy/config/routes.rb
+- spec/dummy/db/development.sqlite3
 - spec/dummy/db/migrate/20140317152438_create_messages.rb
 - spec/dummy/db/schema.rb
+- spec/dummy/db/test.sqlite3
+- spec/dummy/log/development.log
+- spec/dummy/log/test.log
 - spec/dummy/public/404.html
 - spec/dummy/public/422.html
 - spec/dummy/public/500.html
 - spec/dummy/public/favicon.ico
 - spec/dummy/spec/factories/messages.rb
 - spec/dummy/spec/models/message_spec.rb
+- spec/factories/feeder/items.rb
+- spec/lib/feeder/concerns/feedable_spec.rb
 - spec/lib/feeder/configuration_spec.rb
 - spec/lib/feeder_spec.rb
+- spec/models/feeder/feedable_observer_spec.rb
 - spec/models/feeder/item_spec.rb
 - spec/spec_helper.rb
 - spec/support/observers.rb
+- spec/support/shared_examples/filterable.rb
 homepage: http://github.com/hyperoslo/feeder
 licenses:
 - MIT
@@ -202,53 +252,61 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Provides simple feed functionality through an engine
 test_files:
-- spec/controllers/feeder/feeds_controller_spec.rb
-- spec/spec_helper.rb
-- spec/lib/feeder_spec.rb
-- spec/lib/feeder/configuration_spec.rb
-- spec/support/observers.rb
-- spec/dummy/public/422.html
-- spec/dummy/public/500.html
-- spec/dummy/public/favicon.ico
-- spec/dummy/public/404.html
+- spec/controllers/feeder/items_controller_spec.rb
+- spec/dummy/app/assets/javascripts/application.js
+- spec/dummy/app/assets/stylesheets/application.css
+- spec/dummy/app/controllers/application_controller.rb
+- spec/dummy/app/helpers/application_helper.rb
+- spec/dummy/app/models/message.rb
+- spec/dummy/app/views/feeder/types/_message.html.erb
+- spec/dummy/app/views/layouts/application.html.erb
+- spec/dummy/bin/bundle
+- spec/dummy/bin/rails
+- spec/dummy/bin/rake
 - spec/dummy/config/application.rb
-- spec/dummy/config/initializers/feeder.rb
+- spec/dummy/config/boot.rb
+- spec/dummy/config/database.yml
+- spec/dummy/config/environment.rb
+- spec/dummy/config/environments/development.rb
+- spec/dummy/config/environments/production.rb
+- spec/dummy/config/environments/test.rb
+- spec/dummy/config/initializers/backtrace_silencers.rb
 - spec/dummy/config/initializers/cookies_serializer.rb
-- spec/dummy/config/initializers/session_store.rb
-- spec/dummy/config/initializers/mime_types.rb
-- spec/dummy/config/initializers/wrap_parameters.rb
+- spec/dummy/config/initializers/feeder.rb
+- spec/dummy/config/initializers/filter_parameter_logging.rb
 - spec/dummy/config/initializers/inflections.rb
+- spec/dummy/config/initializers/mime_types.rb
 - spec/dummy/config/initializers/secret_token.rb
-- spec/dummy/config/initializers/backtrace_silencers.rb
-- spec/dummy/config/initializers/filter_parameter_logging.rb
-- spec/dummy/config/environments/production.rb
-- spec/dummy/config/environments/test.rb
-- spec/dummy/config/environments/development.rb
+- spec/dummy/config/initializers/session_store.rb
+- spec/dummy/config/initializers/wrap_parameters.rb
 - spec/dummy/config/locales/en.yml
-- spec/dummy/config/database.yml
-- spec/dummy/config/environment.rb
-- spec/dummy/config/boot.rb
 - spec/dummy/config/routes.rb
 - spec/dummy/config.ru
-- spec/dummy/README.md
+- spec/dummy/db/development.sqlite3
 - spec/dummy/db/migrate/20140317152438_create_messages.rb
 - spec/dummy/db/schema.rb
-- spec/dummy/bin/rails
-- spec/dummy/bin/bundle
-- spec/dummy/bin/rake
+- spec/dummy/db/test.sqlite3
+- spec/dummy/log/development.log
+- spec/dummy/log/test.log
+- spec/dummy/public/404.html
+- spec/dummy/public/422.html
+- spec/dummy/public/500.html
+- spec/dummy/public/favicon.ico
 - spec/dummy/Rakefile
-- spec/dummy/app/assets/javascripts/application.js
-- spec/dummy/app/assets/stylesheets/application.css
-- spec/dummy/app/controllers/application_controller.rb
-- spec/dummy/app/helpers/application_helper.rb
-- spec/dummy/app/views/feeder/types/_message.html.erb
-- spec/dummy/app/views/layouts/application.html.erb
-- spec/dummy/app/models/message.rb
+- spec/dummy/README.md
 - spec/dummy/spec/factories/messages.rb
 - spec/dummy/spec/models/message_spec.rb
+- spec/factories/feeder/items.rb
+- spec/lib/feeder/concerns/feedable_spec.rb
+- spec/lib/feeder/configuration_spec.rb
+- spec/lib/feeder_spec.rb
+- spec/models/feeder/feedable_observer_spec.rb
 - spec/models/feeder/item_spec.rb
+- spec/spec_helper.rb
+- spec/support/observers.rb
+- spec/support/shared_examples/filterable.rb