feed_parser 0.1.0 → 0.1.1

data/lib/feed_parser.rb

@@ -3,7 +3,7 @@ require 'nokogiri'
 
 class FeedParser
 
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 
   def initialize(opts)
     @url = opts[:url]

data/lib/feed_parser/feed.rb

@@ -3,7 +3,8 @@ class FeedParser
     attr_reader :type
 
     def initialize(feed_url)
-      @feed = Nokogiri::XML(open(feed_url))
+      parsed_url = parse_url(feed_url)
+      @feed = Nokogiri::XML(open(parsed_url[:url], :http_basic_authentication => parsed_url[:basic_auth]))
       @feed.remove_namespaces!
       @type = (@feed.search('rss')[0] && :rss || :atom)
       self
@@ -33,5 +34,13 @@ class FeedParser
         :items => items.map(&:as_json)
       }
     end
+
+    private
+    def parse_url(feed_url)
+      protocol, auth, *the_rest = URI.split(feed_url)
+      url = (protocol && [protocol, the_rest.join].join('://') || the_rest.join)
+      basic_auth = auth.split(':') if auth
+      {:url => url, :basic_auth => basic_auth}
+    end
   end
 end

data/spec/feed_parser_spec.rb

@@ -7,6 +7,38 @@ class NotSaneSanitizer
 end
 
 describe FeedParser do
+  describe FeedParser::Feed, "#new" do
+    it "should be able to open a feed url" do
+      parser = FeedParser.new(:url => "http://blog.example.com/feed/")
+      lambda {
+        parser.parse
+      }.should_not raise_error(ArgumentError)
+      lambda {
+        parser.parse
+      }.should raise_error(SocketError, /getaddrinfo: nodename nor servname provided, or not known/)
+    end
+
+    it "should be able to open feed urls with basic auth embedded to the url" do
+      parser = FeedParser.new(:url => "http://user:pass@blog.example.com/feed/")
+      lambda {
+        parser.parse
+      }.should_not raise_error(ArgumentError, /userinfo not supported/)
+      lambda {
+        parser.parse
+      }.should raise_error(SocketError, /getaddrinfo: nodename nor servname provided, or not known/)
+    end
+
+    it "should be able to open feed urls with only a user name embedded to the url" do
+      parser = FeedParser.new(:url => "http://user@blog.example.com/feed/")
+      lambda {
+        parser.parse
+      }.should_not raise_error(ArgumentError, /userinfo not supported/)
+      lambda {
+        parser.parse
+      }.should raise_error(SocketError, /getaddrinfo: nodename nor servname provided, or not known/)
+    end
+  end
+
   describe "#parse" do
     shared_examples_for "feed parser" do
       it "should not fail" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: feed_parser
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-11-23 00:00:00.000000000 Z
+date: 2011-11-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
-  requirement: &2156421000 !ruby/object:Gem::Requirement
+  requirement: &2156409240 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2156421000
+  version_requirements: *2156409240
 - !ruby/object:Gem::Dependency
   name: rspec-rails
-  requirement: &2156419940 !ruby/object:Gem::Requirement
+  requirement: &2156408420 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,7 +32,7 @@ dependencies:
         version: '2.6'
   type: :development
   prerelease: false
-  version_requirements: *2156419940
+  version_requirements: *2156408420
 description: Rss and Atom feed parser with sanitizer support built on top of Nokogiri.
 email:
 - arttu.tervo@gmail.com