feed2gram 1.2.2 → 1.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8f1c5ede06c494a4b45e77b7ba717c408f72ce9c2ae272c97550b6f0e687fae2
-  data.tar.gz: df2a2f0ff2ac9ec4663c5fb4c7f48fb2e1cd9aa3f31c4b9ff7cfc0dde5308946
+  metadata.gz: 24a46cff098342888e3997e1dadfc34a6e0526f979ea59b7b2e0687ecc1051e7
+  data.tar.gz: 63f1559288645c2bb02ddfbe45aa6edd55e5f76437f582f8aec9a12a2c1630fe
 SHA512:
-  metadata.gz: 8c0e76000c8a937c57d082e0a20c2e8d05bdb193476584a873bd034eed858fdca7702dbd37a3889d3338e4e79ad05c605a2f61ee4d80e8245a479fdf1e90d878
-  data.tar.gz: e377a974a2aa8c51e8cf8e2eff23feb30b88b5da9c3a63979de1c05ce5a3e7ede6f0e764f65ff7b9f01266c4bb581dfe63a548ad67e4b25c6aac8968a9288a2e
+  metadata.gz: e5eb07918977ad2d034609efbc2372ce3af65f9d75ef6d3766a3eb5db938b955fa3ebe5828091ffc56d0179a138fd433b06d314b3f58e537c71edb5e25ce6ba1
+  data.tar.gz: ad34cbae69b4148ecd5acb953018ef8bbd6c75e61e2fca50514f47a5ac31d061e167ed801e8182d5a735da93a91181b0a8f35175710203d7fa2e0f3a321f09ee

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## [1.2.3]
+
+* Add a retry option after IG continues to fail to download videos correctly. See `RETRIES_AFTER_UPLOAD_TIMEOUT` (default 5 retries)
+
 ## [1.2.2]
 
 * Fix integer/string conversion error when env vars from 1.2.1 are set

data/README.md

@@ -101,8 +101,10 @@ Usage: feed2gram [options]
 These environment variables can be set to augment the gem's behavior:
 
 * `SECONDS_PER_UPLOAD_CHECK` - when uploading video, feed2gram must wait until
-the [status code](https://tiagogrosso.github.io/instagram-graph-api-lib/enums/CONTAINER_STATUS_CODE.html) on the media indicates it is published. This variable determines how many seconds to wait between each check (defaults to 30 seconds). Shortening this value can lead to hitting one's hourly rate limit
-* `MAX_UPLOAD_STATUS_CHECKS` - how many status checks to perform before giving up on a piece of media and calling the post failed. Unfortunately, Facebook's servers can take anywhere from 15 seconds to 15 hours to download and process even trivially small videos, so GLHF
+the [status code](https://tiagogrosso.github.io/instagram-graph-api-lib/enums/CONTAINER_STATUS_CODE.html) on the media indicates it is published. This variable determines how many seconds to wait between each check (defaults to `30` seconds). Shortening this value can lead to hitting one's hourly rate limit
+* `MAX_UPLOAD_STATUS_CHECKS` - how many status checks to perform before giving up on a piece of media and calling the post failed. Unfortunately, Facebook's servers can take anywhere from 15 seconds to 15 hours to download and process even trivially small videos, so GLHF (defaults to `100` attempts)
+* `RETRIES_AFTER_UPLOAD_TIMEOUT` - because Facebook's servers will so often hang and fail to download videos (even when you
+set the timeout to absurd lengths like 20 hours, it'll still report `IN_PROGRESS`), it may be necessary to retry after timeout. (defaults to `5` retries)
 
 ## Formatting your Atom feed's HTML
 

data/example/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    feed2gram (1.2.2)
+    feed2gram (1.2.3)
       nokogiri (~> 1.15)
 
 GEM

data/lib/feed2gram/publishes_posts.rb

@@ -1,7 +1,12 @@
 module Feed2Gram
   Result = Struct.new(:post, :status, keyword_init: true)
+  class FacebookSucksAtDownloadingFilesError < StandardError; end
 
   class PublishesPosts
+    SECONDS_PER_UPLOAD_CHECK = ENV.fetch("SECONDS_PER_UPLOAD_CHECK") { 30 }.to_i
+    MAX_UPLOAD_STATUS_CHECKS = ENV.fetch("MAX_UPLOAD_STATUS_CHECKS") { 100 }.to_i
+    RETRIES_AFTER_UPLOAD_TIMEOUT = ENV.fetch("RETRIES_AFTER_UPLOAD_TIMEOUT") { 5 }.to_i
+
     def publish(posts, config, options)
       post_limit = options.limit || posts.size
       puts "Publishing #{post_limit} posts to Instagram" if options.verbose
@@ -9,12 +14,14 @@ module Feed2Gram
       # reverse to post oldest first (most Atom feeds are reverse-chronological)
       posts.reverse.take(post_limit).map { |post|
         begin
-          if post.medias.size == 1
-            puts "Publishing #{post.media_type.downcase} for: #{post.url}" if options.verbose
-            publish_single_media(post, config, options)
-          else
-            puts "Publishing carousel for: #{post.url}" if options.verbose
-            publish_carousel(post, config, options)
+          retry_if_upload_times_out(RETRIES_AFTER_UPLOAD_TIMEOUT, post, options) do
+            if post.medias.size == 1
+              puts "Publishing #{post.media_type.downcase} for: #{post.url}" if options.verbose
+              publish_single_media(post, config, options)
+            else
+              puts "Publishing carousel for: #{post.url}" if options.verbose
+              publish_carousel(post, config, options)
+            end
           end
         rescue => e
           warn "Failed to post #{post.url}: #{e.message}"
@@ -26,6 +33,18 @@ module Feed2Gram
 
     private
 
+    def retry_if_upload_times_out(times_remaining, post, options, &blk)
+      blk.call
+    rescue FacebookSucksAtDownloadingFilesError
+      if times_remaining > 0
+        puts "Will retry with attempt ##{RETRIES_AFTER_UPLOAD_TIMEOUT - times_remaining + 2} after Facebook failed to download a video without timing out for: #{post.url}" if options.verbose
+        retry_if_upload_times_out(times_remaining - 1, post, options, &blk)
+      else
+        warn "Failed to post #{post.url} after #{RETRIES_AFTER_UPLOAD_TIMEOUT} retries due to Facebook timing out on video downloads"
+        Result.new(post: post, status: :failed)
+      end
+    end
+
     def publish_single_media(post, config, options)
       media = post.medias.first
 
@@ -82,15 +101,13 @@ module Feed2Gram
       Result.new(post: post, status: :posted)
     end
 
-    SECONDS_PER_UPLOAD_CHECK = ENV.fetch("SECONDS_PER_UPLOAD_CHECK") { 30 }.to_i
-    MAX_UPLOAD_STATUS_CHECKS = ENV.fetch("MAX_UPLOAD_STATUS_CHECKS") { 100 }.to_i
     # Good ol' loop-and-sleep. Haven't loop do'd in a while
     def wait_for_media_to_upload!(url, container_id, config, options)
       wait_attempts = 0
       loop do
         if wait_attempts > MAX_UPLOAD_STATUS_CHECKS
           warn "Giving up waiting for media to upload after waiting #{SECONDS_PER_UPLOAD_CHECK * MAX_UPLOAD_STATUS_CHECKS} seconds: #{url}"
-          break
+          raise FacebookSucksAtDownloadingFilesError
         end
 
         res = Http.get("/#{container_id}", {

data/lib/feed2gram/version.rb

@@ -1,3 +1,3 @@
 module Feed2Gram
-  VERSION = "1.2.2"
+  VERSION = "1.2.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: feed2gram
 version: !ruby/object:Gem::Version
-  version: 1.2.2
+  version: 1.2.3
 platform: ruby
 authors:
 - Justin Searls
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-02-13 00:00:00.000000000 Z
+date: 2024-05-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -77,7 +77,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.4
+rubygems_version: 3.5.6
 signing_key:
 specification_version: 4
 summary: Reads an Atom feed and posts its entries to Instagram