fedux_org-stdlib 0.7.21 → 0.7.22

data/spec/models/filesystem_based_model_spec.rb

@@ -8,13 +8,13 @@ RSpec.describe Models::FilesystemBasedModel do
       include Models::FilesystemBasedModel
 
       def self.load_from_filesystem
-        [ :hello, :world ].each { |s| create(s) }
+        [:hello, :world].each { |s| create(s) }
       end
     end
 
     @model.clear
 
-    #where a name for a class is relevant
+    # where a name for a class is relevant
     module Test123
       module Models
         class TestClassForFilesystem < FeduxOrgStdlib::Models::BaseModel
@@ -24,29 +24,29 @@ RSpec.describe Models::FilesystemBasedModel do
     end
   end
 
-  it "finds all available filter" do
+  it 'finds all available filter' do
     @model.init
     filter = @model.find(:hello)
     expect(filter.name).to eq(:hello)
   end
 
-  it "is default that all found filters are disabled" do
+  it 'is default that all found filters are disabled' do
     @model.init
     all_filter = @model.all
     all_not_enabled_filter = @model.find_all(enabled: false)
     expect(all_filter.size).to eq(all_not_enabled_filter.size)
   end
 
-  it "enables a filter by request" do
+  it 'enables a filter by request' do
     @model.init
     @model.enable(:hello)
     all_enabled_filter = @model.find_all(enabled: true)
     filter = @model.find(:hello)
 
-    expect(all_enabled_filter).to eq([ filter ])
+    expect(all_enabled_filter).to eq([filter])
   end
 
-  it "s find method supports a hash based syntax" do
+  it 's find method supports a hash based syntax' do
     @model.init
     @model.enable(:hello)
 
@@ -54,7 +54,7 @@ RSpec.describe Models::FilesystemBasedModel do
     expect(enabled_filter.name).to eq(:hello)
   end
 
-  it "s find method supports a symbol based syntax as well. The search string is compared against the name method." do
+  it 's find method supports a symbol based syntax as well. The search string is compared against the name method.' do
     @model.init
     enabled_filter = @model.find(:hello)
     expect(enabled_filter.name).to eq(:hello)
@@ -63,7 +63,7 @@ RSpec.describe Models::FilesystemBasedModel do
     expect(enabled_filter.first.name).to eq(:hello)
   end
 
-  it "s find method supports a string based syntax as well. The search string is compared against the name method." do
+  it 's find method supports a string based syntax as well. The search string is compared against the name method.' do
     @model.init
     enabled_filter = @model.find('hello')
     expect(enabled_filter.name).to eq(:hello)
@@ -72,28 +72,28 @@ RSpec.describe Models::FilesystemBasedModel do
     expect(enabled_filter.first.name).to eq(:hello)
   end
 
-  it "raises an error if an unknown search criteria is used" do
+  it 'raises an error if an unknown search criteria is used' do
     @model.init
-    expect { 
-      enabled_filter = @model.find(unknown: 'hello')
-    }.to raise_error FeduxOrgStdlib::Models::Exceptions::InvalidSearchCriteria
+    expect do
+      @model.find(unknown: 'hello')
+    end.to raise_error FeduxOrgStdlib::Models::Exceptions::InvalidSearchCriteria
   end
 
-  it "returns the module name" do
+  it 'returns the module name' do
     expect(Test123::Models::TestClassForFilesystem.send(:module_name)).to eq('Test123::Models')
   end
 
-  it "returns the model name" do
+  it 'returns the model name' do
     expect(Test123::Models::TestClassForFilesystem.send(:model_name)).to eq('TestClassForFilesystem')
   end
 
-  context "#library_name" do
-    it "returns the library name" do
+  context '#library_name' do
+    it 'returns the library name' do
       expect(Test123::Models::TestClassForFilesystem.send(:library_name)).to eq('Test123')
     end
   end
 
-  context "#path_to_instances" do
+  context '#path_to_instances' do
     klass = Class.new(FeduxOrgStdlib::Models::BaseModel) do
       include FeduxOrgStdlib::Models::FilesystemBasedModel
 
@@ -102,22 +102,22 @@ RSpec.describe Models::FilesystemBasedModel do
       end
 
       def self.model_path
-        File.join(examples_dir, 'models', 'filesystem_based', 'find_files')
+        File.join(examples_directory, 'models', 'filesystem_based', 'find_files')
       end
 
     end
 
-    it "returns the path to the instances" do
-      expect(klass.send(:path_to_instances)).to eq(File.join(examples_dir, 'models', 'find_files'))
+    it 'returns the path to the instances' do
+      expect(klass.send(:path_to_instances)).to eq(File.join(examples_directory, 'models', 'find_files'))
     end
   end
 
-  context "#find_files" do
+  context '#find_files' do
     klass = Class.new(FeduxOrgStdlib::Models::BaseModel) do
       include FeduxOrgStdlib::Models::FilesystemBasedModel
 
       def self.path_to_instances
-        File.join(examples_dir, 'models', 'filesystem_based', 'find_files')
+        File.join(examples_directory, 'models', 'filesystem_based', 'find_files')
       end
 
       def self.suffix
@@ -125,18 +125,18 @@ RSpec.describe Models::FilesystemBasedModel do
       end
     end
 
-    it "search for available instances in filesystem" do
+    it 'search for available instances in filesystem' do
       expect(klass.send(:find_files)).to eq(
         [
-          File.join(examples_dir, 'models', 'filesystem_based', 'find_files', 'abc.rb'),
-          File.join(examples_dir, 'models', 'filesystem_based', 'find_files', 'cde.rb')
+          File.join(examples_directory, 'models', 'filesystem_based', 'find_files', 'abc.rb'),
+          File.join(examples_directory, 'models', 'filesystem_based', 'find_files', 'cde.rb')
         ]
      )
     end
   end
 
-  context "#init" do
-    it "init should only add unknown instances" do
+  context '#init' do
+    it 'init should only add unknown instances' do
       @model.init
       count1 = @model.all.size
       @model.init

data/spec/project/plan_spec.rb

@@ -4,7 +4,7 @@ require 'fedux_org_stdlib/project/plan'
 
 RSpec.describe FeduxOrgStdlib::Project::Plan do
   context '#to_s' do
-    it 'uses the working directory by default to find plan' do 
+    it 'uses the working directory by default to find plan' do
       plan_file = absolute_path('plan.tjp')
 
       in_current_dir do

data/spec/project/report_spec.rb

@@ -26,7 +26,7 @@ RSpec.describe FeduxOrgStdlib::Project::Report do
     end
 
     it 'generates report only if plan file is newer than output file' do
-      FileUtils.touch report_file, :mtime => Time.now - 2.hours
+      FileUtils.touch report_file, mtime: Time.now - 2.hours
 
       plan = double('Plan')
       allow(plan).to receive(:to_s).and_return(plan_file)
@@ -42,7 +42,7 @@ RSpec.describe FeduxOrgStdlib::Project::Report do
     end
 
     it 'does not generate report if plan file is older or of eqal age than output file' do
-      FileUtils.touch plan_file, :mtime => Time.now - 2.hours
+      FileUtils.touch plan_file, mtime: Time.now - 2.hours
 
       plan = double('Plan')
       expect(plan).to receive(:needs_to_be_compiled?).with(report_file).and_return(false)

data/spec/project/taskjuggler_spec.rb

@@ -10,7 +10,7 @@ RSpec.describe FeduxOrgStdlib::Project::Generators::Taskjuggler do
 
     let(:directory) { absolute_path('projects') }
 
-    it "generates a report using taskjuggler" do
+    it 'generates a report using taskjuggler' do
       plan_file = File.join(examples_directory, 'project', 'plan.tjp')
 
       generator = FeduxOrgStdlib::Project::Generators::Taskjuggler.new
@@ -20,16 +20,16 @@ RSpec.describe FeduxOrgStdlib::Project::Generators::Taskjuggler do
       end
     end
 
-    it "fails if an error occured while generating the report" do
+    it 'fails if an error occured while generating the report' do
       plan_file = File.join(examples_directory, 'project', 'plan_does_not_exist.tjp')
 
       generator = FeduxOrgStdlib::Project::Generators::Taskjuggler.new
 
-      expect {
+      expect do
         silence(:stderr) do
           generator.generate_report(directory, plan_file)
         end
-      }.to raise_error SystemExit
+      end.to raise_error SystemExit
     end
   end
 end

data/spec/spec_helper.rb

@@ -16,8 +16,6 @@ Bundler.require :default, :test, :development
 Dir.glob(::File.expand_path('../support/*.rb', __FILE__)).each { |f| require_relative f }
 Dir.glob(::File.expand_path('../matchers/*.rb', __FILE__)).each { |f| require_relative f }
 
-
-def examples_dir
+def examples_directory
   File.expand_path('../examples', __FILE__)
 end
-alias :examples_directory :examples_dir 

data/spec/support/rspec.rb

@@ -1,5 +1,5 @@
 # encoding: utf-8
 RSpec.configure do |c|
-  c.filter_run_including :focus => true
+  c.filter_run_including focus: true
   c.run_all_when_everything_filtered = true
 end

data/spec/version_management/library_builder_spec.rb

@@ -5,8 +5,8 @@ require 'fedux_org_stdlib/version_management/library_builder'
 RSpec.describe FeduxOrgStdlib::VersionManagement::LibraryBuilder do
   context '#build_from' do
     it 'accepts a version string and builds a version object' do
-      library = FeduxOrgStdlib::VersionManagement::LibraryBuilder.new.build_from([ 'MyModules' ])
-      expect(library.module_names).to eq([ 'MyModules' ])
+      library = FeduxOrgStdlib::VersionManagement::LibraryBuilder.new.build_from(['MyModules'])
+      expect(library.module_names).to eq(['MyModules'])
     end
   end
 end

data/spec/version_management/ruby_library_spec.rb

@@ -5,8 +5,8 @@ require 'fedux_org_stdlib/version_management/ruby_library'
 RSpec.describe FeduxOrgStdlib::VersionManagement::RubyLibrary do
   context '#module_names' do
     it 'nows about module names' do
-      lib = FeduxOrgStdlib::VersionManagement::RubyLibrary.new(['MyModule', 'MyClass' ])
-      expect(lib.module_names).to eq(['MyModule', 'MyClass' ])
+      lib = FeduxOrgStdlib::VersionManagement::RubyLibrary.new(%w(MyModule MyClass))
+      expect(lib.module_names).to eq(%w(MyModule MyClass))
     end
   end
 end

data/spec/version_management/rubygem_version_file_parser_spec.rb

@@ -8,7 +8,7 @@ RSpec.describe FeduxOrgStdlib::VersionManagement::RubygemVersionFileParser do
   context '#parse' do
     it 'extracts version number' do
       write_file(
-      'version.rb', 
+      'version.rb',
       <<-EOS.strip_heredoc
        #main MyLibrary
        module MyLibrary
@@ -24,7 +24,7 @@ RSpec.describe FeduxOrgStdlib::VersionManagement::RubygemVersionFileParser do
 
     it 'extracts modules' do
       write_file(
-      'version.rb', 
+      'version.rb',
       <<-EOS.strip_heredoc
         #main MyLibrary
         module MyLibrary
@@ -35,12 +35,12 @@ RSpec.describe FeduxOrgStdlib::VersionManagement::RubygemVersionFileParser do
 
       parser.parse(absolute_path('version.rb'))
 
-      expect(parser.modules).to eq([ 'MyLibrary' ])
+      expect(parser.modules).to eq(['MyLibrary'])
     end
 
     it 'extracts nested modules as well' do
       write_file(
-      'version.rb', 
+      'version.rb',
       <<-EOS.strip_heredoc
       #main MyLibrary
       module MyLibrary
@@ -53,20 +53,20 @@ RSpec.describe FeduxOrgStdlib::VersionManagement::RubygemVersionFileParser do
 
       parser.parse(absolute_path('version.rb'))
 
-      expect(parser.modules).to eq(['MyLibrary', 'MyClass'])
+      expect(parser.modules).to eq(%w(MyLibrary MyClass))
     end
 
     it 'fails if version cannot be extracted' do
       write_file(
-      'version.rb', 
+      'version.rb',
       <<-EOS.strip_heredoc
         #main MyLibrary
       EOS
       )
 
-      expect {
+      expect do
         parser.parse(absolute_path('version.rb'))
-      }.to raise_error VersionManagement::Exceptions::VersionFileInvalid
+      end.to raise_error VersionManagement::Exceptions::VersionFileInvalid
     end
   end
 end

data/spec/version_management/rubygem_version_file_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe FeduxOrgStdlib::VersionManagement::RubygemVersionFile do
       expect(version).to receive(:to_s).and_return('0.0.0')
 
       library = double('RubyLibrary')
-      expect(library).to receive(:module_names).and_return([ 'MyLibrary' ])
+      expect(library).to receive(:module_names).and_return(['MyLibrary'])
 
       version_file = FeduxOrgStdlib::VersionManagement::RubygemVersionFile.new(version, library)
       expect(version_file.to_s).to eq(<<-EOS.strip_heredoc
@@ -27,7 +27,7 @@ RSpec.describe FeduxOrgStdlib::VersionManagement::RubygemVersionFile do
       expect(version).to receive(:to_s).and_return('0.0.0')
 
       library = double('RubyLibrary')
-      expect(library).to receive(:module_names).and_return([ 'MyLibrary', 'MyClass' ])
+      expect(library).to receive(:module_names).and_return(%w(MyLibrary MyClass))
 
       version_file = FeduxOrgStdlib::VersionManagement::RubygemVersionFile.new(version, library)
       expect(version_file.to_s).to eq(<<-EOS.strip_heredoc
@@ -50,7 +50,7 @@ RSpec.describe FeduxOrgStdlib::VersionManagement::RubygemVersionFile do
       expect(version).to receive(:to_s).and_return('0.0.0')
 
       library = double('RubyLibrary')
-      expect(library).to receive(:module_names).and_return([ 'MyLibrary', 'MyClass' ])
+      expect(library).to receive(:module_names).and_return(%w(MyLibrary MyClass))
       version_file = FeduxOrgStdlib::VersionManagement::RubygemVersionFile.new(version, library)
 
       in_current_dir do
@@ -65,15 +65,15 @@ RSpec.describe FeduxOrgStdlib::VersionManagement::RubygemVersionFile do
         library = double('Library')
 
         version_builder = double('VersionBuilder')
-        expect(version_builder).to receive(:build_from).with('0.0.0').and_return(version) 
+        expect(version_builder).to receive(:build_from).with('0.0.0').and_return(version)
 
         library_builder = double('LibraryBuilder')
-        expect(library_builder).to receive(:build_from).with([ 'MyModule' ]).and_return(library) 
+        expect(library_builder).to receive(:build_from).with(['MyModule']).and_return(library)
 
         parser = double('Parser')
         expect(parser).to receive(:parse)
         expect(parser).to receive(:version).and_return('0.0.0')
-        expect(parser).to receive(:modules).and_return([ 'MyModule' ])
+        expect(parser).to receive(:modules).and_return(['MyModule'])
 
         version_file = write_file('version.rb', <<-EOS.strip_heredoc
                                  # encoding: utf-8
@@ -91,7 +91,7 @@ RSpec.describe FeduxOrgStdlib::VersionManagement::RubygemVersionFile do
     end
 
     context '#version' do
-      it "returns the version for the file" do
+      it 'returns the version for the file' do
         version = double('Version')
         expect(version).to receive(:to_s).and_return('0.0.0')
 
@@ -103,7 +103,7 @@ RSpec.describe FeduxOrgStdlib::VersionManagement::RubygemVersionFile do
     end
 
     context '#bump' do
-      it "bumps versions" do
+      it 'bumps versions' do
         version = double('Version')
         expect(version).to receive(:bump).with(:major)
         expect(version).to receive(:to_s).and_return('1.0.0')

data/spec/version_management/software_version_spec.rb

@@ -11,7 +11,7 @@ RSpec.describe FeduxOrgStdlib::VersionManagement::SoftwareVersion do
   end
 
   context '#update' do
-    it "updates an with an new version number" do
+    it 'updates an with an new version number' do
       version =  FeduxOrgStdlib::VersionManagement::SoftwareVersion.new('1.1.1')
       version.update('2.0.0')
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fedux_org-stdlib
 version: !ruby/object:Gem::Version
-  version: 0.7.21
+  version: 0.7.22
 platform: ruby
 authors:
 - Max Meyer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-03 00:00:00.000000000 Z
+date: 2014-09-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -33,6 +33,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".simplecov"
 - ".travis.yml"
 - ".yardopts"
@@ -42,6 +43,8 @@ files:
 - LICENSE.md
 - README.md
 - Rakefile
+- config/rubocop/exclude.yml
+- config/rubocop/include.yml
 - doc/colors.md
 - doc/commands.md
 - doc/logic_converters.md