federal_register 0.7.1 → 0.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a003dcebeeb80ec509aa695f35459a61700f798a3ab228ac0947b42942713d0a
-  data.tar.gz: 8b1f3bb7602304fbe8c7eae23a2563e0432b9b6e090207aba77c4dca5807c29a
+  metadata.gz: 5b888ccd1e8ba93b75d9217a494435d52408cea9bb7dd76eceee8692183d3a8f
+  data.tar.gz: caad2387bb549a07e0cdd581ec40265f50b46a05c18f2b2c74b193819b5d8b6f
 SHA512:
-  metadata.gz: b5aed81850d81cf4c5dc07547fd694214f5f5d6f033b1fe1033199ba18ab34ae69905e2809377b56efbee1cb4a19e4f408e36544803cfc54de315842cac5c95d
-  data.tar.gz: 619b9ebd3fd143953e97d04f62e403e7e9ec0929d6e6630d1f13db070fc7144b21bda2813092f561acb6e759b32412407a22f4d80fc55bd6dfa12de54a633ead
+  metadata.gz: f507c18904701a263175b2cbf1d8d5fc631e6129b98217d139338ce9634e05d0f36ae9f689129bddcfc1999839537dd8a31330ca5e68b1938c349bc7a474fa25
+  data.tar.gz: 64cb7f390982d0e13d4e6ff6e3cf1239ad00fd6a9e53c63a7be90707323f13277d6446ddc2b3212dd4a3a15df6a5fe32a0a16a4274bffb44821c392ac8010c54

data/VERSION

@@ -1 +1 @@
-0.7.1
+0.7.3

data/federal_register.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "federal_register"
-  s.version = "0.7.1"
+  s.version = "0.7.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Andrew Carpenter", "Bob Burbach"]
-  s.date = "2019-05-13"
+  s.date = "2019-11-19"
   s.description = "Ruby API Client for FederalRegister.gov that handles searching documents and getting information about agencies"
   s.email = "andrew@criticaljuncture.org"
   s.extra_rdoc_files = [

data/lib/federal_register/client.rb

@@ -11,9 +11,11 @@ class FederalRegister::Client
     end
   end
 
-  class RecordNotFound < ResponseError; end
   class BadRequest < ResponseError; end
+  class GatewayTimeout < ResponseError; end
+  class RecordNotFound < ResponseError; end
   class ServerError < ResponseError; end
+  class ServiceUnavailable < ResponseError; end
 
   base_uri 'https://www.federalregister.gov/api/v1'
 
@@ -29,6 +31,10 @@ class FederalRegister::Client
       raise RecordNotFound.new(response)
     when 500
       raise ServerError.new(response)
+    when 503
+      raise ServiceUnavailable.new(response)
+    when 504
+      raise GatewayTimeout.new(response)
     else
       raise HTTParty::ResponseError.new(response)
     end

data/lib/federal_register/document.rb

@@ -60,13 +60,21 @@ class FederalRegister::Document < FederalRegister::Base
   end
 
   def self.find(document_number, options={})
+    query = {}
+    
+    if options[:publication_date].present?
+      publication_date = options[:publication_date]
+      publication_date = publication_date.is_a?(Date) ? publication_date.to_s(:iso) : publication_date
+      
+      query.merge!(:publication_date => publication_date)
+    end
+
     if options[:fields].present?
-      attributes = get("/documents/#{document_number}.json", :query => {:fields => options[:fields]}).parsed_response
-      new(attributes)
-    else
-      attributes = get("/documents/#{document_number}.json").parsed_response
-      new(attributes, :full => true)
+      query.merge!(:fields => options[:fields])
     end
+
+    attributes = get("/documents/#{document_number}.json", :query => query).parsed_response
+    new(attributes, :full => true)
   end
 
   # supports values like: '2016-26522', '2016-26522,2016-26594', '81 FR 76496', '81 FR 76496,81 FR 76685'

data/spec/base_spec.rb

@@ -45,7 +45,7 @@ describe FederalRegister::Base do
             instance = @klass.new('panda' => date_string)
             lambda {
               instance.panda.should == "never going to get here"
-            }.should raise_error
+            }.should raise_error ArgumentError
           end
         end
       end
@@ -84,10 +84,11 @@ describe FederalRegister::Base do
         context "when value is not a valid date string" do
           it "throws" do
             date_string = "foo"
-            instance = @klass.new(:updated_at => date_string)
+            instance = @klass.new('updated_at' => date_string)
+
             lambda {
               instance.updated_at.should == '?'
-            }.should raise_error
+            }.should raise_error ArgumentError
           end
         end
       end

data/spec/document_spec.rb

@@ -29,6 +29,21 @@ describe FederalRegister::Document do
       result.end_page.should be(nil)
     end
 
+    it "fetches the document with the provided publication date (when present)" do
+      document_number = "2010-213"
+      publication_date = "2010-02-02"
+      FakeWeb.register_uri(
+        :get,
+        "https://www.federalregister.gov/api/v1/documents/#{document_number}.json?publication_date=#{publication_date}",
+        :content_type => "text/json",
+        :body => {:title => "Important Notice", :publication_date => publication_date}.to_json
+      )
+
+      result = FederalRegister::Document.find(document_number, :publication_date => publication_date)
+      result.title.should eql("Important Notice")
+      result.publication_date.should eql(Date.parse(publication_date))
+    end
+
     it "throws an error when a document doesn't exist" do
       document_number = "some-random-document"
       FakeWeb.register_uri(

data/spec/spec_helper.rb

@@ -13,6 +13,8 @@ FakeWeb.allow_net_connect = false
 # in ./support/ and its subdirectories.
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}
 
-# RSpec.configure do |config|
-#
-# end
+RSpec.configure do |config|
+  config.expect_with(:rspec) { |c| c.syntax = :should }
+end
+
+

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: federal_register
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.7.3
 platform: ruby
 authors:
 - Andrew Carpenter
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-13 00:00:00.000000000 Z
+date: 2019-11-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty