fech 1.3 → 1.3.1

data/README.rdoc

@@ -6,7 +6,7 @@
 
 Fech makes it easy to parse electronic campaign finance filings[http://www.fec.gov/finance/disclosure/efile_search.shtml] by candidates, parties and political action committees from the Federal Election Commission. It lets you access filing attributes the same way regardless of filing version, and works as a framework for cleaning and filing data. Fech is an open source project of The New York Times, but contributions from anyone interested in working with F.E.C. filings are greatly appreciated.
 
-Latest version: 1.3
+Latest version: 1.3.1
 
 Fech is tested under Ruby versions 1.8.7, 1.9.2 and 1.9.3.
 
@@ -16,7 +16,7 @@ Can be found at Fech's Github page[http://nytimes.github.com/Fech/].
 
 == News
 
-* Dec. 11, 2012: Version 1.3 released. Adds support for F13 filings from inaugural committees.
+* Dec. 11, 2012: Versions 1.3, 1.3.1 released. Adds support for F13 filings from inaugural committees and fixes an encoding bug.
 * Dec. 3, 2012: Version 1.2 released. Fixes encoding errors under Ruby 1.9.3 for ASCII-encoded filings. Thanks to Sanjiv for the bug report.
 * Nov. 13, 2012: Version 1.1 released. CSVDoctor skips rows that don't match row type being searched for, which provides a performance boost, and smaller bugfixes for Form 99 handling and date-field conversions. Thanks to Sai for several patches.
 * June 16, 2012: Version 1.0.1 released. Bug-fix for older Form 2 support.

data/lib/fech/csv.rb

@@ -39,7 +39,7 @@ module Fech
     # the file to a function that will parse it individually.
     # @option opts [Boolean] :row_type yield only rows that match this type
     def self.parse_row(file_path, opts)
-      File.open(file_path, 'r', :encoding => opts[:encoding]).each do |line|
+      File.open(file_path, "r:#{opts[:encoding]}").each do |line|
         # Skip empty lines
         next if line.strip.empty?
 
@@ -55,6 +55,8 @@ module Fech
     # @param [String] line the file's row to parse
     # @options opts :quote_char the quote_char to try initially
     def self.safe_line(line, opts)
+      # :encoding isn't a valid argument to Csv#parse_line
+      opts.delete(:encoding)
       begin
         parse_line(line, opts)
       rescue Fech::Csv::MalformedCSVError

data/lib/fech/version.rb

@@ -1,3 +1,3 @@
 module Fech
-  VERSION = "1.3"
+  VERSION = "1.3.1"
 end

data/spec/csv_spec.rb

@@ -0,0 +1,14 @@
+require 'spec_helper'
+
+describe Fech::Csv do
+  
+  before do
+    @filing = Fech::Filing.new(723604, :csv_parser => Fech::CsvDoctor)
+    @filing.stubs(:file_path).returns(File.join(File.dirname(__FILE__), 'data', '723604.fec'))
+  end
+
+  it "should parse a filing using CsvDoctor" do
+    @filing.rows_like(//) { |row| nil }
+  end
+
+end

metadata

@@ -1,12 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: fech
 version: !ruby/object:Gem::Version 
-  hash: 9
+  hash: 25
   prerelease: 
   segments: 
   - 1
   - 3
-  version: "1.3"
+  - 1
+  version: 1.3.1
 platform: ruby
 authors: 
 - Michael Strickland
@@ -280,6 +281,7 @@ files:
 - sources/headers/8.0.csv
 - sources/headers/ignore.csv
 - spec/comparison_spec.rb
+- spec/csv_spec.rb
 - spec/data/425925.fec
 - spec/data/467627.fec
 - spec/data/723604.fec