featury 1.0.0.rc12 → 1.0.0.rc14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: da71740ad8da839e25609eca445d6571c6addf96cbf3237f0d274f866ef7c04d
-  data.tar.gz: 0dcf024bda1d4573fa0a0231ac03393490c18559c923786e8787069ff994eb1a
+  metadata.gz: e96956d416b000864c67950857203f8b5684e6340b5f73bce937415ec19b4847
+  data.tar.gz: b55c10a5650293385194cccf8b18bf954bccecac287b244b80801a6d5ec7b587
 SHA512:
-  metadata.gz: 2a7a0ba73969fa85cc350fabd84a3feeb7e54c984100e8eb4659a572659d9e20ecd132f3a8446a0aecac477bcc807afc28c0ee82b9bff78da4b02f3eb5a3913e
-  data.tar.gz: 1b4dee48909191577fbd353ad1f75932c0b0dbe96e21ec73c5a60813af8b57d7e3fbff48fa82118ded6c8d3f2b94623d4955320eb371a6d03c8a0066ca0993d7
+  metadata.gz: 4c3e6a1e487b2987c0d8ac8f9177be1fe63191b6f2522b9d355db792c03cf40ba378b5b9d0c58ac90c439e1c587ca3e384da99287dd1f292b7dbebf2250b1bf4
+  data.tar.gz: '0193892e10d804f0edde8bbc201eb8c8c42de5209d54d23f2f990da1a571aa83e9efcbbf0a99c7a4bdd052d25cb3968d394e368d52d1b713340cbaf62be7bcd2'

data/README.md

@@ -26,7 +26,7 @@ gem "featury"
 #### Basic class for your features
 
 For instance, assume that you are utilizing Flipper for managing features.
-In such scenario, the base class could potentially be structured as follows:
+In such a scenario, the base class could potentially be structured as follows:
 
 ```ruby
 class ApplicationFeature < Featury::Base
@@ -45,19 +45,27 @@ class ApplicationFeature < Featury::Base
   action :disable do |features:, **options|
     features.all? { |feature| Flipper.disable(feature, *options.values) }
   end
+
+  before do |action:, features:|
+    Slack::API::Notify.call!(action:, features:)
+  end
+
+  after do |action:, features:|
+    Slack::API::Notify.call!(action:, features:)
+  end
 end
 ```
 
 #### Features of your project
 
 ```ruby
-class UserFeature::Onboarding < ApplicationFeature
+class User::OnboardingFeature < ApplicationFeature
+  prefix :user_onboarding
+
   resource :user, type: User
 
   condition ->(resources:) { resources.user.onboarding_awaiting? }
 
-  prefix :user_onboarding
-
   features :passage # => :user_onboarding_passage
 
   groups BillingFeature,
@@ -104,16 +112,16 @@ Each of these actions will be applied to every feature flag.
 Subsequently, the outcome of these actions will be contingent upon the combined results of all feature flags.
 
 ```ruby
-UserFeature::Onboarding.enabled?(user:) # => true
-UserFeature::Onboarding.disabled?(user:) # => false
-UserFeature::Onboarding.enable(user:) # => true
-UserFeature::Onboarding.disable(user:) # => true
+User::OnboardingFeature.enabled?(user:) # => true
+User::OnboardingFeature.disabled?(user:) # => false
+User::OnboardingFeature.enable(user:) # => true
+User::OnboardingFeature.disable(user:) # => true
 ```
 
 You can also utilize the `with` method to pass necessary arguments.
 
 ```ruby
-feature = UserFeature::Onboarding.with(user:)
+feature = User::OnboardingFeature.with(user:)
 
 feature.enabled? # => true
 feature.disabled? # => false

data/lib/featury/base.rb

@@ -4,6 +4,7 @@ module Featury
   class Base
     include Context::DSL
     include Actions::DSL
+    include Callbacks::DSL
     include Groups::DSL
     include Features::DSL
     include Conditions::DSL

data/lib/featury/callbacks/callback.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+module Featury
+  module Callbacks
+    class Callback
+      attr_reader :desired_actions, :block
+
+      def initialize(stage:, desired_actions:, block:)
+        @stage = stage.to_sym
+        @desired_actions = desired_actions
+        @block = block
+      end
+
+      def before?
+        @stage == :before
+      end
+
+      def after?
+        @stage == :after
+      end
+    end
+  end
+end

data/lib/featury/callbacks/collection.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+module Featury
+  module Callbacks
+    class Collection
+      extend Forwardable
+      def_delegators :@collection, :<<, :filter, :each, :map, :merge, :find
+
+      def initialize(collection = Set.new)
+        @collection = collection
+      end
+
+      def desired_actions(include:)
+        Collection.new(
+          filter do |callback|
+            callback.desired_actions.blank? ||
+              callback.desired_actions.include?(include)
+          end
+        )
+      end
+
+      def before
+        Collection.new(filter(&:before?))
+      end
+
+      def after
+        Collection.new(filter(&:after?))
+      end
+    end
+  end
+end

data/lib/featury/callbacks/dsl.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+module Featury
+  module Callbacks
+    module DSL
+      def self.included(base)
+        base.extend(ClassMethods)
+        base.include(Workspace)
+      end
+
+      module ClassMethods
+        def inherited(child)
+          super
+
+          child.send(:collection_of_callbacks).merge(collection_of_callbacks)
+        end
+
+        private
+
+        def before(*actions)
+          collection_of_callbacks << Callback.new(
+            stage: :before,
+            desired_actions: actions,
+            block: ->(**arguments) { yield(**arguments) }
+          )
+        end
+
+        def after(*actions)
+          collection_of_callbacks << Callback.new(
+            stage: :after,
+            desired_actions: actions,
+            block: ->(**arguments) { yield(**arguments) }
+          )
+        end
+
+        def collection_of_callbacks
+          @collection_of_callbacks ||= Collection.new
+        end
+      end
+    end
+  end
+end

data/lib/featury/callbacks/service.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+module Featury
+  module Callbacks
+    class Service
+      def self.call!(...)
+        new(...).call!
+      end
+
+      def initialize(action:, callbacks:, features:)
+        @action = action
+        @callbacks = callbacks
+        @features = features
+      end
+
+      def call!
+        @callbacks.desired_actions(include: @action).each do |callback|
+          callback.block.call(action: @action, features: @features)
+        end
+      end
+    end
+  end
+end

data/lib/featury/callbacks/workspace.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+module Featury
+  module Callbacks
+    module Workspace
+      private
+
+      def call!(action:, collection_of_callbacks:, collection_of_features:, **) # rubocop:disable Metrics/MethodLength
+        Featury::Callbacks::Service.call!(
+          action: action.name,
+          callbacks: collection_of_callbacks.before,
+          features: collection_of_features.list
+        )
+
+        result = super
+
+        Featury::Callbacks::Service.call!(
+          action: action.name,
+          callbacks: collection_of_callbacks.after,
+          features: collection_of_features.list
+        )
+
+        result
+      end
+    end
+  end
+end

data/lib/featury/context/callable.rb

@@ -32,6 +32,7 @@ module Featury
           :_call!,
           action:,
           incoming_arguments: arguments.symbolize_keys,
+          collection_of_callbacks:,
           collection_of_resources:,
           collection_of_conditions:,
           collection_of_features:,

data/lib/featury/context/workspace.rb

@@ -7,6 +7,7 @@ module Featury
 
       attr_reader :action,
                   :incoming_arguments,
+                  :collection_of_callbacks,
                   :collection_of_conditions,
                   :collection_of_features,
                   :collection_of_groups
@@ -14,6 +15,7 @@ module Featury
       def _call!(
         action:,
         incoming_arguments:,
+        collection_of_callbacks:,
         collection_of_resources:,
         collection_of_conditions:,
         collection_of_features:,
@@ -22,6 +24,7 @@ module Featury
         call!(
           action:,
           incoming_arguments:,
+          collection_of_callbacks:,
           collection_of_resources:,
           collection_of_conditions:,
           collection_of_features:,
@@ -32,6 +35,7 @@ module Featury
       def call!(
         action:,
         incoming_arguments:,
+        collection_of_callbacks:,
         collection_of_resources:,
         collection_of_conditions:,
         collection_of_features:,
@@ -39,6 +43,7 @@ module Featury
       )
         @action = action
         @incoming_arguments = incoming_arguments
+        @collection_of_callbacks = collection_of_callbacks
         @collection_of_resources = collection_of_resources
         @collection_of_conditions = collection_of_conditions
         @collection_of_features = collection_of_features

data/lib/featury/features/collection.rb

@@ -11,7 +11,7 @@ module Featury
       end
 
       def list
-        map { |feature| :"#{feature.prefix}_#{feature.name}" }
+        @list ||= map { |feature| :"#{feature.prefix}_#{feature.name}" }
       end
     end
   end

data/lib/featury/features/dsl.rb

@@ -17,15 +17,32 @@ module Featury
         private
 
         def prefix(prefix)
-          @prefix = prefix
+          self.feature_prefix = prefix
         end
 
         def features(*names)
           names.each do |name|
-            collection_of_features << Feature.new(@prefix, name)
+            collection_of_features << Feature.new(feature_prefix, name)
           end
         end
 
+        def feature_prefix=(value)
+          @feature_prefix = value
+        end
+
+        def feature_prefix
+          @feature_prefix || default_feature_prefix
+        end
+
+        def default_feature_prefix
+          @default_feature_prefix ||=
+            name.underscore
+                .gsub(/([a-z])(\d+)/, '\1_\2')
+                .gsub(/(\d+)([a-z])/, '\1_\2')
+                .tr("/", "_")
+                .to_sym
+        end
+
         def collection_of_features
           @collection_of_features ||= Collection.new
         end

data/lib/featury/version.rb

@@ -5,7 +5,7 @@ module Featury
     MAJOR = 1
     MINOR = 0
     PATCH = 0
-    PRE = "rc12"
+    PRE = "rc14"
 
     STRING = [MAJOR, MINOR, PATCH, PRE].compact.join(".")
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: featury
 version: !ruby/object:Gem::Version
-  version: 1.0.0.rc12
+  version: 1.0.0.rc14
 platform: ruby
 authors:
 - Anton Sokolov
@@ -160,6 +160,11 @@ files:
 - lib/featury/actions/service/factory.rb
 - lib/featury/actions/workspace.rb
 - lib/featury/base.rb
+- lib/featury/callbacks/callback.rb
+- lib/featury/callbacks/collection.rb
+- lib/featury/callbacks/dsl.rb
+- lib/featury/callbacks/service.rb
+- lib/featury/callbacks/workspace.rb
 - lib/featury/conditions/collection.rb
 - lib/featury/conditions/condition.rb
 - lib/featury/conditions/dsl.rb