featurevisor 0.3.0 → 1.0.0

data/lib/featurevisor/modules.rb

@@ -0,0 +1,184 @@
+# frozen_string_literal: true
+
+require "securerandom"
+
+module Featurevisor
+  # Modules extend evaluation behavior and SDK lifecycle.
+  module Modules
+    class FeaturevisorModule
+      attr_reader :id, :name
+
+      def initialize(options = {})
+        @id = SecureRandom.uuid
+        @name = options[:name]
+        @setup = options[:setup]
+        @before = options[:before]
+        @bucket_key = options[:bucket_key]
+        @bucket_value = options[:bucket_value]
+        @after = options[:after]
+        @close = options[:close]
+      end
+
+      def call_setup(api)
+        @setup.call(api) if @setup
+      end
+
+      def call_before(options)
+        return options unless @before
+
+        @before.call(options)
+      end
+
+      def call_bucket_key(options)
+        return options[:bucket_key] unless @bucket_key
+
+        @bucket_key.call(options)
+      end
+
+      def call_bucket_value(options)
+        return options[:bucket_value] unless @bucket_value
+
+        @bucket_value.call(options)
+      end
+
+      def call_after(evaluation, options)
+        return evaluation unless @after
+
+        @after.call(evaluation, options)
+      end
+
+      def call_close
+        @close.call if @close
+      end
+    end
+
+    class ModulesManager
+      attr_reader :modules
+
+      def initialize(options = {})
+        @modules = []
+        @report_diagnostic = options[:report_diagnostic]
+        @module_api_factory = options[:module_api_factory]
+        @clear_module_diagnostic_subscriptions = options[:clear_module_diagnostic_subscriptions]
+
+        (options[:modules] || []).each do |mod|
+          add(mod)
+        end
+      end
+
+      def add(mod)
+        mod = FeaturevisorModule.new(mod) if mod.is_a?(Hash)
+        return nil unless mod
+
+        if mod.name && !mod.name.to_s.empty? && @modules.any? { |existing| existing.name == mod.name }
+          report(
+            {
+              level: "error",
+              code: "duplicate_module",
+              message: "Duplicate module name",
+              module_name: mod.name
+            },
+            nil
+          )
+          return nil
+        end
+
+        begin
+          mod.call_setup(@module_api_factory.call(mod)) if @module_api_factory
+        rescue => e
+          @clear_module_diagnostic_subscriptions.call(mod) if @clear_module_diagnostic_subscriptions
+          report(
+            {
+              level: "error",
+              code: "module_setup_error",
+              message: "Module setup failed",
+              module_name: mod.name,
+              original_error: e
+            },
+            nil
+          )
+          close_module(mod)
+          return nil
+        end
+        @modules << mod
+
+        -> { remove(mod) }
+      end
+
+      def remove(name_or_module)
+        removed = []
+        @modules = @modules.reject do |mod|
+          matches = name_or_module.equal?(mod) || mod.name == name_or_module
+          removed << mod if matches
+          matches
+        end
+
+        removed.each do |mod|
+          @clear_module_diagnostic_subscriptions.call(mod) if @clear_module_diagnostic_subscriptions
+          close_module(mod)
+        end
+      end
+
+      def get_all
+        @modules
+      end
+
+      def run_before_modules(options)
+        @modules.reduce(options) do |result, mod|
+          mod.call_before(result)
+        end
+      end
+
+      def run_bucket_key_modules(options)
+        bucket_key = options[:bucket_key]
+        @modules.each do |mod|
+          bucket_key = mod.call_bucket_key(options.merge(bucket_key: bucket_key))
+        end
+        bucket_key
+      end
+
+      def run_bucket_value_modules(options)
+        bucket_value = options[:bucket_value]
+        @modules.each do |mod|
+          bucket_value = mod.call_bucket_value(options.merge(bucket_value: bucket_value))
+        end
+        bucket_value
+      end
+
+      def run_after_modules(evaluation, options)
+        @modules.reduce(evaluation) do |result, mod|
+          mod.call_after(result, options)
+        end
+      end
+
+      def close_all
+        @modules.each do |mod|
+          @clear_module_diagnostic_subscriptions.call(mod) if @clear_module_diagnostic_subscriptions
+          close_module(mod)
+        end
+        @modules = []
+      end
+
+      private
+
+      def close_module(mod)
+        mod.call_close
+      rescue => e
+        report(
+          {
+            level: "error",
+            code: "module_close_error",
+            message: "Module close failed",
+            module_name: mod.name,
+            original_error: e
+          },
+          nil
+        )
+      end
+
+      def report(diagnostic, mod)
+        @report_diagnostic.call(diagnostic, mod) if @report_diagnostic
+      end
+    end
+  end
+end

data/lib/featurevisor/version.rb

@@ -1,3 +1,3 @@
 module Featurevisor
-  VERSION = "0.3.0"
+  VERSION = "1.0.0"
 end

data/lib/featurevisor.rb

@@ -6,7 +6,7 @@ require_relative "featurevisor/emitter"
 require_relative "featurevisor/conditions"
 require_relative "featurevisor/datafile_reader"
 require_relative "featurevisor/bucketer"
-require_relative "featurevisor/hooks"
+require_relative "featurevisor/modules"
 require_relative "featurevisor/evaluate"
 require_relative "featurevisor/instance"
 require_relative "featurevisor/child_instance"
@@ -14,4 +14,7 @@ require_relative "featurevisor/events"
 
 module Featurevisor
   class Error < StandardError; end
+
+  private_constant :DatafileReader
+  private_constant :Logger
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: featurevisor
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Fahad Heylaal
@@ -9,6 +9,20 @@ bindir: bin
 cert_chain: []
 date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: benchmark
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -60,9 +74,9 @@ files:
 - lib/featurevisor/emitter.rb
 - lib/featurevisor/evaluate.rb
 - lib/featurevisor/events.rb
-- lib/featurevisor/hooks.rb
 - lib/featurevisor/instance.rb
 - lib/featurevisor/logger.rb
+- lib/featurevisor/modules.rb
 - lib/featurevisor/murmurhash.rb
 - lib/featurevisor/version.rb
 homepage: https://featurevisor.com

data/lib/featurevisor/hooks.rb

@@ -1,159 +0,0 @@
-# frozen_string_literal: true
-
-module Featurevisor
-  # Hooks module for extending evaluation behavior
-  module Hooks
-    # Hook interface for extending evaluation behavior
-    class Hook
-      attr_reader :name
-
-      # Initialize a new hook
-      # @param options [Hash] Hook options
-      # @option options [String] :name Hook name
-      # @option options [Proc, nil] :before Before evaluation hook
-      # @option options [Proc, nil] :bucket_key Bucket key configuration hook
-      # @option options [Proc, nil] :bucket_value Bucket value configuration hook
-      # @option options [Proc, nil] :after After evaluation hook
-      def initialize(options)
-        @name = options[:name]
-        @before = options[:before]
-        @bucket_key = options[:bucket_key]
-        @bucket_value = options[:bucket_value]
-        @after = options[:after]
-      end
-
-      # Call the before hook if defined
-      # @param options [Hash] Evaluation options
-      # @return [Hash] Modified evaluation options
-      def call_before(options)
-        return options unless @before
-
-        @before.call(options)
-      end
-
-      # Call the bucket key hook if defined
-      # @param options [Hash] Bucket key options
-      # @return [String] Modified bucket key
-      def call_bucket_key(options)
-        return options[:bucket_key] unless @bucket_key
-
-        @bucket_key.call(options)
-      end
-
-      # Call the bucket value hook if defined
-      # @param options [Hash] Bucket value options
-      # @return [Integer] Modified bucket value
-      def call_bucket_value(options)
-        return options[:bucket_value] unless @bucket_value
-
-        @bucket_value.call(options)
-      end
-
-      # Call the after hook if defined
-      # @param evaluation [Hash] Evaluation result
-      # @param options [Hash] Evaluation options
-      # @return [Hash] Modified evaluation result
-      def call_after(evaluation, options)
-        return evaluation unless @after
-
-        @after.call(evaluation, options)
-      end
-    end
-
-    # HooksManager class for managing hooks
-    class HooksManager
-      attr_reader :hooks, :logger
-
-      # Initialize a new HooksManager
-      # @param options [Hash] Options hash containing hooks and logger
-      # @option options [Array<Hook>] :hooks Array of hooks
-      # @option options [Logger] :logger Logger instance
-      def initialize(options)
-        @logger = options[:logger]
-        @hooks = []
-
-        if options[:hooks]
-          options[:hooks].each do |hook|
-            add(hook)
-          end
-        end
-      end
-
-      # Add a hook to the manager
-      # @param hook [Hook] Hook to add
-      # @return [Proc, nil] Remove function or nil if hook already exists
-      def add(hook)
-        if @hooks.any? { |existing_hook| existing_hook.name == hook.name }
-          @logger.error("Hook with name \"#{hook.name}\" already exists.", {
-            name: hook.name,
-            hook: hook
-          })
-
-          return nil
-        end
-
-        @hooks << hook
-
-        # Return a remove function
-        -> { remove(hook.name) }
-      end
-
-      # Remove a hook by name
-      # @param name [String] Hook name to remove
-      def remove(name)
-        @hooks = @hooks.reject { |hook| hook.name == name }
-      end
-
-      # Get all hooks
-      # @return [Array<Hook>] Array of all hooks
-      def get_all
-        @hooks
-      end
-
-      # Run before hooks
-      # @param options [Hash] Evaluation options
-      # @return [Hash] Modified evaluation options
-      def run_before_hooks(options)
-        result = options
-        @hooks.each do |hook|
-          result = hook.call_before(result)
-        end
-        result
-      end
-
-      # Run bucket key hooks
-      # @param options [Hash] Bucket key options
-      # @return [String] Modified bucket key
-      def run_bucket_key_hooks(options)
-        bucket_key = options[:bucket_key]
-        @hooks.each do |hook|
-          bucket_key = hook.call_bucket_key(options.merge(bucket_key: bucket_key))
-        end
-        bucket_key
-      end
-
-      # Run bucket value hooks
-      # @param options [Hash] Bucket value options
-      # @return [Integer] Modified bucket value
-      def run_bucket_value_hooks(options)
-        bucket_value = options[:bucket_value]
-        @hooks.each do |hook|
-          bucket_value = hook.call_bucket_value(options.merge(bucket_value: bucket_value))
-        end
-        bucket_value
-      end
-
-      # Run after hooks
-      # @param evaluation [Hash] Evaluation result
-      # @param options [Hash] Evaluation options
-      # @return [Hash] Modified evaluation result
-      def run_after_hooks(evaluation, options)
-        result = evaluation
-        @hooks.each do |hook|
-          result = hook.call_after(result, options)
-        end
-        result
-      end
-    end
-  end
-end