featurer 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b841a0cb7f4bdda8b8484436e69c086ed3c356e8
-  data.tar.gz: b3cef4ae265b6de20e91b174923e676afaaa2dbf
+  metadata.gz: 229df6bdbec627a7618b56cab5bfde8771c28689
+  data.tar.gz: 14aca1cb4f1eb24914320f5471024e5031c450ff
 SHA512:
-  metadata.gz: 77548e6ba64d74da3a3f94a309084469e9fe6fffdd9f1b4bdae38aa632bbc589f872de9bd66ccffe1be7e1d74dbdbc0c7a326b5305dba4da6a8ca713393db89f
-  data.tar.gz: 8ea8674ab337fbb44b1eccdd95da7d5cde70d22a251c871569143ad21834da0ea77b657d930d1d5dc3b27668ed7b83aca74bdb98dd54237d044ac4c9c6fd90d1
+  metadata.gz: 6cb0799b3aee303df9d5a1bc95ad261435f9dbeb2431a90dd3bc3a258f5df21fdfe09b13f13fcc9eb157326e4b83d65122f8e0d3db8089b2a20327f87ea0fde4
+  data.tar.gz: 0774e3c0335f70e605e327e591cf7caf55c9b086edc93ad3193b3d59a9663ab6b7415f7052803181631f1f630c8c49295158c56c4ded6706b873e3edb7a9158a

data/lib/featurer/adapters/redis.rb

@@ -36,7 +36,8 @@ module Featurer
     end
 
     def register(feature, value = true)
-      # ensure old data is wiped
+      return if feature.nil? || feature.empty?
+
       delete(feature)
       save_set(feature, value)
     end

data/lib/featurer/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Featurer
-  VERSION = '0.1.0'.freeze
+  VERSION = '0.1.1'.freeze
 end

data/spec/lib/featurer/adapters/redis_spec.rb

@@ -75,4 +75,38 @@ describe Featurer::RedisAdapter do
       end
     end
   end
+
+  describe '#register' do
+    shared_examples 'rejected feature' do
+      it "doesn't register the feature" do
+        expect(subject).not_to receive(:delete)
+        expect(subject).not_to receive(:save_set)
+
+        subject.register(feature)
+      end
+    end
+
+    context 'feature name is not empty' do
+      let(:feature) { 'awesome_feature' }
+
+      it 'registers the feature' do
+        expect(subject).to receive(:delete).with(feature)
+        expect(subject).to receive(:save_set).with(feature, true)
+
+        subject.register(feature)
+      end
+    end
+
+    context 'feature name is empty' do
+      let(:feature) { '' }
+
+      it_behaves_like 'rejected feature'
+    end
+
+    context 'feature name is nil' do
+      let(:feature) { nil }
+
+      it_behaves_like 'rejected feature'
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: featurer
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Alejandro El Informatico