featureparity 0.0.20 → 0.0.21

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 65fc8c40a37a8d05f6fd566fd6362a5b5f489c3ee516ea4643c37afedb0d4534
-  data.tar.gz: 2a05968f741537fbc82fc0cc12cb67d7f4bf9fa2c5cebd11bc3514a9637e1745
+  metadata.gz: 6ae3f4be081207da9feb300fbdfaad6d2afddf2ffb021ffc8136508da964f0c2
+  data.tar.gz: 74d2cf3feb18ea77cac72f38be15c5eb6870d237d76f2a21a3b859853649b02d
 SHA512:
-  metadata.gz: a9dc847a7281c8b018547b97fb3c06b9bbcf0bcaee596cf1afb098428f025a48af5b01acaad7b76583ed18f0385602dbc9ccae47f5a9605220bacfe31f543723
-  data.tar.gz: 95909562928c8f9780eafed047018e8d9e752d6a3e10a5feeb09cdd716ac14945e39948d692aa04102d233f1403570f8e4e926225257093e56a7ed08c1af7b1e
+  metadata.gz: f14f50d9f5e6d620341081a55ee98734bafd6893ade078cb424246c6ddb16a2f85a8aff6b5d28dc1d969505708b0e59806628699c47146736b024f90c0e0c6e6
+  data.tar.gz: 156d5c4e679017b8d5ec7825eb51d7eb64acec51daf02700a263f58e20251c2136efadab399244856f4ce943fe832825e89e45a75f57a814368e8dbc54a5189e

data/lib/fp/client.rb

@@ -72,6 +72,16 @@ module Fp
       post("/api/projects/#{project_id}/surfaces", params)
     end
 
+    # PUT /projects/:id/surfaces/:surface_id
+    def update_surface(project_id, surface_id, params)
+      put("/api/projects/#{project_id}/surfaces/#{surface_id}", params)
+    end
+
+    # DELETE /projects/:id/surfaces/:surface_id
+    def delete_surface(project_id, surface_id)
+      delete("/api/projects/#{project_id}/surfaces/#{surface_id}")
+    end
+
     # GET /requirements
     def list_requirements(project_id: nil, status: nil, category: nil, tag: nil)
       params = {}

data/lib/fp/commands/help.rb

@@ -21,6 +21,8 @@ module Fp
             surfaces --project <slug>         List surfaces for a project
             surfaces show <key> --project ... View a single surface's details
             surfaces add <key> --project ...  Create a surface
+            surfaces edit <key> --project ... Change a surface (name, kind, repo, key...)
+            surfaces delete <key> --project . Delete a surface (asks first; --yes to skip)
             list --project <slug>             List active requirements
             show <slug> --project <slug>      Show requirement details
             propose --project <slug> ...      Propose a new requirement (as draft)
@@ -178,6 +180,12 @@ module Fp
               --kind android \\
               --repo stowzilla/customer-android
 
+            # Fix up an existing surface (add refuses a key that already exists)
+            fp surfaces edit web --project stowzilla --kind web --repo stowzilla/web
+
+            # Delete a surface (type the key back, or --yes non-interactively)
+            fp surfaces delete web --project stowzilla --yes
+
             # List requirements for a project
             fp list --project stowzilla
 

data/lib/fp/commands/history.rb

@@ -22,7 +22,16 @@ module Fp
         'change_proposed' => 'change proposed',
         'removal_proposed' => 'deletion proposed',
         'change_approved' => 'change approved',
-        'change_rejected' => 'change rejected'
+        'change_rejected' => 'change rejected',
+        'decision_recorded' => 'decision recorded'
+      }.freeze
+
+      # A member's own stance on a requirement that already has a status (Fizzy #1478),
+      # including a request for changes (Fizzy #1481) — its note says what to change.
+      DECISION_LABELS = {
+        'approve' => 'approves',
+        'request_changes' => 'requests changes',
+        'reject' => 'rejects'
       }.freeze
 
       def run(args)
@@ -86,11 +95,13 @@ module Fp
 
       def print_entry(change)
         label = TYPE_LABELS[change['type']] || change['type']
+        label = DECISION_LABELS.fetch(change['decision'], label) if change['type'] == 'decision_recorded'
         actor = change['actor'] || 'unknown'
         kind = change['actor_kind'] == 'agent' ? 'agent' : 'human'
 
         puts "* #{label} — #{actor} (#{kind}) at #{format_time(change['recorded_at'])}"
         puts "  #{change['reason']}" if present?(change['reason'])
+        puts "  note: #{change['note']}" if change['type'] == 'decision_recorded' && present?(change['note'])
         print_source(change['source'])
         print_diff(change['changes'])
         print_evidence_diff(change['evidence_diff'])

data/lib/fp/commands/surfaces.rb

@@ -7,10 +7,17 @@ module Fp
     # fp surfaces --project <slug>              - list available surfaces for a project
     # fp surfaces show <key> --project <slug>   - view a single surface's details
     # fp surfaces add <key> --project <slug>    - create a surface
+    # fp surfaces edit <key> --project <slug>   - change an existing surface
+    # fp surfaces delete <key> --project <slug> - delete a surface, with confirmation
     #
     # `add` exists because a requirement can only name surfaces that already exist, so an
     # agent onboarding a project it hasn't seen before would otherwise be blocked waiting
     # on a human to click through the web app.
+    #
+    # `edit` and `delete` exist because `add` on an existing key used to make a second
+    # surface with the same key, and there was no way to fix that short of a raw API call
+    # (Fizzy #1480). The server now refuses a duplicate key with a 409; `add` turns that
+    # into a pointer at `edit`. `delete` is guarded like `fp projects delete`.
     class Surfaces < Base
       ADD_FLAGS = {
         project: :string,
@@ -21,6 +28,13 @@ module Fp
         default_branch: :string
       }.freeze
 
+      EDIT_FLAGS = ADD_FLAGS.merge(key: :string).freeze
+
+      DELETE_FLAGS = {
+        project: :string,
+        yes: :boolean
+      }.freeze
+
       VALID_KINDS = %w[api web android ios other].freeze
       VALID_AUDIENCES = %w[customer ops both internal].freeze
 
@@ -32,6 +46,10 @@ module Fp
           add(args[1..])
         when 'show'
           show(args[1..])
+        when 'edit'
+          edit(args[1..])
+        when 'delete'
+          delete(args[1..])
         else
           list(args)
         end
@@ -116,6 +134,15 @@ module Fp
 
         result = client.create_surface(project_id, params)
 
+        if !result[:ok] && result[:status] == 409
+          output.error(
+            "Surface '#{key}' already exists in project '#{opts[:project]}'. " \
+            "Change it with: fp surfaces edit #{key} --project #{opts[:project]} [--name ...] [--kind ...] [--repo ...]",
+            status: 409
+          )
+          exit 1
+        end
+
         unless result[:ok]
           output.error(result[:error], status: result[:status])
           exit 1
@@ -133,6 +160,124 @@ module Fp
         end
       end
 
+      def edit(args)
+        opts, positional = parse_flags(args, EDIT_FLAGS)
+        require_project!(opts)
+
+        key = positional.first
+        if key.nil? || key.strip.empty?
+          output.error('Usage: fp surfaces edit <key> --project <slug> [--name "Name"] [--kind ...] ' \
+                       '[--audience ...] [--repo org/repo] [--default-branch main] [--key new_key]')
+          exit 1
+        end
+
+        validate_choice!(opts[:kind], VALID_KINDS, '--kind')
+        validate_choice!(opts[:audience], VALID_AUDIENCES, '--audience')
+
+        # Only what was passed is sent, so an edit never blanks a field it wasn't asked about.
+        params = {}
+        %i[key name kind audience repo default_branch].each do |field|
+          params[field] = opts[field] if opts.key?(field)
+        end
+
+        if params.empty?
+          output.error('Nothing to change. Pass --name, --kind, --audience, --repo, --default-branch, or --key.')
+          exit 1
+        end
+
+        project_id = resolve_project_id(opts[:project])
+        surface = find_surface!(project_id, key)
+
+        result = client.update_surface(project_id, surface['id'], params)
+
+        unless result[:ok]
+          output.error(result[:error], status: result[:status])
+          exit 1
+        end
+
+        # The update action answers with update!'s return value, not the record, so read
+        # the surface back rather than trusting the response body.
+        updated = client.get_surface(project_id, surface['id'])
+        record = (updated[:ok] && updated[:data]['surface']) || surface.merge(params.transform_keys(&:to_s))
+
+        output.success({ surface: record, project: opts[:project] }) do
+          puts "Updated surface '#{record['key']}' in project '#{opts[:project]}'."
+          puts
+          puts "  Name:     #{record['name']}"
+          puts "  Kind:     #{record['kind']}"
+          puts "  Audience: #{record['audience']}"
+          puts "  Repo:     #{record['repo'] || '(none)'}"
+          puts "  Branch:   #{record['default_branch'] || '(none)'}"
+        end
+      end
+
+      def delete(args)
+        opts, positional = parse_flags(args, DELETE_FLAGS)
+        require_project!(opts)
+
+        key = positional.first
+        if key.nil? || key.strip.empty?
+          output.error('Usage: fp surfaces delete <key> --project <slug> [--yes]')
+          exit 1
+        end
+
+        project_id = resolve_project_id(opts[:project])
+        surface = find_surface!(project_id, key)
+        confirm_delete!(surface, opts)
+
+        result = client.delete_surface(project_id, surface['id'])
+
+        unless result[:ok]
+          output.error(result[:error], status: result[:status])
+          exit 1
+        end
+
+        output.success({ deleted: true, surface: { 'id' => surface['id'], 'key' => surface['key'] },
+                         project: opts[:project] }) do
+          puts "Deleted surface '#{surface['key']}' from project '#{opts[:project]}'."
+        end
+      end
+
+      # Same guard as `fp projects delete`: --yes skips the prompt, an interactive
+      # terminal types the key back, and anything else is refused.
+      def confirm_delete!(surface, opts)
+        return if opts[:yes]
+
+        unless interactive?
+          output.error(
+            "Refusing to delete surface '#{surface['key']}' without confirmation. " \
+            'Re-run with --yes to confirm from a non-interactive session.'
+          )
+          exit 1
+        end
+
+        warn "This will delete surface '#{surface['key']}' (#{surface['name']}) from project '#{opts[:project]}'."
+        warn 'Evidence filed against it stays behind with nothing to measure.'
+        $stderr.print "Type '#{surface['key']}' to confirm: "
+        $stderr.flush
+
+        typed = $stdin.gets&.strip
+        return if typed == surface['key']
+
+        output.error('Aborted. The key did not match; nothing was deleted.')
+        exit 1
+      end
+
+      def interactive?
+        $stdin.respond_to?(:tty?) && $stdin.tty?
+      end
+
+      def find_surface!(project_id, key)
+        result = client.find_surface_by_key(project_id, key)
+
+        unless result[:ok]
+          output.error(result[:error], status: result[:status])
+          exit 1
+        end
+
+        result[:data]['surface']
+      end
+
       def validate_choice!(value, allowed, flag)
         return if value.nil? || allowed.include?(value)
 

data/lib/fp/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Fp
-  VERSION = '0.0.20'
+  VERSION = '0.0.21'
 end

data/skills/fp/references/cli.md

@@ -54,13 +54,26 @@ owner — or a key minted by one — may delete; a member's key gets 403.
 
 ### fp surfaces
 
-List surfaces for a project.
+List, view, create, edit and delete a project's surfaces.
 
 ```bash
 fp surfaces --project stowzilla
 fp surfaces --project stowzilla --json
+fp surfaces show <key> --project stowzilla
+fp surfaces add <key> --project stowzilla [--name "..."] [--kind api|web|android|ios|other] [--audience ...] [--repo org/repo] [--default-branch main]
+fp surfaces edit <key> --project stowzilla [--name "..."] [--kind ...] [--audience ...] [--repo ...] [--default-branch ...] [--key new_key]
+fp surfaces delete <key> --project stowzilla [--yes]
 ```
 
+A key is unique within a project. `add` on a key that already exists fails and points
+you at `edit` — use `edit` to fill in the kind or repo of a surface that `fp projects
+create --surfaces` made with defaults. `edit` only sends the flags you pass. `delete`
+asks you to type the key back in a terminal and refuses without `--yes` otherwise.
+
+A surface that requirements still require can't be deleted or re-keyed — the server
+refuses and names them. Taking a surface off a requirement is a human's call, so ask
+one rather than working around it.
+
 ### fp list
 
 List requirements.

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: featureparity
 version: !ruby/object:Gem::Version
-  version: 0.0.20
+  version: 0.0.21
 platform: ruby
 authors:
 - Stowzilla
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-10-17 00:00:00.000000000 Z
+date: 2026-10-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: net-http