featureflip 2.5.0 → 2.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f3e88364434f9dced8db82624524bf1ffe905b35b5ae8a062896bfb6c02dc5e6
-  data.tar.gz: 87d5bdaa62bb9f6e8eb0685f235315b31adfb5cd0dbdaac478965144a09709ff
+  metadata.gz: a41a0e3edb8d4325e4a0784930973f07ad8339e7b25b127f076bc7cfade0d948
+  data.tar.gz: 6ceb86141220f142710e6a0937af742270c61961ff87f583a2d727bab1c6ee65
 SHA512:
-  metadata.gz: 7b9c0cbfce3e7451f4218dc5a0274a28181d770a5689427d5fba20899702c5a580413b6adcb99482c717708cc2b60cccd5e9ee6dfb423351ff82024befae0477
-  data.tar.gz: d4c066e87770edfa6881cf000d36cc8e7f9f476cc3afebc8b44e5842f2c5946805af79a47dbceb575bd4e50496e56d024b3485fa083d414fb52bf8809b25eff2
+  metadata.gz: 013af1bacae587f2dd832bd7004ac4a94a45e8d635c64204d8ea892d4e62c80112d07856856d097f03393f4bbf7c3aef7d54c378672db9c61623d9053b8e3e3b
+  data.tar.gz: 822537c99bfdd30d8f2f4b16b9b8592d2cd23fdaccaf2cea0333fccdf68f0998877bf124da0060ec63abc0fb347f6506ad10f0fc235d8f22291de50a68f20a33

data/lib/featureflip/evaluation/condition_evaluator.rb

@@ -32,6 +32,14 @@ module Featureflip
         targets = condition.values.map(&:to_s)
 
         result = evaluate_operator(condition.operator, str_value, targets)
+
+        # Issue #2262: an unrecognised operator fails CLOSED. `!nil` is `true`
+        # in Ruby, so without this guard a negated unknown operator would match
+        # every user and roll the flag out to 100% of traffic. The realistic
+        # trigger is a new operator shipped server-side reaching an SDK pinned
+        # to an older version.
+        return false if result.nil?
+
         condition.negate ? !result : result
       end
 
@@ -150,7 +158,10 @@ module Featureflip
         when "SemverLessThanOrEqual"
           targets.any? { |t| compare_semver(value, t, :<=) }
         else
-          false
+          # Unrecognised operator. `nil` — NOT `false` — so the caller can tell
+          # "cannot evaluate" apart from "evaluated, did not match"; only the
+          # latter may be inverted by `negate` (#2262).
+          nil
         end
       end
 

data/lib/featureflip/shared_core.rb

@@ -241,25 +241,29 @@ module Featureflip
       return unless @event_processor
 
       context = normalize_context(context)
-      @event_processor.queue_event({
+      @event_processor.queue_event(compact_event({
         type: "Custom",
         flagKey: event_key,
-        userId: context["user_id"]&.to_s,
-        metadata: metadata || {},
+        userId: resolve_event_user_id(context),
+        metadata: metadata,
         timestamp: Time.now.utc.iso8601
-      })
+      }))
     end
 
     def identify(context)
       return unless @event_processor
 
       context = normalize_context(context)
-      @event_processor.queue_event({
+      # Strip both identity spellings so the id is carried once, at the top
+      # level, and not duplicated inside the attribute bag.
+      attributes = context.reject { |k, _| IDENTITY_KEYS.include?(k) }
+      @event_processor.queue_event(compact_event({
         type: "Identify",
         flagKey: "$identify",
-        userId: context["user_id"]&.to_s,
+        userId: resolve_event_user_id(context),
+        metadata: attributes,
         timestamp: Time.now.utc.iso8601
-      })
+      }))
     end
 
     def flush
@@ -417,16 +421,43 @@ module Featureflip
       context.transform_keys(&:to_s)
     end
 
+    # Both spellings of the identity are accepted on an event context; the
+    # canonical +user_id+ wins when a caller supplies both. The evaluator
+    # already aliases these for bucketing, so events have to as well or an
+    # alias caller gets every event attributed to nil.
+    IDENTITY_KEYS = %w[user_id userId].freeze
+
+    def resolve_event_user_id(context)
+      raw = context["user_id"]
+      raw = context["userId"] if raw.nil?
+      raw&.to_s
+    end
+
+    # +userId+ and +metadata+ are optional on the wire. Omit them rather than
+    # sending nulls or empty bags, matching the other SDKs.
+    #
+    # +metadata+ is caller-supplied and untyped, so the emptiness check is
+    # guarded: a caller passing a non-collection must not take a NoMethodError
+    # into their request path just to record an analytics event.
+    def compact_event(event)
+      event.delete(:userId) if event[:userId].nil?
+      metadata = event[:metadata]
+      if metadata.nil? || (metadata.respond_to?(:empty?) && metadata.empty?)
+        event.delete(:metadata)
+      end
+      event
+    end
+
     def record_evaluation(key, context, variation_key)
       return unless @event_processor
 
-      @event_processor.queue_event({
+      @event_processor.queue_event(compact_event({
         type: "Evaluation",
         flagKey: key,
-        userId: context["user_id"]&.to_s,
+        userId: resolve_event_user_id(context),
         variation: variation_key,
         timestamp: Time.now.utc.iso8601
-      })
+      }))
     end
 
     # Fire the registered evaluation inspectors. Called once per variation call

data/lib/featureflip/version.rb

@@ -1,3 +1,3 @@
 module Featureflip
-  VERSION = "2.5.0"
+  VERSION = "2.5.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: featureflip
 version: !ruby/object:Gem::Version
-  version: 2.5.0
+  version: 2.5.1
 platform: ruby
 authors:
 - Featureflip
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-08-20 00:00:00.000000000 Z
+date: 2026-08-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: logger