feature_toggle 0.0.1 → 0.0.2

data/CHANGELOG.md

@@ -0,0 +1,2 @@
+0.0.2 print warnings when feature not exists
+0.0.1 first version for toggling features

data/Rakefile

@@ -0,0 +1,10 @@
+require 'rake'
+require 'rake/testtask'
+
+Rake::TestTask.new do |t|
+    t.libs << "test"
+    t.test_files = FileList['test/*test.rb']
+    t.verbose = true
+end
+
+task :default => :test

data/lib/feature_toggle/features.rb

@@ -13,15 +13,13 @@ module FeatureToggle
 
     def activate(*feature_names)
       feature_names.each do |feature_name|
-        validate!(feature_name)
-        @deactivated_features.delete(feature_name)
+        @deactivated_features.delete(feature_name) if valid?(feature_name)
       end
     end
 
     def deactivate(*feature_names)
       feature_names.each do |feature_name|
-        validate!(feature_name)
-        @deactivated_features << feature_name
+        @deactivated_features << feature_name if valid?(feature_name)
       end
     end
 
@@ -35,9 +33,13 @@ module FeatureToggle
     end
 
     private
-    def validate!(feature_name)
-      raise UnknownFeatureError, "Unknown feature name: #{feature_name}" unless @features.has_key?(feature_name)
+
+    def valid?(feature_name)
+      @features.has_key?(feature_name).tap do |exists|
+        puts "Unknown feature: #{feature_name}" unless exists
+      end
     end
+
     def build_actions_feature_map(features)
       map = {}
       features.each do |feature, controllers|
@@ -50,4 +52,4 @@ module FeatureToggle
       map
     end
   end
-end
+end

data/test/feature_toggle_test.rb

@@ -27,18 +27,10 @@ class FeatureToggleTest < Test::Unit::TestCase
     assert features.active?('user_profile')
   end
 
-  def test_disabling_non_existent_features_should_raise_error
+  def test_disabling_non_existent_features_should_be_ignored
     features = load_features
-    assert_raises FeatureToggle::UnknownFeatureError do
-      features.deactivate("user")
-    end
-  end
-
-  def test_activating_non_existent_features_should_raise_error
-    features = load_features
-    assert_raises FeatureToggle::UnknownFeatureError do
-      features.activate("user")
-    end
+    features.deactivate("user_profile_x")
+    assert features.active?('user_profile')
   end
 
   def test_feature_actions_should_be_active_when_feature_is_active
@@ -57,4 +49,4 @@ class FeatureToggleTest < Test::Unit::TestCase
     config = File.join(File.dirname(__FILE__), 'features.yml')
     FeatureToggle.load(config)
   end
-end
+end

metadata

@@ -1,32 +1,22 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: feature_toggle
-version: !ruby/object:Gem::Version 
-  hash: 29
+version: !ruby/object:Gem::Version
+  version: 0.0.2
   prerelease: 
-  segments: 
-  - 0
-  - 0
-  - 1
-  version: 0.0.1
 platform: ruby
-authors: 
+authors:
 - Mingle SaaS team
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2012-07-31 00:00:00 Z
+date: 2012-09-15 00:00:00.000000000 Z
 dependencies: []
-
 description: 
 email: mingle.saas@thoughtworks.com
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
 - lib/feature_toggle/features.rb
 - lib/feature_toggle.rb
 - test/feature_toggle_test.rb
@@ -36,36 +26,26 @@ files:
 - CHANGELOG.md
 homepage: https://github.com/ThoughtWorksStudios/feature_toggle
 licenses: []
-
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
 rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: Feature Toggle library for ruby
 test_files: []
-