feature_setting 1.7.0 → 1.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d88b8c501d738b622e547956bbbc2e44164e375d72fe949a02749a5dbba93207
-  data.tar.gz: 5ae3b3db98a22c65a7595b4b14015fae8b3b3de9f3c08d506186bb27a2c03657
+  metadata.gz: bc9ce0a91fa49c7c49d2e0abf9d15e636220934e0edb0ec6bec6de2e9ca8c9f3
+  data.tar.gz: 236b4539436772ff6d041e7b0e4b485debb59ffc7e2a2a0b96aee43a2d56c37a
 SHA512:
-  metadata.gz: e97a3af42489cc34a2b4c716b6c36d241eb834156aa0936358cc57b0fb7d387fcfdea6f11d7b01f4e8c7551174d4b37a69800831f5927ae82f0c4f9d58809442
-  data.tar.gz: 6954b1cb38e3314b9cf0f63181c0e6e100ad0e7ed647fa969e6cd71b67b15326ad60092a9de4159035b5e22068b444559d4b2b21831cfff5a9e54e4cfb9996ea
+  metadata.gz: 8a1b7325cfd5dbb39e3ec03d3de42e31733759282e9b952bc0aa2298584bfaeb0243623fd520424756073fde22f5da850ade263777672d95c2824120113dc513
+  data.tar.gz: bdbe4980d868e7e0727748c34ddb255b54ba417e02b102b92c0af974be3f96297127509c2e1e77fe720d53e39b623fa9b17085f03d77240cb1fd977ae4767866

data/.rubocop.yml

@@ -4,6 +4,8 @@ require:
 
 AllCops:
   TargetRubyVersion: 2.6
+  NewCops: enable
+
 Style/FrozenStringLiteralComment:
   Enabled: false
 Metrics/BlockLength:
@@ -24,77 +26,3 @@ Metrics/MethodLength:
   Max: 12
   Exclude:
     - 'lib/generators/**/**'
-RSpec/FilePath:
-  Enabled: false
-Gemspec/DateAssignment: # (new in 1.10)
-  Enabled: true
-Layout/SpaceBeforeBrackets: # (new in 1.7)
-  Enabled: true
-Lint/AmbiguousAssignment: # (new in 1.7)
-  Enabled: true
-Lint/DeprecatedConstants: # (new in 1.8)
-  Enabled: true
-Lint/DuplicateBranch: # (new in 1.3)
-  Enabled: true
-Lint/DuplicateRegexpCharacterClassElement: # (new in 1.1)
-  Enabled: true
-Lint/EmptyBlock: # (new in 1.1)
-  Enabled: true
-Lint/EmptyClass: # (new in 1.3)
-  Enabled: true
-Lint/EmptyInPattern: # (new in 1.16)
-  Enabled: true
-Lint/LambdaWithoutLiteralBlock: # (new in 1.8)
-  Enabled: true
-Lint/NoReturnInBeginEndBlocks: # (new in 1.2)
-  Enabled: true
-Lint/NumberedParameterAssignment: # (new in 1.9)
-  Enabled: true
-Lint/OrAssignmentToConstant: # (new in 1.9)
-  Enabled: true
-Lint/RedundantDirGlobSort: # (new in 1.8)
-  Enabled: true
-Lint/SymbolConversion: # (new in 1.9)
-  Enabled: true
-Lint/ToEnumArguments: # (new in 1.1)
-  Enabled: true
-Lint/TripleQuotes: # (new in 1.9)
-  Enabled: true
-Lint/UnexpectedBlockArity: # (new in 1.5)
-  Enabled: true
-Lint/UnmodifiedReduceAccumulator: # (new in 1.1)
-  Enabled: true
-Style/ArgumentsForwarding: # (new in 1.1)
-  Enabled: true
-Style/CollectionCompact: # (new in 1.2)
-  Enabled: true
-Style/DocumentDynamicEvalDefinition: # (new in 1.1)
-  Enabled: true
-Style/EndlessMethod: # (new in 1.8)
-  Enabled: true
-Style/HashConversion: # (new in 1.10)
-  Enabled: true
-Style/HashExcept: # (new in 1.7)
-  Enabled: true
-Style/IfWithBooleanLiteralBranches: # (new in 1.9)
-  Enabled: true
-Style/InPatternThen: # (new in 1.16)
-  Enabled: true
-Style/MultilineInPatternThen: # (new in 1.16)
-  Enabled: true
-Style/NegatedIfElseCondition: # (new in 1.2)
-  Enabled: true
-Style/NilLambda: # (new in 1.3)
-  Enabled: true
-Style/QuotedSymbols: # (new in 1.16)
-  Enabled: true
-Style/RedundantArgument: # (new in 1.4)
-  Enabled: true
-Style/StringChars: # (new in 1.12)
-  Enabled: true
-Style/SwapValues: # (new in 1.1)
-  Enabled: true
-RSpec/IdenticalEqualityAssertion: # (new in 2.4)
-  Enabled: true
-RSpec/Rails/AvoidSetupHook: # (new in 2.4)
-  Enabled: true

data/README.md

@@ -6,7 +6,7 @@ Version](https://badge.fury.io/rb/feature_setting.svg)](https://badge.fury.io/rb
 Climate](https://codeclimate.com/github/indrode/feature_setting/badges/gpa.svg)](https://codeclimate.com/github/indrode/feature_setting)
 [![Test
 Coverage](https://codeclimate.com/github/indrode/feature_setting/badges/coverage.svg)](https://codeclimate.com/github/indrode/feature_setting/coverage)
-[![security](https://hakiri.io/github/indrode/feature_setting/master.svg)](https://hakiri.io/github/indrode/feature_setting/master) [![Build Status](https://travis-ci.org/indrode/feature_setting.svg?branch=master)](https://travis-ci.org/indrode/feature_setting)
+[![security](https://hakiri.io/github/indrode/feature_setting/master.svg)](https://hakiri.io/github/indrode/feature_setting/master)
 
 This gem introduces the concept of "features" and "settings" to your Rails app. It provides an easy way to define such features and settings with default values right in your code and will persist them in the database.
 
@@ -53,7 +53,6 @@ This generates a migration file. To run this migration:
 
 The next step is to define your Feature and/or Setting classes.
 
-
 ## Usage
 
 ### Features
@@ -90,7 +89,6 @@ Features.disable_newfeature!
 
 Default values for features are defined in your class and current values are persisted in the database.
 
-
 ### Settings
 
 To create a new Setting class, inherit a class from `FeatureSetting::Setting` (if using a gem version prior to `1.2.0` use `FeatureSetting::FsSetting`). Then define your settings in a hash called `SETTINGS` and call `init_settings!`. The following example shows the setup and some possible definitions.
@@ -102,7 +100,7 @@ class Settings < FeatureSetting::Setting
     setting_two:   'some string',
     setting_three: %w(one two three),
     setting_four:  ENV['SETTING_FOUR'],
-    setting_five:  { key1: 'value1', key2: 'value2' }
+    setting_five:  { key1: 'value1', key2: 'value2' },
     setting_six:   true
   }
 
@@ -187,7 +185,6 @@ Notes:
 - Contributions without tests won't be accepted.
 - Please don't update the gem version.
 
-
 ## License
 
 The MIT License (MIT)

data/feature_setting.gemspec

@@ -21,8 +21,8 @@ Gem::Specification.new do |spec|
   spec.files                 = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   spec.require_paths         = ['lib']
 
-  spec.add_runtime_dependency 'activerecord', '>= 4.0'
-  spec.add_runtime_dependency 'activesupport', '>= 4.0'
+  spec.add_runtime_dependency 'activerecord', '>= 5.2.4.5'
+  spec.add_runtime_dependency 'activesupport', '>= 5.2.4.3'
   spec.add_runtime_dependency 'hashie', '>= 3.4.3'
   spec.add_development_dependency 'bundler', '>= 1.9'
   spec.add_development_dependency 'byebug'

data/lib/feature_setting/orm/active_record/fs_feature.rb

@@ -54,8 +54,7 @@ module FeatureSetting
       def define_checker_method(key, &block)
         unless block_given?
           block = proc do
-            record = find_by key: key, klass: klass
-            record ? record.enabled : false
+            find_by(key: key, klass: klass)&.enabled ? true : false
           end
         end
         define_singleton_method("#{key}_enabled?") { block.call }
@@ -90,14 +89,14 @@ module FeatureSetting
       def enable!(key)
         return unless features.key?(key.to_sym)
 
-        record = find_by key: key, klass: klass
+        record = find_by(key: key, klass: klass)
         record.update(enabled: true)
       end
 
       def disable!(key)
         return unless features.key?(key.to_sym)
 
-        record = find_by key: key, klass: klass
+        record = find_by(key: key, klass: klass)
         record.update(enabled: false)
       end
 

data/lib/feature_setting/orm/active_record/fs_setting.rb

@@ -49,7 +49,7 @@ module FeatureSetting
       def cache_settings!
         settings.each do |key, value|
           create_setting(key, value)
-          record = find_by key: key, klass: klass
+          record = find_by(key: key, klass: klass)
           value = ConvertValue.convert_to_type(record.value, record.value_type)
           define_getter_method(key) { value }
         end
@@ -58,7 +58,7 @@ module FeatureSetting
       def define_getter_method(key, &block)
         unless block_given?
           block = proc do
-            record = find_by key: key, klass: klass
+            record = find_by(key: key, klass: klass)
             ConvertValue.convert_to_type(record.value, record.value_type)
           end
         end
@@ -84,7 +84,7 @@ module FeatureSetting
       def set!(key = nil, value = nil)
         raise SettingNotExistsError unless defined_keys.include?(key.to_s)
 
-        record = find_by key: key.to_s, klass: klass
+        record = find_by(key: key.to_s, klass: klass)
         old_value = ConvertValue.convert_to_type(record.value, record.value_type)
 
         if record.value_type == 'Hash'

data/lib/feature_setting/version.rb

@@ -1,3 +1,3 @@
 module FeatureSetting
-  VERSION = '1.7.0'.freeze
+  VERSION = '1.7.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: feature_setting
 version: !ruby/object:Gem::Version
-  version: 1.7.0
+  version: 1.7.1
 platform: ruby
 authors:
 - Indro De
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-08-23 00:00:00.000000000 Z
+date: 2021-09-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: 5.2.4.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: 5.2.4.5
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: 5.2.4.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: 5.2.4.3
 - !ruby/object:Gem::Dependency
   name: hashie
   requirement: !ruby/object:Gem::Requirement