feature_flagger 0.5.0 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 434b1224539eeb898620d2ab8955c3e09f9f3050
-  data.tar.gz: 9cb1463434d02d535642491ccf47c8c639b054ff
+  metadata.gz: c95a74dd29e1ccbb38966d66e368870c9bbba2a3
+  data.tar.gz: 19b9861564074b57ec1c7e8f15080e15c9259379
 SHA512:
-  metadata.gz: 0e83beff5c32c024b8e8a032aa1a7d298f36007ce3c7791e04c05deaf500d3d6424bad331e4622cfd5fe6a0570031264038cc9613f7eef564740d0f66a605996
-  data.tar.gz: c7994cd5011b0a12650a7a9256862d5b16454a472be4876746eea695fd67b850d70643c35b561dfcbb6aac453f82a3d9663b18fbae187ae0e3514b57a70d4452
+  metadata.gz: d942d7da67e349ebeb8bc0eac07896a19c91bbce01deee210044f07af78184b12d6a9f4ceddd255c2079f37190130c2906cf54c7e6f78970b43904fab1274050
+  data.tar.gz: 8bac72b54148363152b8d2d092e1cea26976945dfed64797b0d83e0f412c0598cdaeebb8454ee22fdf820a62a90853c32bab4387fa4fd6ba90ec2cd707a7a036

data/README.md

@@ -60,7 +60,7 @@ end
 account = Account.first
 
 # Release feature for account
-account.release!(:email_marketing, :new_email_flow)
+account.release(:email_marketing, :new_email_flow)
 #=> true
 
 # Check feature for a given account
@@ -68,7 +68,7 @@ account.rollout?(:email_marketing, :new_email_flow)
 #=> true
 
 # Remove feature for given account
-account.unrelease!(:email_marketing, :new_email_flow)
+account.unrelease(:email_marketing, :new_email_flow)
 #=> true
 
 # If you try to check an inexistent rollout key it will raise an error.

data/lib/feature_flagger.rb

@@ -5,53 +5,20 @@ require 'feature_flagger/storage/redis'
 require 'feature_flagger/control'
 require 'feature_flagger/model'
 require 'feature_flagger/feature'
+require 'feature_flagger/configuration'
 
 module FeatureFlagger
   class << self
     def configure(&block)
-      set_config
-      yield self if block_given?
+      yield config if block_given?
     end
 
-    # TODO: rename to just _config_.
     def config
-      @@config
+      @@configuration ||= Configuration.new
     end
 
     def control
-      @@control ||= Control.new(storage)
-    end
-
-    def storage=(storage)
-      set_config
-      @@config[:storage] = storage
-    end
-
-    def storage
-      set_config
-      @@config[:storage]
-    end
-
-    private
-
-    def set_config
-      @@config ||= {}
-      @@config[:storage] ||= default_client
-
-      # TODO: Provide a Rake to generate initial YAML file
-      # for new projects.
-
-      if defined?(Rails)
-        @@config[:yaml_filepath] ||= "#{Rails.root}/config/rollout.yml"
-      end
-
-      if file_path = @@config[:yaml_filepath]
-        @@config[:info] ||= YAML.load_file(file_path)
-      end
-    end
-
-    def default_client
-      Storage::Redis.default_client
+      @@control ||= Control.new(config.storage)
     end
   end
 end

data/lib/feature_flagger/configuration.rb

@@ -0,0 +1,20 @@
+module FeatureFlagger
+  class Configuration
+    attr_accessor :storage, :yaml_filepath
+
+    def initialize
+      @storage       ||= Storage::Redis.default_client
+      @yaml_filepath ||= default_yaml_filepath
+    end
+
+    def info
+      @info ||= YAML.load_file(yaml_filepath) if yaml_filepath
+    end
+
+    private
+
+    def default_yaml_filepath
+      "#{Rails.root}/config/rollout.yml" if defined?(Rails)
+    end
+  end
+end

data/lib/feature_flagger/control.rb

@@ -10,14 +10,26 @@ module FeatureFlagger
       @storage.has_value?(feature_key, resource_id)
     end
 
-    def release!(feature_key, resource_id)
+    def release(feature_key, resource_id)
       @storage.add(feature_key, resource_id)
     end
 
-    def unrelease!(feature_key, resource_id)
+    # <b>DEPRECATED:</b> Please use <tt>release</tt> instead.
+    def release!(feature_key, resource_id)
+      warn "[DEPRECATION] `release!` is deprecated.  Please use `release` instead."
+      release(feature_key, resource_id)
+    end
+
+    def unrelease(feature_key, resource_id)
       @storage.remove(feature_key, resource_id)
     end
 
+    # <b>DEPRECATED:</b> Please use <tt>unrelease</tt> instead.
+    def unrelease!(feature_key, resource_id)
+      warn "[DEPRECATION] `unrelease!` is deprecated.  Please use `unrelease` instead."
+      unrelease(feature_key, resource_id)
+    end
+
     def resource_ids(feature_key)
       @storage.all_values(feature_key)
     end

data/lib/feature_flagger/feature.rb

@@ -2,7 +2,7 @@ module FeatureFlagger
   class Feature
     def initialize(feature_key, resource_name = nil)
       @feature_key = resolve_key(feature_key, resource_name)
-      @doc = FeatureFlagger.config[:info]
+      @doc = FeatureFlagger.config.info
       fetch_data
     end
 

data/lib/feature_flagger/model.rb

@@ -18,16 +18,28 @@ module FeatureFlagger
       FeatureFlagger.control.rollout?(feature.key, id)
     end
 
+    # <b>DEPRECATED:</b> Please use <tt>release</tt> instead.
     def release!(*feature_key)
+      warn "[DEPRECATION] `release!` is deprecated.  Please use `release` instead."
+      release(*feature_key)
+    end
+
+    def release(*feature_key)
       resource_name = self.class.rollout_resource_name
       feature = Feature.new(feature_key, resource_name)
-      FeatureFlagger.control.release!(feature.key, id)
+      FeatureFlagger.control.release(feature.key, id)
     end
 
+    # <b>DEPRECATED:</b> Please use <tt>unrelease</tt> instead.
     def unrelease!(*feature_key)
+      warn "[DEPRECATION] `unrelease!` is deprecated.  Please use `unrelease` instead."
+      unrelease(*feature_key)
+    end
+
+    def unrelease(*feature_key)
       resource_name = self.class.rollout_resource_name
       feature = Feature.new(feature_key, resource_name)
-      FeatureFlagger.control.unrelease!(feature.key, id)
+      FeatureFlagger.control.unrelease(feature.key, id)
     end
 
     module ClassMethods

data/lib/feature_flagger/version.rb

@@ -1,3 +1,3 @@
 module FeatureFlagger
-  VERSION = "0.5.0"
+  VERSION = "0.6.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: feature_flagger
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.0
 platform: ruby
 authors:
 - Nando Sousa
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-17 00:00:00.000000000 Z
+date: 2016-09-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
@@ -106,6 +106,7 @@ files:
 - MIT-LICENSE
 - README.md
 - lib/feature_flagger.rb
+- lib/feature_flagger/configuration.rb
 - lib/feature_flagger/control.rb
 - lib/feature_flagger/feature.rb
 - lib/feature_flagger/model.rb