feature_flagger 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d29e1d31d6e0908bf08af3e04cb7c5b6bc0b540a
-  data.tar.gz: 7bf7063dd406d12d78ee8fdd01d4fa3dfcf247c6
+  metadata.gz: 434b1224539eeb898620d2ab8955c3e09f9f3050
+  data.tar.gz: 9cb1463434d02d535642491ccf47c8c639b054ff
 SHA512:
-  metadata.gz: 3f82ebd10dca01517e578cc8d079e70510a3e14aec9fabcc5d839e9e35493e2f5cf7eb7a1a9f40902f0d0d50c81f9af308a193cc831c945b2382916beb0b11e4
-  data.tar.gz: a32b48b06e4fd065ba013feb7cc9d239ef31824d1f6b919c66eb82ec3dc71e2fa2b499ad03182846aa6ad2a0a568899ec05994947c6af63b1be7aa78edc997c0
+  metadata.gz: 0e83beff5c32c024b8e8a032aa1a7d298f36007ce3c7791e04c05deaf500d3d6424bad331e4622cfd5fe6a0570031264038cc9613f7eef564740d0f66a605996
+  data.tar.gz: c7994cd5011b0a12650a7a9256862d5b16454a472be4876746eea695fd67b850d70643c35b561dfcbb6aac453f82a3d9663b18fbae187ae0e3514b57a70d4452

data/README.md

@@ -60,19 +60,19 @@ end
 account = Account.first
 
 # Release feature for account
-account.release!([:email_marketing, :new_email_flow])
+account.release!(:email_marketing, :new_email_flow)
 #=> true
 
 # Check feature for a given account
-account.rollout?([:email_marketing, :new_email_flow])
+account.rollout?(:email_marketing, :new_email_flow)
 #=> true
 
 # Remove feature for given account
-account.unrelease!([:email_marketing, :new_email_flow])
+account.unrelease!(:email_marketing, :new_email_flow)
 #=> true
 
 # If you try to check an inexistent rollout key it will raise an error.
-account.rollout?([:email_marketing, :new_email_flo])
+account.rollout?(:email_marketing, :new_email_flow)
 FeatureFlagger::KeyNotFoundError: ["account", "email_marketing", "new_email_flo"]
 ```
 

data/lib/feature_flagger/control.rb

@@ -6,32 +6,20 @@ module FeatureFlagger
       @storage = storage
     end
 
-    def rollout?(feature_key, resource_id, resource_name = nil)
-      feature_key = rsolv_key(feature_key, resource_name)
+    def rollout?(feature_key, resource_id)
       @storage.has_value?(feature_key, resource_id)
     end
 
-    def release!(feature_key, resource_id, resource_name = nil)
-      feature_key = rsolv_key(feature_key, resource_name)
+    def release!(feature_key, resource_id)
       @storage.add(feature_key, resource_id)
     end
 
-    def unrelease!(feature_key, resource_id, resource_name = nil)
-      feature_key = rsolv_key(feature_key, resource_name)
+    def unrelease!(feature_key, resource_id)
       @storage.remove(feature_key, resource_id)
     end
 
-    def resource_ids(feature_key, resource_name = nil)
-      feature_key = rsolv_key(feature_key, resource_name)
+    def resource_ids(feature_key)
       @storage.all_values(feature_key)
     end
-
-    private
-
-    def rsolv_key(feature_key, resource_name = nil)
-      feature_key_arr = Array(feature_key)
-      feature_key_arr.insert(0, resource_name) unless resource_name.nil?
-      feature_key_arr.join(':')
-    end
   end
 end

data/lib/feature_flagger/feature.rb

@@ -1,25 +1,33 @@
 module FeatureFlagger
   class Feature
-
-    def initialize(key, resource_name = nil)
-      @key = resource_name.nil? ? key : key.clone.insert(0, resource_name)
-      @key = Array(@key).collect(&:to_s)
+    def initialize(feature_key, resource_name = nil)
+      @feature_key = resolve_key(feature_key, resource_name)
       @doc = FeatureFlagger.config[:info]
-    end
-
-    def fetch!
-      @data ||= find_value(@doc, *@key)
-      raise FeatureFlagger::KeyNotFoundError.new(@key) if @data.nil?
-      @data
+      fetch_data
     end
 
     def description
-      fetch!
       @data['description']
     end
 
+    def key
+      @feature_key.join(':')
+    end
+
     private
 
+    def resolve_key(feature_key, resource_name)
+      key = Array(feature_key).flatten
+      key.insert(0, resource_name) if resource_name
+      key.map(&:to_s)
+    end
+
+    def fetch_data
+      @data ||= find_value(@doc, *@feature_key)
+      raise FeatureFlagger::KeyNotFoundError.new(@feature_key) if @data.nil?
+      @data
+    end
+
     def find_value(hash, key, *tail)
       value = hash[key]
 
@@ -29,7 +37,6 @@ module FeatureFlagger
         find_value(value, *tail)
       end
     end
-
   end
 end
 

data/lib/feature_flagger/model.rb

@@ -12,28 +12,29 @@ module FeatureFlagger
       base.extend ClassMethods
     end
 
-    def rollout?(feature_key)
+    def rollout?(*feature_key)
       resource_name = self.class.rollout_resource_name
-      Feature.new(feature_key, resource_name).fetch!
-      FeatureFlagger.control.rollout?(feature_key, id, resource_name)
+      feature = Feature.new(feature_key, resource_name)
+      FeatureFlagger.control.rollout?(feature.key, id)
     end
 
-    def release!(feature_key)
+    def release!(*feature_key)
       resource_name = self.class.rollout_resource_name
-      Feature.new(feature_key, resource_name).fetch!
-      FeatureFlagger.control.release!(feature_key, id, resource_name)
+      feature = Feature.new(feature_key, resource_name)
+      FeatureFlagger.control.release!(feature.key, id)
     end
 
-    def unrelease!(feature_key)
+    def unrelease!(*feature_key)
       resource_name = self.class.rollout_resource_name
-      Feature.new(feature_key, resource_name).fetch!
-      FeatureFlagger.control.unrelease!(feature_key, id, resource_name)
+      feature = Feature.new(feature_key, resource_name)
+      FeatureFlagger.control.unrelease!(feature.key, id)
     end
 
     module ClassMethods
-      def all_released_ids_for(feature_key)
-        Feature.new(feature_key, rollout_resource_name).fetch!
-        Control.resource_ids(feature_key, rollout_resource_name)
+      def all_released_ids_for(*feature_key)
+        feature_key.flatten!
+        feature = Feature.new(feature_key, rollout_resource_name)
+        Control.resource_ids(feature.key)
       end
 
       def rollout_resource_name

data/lib/feature_flagger/version.rb

@@ -1,3 +1,3 @@
 module FeatureFlagger
-  VERSION = "0.4.0"
+  VERSION = "0.5.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: feature_flagger
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Nando Sousa
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-13 00:00:00.000000000 Z
+date: 2016-09-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
@@ -131,9 +131,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.3
+rubygems_version: 2.6.6
 signing_key: 
 specification_version: 4
 summary: Partial release your features.
 test_files: []
-has_rdoc: