feature_definitions 0.3.0 → 0.3.1

data/Gemfile

@@ -2,7 +2,6 @@ source "http://rubygems.org"
 # Add dependencies required to use your gem here.
 # Example:
 #   gem "activesupport", ">= 2.3.5"
-gem 'lazy_const', '~> 0.1.3'
 
 # Add dependencies to develop your gem here.
 # Include everything needed to run rake, tests, features, etc.

data/README.rdoc

@@ -37,6 +37,12 @@ app/elsewhere.rb
     # else noop
   end
 
+  def some_other_method
+    Features.AWESOME do
+      # declarative form!
+    end
+  end
+
 === Rails (and define_feature helper)
 Rails is *NOT* required, but this is how you would use this gem with Rails.
 
@@ -59,6 +65,10 @@ app/views/some/view.erb.html:
   <% Features.AWESOME.enabled? do %>
     You have awesome blocks enabled!
   <% end %>
+  <% Features.AWESOME do %>
+    Declarative feature blocks!
+  <% end %>
+
 
 == Contributing to feature_definitions
  

data/VERSION

@@ -1 +1 @@
-0.3.0
+0.3.1

data/feature_definitions.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "feature_definitions"
-  s.version = "0.3.0"
+  s.version = "0.3.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Ryan Graham"]
-  s.date = "2013-03-19"
+  s.date = "2013-03-20"
   s.description = "Simple and flexible feature toggle defintion"
   s.email = "r.m.graham@gmail.com"
   s.extra_rdoc_files = [
@@ -40,14 +40,12 @@ Gem::Specification.new do |s|
     s.specification_version = 3
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
-      s.add_runtime_dependency(%q<lazy_const>, ["~> 0.1.3"])
       s.add_development_dependency(%q<minitest>, [">= 0"])
       s.add_development_dependency(%q<bundler>, [">= 0"])
       s.add_development_dependency(%q<rake>, [">= 0"])
       s.add_development_dependency(%q<rdoc>, ["~> 3.12"])
       s.add_development_dependency(%q<jeweler>, ["~> 1.8.4"])
     else
-      s.add_dependency(%q<lazy_const>, ["~> 0.1.3"])
       s.add_dependency(%q<minitest>, [">= 0"])
       s.add_dependency(%q<bundler>, [">= 0"])
       s.add_dependency(%q<rake>, [">= 0"])
@@ -55,7 +53,6 @@ Gem::Specification.new do |s|
       s.add_dependency(%q<jeweler>, ["~> 1.8.4"])
     end
   else
-    s.add_dependency(%q<lazy_const>, ["~> 0.1.3"])
     s.add_dependency(%q<minitest>, [">= 0"])
     s.add_dependency(%q<bundler>, [">= 0"])
     s.add_dependency(%q<rake>, [">= 0"])

data/lib/feature_definitions.rb

@@ -1,11 +1,15 @@
-require 'lazy_const'
-
 class FeatureDefinitions
-  extend LazyConst
   attr_reader :test_proc
 
-  def self.define_feature(name, &block)
-    lazy_const(name) { new(&block) }
+  def self.define_feature(name, &feature_test_block)
+    feature = new(&feature_test_block)
+    meta_class = class << self; self end
+    meta_class.__send__(:define_method, name) do |&feature_impl_block|
+      if block_given?
+        feature.enabled?(&feature_impl_block)
+      end
+      feature
+    end
   end
 
   PASSTHROUGH = Proc.new { |arg| arg }
@@ -30,7 +34,9 @@ class FeatureDefinitions
 
   def enabled?(&block)
     test_proc.call(context).tap do |verdict|
-      yield if verdict and block_given?
+      if verdict and block_given?
+        yield
+      end
     end
   end
 end

data/test/test_feature_definitions.rb

@@ -1,4 +1,5 @@
 require 'helper'
+require 'feature_definitions'
 
 class ConstFeatures < FeatureDefinitions
   ALWAYS_ENABLED_FEATURE = self.new { |context| true }
@@ -72,7 +73,7 @@ class TestFeatureDefaultBlock < MiniTest::Unit::TestCase
     @feature_class.context = false
     refute @feature_class.AWESOME.enabled?
   end
-  def test_feature_toggle
+  def test_feature_toggles
     @feature_class.context = true
     assert @feature_class.AWESOME.enabled?
     @feature_class.context = false
@@ -87,3 +88,26 @@ class TestFeatureDefaultBlock < MiniTest::Unit::TestCase
     assert called
   end
 end
+
+class TestDeclarativeFeatures < MiniTest::Unit::TestCase
+  def setup
+    @feature_class = Class.new(FeatureDefinitions) do
+      define_feature(:ENABLED_FEATURE) { |c| true }
+      define_feature(:DISABLED_FEATURE) { |c| false }
+    end
+  end
+  def test_declarative_feature_enabled
+    called = false
+    @feature_class.ENABLED_FEATURE do
+      called = true
+    end
+    assert called
+  end
+  def test_declarative_feature_disabled
+    called = false
+    @feature_class.DISABLED_FEATURE do
+      called = true
+    end
+    refute called
+  end
+end

metadata

@@ -2,31 +2,15 @@
 name: feature_definitions
 version: !ruby/object:Gem::Version
   prerelease: 
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Ryan Graham
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-19 00:00:00.000000000 Z
+date: 2013-03-20 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 0.1.3
-  type: :runtime
-  name: lazy_const
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 0.1.3
-  prerelease: false
 - !ruby/object:Gem::Dependency
   version_requirements: !ruby/object:Gem::Requirement
     none: false
@@ -141,7 +125,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       segments:
       - 0
-      hash: -4330562717910034088
+      hash: -2164482606995363912
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false