feature_creep 0.1.2 → 0.2.0

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    feature_creep (0.0.1)
+    feature_creep (0.1.2)
       redis
 
 GEM

data/README.md

@@ -11,14 +11,23 @@ This is not a drop in replacement. The API has aleadey changed.
 Namely, `groups` are now `scopes` and `users` are `agent_ids`.
 Agent_ids are expected to be uuids, not the object itself.
 
-The class constructor now takes a datastore and an options hash.
+The class constructor now takes
 
-options[:info] should be a lambda that returns a hash when called
+`datastore` -- FeatureCreep::RedisDatastore is provided with more to come.
 
-options[:warden] is also a lambda that encapsulates the business logic for FeatureCreep#active?
+`info` -- should be a lambda that takes two parameters and returns a hash when called
 
-options[:scopes] is a hash that expects a string key and a lambda that encapsulates the business logic for membership in a scope
+`warden` -- is also a lambda that takes two parameters and returns a boolean. It encapsulates the business logic for FeatureCreep#active?
 
+`options` -- an aptly named options hash
+
+`options[:scopes]` is a hash that expects a string key and a lambda that encapsulates the business logic for membership in a scope
+
+`options[:features]` is an array of strings or symbols that will add  to the list of all possible features.
+
+@feature_creep = FeatureCreep.new(@datastore,FeatureCreep::DefaultConfig.warden,
+                                  FeatureCreep::DefaultConfig.info,
+                                  {:scopes => {:some_scope_name => lambda { |agent_id| User.find(agent_id).can?(:some_scope) }}, :features => [:feature_1, :feature_2]})
 
 At this point it should be easy to extend.
 I would expect the API to stablize over the next couple of weeks.

data/lib/feature_creep.rb

@@ -2,8 +2,10 @@ class FeatureCreep
 
   attr_accessor :scopes, :info, :warden
 
-  def initialize(datastore, options = {})
+  def initialize(datastore, warden, info, options = {})
     @datastore = datastore
+    @warden = warden
+    @info = info
     @scopes = {"all" => lambda { |agent_id| true }}
 
     if options.has_key?(:scopes)
@@ -17,95 +19,47 @@ class FeatureCreep
         add_feature(feature)
       end
     end
-
-    @warden = if options.has_key?(:warden)
-      options[:warden]
-    else
-      lambda { |feature,agent_id|
-        if agent_id
-          active_globally?(feature) ||
-            agent_id_in_active_scope?(feature, agent_id) ||
-            agent_id_active?(feature, agent_id) ||
-            agent_id_within_active_percentage?(feature, agent_id)
-        else
-          active_globally?(feature)
-        end
-      }
-    end
-
-    @info = if options.has_key?(:info)
-      options[:info]
-    else lambda { |feature|
-        if feature
-          {
-            :percentage => (active_percentage(feature) || 0).to_i,
-            :scopes     => active_scopes(feature).map { |g| g.to_sym },
-            :agent_ids      => active_agent_ids(feature),
-            :global     => active_global_features,
-            :available_features => features
-          }
-        else
-          {
-            :global     => active_global_features,
-            :available_features => features
-          }
-        end
-      }
-    end
   end
 
+  # Activate Methods
   def activate_globally(feature)
     @datastore.activate_globally(feature)
   end
 
-  def deactivate_globally(feature)
-    @datastore.deactivate_globally(feature)
-  end
-
   def activate_scope(feature, scope)
     @datastore.activate_scope(feature, scope)
   end
 
-  def deactivate_scope(feature, scope)
-    @datastore.deactivate_scope(feature, scope)
-  end
-
-  def deactivate_all(feature)
-    @datastore.deactivate_all(feature)
-  end
-
   def activate_agent_id(feature, agent_id)
     @datastore.activate_agent_id(feature, agent_id)
   end
 
-  def deactivate_agent_id(feature, agent_id)
-    @datastore.deactivate_agent_id(feature, agent_id)
-  end
-
-  def active?(feature, agent_id = nil)
-    @warden.call(feature,agent_id)
-  end
-
   def activate_percentage(feature, percentage)
     @datastore.activate_percentage(feature, percentage)
   end
 
-  def deactivate_percentage(feature)
-    @datastore.deactivate_percentage(feature)
+  # Deactivate Methods
+  def deactivate_globally(feature)
+    @datastore.deactivate_globally(feature)
   end
 
-  def features
-    @datastore.features
+  def deactivate_scope(feature, scope)
+    @datastore.deactivate_scope(feature, scope)
   end
 
-  def add_feature(feature)
-    @datastore.add_feature(feature)
+  def deactivate_agent_id(feature, agent_id)
+    @datastore.deactivate_agent_id(feature, agent_id)
   end
 
-  def info(feature = nil)
-    @info.call(feature)
+  def deactivate_percentage(feature)
+    @datastore.deactivate_percentage(feature)
+  end
+
+  def deactivate_all(feature)
+    @datastore.deactivate_all(feature)
   end
 
+  # Reporting Methods
   def active_scopes(feature)
     @datastore.active_scopes(feature)
   end
@@ -122,6 +76,11 @@ class FeatureCreep
     @datastore.active_percentage(feature)
   end
 
+  # Boolean Methods
+  def active?(feature, agent_id = nil)
+    @warden.call(self,feature,agent_id)
+  end
+
   def active_globally?(feature)
     @datastore.active_globally?(feature)
   end
@@ -139,4 +98,17 @@ class FeatureCreep
   def agent_id_within_active_percentage?(feature, agent_id)
     @datastore.agent_id_within_active_percentage?(feature, agent_id)
   end
+
+  # Utility Methods
+  def features
+    @datastore.features
+  end
+
+  def add_feature(feature)
+    @datastore.add_feature(feature)
+  end
+
+  def info(feature = nil)
+    @info.call(self,feature)
+  end
 end

data/lib/feature_creep/default_config.rb

@@ -0,0 +1,36 @@
+class FeatureCreep
+	class DefaultConfig
+		def self.info
+			lambda { |creep,feature|
+        if feature
+          {
+            :percentage => (creep.active_percentage(feature) || 0).to_i,
+            :scopes     => creep.active_scopes(feature).map { |g| g.to_sym },
+            :agent_ids      => creep.active_agent_ids(feature),
+            :global     => creep.active_global_features,
+            :available_features => creep.features
+          }
+        else
+          {
+            :global     => creep.active_global_features,
+            :available_features => creep.features
+          }
+        end
+      }
+
+		end
+
+		def self.warden
+      lambda { |creep,feature,agent_id|
+        if agent_id
+          creep.active_globally?(feature) ||
+            creep.agent_id_in_active_scope?(feature, agent_id) ||
+            creep.agent_id_active?(feature, agent_id) ||
+            creep.agent_id_within_active_percentage?(feature, agent_id)
+        else
+          creep.active_globally?(feature)
+        end
+      }
+		end
+	end
+end

data/lib/feature_creep/version.rb

@@ -1,3 +1,3 @@
 class FeatureCreep
-  VERSION = "0.1.2"
+  VERSION = "0.2.0"
 end

data/spec/feature_creep_spec.rb

@@ -6,7 +6,9 @@ describe "FeatureCreep" do
     scopes = {
       :fivesonly => lambda { |agent_id| agent_id == 5 }
     }
-    @feature_creep = FeatureCreep.new(@datastore, {:scopes => scopes, :features => [:test1, :test2]})
+    @feature_creep = FeatureCreep.new(@datastore,FeatureCreep::DefaultConfig.warden,
+                                      FeatureCreep::DefaultConfig.info,
+                                      {:scopes => scopes, :features => [:test1, :test2]})
   end
 
   describe ".new" do

data/spec/spec_helper.rb

@@ -2,6 +2,7 @@ $LOAD_PATH.unshift(File.dirname(__FILE__))
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 require 'feature_creep'
 require 'feature_creep/redis_datastore'
+require 'feature_creep/default_config'
 require 'rspec'
 require 'bourne'
 require 'redis'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: feature_creep
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.2.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-10-28 00:00:00.000000000 Z
+date: 2012-10-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -137,6 +137,7 @@ files:
 - README.md
 - feature_creep.gemspec
 - lib/feature_creep.rb
+- lib/feature_creep/default_config.rb
 - lib/feature_creep/redis_datastore.rb
 - lib/feature_creep/version.rb
 - spec/feature_creep_spec.rb