feature_creep 0.0.1 → 0.1.2

data/lib/feature_creep.rb

@@ -5,11 +5,19 @@ class FeatureCreep
   def initialize(datastore, options = {})
     @datastore = datastore
     @scopes = {"all" => lambda { |agent_id| true }}
+
     if options.has_key?(:scopes)
       options[:scopes].each do |name,membership_block|
         @scopes[name.to_s] = membership_block
       end
     end
+
+    if options.has_key?(:features)
+      options[:features].each do |feature|
+        add_feature(feature)
+      end
+    end
+
     @warden = if options.has_key?(:warden)
       options[:warden]
     else
@@ -24,6 +32,7 @@ class FeatureCreep
         end
       }
     end
+
     @info = if options.has_key?(:info)
       options[:info]
     else lambda { |feature|
@@ -31,12 +40,14 @@ class FeatureCreep
           {
             :percentage => (active_percentage(feature) || 0).to_i,
             :scopes     => active_scopes(feature).map { |g| g.to_sym },
-            :agent_ids      => active_agent_id_ids(feature),
-            :global     => active_global_features
+            :agent_ids      => active_agent_ids(feature),
+            :global     => active_global_features,
+            :available_features => features
           }
         else
           {
-            :global     => active_global_features
+            :global     => active_global_features,
+            :available_features => features
           }
         end
       }
@@ -83,8 +94,8 @@ class FeatureCreep
     @datastore.deactivate_percentage(feature)
   end
 
-  def current_features
-    @datastore.current_features
+  def features
+    @datastore.features
   end
 
   def add_feature(feature)
@@ -99,8 +110,8 @@ class FeatureCreep
     @datastore.active_scopes(feature)
   end
 
-  def active_agent_id_ids(feature)
-    @datastore.active_agent_id_ids(feature)
+  def active_agent_ids(feature)
+    @datastore.active_agent_ids(feature)
   end
 
   def active_global_features

data/lib/feature_creep/redis_datastore.rb

@@ -7,6 +7,7 @@ class FeatureCreep
     end
 
     def activate_globally(feature)
+      add_feature(feature)
       @redis.sadd(global_key, feature)
     end
 
@@ -15,6 +16,7 @@ class FeatureCreep
     end
 
     def activate_scope(feature, scope)
+      add_feature(feature)
       @redis.sadd(scope_key(feature), scope)
     end
 
@@ -30,6 +32,7 @@ class FeatureCreep
     end
 
     def activate_agent_id(feature, agent_id)
+      add_feature(feature)
       @redis.sadd(agent_id_key(feature), agent_id)
     end
 
@@ -56,27 +59,12 @@ class FeatureCreep
       @redis.del(percentage_key(feature))
     end
 
-    def info(feature = nil)
-      if feature
-        {
-          :percentage => (active_percentage(feature) || 0).to_i,
-          :scopes     => active_scopes(feature).map { |g| g.to_sym },
-          :agent_ids  => active_agent_id_ids(feature),
-          :global     => active_global_features
-        }
-      else
-        {
-          :features   => current_features
-        }
-      end
-    end
-
     def active_scopes(feature)
       @redis.smembers(scope_key(feature)) || []
     end
 
-    def active_agent_id_ids(feature)
-      @redis.smembers(agent_id_key(feature)).map { |id| id.to_i }
+    def active_agent_ids(feature)
+      @redis.smembers(agent_id_key(feature))
     end
 
     def active_global_features
@@ -101,12 +89,12 @@ class FeatureCreep
       agent_id % 100 < percentage.to_i
     end
 
-    def current_features
-      @redis.smembers(@key_prefix)
+    def features
+      @redis.smembers(@key_prefix).map(&:to_sym)
     end
 
     def add_feature(feature)
-      redis.sadd(@key_prefix, feature)
+      @redis.sadd(@key_prefix, feature)
     end
 
     private

data/lib/feature_creep/version.rb

@@ -1,3 +1,3 @@
 class FeatureCreep
-  VERSION = "0.0.1"
+  VERSION = "0.1.2"
 end

data/spec/feature_creep_spec.rb

@@ -6,7 +6,25 @@ describe "FeatureCreep" do
     scopes = {
       :fivesonly => lambda { |agent_id| agent_id == 5 }
     }
-    @feature_creep = FeatureCreep.new(@datastore, {:scopes => scopes})
+    @feature_creep = FeatureCreep.new(@datastore, {:scopes => scopes, :features => [:test1, :test2]})
+  end
+
+  describe ".new" do
+    it "sets features" do
+      @feature_creep.features.should == [:test1, :test2]
+    end
+
+    it "sets @scopes" do
+      @feature_creep.scopes['fivesonly'].should be_a Proc
+    end
+
+    it "sets @info" do
+      @feature_creep.info.should be_a Hash
+    end
+
+    it "sets @warden" do
+      @feature_creep.warden.should be_a Proc
+    end
   end
 
   describe "when a scope is activated" do
@@ -177,6 +195,7 @@ describe "FeatureCreep" do
   describe "#info" do
     context "global features" do
       let(:features) { [:signup, :chat, :table] }
+      let(:available_features) { [:chat, :test1, :signup, :test2, :table] }
 
       before do
         features.each do |f|
@@ -185,7 +204,7 @@ describe "FeatureCreep" do
       end
 
       it "returns all global features" do
-        @feature_creep.info.should eq({ :global => features.reverse })
+        @feature_creep.info.should eq({ :global => features.reverse, :available_features => available_features })
       end
     end
 
@@ -202,8 +221,9 @@ describe "FeatureCreep" do
         @feature_creep.info(:chat).should == {
           :percentage => 10,
           :scopes     => [:greeters, :caretakers],
-          :agent_ids      => [42],
-          :global     => [:signup]
+          :agent_ids      => ["42"],
+          :global     => [:signup],
+          :available_features => [:chat, :test1, :signup, :test2]
         }
       end
     end
@@ -214,7 +234,8 @@ describe "FeatureCreep" do
           :percentage => 0,
           :scopes     => [],
           :agent_ids      => [],
-          :global     => []
+          :global     => [],
+          :available_features=>[:test1, :test2]
         }
       end
     end

data/spec/spec_helper.rb

@@ -5,6 +5,7 @@ require 'feature_creep/redis_datastore'
 require 'rspec'
 require 'bourne'
 require 'redis'
+require 'pry'
 
 RSpec.configure do |config|
   config.mock_with :mocha

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: feature_creep
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.2
   prerelease: 
 platform: ruby
 authors: