feature_cop 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 23e13c27a95eb98d2e6575e2496cf0508a97b38c
-  data.tar.gz: ab18e2e7f822c9d0e4cf0f2be37c8eb01c27d704
+  metadata.gz: cfc3f020ac957af0592f60d8483b3290cbd45094
+  data.tar.gz: b1b3f3aced850ffe765d09a6466c931f313093e6
 SHA512:
-  metadata.gz: 1592e693b61d3d0a65940150caddff431a68545d8198cc5bddbd7bd3fc16ad0b08a543acf09de237a42e143c6fdf154711faf7c69577cf10f8c5cf1c7306de2f
-  data.tar.gz: 2f490d457210964d0b049b468781616a18d07255be97b54e32ba3abf80a17e54e6ad4c39e81262d6eeadaebc4398f2452a624a8a7508bdfc7ebc0f892a764cde
+  metadata.gz: c48cdd39b1fc6de45ccea25b9930eac1e2bc4853f735bc48f148c060d8f985d7c8e9309b5a8706571949183c6fc70192b2870f9bca7f12f7206ec55a81457f28
+  data.tar.gz: 351df11878016e0e80a96fdd491dee93bf0aabdf452c44ff2cdb7552189ddcf108da2f8b9fef796754474544029dc3724a74cc4b9bb58c0c5feb23d40367016a

data/README.md

@@ -6,10 +6,11 @@ The following roll out strategies is available:
 
 1. **disabled** - during development, a feature can be completely disabled so it isn't seen or executed.
 2. **whitelist_only** - features can be turned on for specific users or groups.
-3. **sample10** - feature is enabled for roughly 10% of users
-4. **sample30** - feature is enabled for rougly 30% of users
-5. **sample50** - feature is enabled for rougly 50% of users
-6. **all_except_blacklist** - feature is enabled for everyone except a specified list of customers.  These customers could be enterprise clients that must be notified before enabling new features, etc.
+3. **sample10** - feature is enabled for roughly 10% of ids (statistically this ranges from 7% - 13%), includes whitelisted ids and excludes blacklisted ids
+4. **sample30** - feature is enabled for roughly 30% of ids (statistically this ranges from 24% - 36%), includes whitelisted ids and excludes blacklisted ids
+5. **sample50** - feature is enabled for roughly 50% of ids (statistically this ranges from 44% - 56%), includes whitelisted ids and excludes blacklisted ids
+
+6. **all_except_blacklist** - feature is enabled for everyone except a specified list of ids.  These customers could be enterprise clients that must be notified before enabling new features, etc.
 6. **enabled** - enabled for all customers.  At this point it is recommended to remove the feature flag from the system since the roll out is complete.
 
 

data/lib/feature_cop.rb

@@ -41,14 +41,20 @@ module FeatureCop
   end
 
   def self.sample10(identifier)
+    return true if whitelisted?(identifier)
+    return false if blacklisted?(identifier)
     identifier.bytes.sum % 10 == 0 
   end
 
   def self.sample30(identifier)
+    return true if whitelisted?(identifier)
+    return false if blacklisted?(identifier)
     identifier.bytes.sum % 3 == 0 
   end
 
   def self.sample50(identifier)
+    return true if whitelisted?(identifier)
+    return false if blacklisted?(identifier)
     identifier.bytes.sum.odd? 
   end
 

data/lib/feature_cop/blacklist.rb

@@ -10,20 +10,19 @@ module FeatureCop
       def blacklist_from_yaml(file = "feature_cop_blacklist.yml")
         if ::File.exists?(file)
           absolute_path = file       
-        else
-          absolute_path = ::File.expand_path(::File.join("config", file))
-          raise "#{file} not found!" unless ::File.exists?(absolute_path)
+        elsif defined?(Rails)
+          absolute_path = ::File.join(Rails.root, "config", file)
         end
 
+        raise "#{file} not found!" unless ::File.exists?(absolute_path)
         self.blacklist = ::YAML.load_file(absolute_path)[env]      
       end
 
       def all_except_blacklist(identifier)
         return true if @blacklist.nil?
-        !@blacklist.include?(identifier)
+        !blacklisted?(identifier)
       end
 
-
       def blacklist
         @blacklist 
       end
@@ -32,6 +31,10 @@ module FeatureCop
         @blacklist = blacklist
       end
 
+      def blacklisted?(identifier)
+        return false if @blacklist.nil?
+        @blacklist.include?(identifier)
+      end
     end
   end
 end

data/lib/feature_cop/version.rb

@@ -1,3 +1,3 @@
 module FeatureCop
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

data/lib/feature_cop/whitelist.rb

@@ -8,7 +8,6 @@ module FeatureCop
     module ClassMethods
 
       def whitelist_from_yaml(file = "feature_cop_whitelist.yml")
-
         if ::File.exists?(file)
           absolute_path = file       
         elsif defined?(Rails)
@@ -28,6 +27,10 @@ module FeatureCop
       end
 
       def whitelist_only(identifier)
+        whitelisted?(identifier)
+      end
+
+      def whitelisted?(identifier)
         return false if @whitelist.nil?
         @whitelist.include?(identifier)
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: feature_cop
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Brett Allred
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-04-30 00:00:00.000000000 Z
+date: 2016-05-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport