feature 1.1.0 → 1.2.0

data/spec/feature/testing_spec.rb

@@ -1,14 +1,14 @@
 require 'spec_helper'
 require 'feature/testing'
 
-describe "Feature testing support" do
+describe 'Feature testing support' do
   before(:each) do
     repository = SimpleRepository.new
     repository.add_active_feature(:active_feature)
     Feature.set_repository(repository)
   end
 
-  it "should execute code block with an deactivated feature" do
+  it 'should execute code block with an deactivated feature' do
     expect(Feature.active?(:another_feature)).to be_falsey
 
     Feature.run_with_activated(:another_feature) do
@@ -18,7 +18,7 @@ describe "Feature testing support" do
     expect(Feature.active?(:another_feature)).to be_falsey
   end
 
-  it "should execute code block with an deactivated feature" do
+  it 'should execute code block with an deactivated feature' do
     expect(Feature.active?(:active_feature)).to be_truthy
 
     Feature.run_with_deactivated(:active_feature) do

data/spec/feature/yaml_repository_spec.rb

@@ -4,11 +4,11 @@ require 'tempfile'
 include Feature::Repository
 
 describe Feature::Repository::YamlRepository do
-  context "proper config file" do
+  context 'proper config file' do
     before(:each) do
       @filename = Tempfile.new(['feature_config', '.yaml']).path
       fp = File.new(@filename, 'w')
-      fp.write <<"EOF";
+      fp.write <<"EOF"
 features:
     feature_a_active: true
     feature_b_active: true
@@ -24,14 +24,14 @@ EOF
       File.delete(@filename)
     end
 
-    it "should read active features from a config file" do
+    it 'should read active features from a config file' do
       expect(@repo.active_features).to eq([:feature_a_active, :feature_b_active])
     end
 
-    context "re-read config file" do
+    context 're-read config file' do
       before(:each) do
         fp = File.new(@filename, 'w')
-        fp.write <<"EOF";
+        fp.write <<"EOF"
 features:
     feature_a_active: true
     feature_c_inactive: false
@@ -39,30 +39,29 @@ EOF
         fp.close
       end
 
-      it "should read active features new on each request" do
+      it 'should read active features new on each request' do
         expect(@repo.active_features).to eq([:feature_a_active])
       end
     end
 
-    # For example, when all your features are in production and working fine.
-    context "with no features" do
+    context 'with no features' do
       before(:each) do
         fp = File.new(@filename, 'w')
-        fp.write <<"EOF";
+        fp.write <<"EOF"
 features:
 EOF
         fp.close
       end
 
-      it "should read active features new on each request" do
+      it 'should read active features new on each request' do
         expect(@repo.active_features).to eq([])
       end
     end
 
-    context "with optional environment name" do
+    context 'with optional environment name' do
       before(:each) do
         fp = File.new(@filename, 'w')
-        fp.write <<"EOF";
+        fp.write <<"EOF"
 development:
   features:
       feature_a: true
@@ -75,12 +74,12 @@ EOF
         fp.close
       end
 
-      it "has two active features for development environment" do
+      it 'has two active features for development environment' do
         repo = YamlRepository.new(@filename, 'development')
         expect(repo.active_features).to eq([:feature_a, :feature_b])
       end
 
-      it "has one active feature for production environment" do
+      it 'has one active feature for production environment' do
         repo = YamlRepository.new(@filename, 'production')
         expect(repo.active_features).to eq([:feature_a])
       end
@@ -88,11 +87,11 @@ EOF
 
     # Sometimes needed when loading features from ENV variables or are time
     # based rules Ex: Date.today > Date.strptime('1/2/2012', '%d/%m/%Y')
-    context "a config file with embedded erb" do
+    context 'a config file with embedded erb' do
       before(:each) do
         @filename = Tempfile.new(['feature_config', '.yaml']).path
         fp = File.new(@filename, 'w')
-        fp.write <<"EOF";
+        fp.write <<"EOF"
 features:
     feature_a_active: <%= 'true' == 'true' %>
     feature_b_active: true
@@ -104,35 +103,50 @@ EOF
         @repo = YamlRepository.new(@filename)
       end
 
-      it "should read active features from the config file" do
+      it 'should read active features from the config file' do
         expect(@repo.active_features).to eq([:feature_a_active, :feature_b_active])
       end
     end
   end
 
-  it "should raise exception on no file found" do
-    repo = YamlRepository.new("/this/file/should/not/exist")
+  it 'should raise exception on no file found' do
+    repo = YamlRepository.new('/this/file/should/not/exist')
     expect do
       repo.active_features
     end.to raise_error(Errno::ENOENT, /No such file or directory/)
   end
 
-  it "should raise exception on invalid yaml" do
+  it 'should raise exception on invalid yaml' do
     @filename = Tempfile.new(['feature_config', '.yaml']).path
     fp = File.new(@filename, 'w')
-    fp.write "this is not valid feature config"
+    fp.write 'this is not valid feature config'
     fp.close
 
     repo = YamlRepository.new(@filename)
     expect do
       repo.active_features
-    end.to raise_error(ArgumentError, "content of #{@filename} does not contain proper config")
+    end.to raise_error(ArgumentError, 'yaml config does not contain proper config')
   end
 
-  it "should raise exception on not true/false value in config" do
+  it 'should raise exception on yaml without features key' do
     @filename = Tempfile.new(['feature_config', '.yaml']).path
     fp = File.new(@filename, 'w')
-    fp.write <<"EOF";
+    fp.write <<"EOF"
+fail:
+    feature: true
+EOF
+    fp.close
+
+    repo = YamlRepository.new(@filename)
+    expect do
+      repo.active_features
+    end.to raise_error(ArgumentError, 'yaml config does not contain proper config')
+  end
+
+  it 'should raise exception on not true/false value in config' do
+    @filename = Tempfile.new(['feature_config', '.yaml']).path
+    fp = File.new(@filename, 'w')
+    fp.write <<"EOF"
 features:
     invalid_feature: neither_true_or_false
 EOF
@@ -141,6 +155,6 @@ EOF
     repo = YamlRepository.new(@filename)
     expect do
       repo.active_features
-    end.to raise_error(ArgumentError, "neither_true_or_false is not allowed value in config, use true/false")
+    end.to raise_error(ArgumentError, 'neither_true_or_false is not allowed value in config, use true/false')
   end
 end

data/spec/integration/rails/test-against-several-rails-versions.sh

@@ -2,6 +2,6 @@
 
 set -e
 
-for rails_version in 3 4; do
+for rails_version in 4; do
   RAILS_VERSION=$rails_version ./test-against-specific-rails-version.sh
 done

data/spec/integration/rails/test-against-specific-rails-version.sh

@@ -2,7 +2,7 @@
 
 set -e
 
-BUNDLE_GEMFILE=gemfiles/rails${RAILS_VERSION}.gemfile
+export BUNDLE_GEMFILE=gemfiles/rails${RAILS_VERSION}.gemfile
 
 TESTAPP_NAME=testapp
 
@@ -22,3 +22,6 @@ cd $TESTAPP_NAME
 bundle install
 bundle exec rails g feature:install
 bundle exec rake db:migrate
+
+cd ..
+rm -Rf $TESTAPP_NAME

data/spec/spec_helper.rb

@@ -1,6 +1,9 @@
 require 'pathname'
 require 'coveralls'
+require 'fakeredis/rspec'
+
 Coveralls.wear!
+Coveralls::Output.silent = true
 
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 $LOAD_PATH.unshift(File.dirname(__FILE__))

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: feature
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Markus Gerdes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-30 00:00:00.000000000 Z
+date: 2014-10-28 00:00:00.000000000 Z
 dependencies: []
 description: 
 email: github@mgsnova.de
@@ -22,22 +22,19 @@ files:
 - Rakefile
 - lib/feature.rb
 - lib/feature/generators/install_generator.rb
-- lib/feature/generators/templates/create_feature_toggles.rb
 - lib/feature/generators/templates/feature.rb
-- lib/feature/generators/templates/feature_toggle.rb
-- lib/feature/generators/templates/feature_toggle_without_attr_accessible.rb
 - lib/feature/repository.rb
 - lib/feature/repository/active_record_repository.rb
+- lib/feature/repository/redis_repository.rb
 - lib/feature/repository/simple_repository.rb
 - lib/feature/repository/yaml_repository.rb
 - lib/feature/testing.rb
 - spec/feature/active_record_repository_spec.rb
 - spec/feature/feature_spec.rb
+- spec/feature/redis_repository_spec.rb
 - spec/feature/simple_repository_spec.rb
 - spec/feature/testing_spec.rb
 - spec/feature/yaml_repository_spec.rb
-- spec/integration/rails/gemfiles/rails3.gemfile
-- spec/integration/rails/gemfiles/rails3.gemfile.lock
 - spec/integration/rails/gemfiles/rails4.gemfile
 - spec/integration/rails/gemfiles/rails4.gemfile.lock
 - spec/integration/rails/test-against-several-rails-versions.sh

data/lib/feature/generators/templates/create_feature_toggles.rb

@@ -1,10 +0,0 @@
-class CreateFeatureToggles < ActiveRecord::Migration
-  def change
-    create_table :feature_toggles do |t|
-      t.string :name
-      t.boolean :active
-
-      t.timestamps
-    end
-  end
-end

data/lib/feature/generators/templates/feature_toggle.rb

@@ -1,6 +0,0 @@
-class FeatureToggle < ActiveRecord::Base
-  attr_accessible :name, :active
-
-  # Feature name should be present and unique
-  validates :name, presence: true, uniqueness: true
-end

data/lib/feature/generators/templates/feature_toggle_without_attr_accessible.rb

@@ -1,4 +0,0 @@
-class FeatureToggle < ActiveRecord::Base
-  # Feature name should be present and unique
-  validates :name, presence: true, uniqueness: true
-end

data/spec/integration/rails/gemfiles/rails3.gemfile

@@ -1,4 +0,0 @@
-source 'https://rubygems.org'
-
-gem 'rails', '~> 3.2.19'
-gem 'railties'

data/spec/integration/rails/gemfiles/rails3.gemfile.lock

@@ -1,86 +0,0 @@
-GEM
-  remote: https://rubygems.org/
-  specs:
-    actionmailer (3.2.19)
-      actionpack (= 3.2.19)
-      mail (~> 2.5.4)
-    actionpack (3.2.19)
-      activemodel (= 3.2.19)
-      activesupport (= 3.2.19)
-      builder (~> 3.0.0)
-      erubis (~> 2.7.0)
-      journey (~> 1.0.4)
-      rack (~> 1.4.5)
-      rack-cache (~> 1.2)
-      rack-test (~> 0.6.1)
-      sprockets (~> 2.2.1)
-    activemodel (3.2.19)
-      activesupport (= 3.2.19)
-      builder (~> 3.0.0)
-    activerecord (3.2.19)
-      activemodel (= 3.2.19)
-      activesupport (= 3.2.19)
-      arel (~> 3.0.2)
-      tzinfo (~> 0.3.29)
-    activeresource (3.2.19)
-      activemodel (= 3.2.19)
-      activesupport (= 3.2.19)
-    activesupport (3.2.19)
-      i18n (~> 0.6, >= 0.6.4)
-      multi_json (~> 1.0)
-    arel (3.0.3)
-    builder (3.0.4)
-    erubis (2.7.0)
-    hike (1.2.3)
-    i18n (0.6.11)
-    journey (1.0.4)
-    json (1.8.1)
-    mail (2.5.4)
-      mime-types (~> 1.16)
-      treetop (~> 1.4.8)
-    mime-types (1.25.1)
-    multi_json (1.10.1)
-    polyglot (0.3.5)
-    rack (1.4.5)
-    rack-cache (1.2)
-      rack (>= 0.4)
-    rack-ssl (1.3.4)
-      rack
-    rack-test (0.6.2)
-      rack (>= 1.0)
-    rails (3.2.19)
-      actionmailer (= 3.2.19)
-      actionpack (= 3.2.19)
-      activerecord (= 3.2.19)
-      activeresource (= 3.2.19)
-      activesupport (= 3.2.19)
-      bundler (~> 1.0)
-      railties (= 3.2.19)
-    railties (3.2.19)
-      actionpack (= 3.2.19)
-      activesupport (= 3.2.19)
-      rack-ssl (~> 1.3.2)
-      rake (>= 0.8.7)
-      rdoc (~> 3.4)
-      thor (>= 0.14.6, < 2.0)
-    rake (10.3.2)
-    rdoc (3.12.2)
-      json (~> 1.4)
-    sprockets (2.2.2)
-      hike (~> 1.2)
-      multi_json (~> 1.0)
-      rack (~> 1.0)
-      tilt (~> 1.1, != 1.3.0)
-    thor (0.19.1)
-    tilt (1.4.1)
-    treetop (1.4.15)
-      polyglot
-      polyglot (>= 0.3.1)
-    tzinfo (0.3.40)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  rails (~> 3.2.19)
-  railties