fe 0.0.4 → 2.0.0

data/db/migrate/20150713022326_add_locale_columns.rb

@@ -0,0 +1,9 @@
+class AddLocaleColumns < ActiveRecord::Migration[4.2]
+  def change
+    add_column Fe::QuestionSheet.table_name, :languages, :text
+    add_column Fe::Element.table_name, :label_translations, :text
+    add_column Fe::Element.table_name, :tip_translations, :text
+    add_column Fe::Element.table_name, :content_translations, :text
+    add_column Fe::Page.table_name, :label_translations, :text
+  end
+end

data/db/migrate/20150714220730_add_locale_to_answer_sheet.rb

@@ -0,0 +1,5 @@
+class AddLocaleToAnswerSheet < ActiveRecord::Migration[4.2]
+  def change
+    add_column Fe.answer_sheet_class.constantize.table_name, :locale, :string, default: 'en'
+  end
+end

data/db/migrate/20150925181652_add_share_to_elements.rb

@@ -0,0 +1,5 @@
+class AddShareToElements < ActiveRecord::Migration[4.2]
+  def change
+    add_column Fe::Element.table_name, :share, :boolean, default: false
+  end
+end

data/db/migrate/20150928085325_change_pages_all_element_ids_to_text.rb

@@ -0,0 +1,5 @@
+class ChangePagesAllElementIdsToText < ActiveRecord::Migration[4.2]
+  def change
+    change_column Fe::Page.table_name, :all_element_ids, :text
+  end
+end

data/db/migrate/20150930191538_add_locale_to_reference_sheets.rb

@@ -0,0 +1,5 @@
+class AddLocaleToReferenceSheets < ActiveRecord::Migration[4.2]
+  def change
+    add_column Fe::ReferenceSheet.table_name, :locale, :string, default: 'en'
+  end
+end

data/db/migrate/20151021181928_switch_conditional_answer_separator_to_semicolon.rb

@@ -0,0 +1,7 @@
+class SwitchConditionalAnswerSeparatorToSemicolon < ActiveRecord::Migration[4.2]
+  def change
+    Fe::Element.where("conditional_answer IS NOT NULL AND conditional_answer != ''").each do |e|
+      e.update_column :conditional_answer, e.conditional_answer.gsub(',', ';')
+    end
+  end
+end

data/db/migrate/20151021184250_add_question_sheet_id_in_refs.rb

@@ -0,0 +1,12 @@
+class AddQuestionSheetIdInRefs < ActiveRecord::Migration[4.2]
+  def change
+    add_column Fe::ReferenceSheet.table_name, :question_sheet_id, :integer
+
+    # set initial question_sheet_id on all refs
+    # NOTE: doing an update on a join query is a pain to do in both mysql and postgres
+    # and since there's not that many reference questions, this should be fine
+    Fe::ReferenceQuestion.all.each do |rq|
+      Fe::ReferenceSheet.where(question_id: rq.id).update_all(question_sheet_id: rq.related_question_sheet_id)
+    end
+  end
+end

data/db/migrate/20160201185838_add_visible_and_visibility_cache_key_to_reference_sheets.rb

@@ -0,0 +1,6 @@
+class AddVisibleAndVisibilityCacheKeyToReferenceSheets < ActiveRecord::Migration[4.2]
+  def change
+    add_column Fe::ReferenceSheet.table_name, :visible, :boolean
+    add_column Fe::ReferenceSheet.table_name, :visibility_cache_key, :string
+  end
+end

data/db/migrate/20160805221415_add_rating_extra_labels.rb

@@ -0,0 +1,10 @@
+class AddRatingExtraLabels < ActiveRecord::Migration[4.2]
+  def change
+    add_column Fe::Element.table_name, :rating_before_label, :text
+    add_column Fe::Element.table_name, :rating_after_label, :text
+    add_column Fe::Element.table_name, :rating_na_label, :text
+    add_column Fe::Element.table_name, :rating_before_label_translations, :text
+    add_column Fe::Element.table_name, :rating_after_label_translations, :text
+    add_column Fe::Element.table_name, :rating_na_label_translations, :text
+  end
+end

data/db/migrate/20181108201746_create_versions.rb

@@ -0,0 +1,80 @@
+# This migration creates the `versions` table, the only schema PT requires.
+# All other migrations PT provides are optional.
+class CreateVersions < ActiveRecord::Migration[4.2]
+  # Class names of MySQL adapters.
+  # - `MysqlAdapter` - Used by gems: `mysql`, `activerecord-jdbcmysql-adapter`.
+  # - `Mysql2Adapter` - Used by `mysql2` gem.
+  MYSQL_ADAPTERS = [
+    "ActiveRecord::ConnectionAdapters::MysqlAdapter",
+    "ActiveRecord::ConnectionAdapters::Mysql2Adapter"
+  ].freeze
+
+  # The largest text column available in all supported RDBMS is
+  # 1024^3 - 1 bytes, roughly one gibibyte.  We specify a size
+  # so that MySQL will use `longtext` instead of `text`.  Otherwise,
+  # when serializing very large objects, `text` might not be big enough.
+  TEXT_BYTES = 1_073_741_823
+
+  def change
+    create_table :versions, versions_table_options do |t|
+      t.string   :item_type, item_type_options
+      t.integer  :item_id,   null: false
+      t.string   :event,     null: false
+      t.string   :whodunnit
+      t.text     :object, limit: TEXT_BYTES
+
+      # Known issue in MySQL: fractional second precision
+      # -------------------------------------------------
+      #
+      # MySQL timestamp columns do not support fractional seconds unless
+      # defined with "fractional seconds precision". MySQL users should manually
+      # add fractional seconds precision to this migration, specifically, to
+      # the `created_at` column.
+      # (https://dev.mysql.com/doc/refman/5.6/en/fractional-seconds.html)
+      #
+      # MySQL users should also upgrade to rails 4.2, which is the first
+      # version of ActiveRecord with support for fractional seconds in MySQL.
+      # (https://github.com/rails/rails/pull/14359)
+      #
+      t.datetime :created_at
+    end
+    add_index :versions, [:item_type, :item_id]
+  end
+
+  private
+
+  # MySQL 5.6 utf8mb4 limit is 191 chars for keys used in indexes.
+  # See https://github.com/airblade/paper_trail/issues/651
+  def item_type_options
+    opt = { null: false }
+    opt[:limit] = 191 if mysql?
+    opt
+  end
+
+  def mysql?
+    MYSQL_ADAPTERS.include?(connection.class.name)
+  end
+
+  # Even modern versions of MySQL still use `latin1` as the default character
+  # encoding. Many users are not aware of this, and run into trouble when they
+  # try to use PaperTrail in apps that otherwise tend to use UTF-8. Postgres, by
+  # comparison, uses UTF-8 except in the unusual case where the OS is configured
+  # with a custom locale.
+  #
+  # - https://dev.mysql.com/doc/refman/5.7/en/charset-applications.html
+  # - http://www.postgresql.org/docs/9.4/static/multibyte.html
+  #
+  # Furthermore, MySQL's original implementation of UTF-8 was flawed, and had
+  # to be fixed later by introducing a new charset, `utf8mb4`.
+  #
+  # - https://mathiasbynens.be/notes/mysql-utf8mb4
+  # - https://dev.mysql.com/doc/refman/5.5/en/charset-unicode-utf8mb4.html
+  #
+  def versions_table_options
+    if mysql?
+      { options: "ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_general_ci" }
+    else
+      {}
+    end
+  end
+end

data/db/migrate/20181218201130_increase_slug_length.rb

@@ -0,0 +1,5 @@
+class IncreaseSlugLength < ActiveRecord::Migration
+  def change
+    change_column Fe::Question.table_name, :slug, :string, limit: 128
+  end
+end

data/lib/access_key_generator.rb

@@ -0,0 +1,12 @@
+require 'securerandom'
+
+module Fe
+  module AccessKeyGenerator
+    def generate_access_key
+      begin
+        self.access_key = SecureRandom.hex
+      end while self.class.exists?(access_key: access_key)
+      return access_key
+    end
+  end
+end

data/lib/distinct_distinct_patch.rb

@@ -0,0 +1,20 @@
+require 'active_record'
+
+module DistinctDistinctPatch
+  def construct_limited_ids_condition(relation)
+    orders = relation.order_values.map { |val| val.presence }.compact
+    values = @klass.connection.distinct("#{@klass.connection.quote_table_name table_name}.#{primary_key}", orders)
+
+    relation = relation.dup.select(values)
+    relation.uniq_value = nil
+
+    id_rows = @klass.connection.select_all(relation.arel, 'SQL', relation.bind_values)
+    ids_array = id_rows.map {|row| row[primary_key]}
+
+    ids_array.empty? ? raise(ActiveRecord::ThrowResult) : table[primary_key].in(ids_array)
+  end
+end
+
+class ActiveRecord::Relation
+  include DistinctDistinctPatch
+end

data/lib/fe/engine.rb

@@ -1,3 +1,5 @@
+require 'acts_as_list'
+
 module Fe
   class Engine < ::Rails::Engine
     # isolate_namespace is causing problems accessing the app's url helpers when the app
@@ -6,7 +8,7 @@ module Fe
     # Using the si as an example:
     #
     # si/app/controllers/fe/test_controller.rb
-    # 
+    #
     #   class Fe::TestController < ApplicationController
     #     def index
     #     end
@@ -20,15 +22,15 @@ module Fe
     # http://crypt.codemancers.com/posts/2013-09-22-isolate-namespace-in-rails-engines/
     # it's a real pain to extend an isolated namespace engine from the app:
     #
-    #   "Other issues include extending models and controllers. Rails 
+    #   "Other issues include extending models and controllers. Rails
     #   guides gives two options here. One to use class_eval, and other
-    #   to use concerns introduced in Rails 4. Both are kind of hacky. 
+    #   to use concerns introduced in Rails 4. Both are kind of hacky.
     #   Hope there is a better solution."
-    # 
+    #
     # and as per a user comment on that page:
     #
     #   "I've had a similar experience with `isolate_namespace`, if the engines
-    #   need to be truely isolated it works, but if you need to extend the engine 
+    #   need to be truely isolated it works, but if you need to extend the engine
     #   from the client app its best to remove it and just namespace manually.
     #
     # I'm disabling the isolate_namespace
@@ -37,28 +39,38 @@ module Fe
 
 
     config.to_prepare do
-      Dir.glob(File.join(File.dirname(__FILE__), "..", "..", "app", "**", "*_concern.rb")).each do |c|
-        require_dependency(c)
+      require_dependency('distinct_distinct_patch.rb')
+      require_dependency('access_key_generator')
+
+      # Loading concerns and dependencies here when running FE specs breaks the coverage report.  The
+      # Rakefile will set SKIP_CONCERNS and SKIP_DECORATORS true and decorators/concerns are loaded from
+      # spec/rails_helper.rb instead
+      if ENV['SKIP_CONCERNS'] != 'true'
+        Dir.glob(File.join(File.dirname(__FILE__), "..", "..", "app", "**", "*_concern.rb")).each do |c|
+          require_dependency(c)
+        end
       end
 
-      Dir.glob(File.join(Rails.root + 'app/decorators/**/*_decorator.rb')).each do |c|
-        require_dependency(c)
+      if ENV['SKIP_CONCERNS'] != 'true'
+        Dir.glob(File.join(Rails.root + 'app/decorators/**/*_decorator.rb')).each do |c|
+          require_dependency(c)
+        end
       end
     end
 
     config.generators do |g|
-      g.test_framework      :rspec,        :fixture => false
-      g.fixture_replacement :factory_girl, :dir => 'spec/factories'
+      g.test_framework      :rspec,        fixture: false
+      g.fixture_replacement :factory_bot, dir: 'spec/factories'
       g.assets false
       g.helper false
     end
 
     initializer "fe.asset_precompile_paths" do |app|
       app.config.assets.precompile += %w(fe/admin.js fe/fe.screen.css)
-    end 
+    end
 
-    initializer "model_core.factories", :after => "factory_girl.set_factory_paths" do
-      FactoryGirl.definition_file_paths << File.expand_path('../../../spec/factories', __FILE__) if defined?(FactoryGirl)
+    initializer "model_core.factories", after: "factory_bot.set_factory_paths" do
+      FactoryBot.definition_file_paths << File.expand_path('../../../spec/factories', __FILE__) if defined?(FactoryBot)
     end
   end
 end

data/lib/fe/version.rb

@@ -1,3 +1,3 @@
 module Fe
-  VERSION = "0.0.4"
+  VERSION = "2.0.0"
 end

data/lib/fe.rb

@@ -1,16 +1,20 @@
 require "fe/engine"
 
 module Fe
+  LANGUAGES = { 'es' => 'Español', 'pt' => 'Português' }
   # prefix for database tables
   mattr_accessor :table_name_prefix
   self.table_name_prefix ||= 'fe_'
-  
+
   mattr_accessor :answer_sheet_class
   self.answer_sheet_class ||= 'Fe::Application'
 
   mattr_accessor :from_email
   self.from_email ||= 'info@example.com'
 
+  mattr_accessor :never_reuse_elements
+  self.never_reuse_elements = false
+
   def self.next_label(prefix, labels)
     max = labels.inject(0) do |m, label|
       num = label[/^#{prefix} ([0-9]+)$/i, 1].to_i   # extract your digits
@@ -19,4 +23,10 @@ module Fe
 
     "#{prefix} #{max.next}"
   end
+
+  mattr_accessor :date_format
+  self.date_format = 'yy-mm-dd'
+
+  mattr_accessor :bootstrap
+  self.bootstrap = false
 end

data/spec/controllers/fe/admin/elements_controller_spec.rb

@@ -1,4 +1,214 @@
 require 'rails_helper'
 
-describe Fe::Admin::ElementsController do
+describe Fe::Admin::ElementsController, type: :controller do
+  context '#show' do
+    it 'should work' do
+      answer_sheet = create(:answer_sheet)
+      page = create(:page)
+      question_sheet = page.question_sheet
+      create(:answer_sheet_question_sheet, answer_sheet: answer_sheet, question_sheet: question_sheet)
+      element = create(:text_field_element)
+      create(:page_element, element: element, page: page)
+
+      get :edit, params: {question_sheet_id: question_sheet.id, page_id: page.id, id: element.id}, xhr: true
+      expect(assigns(:element)).to eq(element)
+    end
+  end
+  context '#new' do
+    it 'should work' do
+      answer_sheet = create(:answer_sheet)
+      page = create(:page)
+      question_sheet = page.question_sheet
+      create(:answer_sheet_question_sheet, answer_sheet: answer_sheet, question_sheet: question_sheet)
+      element1 = create(:text_field_element, style: 'style', share: true)
+      element2 = create(:text_field_element, style: 'style', share: false)
+      create(:page_element, element: element1, page: page)
+      create(:page_element, element: element2, page: page)
+
+      get :new, params: {element_type: 'Fe::TextField', element: { style: 'style' }, question_sheet_id: question_sheet.id, page_id: page.id}, xhr: true
+      expect(assigns(:questions)).to eq([element1])
+    end
+  end
+  context '#use_existing' do
+    it 'should work' do
+      answer_sheet = create(:answer_sheet)
+      page = create(:page)
+      question_sheet = page.question_sheet
+      create(:answer_sheet_question_sheet, answer_sheet: answer_sheet, question_sheet: question_sheet)
+      element = create(:text_field_element, style: 'style')
+
+      get :use_existing, params: {question_sheet_id: question_sheet.id, page_id: page.id, id: element.id}, xhr: true
+      expect(assigns(:page_element)).to_not be_nil
+      expect(assigns(:page_element)).to_not be_nil
+      expect(assigns(:page)).to eq(page)
+      expect(assigns(:page_element).element).to eq(element)
+    end
+  end
+  context '#copy_existing' do
+    it 'should work' do
+      answer_sheet = create(:answer_sheet)
+      page = create(:page)
+      question_sheet = page.question_sheet
+      create(:answer_sheet_question_sheet, answer_sheet: answer_sheet, question_sheet: question_sheet)
+      element = create(:text_field_element, style: 'style', share: true)
+
+      get :copy_existing, params: {question_sheet_id: question_sheet.id, page_id: page.id, id: element.id}, xhr: true
+      expect(assigns(:page_element)).to_not be_nil
+      expect(assigns(:page_element)).to_not be_nil
+      expect(assigns(:page)).to eq(page)
+      expect(assigns(:page_element).element).to_not eq(element)
+      expect(assigns(:page_element).element.share).to be false
+    end
+  end
+  context '#create' do
+    it 'should work' do
+      answer_sheet = create(:answer_sheet)
+      page = create(:page)
+      question_sheet = page.question_sheet
+      create(:answer_sheet_question_sheet, answer_sheet: answer_sheet, question_sheet: question_sheet)
+
+      expect {
+        post :create, params: {element_type: 'Fe::TextField', element: { style: 'style' }, question_sheet_id: question_sheet.id, page_id: page.id}, xhr: true
+      }.to change{Fe::Element.count}.by(1)
+
+      expect(assigns(:page_element)).to_not be_nil
+      new_element = Fe::Element.last
+      expect(assigns(:page_element).element).to eq(new_element)
+      expect(assigns(:page_element).page).to eq(page)
+    end
+    it 'should handle error saving element' do
+      answer_sheet = create(:answer_sheet)
+      page = create(:page)
+      question_sheet = page.question_sheet
+      create(:answer_sheet_question_sheet, answer_sheet: answer_sheet, question_sheet: question_sheet)
+
+      expect {
+        post :create, params: {element_type: 'Fe::TextField', element: { slug: "Illegal Chars: #@$!" }, question_sheet_id: question_sheet.id, page_id: page.id}, xhr: true
+      }.to change{Fe::Element.count}.by(0)
+
+      expect(assigns(:page_element)).to be_nil
+      expect(response).to render_template('error.js.erb')
+    end
+  end
+  context '#update' do
+    it 'should work' do
+      answer_sheet = create(:answer_sheet)
+      page = create(:page)
+      question_sheet = page.question_sheet
+      create(:answer_sheet_question_sheet, answer_sheet: answer_sheet, question_sheet: question_sheet)
+      element = create(:text_field_element, style: 'style')
+      create(:page_element, element: element, page: page)
+
+      put :update, params: {element: { style: 'style' }, question_sheet_id: question_sheet.id, page_id: page.id, id: element.id}, xhr: true
+
+      expect(assigns(:element)).to eq(element)
+      expect(assigns(:element).style).to eq('style')
+    end
+    it 'should handle error saving element' do
+      answer_sheet = create(:answer_sheet)
+      page = create(:page)
+      question_sheet = page.question_sheet
+      create(:answer_sheet_question_sheet, answer_sheet: answer_sheet, question_sheet: question_sheet)
+      element = create(:text_field_element, style: 'style')
+      create(:page_element, element: element, page: page)
+
+      put :update, params: {element: { slug: "Illegal Chars: #@$!" }, question_sheet_id: question_sheet.id, page_id: page.id, id: element.id}, xhr: true
+      expect(assigns(:element)).to eq(element)
+      expect(response).to render_template('error.js.erb')
+    end
+  end
+  context '#destroy' do
+    it 'should destroy the element when it is not used in any other pages' do
+      answer_sheet = create(:answer_sheet)
+      page = create(:page)
+      question_sheet = page.question_sheet
+      create(:answer_sheet_question_sheet, answer_sheet: answer_sheet, question_sheet: question_sheet)
+      element = create(:text_field_element, style: 'style')
+      create(:page_element, element: element, page: page)
+
+      delete :destroy, params: {question_sheet_id: question_sheet.id, page_id: page.id, id: element.id}, xhr: true
+
+      expect(Fe::PageElement.find_by(page_id: page.id, element_id: element.id)).to be_nil
+      expect(Fe::Element.find_by(id: element.id)).to be_nil
+    end
+    it 'should not destroy the element when it is not used in any other pages, but it has answers' do
+      answer_sheet = create(:answer_sheet)
+      page = create(:page)
+      question_sheet = page.question_sheet
+      create(:answer_sheet_question_sheet, answer_sheet: answer_sheet, question_sheet: question_sheet)
+      element = create(:text_field_element, style: 'style')
+      create(:page_element, element: element, page: page)
+      create(:answer, question: element, value: 'answer here', answer_sheet: answer_sheet)
+
+      delete :destroy, params: {question_sheet_id: question_sheet.id, page_id: page.id, id: element.id}, xhr: true
+
+      expect(Fe::PageElement.find_by(page_id: page.id, element_id: element.id)).to be_nil
+      expect(Fe::Element.find_by(id: element.id)).to_not be_nil
+    end
+    it 'should not destroy the element when it has no answers, but is being used in another page' do
+      answer_sheet = create(:answer_sheet)
+      page = create(:page)
+      page2 = create(:page)
+      question_sheet = page.question_sheet
+      create(:answer_sheet_question_sheet, answer_sheet: answer_sheet, question_sheet: question_sheet)
+      element = create(:text_field_element, style: 'style')
+      create(:page_element, element: element, page: page)
+      create(:page_element, element: element, page: page2)
+
+      delete :destroy, params: {question_sheet_id: question_sheet.id, page_id: page.id, id: element.id}, xhr: true
+
+      expect(Fe::PageElement.find_by(page_id: page.id, element_id: element.id)).to be_nil
+      expect(Fe::Element.find_by(id: element.id)).to_not be_nil
+    end
+  end
+
+  context '#reorder' do
+    it 'should work inside a question grid' do
+      answer_sheet = create(:answer_sheet)
+      page = create(:page)
+      question_sheet = page.question_sheet
+      create(:answer_sheet_question_sheet, answer_sheet: answer_sheet, question_sheet: question_sheet)
+      element = create(:text_field_element, style: 'style')
+      element2 = create(:text_field_element, style: 'style')
+      element3 = create(:question_grid, style: 'style')
+      element4 = create(:text_field_element, style: 'style', question_grid_id: element3.id)
+      element5 = create(:text_field_element, style: 'style', question_grid_id: element3.id)
+      create(:page_element, element: element, page: page)
+      create(:page_element, element: element2, page: page)
+      create(:page_element, element: element3, page: page)
+
+      page_element_positions_before = Fe::PageElement.all.pluck(:position)
+
+      post :reorder, params: {question_sheet_id: question_sheet.id, page_id: page.id, "questions_list_#{element3.id}" => [ element5.id, element4.id ]}, xhr: true
+      # it shouldn't touch the page elements
+      expect(Fe::PageElement.all.pluck(:position)).to eq(page_element_positions_before)
+      # it should put a new order on the question grid elements
+      expect(element5.reload.position).to eq(1)
+      expect(element4.reload.position).to eq(2)
+    end
+    it 'should work outside a question grid' do
+      answer_sheet = create(:answer_sheet)
+      page = create(:page)
+      question_sheet = page.question_sheet
+      create(:answer_sheet_question_sheet, answer_sheet: answer_sheet, question_sheet: question_sheet)
+      element = create(:text_field_element, style: 'style')
+      element2 = create(:text_field_element, style: 'style')
+      element3 = create(:question_grid, style: 'style')
+      element4 = create(:text_field_element, style: 'style', question_grid_id: element3.id)
+      element5 = create(:text_field_element, style: 'style', question_grid_id: element3.id)
+      pe1 = create(:page_element, element: element, page: page)
+      pe2 = create(:page_element, element: element2, page: page)
+      pe3 = create(:page_element, element: element3, page: page)
+
+      question_grid_elements_positions_before = element3.reload.elements.pluck(:position)
+
+      post :reorder, params: {question_sheet_id: question_sheet.id, page_id: page.id, "questions_list" => [ element3.id, element.id, element2.id ]}, xhr: true
+      # it shouldn't touch the question grid positions
+      expect(element3.reload.elements.pluck(:position)).to eq(question_grid_elements_positions_before)
+      # it should put a new order on the page elements
+      expect(pe3.reload.position).to eq(1)
+      expect(pe1.reload.position).to eq(2)
+      expect(pe2.reload.position).to eq(3)
+    end
+  end
 end

data/spec/controllers/fe/admin/email_templates_controller_spec.rb

@@ -1,4 +1,29 @@
 require 'rails_helper'
 
-describe Fe::Admin::EmailTemplatesController do
+describe Fe::Admin::EmailTemplatesController, type: :controller do
+  let(:email_template) { create(:email_template) }
+
+  context '#index' do
+    it 'should work' do
+      email_template = create(:email_template, name: 'Template')
+      get :index
+      expect(assigns(:email_templates)).to eq([email_template])
+    end
+  end
+
+  context '#new' do
+    it 'should work' do
+      get :new
+      expect(assigns(:email_template)).to_not be_nil
+    end
+  end
+
+  context '#create' do
+    it 'should work' do
+      expect {
+        post :create, params: {email_template: { name: 'Name', subject: 'Subject', content: 'Content' }}
+      }.to change{Fe::EmailTemplate.count}.by(1)
+      expect(assigns(:email_template)).to_not be_nil
+    end
+  end
 end

data/spec/controllers/fe/admin/question_pages_controller_spec.rb

@@ -1,4 +1,11 @@
 require 'rails_helper'
 
-describe Fe::Admin::QuestionPagesController do
+describe Fe::Admin::QuestionPagesController, type: :controller do
+  context '#show' do
+    it 'should work' do
+      page = create(:page)
+      question_sheet = page.question_sheet
+      get :show, params: {question_sheet_id: question_sheet.id, id: page.id}, xhr: true
+    end
+  end
 end

data/spec/controllers/fe/admin/question_sheets_controller_spec.rb

@@ -1,4 +1,51 @@
 require 'rails_helper'
 
-describe Fe::Admin::QuestionSheetsController do
+describe Fe::Admin::QuestionSheetsController, type: :controller do
+  context '#index' do
+    it 'should work' do
+      active_qs = create(:question_sheet, archived: false)
+      archived_qs = create(:question_sheet, archived: true)
+      get :index
+      expect(assigns(:active_question_sheets)).to_not be_nil
+      expect(assigns(:archived_question_sheets)).to_not be_nil
+      expect(assigns(:active_question_sheets)).to eq([active_qs])
+      expect(assigns(:archived_question_sheets)).to eq([archived_qs])
+    end
+  end
+  context '#archive' do
+    it 'should work' do
+      active_qs = create(:question_sheet, archived: false)
+      request.env["HTTP_REFERER"] = '/'
+      post :archive, params: {id: active_qs.id}
+      expect(active_qs.reload.archived).to be true
+    end
+  end
+  context '#unarchive' do
+    it 'should work' do
+      active_qs = create(:question_sheet, archived: true)
+      request.env["HTTP_REFERER"] = '/'
+      post :unarchive, params: {id: active_qs.id}
+      expect(active_qs.reload.archived).to be false
+    end
+  end
+  context '#duplicate' do
+    it 'should work' do
+      qs = create(:question_sheet)
+      request.env["HTTP_REFERER"] = '/'
+      expect {
+        post :duplicate, params: {id: qs.id}
+      }.to change{Fe::QuestionSheet.count}.by(1)
+      expect(Fe::QuestionSheet.last.label).to eq("#{qs.label} - COPY")
+    end
+  end
+  context '#show' do
+    it 'should work' do
+      qs = create(:question_sheet)
+      p1 = create(:page, question_sheet: qs)
+      p2 = create(:page, question_sheet: qs)
+      get :show, params: {id: qs.id}
+      expect(assigns(:all_pages)).to eq([p1, p2])
+      expect(assigns(:page)).to eq(p1)
+    end
+  end
 end