fe 0.0.3 → 0.0.4

data/spec/models/fe/element_spec.rb

@@ -1,12 +1,142 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Fe::Element do
-  it { should belong_to :question_grid }  
-  it { should belong_to :choice_field }  
-  it { should have_many :page_elements }
-  it { should have_many :pages }
-  it { should validate_presence_of :kind }
-  # it { should validate_presence_of :style } # this isn't working
-  it { should ensure_length_of :kind }
-  it { should ensure_length_of :style }
+  it { expect belong_to :question_grid }  
+  it { expect belong_to :choice_field }  
+  it { expect have_many :page_elements }
+  it { expect have_many :pages }
+  it { expect validate_presence_of :kind }
+  # it { expect validate_presence_of :style } # this isn't working
+  it { expect ensure_length_of :kind }
+  it { expect ensure_length_of :style }
+
+  it "should update a conditional question if added after that question" do
+    question_sheet = FactoryGirl.create(:question_sheet_with_pages)
+    conditional_el = FactoryGirl.create(:choice_field_element, label: "This is a test for a yes/no question that will hide the next element", conditional_type: "Fe::Element")
+    question_sheet.pages.reload
+    question_sheet.pages[3].elements << conditional_el
+    element = FactoryGirl.create(:text_field_element, label: "This is a test of a short answer that will be hidden by the previous elemenet", conditional_type: nil, conditional_answer: nil)
+    question_sheet.pages[3].elements << element
+    conditional_el.reload
+    expect(conditional_el.conditional).to eq(element)
+  end
+
+  it "should update a conditional question if elements are moved around" do
+    question_sheet = FactoryGirl.create(:question_sheet_with_pages)
+    conditional_el = FactoryGirl.create(:choice_field_element, label: "This is a test for a yes/no question that will hide the next element", conditional_type: "Fe::Element")
+    question_sheet.pages.reload
+    question_sheet.pages[3].elements << conditional_el
+    element = FactoryGirl.create(:text_field_element, label: "This is a test of a short answer that will be moved", conditional_type: nil, conditional_answer: nil)
+    question_sheet.pages[3].elements << element
+    element2 = FactoryGirl.create(:text_field_element, label: "This is a test of a short answer that will be moved to become hidden", conditional_type: nil, conditional_answer: nil)
+    question_sheet.pages[3].elements << element2
+
+    element.reload
+    element2.reload
+    conditional_el.reload
+
+    # currently, page has elements in this order: conditional, element, element2
+    # now swap the last 2 elements
+    old_element_position = element.position(question_sheet.pages[3])
+    old_element2_position = element2.position(question_sheet.pages[3])
+    element.page_elements.first.update_attributes(position: old_element2_position)
+    element2.page_elements.first.update_attributes(position: old_element_position)
+
+    conditional_el.reload
+    expect(conditional_el.conditional).to eq(element2)
+  end
+
+  it "should set the conditional page if a new conditional page element is created" do
+    question_sheet = FactoryGirl.create(:question_sheet_with_pages)
+    hide_page = question_sheet.pages[4]
+    conditional_el = FactoryGirl.create(:choice_field_element, label: "This is a test for a yes/no question that will hide the next pag", conditional_type: "Fe::Page", conditional_id: hide_page.id)
+    question_sheet.pages.reload
+    question_sheet.pages[3].elements << conditional_el
+    conditional_el.reload
+    expect(conditional_el.conditional).to eq(hide_page)
+  end
+
+  it "should keep the conditional page if a page is moved" do
+    question_sheet = FactoryGirl.create(:question_sheet_with_pages)
+    hide_page = question_sheet.pages[4]
+    conditional_el = FactoryGirl.create(:choice_field_element, label: "This is a test for a yes/no question that will hide the next pag", conditional_type: "Fe::Page", conditional_id: hide_page.id)
+    question_sheet.pages.reload
+    question_sheet.pages[3].elements << conditional_el
+    conditional_el.reload
+    expect(conditional_el.conditional).to eq(question_sheet.pages[4])
+
+    # move some pages around
+    question_sheet.pages[0].update_attributes number: 1
+    question_sheet.pages[1].update_attributes number: 2
+    question_sheet.pages[2].update_attributes number: 3
+    question_sheet.pages[3].update_attributes number: 0 # the page the conditional element is on
+    question_sheet.pages[4].update_attributes number: 4
+    question_sheet.pages.reload
+
+    # the page after the conditional page should still be set to the same page
+    conditional_el.reload
+    expect(conditional_el.conditional).to eq(hide_page)
+  end
+
+  it "should not let a hidden page make the questionnaire incomplete" do
+    question_sheet = FactoryGirl.create(:question_sheet_with_pages)
+    hide_page = question_sheet.pages[4]
+    conditional_el = FactoryGirl.create(:choice_field_element, label: "This is a test for a yes/no question that will hide the next page", conditional_type: "Fe::Page", conditional_id: hide_page.id, conditional_answer: "yes")
+    question_sheet.pages.reload
+    question_sheet.pages[3].elements << conditional_el
+    conditional_el.reload
+    expect(conditional_el.conditional).to eq(question_sheet.pages[4])
+
+    # add required element on hidden page
+    element = FactoryGirl.create(:text_field_element, label: "This is a test of a short answer on a hidden page")
+    hide_page.elements << element
+
+    # set up an answer sheet
+    application = FactoryGirl.create(:answer_sheet)
+    application.answer_sheet_question_sheet = FactoryGirl.create(:answer_sheet_question_sheet, answer_sheet: application, question_sheet: question_sheet)
+    application.answer_sheet_question_sheets.first.update_attributes(question_sheet_id: question_sheet.id)
+
+    # validate the hidden page, it should be marked complete
+    expect(hide_page.complete?(application)).to eq(true)
+
+    # make the answer to the conditional question 'yes' so that the element shows up and is thus required
+    conditional_el.set_response("yes", application)
+    conditional_el.save_response(application)
+
+    # validate the now-visible  page, it should be marked not complete
+    expect(hide_page.complete?(application)).to eq(false)
+  end
+
+  it "should not require questions in a hidden page" do
+    question_sheet = FactoryGirl.create(:question_sheet_with_pages)
+    hide_page = question_sheet.pages[4]
+    conditional_el = FactoryGirl.create(:choice_field_element, label: "This is a test for a yes/no question that will hide the next page", conditional_type: "Fe::Page", conditional_id: hide_page.id, conditional_answer: "yes")
+    question_sheet.pages.reload
+    question_sheet.pages[3].elements << conditional_el
+    conditional_el.reload
+    expect(conditional_el.conditional).to eq(question_sheet.pages[4])
+
+    # add required element on hidden page
+    element = FactoryGirl.create(:text_field_element, label: "This is a test of a short answer on a hidden page")
+    hide_page.elements << element
+
+    # set up an answer sheet
+    application = FactoryGirl.create(:answer_sheet)
+    application.answer_sheet_question_sheet = FactoryGirl.create(:answer_sheet_question_sheet, answer_sheet: application, question_sheet: question_sheet)
+    application.answer_sheet_question_sheets.first.update_attributes(question_sheet_id: question_sheet.id)
+
+    # make the answer to the conditional question 'yes' (match) so that the element is visible (and thus required)
+    conditional_el.set_response("yes", application)
+    conditional_el.save_response(application)
+
+    # validate the hidden page, it should not be complete
+    expect(hide_page.complete?(application)).to eq(false)
+
+    # make the answer to the conditional question 'no' (no match) so that the element is hidden
+    conditional_el.set_response("no", application)
+    conditional_el.save_response(application)
+
+    # validate the hidden page, it should be marked complete because of being hidden
+    expect(hide_page.complete?(application)).to eq(true)
+  end
 end

data/spec/models/fe/email_template_spec.rb

@@ -1,5 +1,5 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Fe::EmailTemplate do
-  it { should validate_presence_of :name }
+  it { expect validate_presence_of :name }
 end

data/spec/models/fe/option_group_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Fe::OptionGroup do
 end

data/spec/models/fe/option_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Fe::Option do
 end

data/spec/models/fe/page_element_spec.rb

@@ -1,6 +1,6 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Fe::PageElement do
-  it { should belong_to :page }
-  it { should belong_to :element }
+  it { expect belong_to :page }
+  it { expect belong_to :element }
 end

data/spec/models/fe/page_link_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Fe::PageLink do
 end

data/spec/models/fe/page_spec.rb

@@ -1,14 +1,46 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Fe::Page do
-  it { should belong_to :question_sheet }
-  it { should have_many :page_elements }
-  it { should have_many :elements }
-  it { should have_many :questions }
-  it { should have_many :question_grids }
-  it { should have_many :question_grid_with_totals }
-  # it { should validate_presence_of :label } # this isn't working
-  # it { should validate_presence_of :number } # this isn't working
-  it { should ensure_length_of :label }
-  it { should validate_numericality_of :number }
+  it { expect belong_to :question_sheet }
+  it { expect have_many :page_elements }
+  it { expect have_many :elements }
+  it { expect have_many :questions }
+  it { expect have_many :question_grids }
+  it { expect have_many :question_grid_with_totals }
+  # it { expect validate_presence_of :label } # this isn't working
+  # it { expect validate_presence_of :number } # this isn't working
+  it { expect ensure_length_of :label }
+  # it { expect validate_numericality_of :number }
+
+  it "should not require a hidden element" do
+    question_sheet = FactoryGirl.create(:question_sheet_with_pages)
+    conditional_el = FactoryGirl.create(:choice_field_element, label: "This is a test for a yes/no question that will hide the next element if the answer is yes", conditional_type: "Fe::Element", conditional_answer: "yes")
+    question_sheet.pages.reload
+    question_sheet.pages[3].elements << conditional_el
+    element = FactoryGirl.create(:text_field_element, label: "This is a test of a short answer that is made visible by the previous elemenet")
+    question_sheet.pages[3].elements << element
+    conditional_el.reload
+    expect(conditional_el.conditional).to eq(element)
+
+    # set up an answer sheet
+    application = FactoryGirl.create(:answer_sheet)
+    application.answer_sheet_question_sheet = FactoryGirl.create(:answer_sheet_question_sheet, answer_sheet: application, question_sheet: question_sheet)
+    application.answer_sheet_question_sheets.first.update_attributes(question_sheet_id: question_sheet.id)
+
+    # make the answer to the conditional question 'yes' so that the next element shows up and is thus required
+    conditional_el.set_response("no", application)
+    conditional_el.save_response(application)
+
+    # validate the page -- the next element after the conditional should not be required
+    page = question_sheet.pages[3]
+    expect(page.complete?(application)).to eq(true)
+
+    # make the answer to the conditional question 'yes' so that the next element shows up and is thus required
+    conditional_el.set_response("yes", application)
+    conditional_el.save_response(application)
+
+    # validate the page -- the next element after the conditional should not be required
+    page = question_sheet.pages[3]
+    expect(page.complete?(application)).to eq(false)
+  end
 end

data/spec/models/fe/paragraph_spec.rb

@@ -1,17 +1,17 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Fe::Paragraph do
   describe '#validate_presence_of :content on update' do 
     it 'successfully saves with content' do 
       paragraph = build(:paragraph)
       paragraph.content = "abc"
-      paragraph.save.should be_true 
+      expect(paragraph.save).to eq(true)
     end
     
     it 'saves with default content' do 
       paragraph = build(:paragraph) 
-      paragraph.save.should be_true
-      paragraph.content.should == "Lorem ipsum..."
+      expect(paragraph.save).to eq(true)
+      expect(paragraph.content).to eq("Lorem ipsum...")
     end
   end
 end

data/spec/models/fe/payment_question_spec.rb

@@ -0,0 +1,65 @@
+require 'rails_helper'
+
+describe Fe::PaymentQuestion do
+  before(:all) do
+    @person = create(:fe_person)
+    @application = create(:application, applicant: @person)
+    @payment_question = Fe::PaymentQuestion.new
+  end
+
+  describe "when calling 'response' function" do
+    it 'returns a new payment if no application specified' do
+      response = @payment_question.send(:response)
+      expect(response.new_record?).to be_truthy
+    end
+    it 'returns the existing application payment if the application already have payments' do
+      payment = create(:payment, application: @application)
+      response = @payment_question.send(:response, @application).first
+      expect(response.id).to be payment.id
+    end
+    it 'returns a new application payment if the application do not have payments yet' do
+      response = @payment_question.send(:response, @application)
+      expect(response).not_to be nil
+    end
+  end
+
+  describe "when calling 'display_response' function" do
+    it 'returns a blank string if no application specified' do
+      expect(@payment_question).to receive(:response)
+      response = @payment_question.send(:display_response)
+      expect(response).to eq('')
+    end
+    it 'returns an existing application payment string if the application already have payments' do
+      payment = create(:payment, application: @application)
+      expect(@payment_question).to receive(:response).with(@application).and_return(payment)
+      response = @payment_question.send(:display_response, @application)
+      expect(response).not_to be_blank
+    end
+    it 'returns a blank string if the application do not have payments yet' do
+      expect(@payment_question).to receive(:response).with(@application)
+      response = @payment_question.send(:display_response, @application)
+      expect(response).to eq('')
+    end
+  end
+
+  #describe "when calling 'has_response' function" do
+    #before(:each) do
+      #question_sheet = create(:question_sheet)
+      #answer_sheet = create(:answer_sheet)
+      #answer_sheet_question_sheet = create(:answer_sheet_question_sheet, answer_sheet: answer_sheet, question_sheet: question_sheet)
+    #end
+    #it "returns a boolean 'false' if no application specified" do
+      #response = @payment_question.send(:has_response?)
+      #response.should be false
+    #end
+    #it "returns a boolean 'true' if the application already have payments" do
+      #payment = create(:payment, application: @application)
+      #response = @payment_question.send(:has_response?, @application)
+      #response.should be true
+    #end
+    #it "returns a boolean 'false' if the application do not have payments yet" do
+      #response = @payment_question.send(:has_response?, @application)
+      #response.should be false
+    #end
+  #end
+end

data/spec/models/fe/person_spec.rb

@@ -0,0 +1,4 @@
+require 'rails_helper'
+
+RSpec.describe Fe::Person, :type => :model do
+end

data/spec/models/fe/question_grid_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Fe::QuestionGrid do
 end

data/spec/models/fe/question_grid_with_total_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Fe::QuestionGridWithTotal do
 end

data/spec/models/fe/question_set_spec.rb

@@ -1,4 +1,4 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Fe::QuestionSet do
 end

data/spec/models/fe/question_sheet_spec.rb

@@ -1,8 +1,8 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Fe::QuestionSheet do
-  it { should have_many :pages }
-  it { should have_many :answer_sheets }
-  it { should validate_presence_of :label }
-  it { should validate_uniqueness_of :label }
+  it { expect have_many :pages }
+  it { expect have_many :answer_sheets }
+  it { expect validate_presence_of :label }
+  it { expect validate_uniqueness_of :label }
 end

data/spec/models/fe/question_spec.rb

@@ -1,19 +1,20 @@
-require 'spec_helper'
+require 'rails_helper'
 
-describe Question do
-  it { should have_many :conditions }
-  it { should have_many :dependents }
-  it { should have_many :sheet_answers }
-  it { should belong_to :related_question_sheet }
+describe Fe::Question do
+  it { expect have_many :conditions }
+  it { expect have_many :dependents }
+  it { expect have_many :sheet_answers }
+  it { expect belong_to :related_question_sheet }
   
-  # it { should validate_format_of :slug }
-  # it { should validate_length_of :slug }
-  # it { should validate_uniqueness_of :slug }
+  # it { expect validate_format_of :slug }
+  # it { expect validate_length_of :slug }
+  # it { expect validate_uniqueness_of :slug }
   
   describe '#default_label?' do 
-    it 'should return true' do 
-      question = Question.new
-      question.default_label?.should be_true
+    it 'expect return true' do 
+      question = Fe::Question.new
+      #question.default_label?.expect be_true
+      expect(question.default_label?).to eq(true)
     end
   end
   

data/spec/models/fe/reference_question_spec.rb

@@ -1,17 +1,17 @@
-require 'spec_helper' 
+require 'rails_helper' 
 
 describe Fe::ReferenceQuestion do
   describe '#ptemplate' do 
     it 'default' do 
       ref = create(:reference_question)
-      ref.style.should == "peer"
-      ref.ptemplate.should == "reference_peer"
+      expect(ref.style).to eq("peer")
+      expect(ref.ptemplate).to eq("fe/reference_peer")
     end
     
     it 'customized' do 
       ref = create(:reference_question)
       ref.style = "abc"
-      ref.ptemplate.should == "reference_abc"
+      expect(ref.ptemplate).to eq("fe/reference_abc")
     end
   end
 end

data/spec/models/fe/reference_sheet_spec.rb

@@ -1,11 +1,11 @@
-require 'spec_helper'
+require 'rails_helper'
 
 describe Fe::ReferenceSheet do
-  it { should belong_to :question }  
-  it { should belong_to :applicant_answer_sheet }
-  # it { should validate_presence_of :first_name } # need to add started_at column
-  # it { should validate_presence_of :last_name } # need to add started_at column
-  # it { should validate_presence_of :phone } # need to add started_at column
-  # it { should validate_presence_of :email } # need to add started_at column
-  # it { should validate_presence_of :relationship } # need to add started_at column
+  it { expect belong_to :question }  
+  it { expect belong_to :applicant_answer_sheet }
+  # it { expect validate_presence_of :first_name } # need to add started_at column
+  # it { expect validate_presence_of :last_name } # need to add started_at column
+  # it { expect validate_presence_of :phone } # need to add started_at column
+  # it { expect validate_presence_of :email } # need to add started_at column
+  # it { expect validate_presence_of :relationship } # need to add started_at column
 end