RubyGems - fdlint - Versions diffs - 0.2.0.pre → 0.2.0 - Mend

fdlint 0.2.0.pre → 0.2.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (114) hide show

checksums.yaml +4 -4
data/Gemfile.lock +1 -1
data/README.md +36 -15
data/Rakefile +1 -1
data/bin/fdlint +30 -9
data/lib/fdlint/cli.rb +62 -10
data/lib/fdlint/helper/logger.rb +1 -1
data/lib/fdlint/log_entry.rb +14 -0
data/lib/fdlint/parser/html/html_parser.rb +10 -12
data/lib/fdlint/parser/html/query.rb +64 -50
data/lib/fdlint/parser/html/struct.rb +20 -3
data/lib/fdlint/parser/parser_visitable.rb +11 -5
data/lib/fdlint/printer/base_printer.rb +6 -0
data/lib/fdlint/printer/console_printer.rb +15 -23
data/lib/fdlint/rule.rb +4 -4
data/lib/fdlint/support/core/object.rb +6 -0
data/lib/fdlint/support/core_ext.rb +1 -0
data/lib/fdlint/validator.rb +60 -8
data/lib/fdlint/version.rb +1 -1
data/lib/hook/git_pre_commit +18 -0
data/rules.d/css.rule.rb +1 -1
data/rules.d/filename.rule.rb +3 -1
data/rules.d/html.rule.rb +45 -32
data/rules.d/js.rule.rb +2 -2
data/test/all_tests.rb +28 -42
data/test/css/mac_line_end_support_test.rb +10 -12
data/test/css/parser_test.rb +4 -5
data/test/css/rule/check_encoding_test.rb +7 -8
data/test/css/rule/check_list_rule_test.rb +85 -102
data/test/css/rule/file_name_test.rb +18 -39
data/test/default_test.rb +1 -14
data/test/fixtures/css/ad.css +0 -0
data/test/fixtures/css/adver/test.css +0 -0
data/test/fixtures/css/camelCase.css +0 -0
data/test/fixtures/css/min/ad.css +0 -0
data/test/fixtures/css/min/ad.min.css +0 -0
data/test/fixtures/html/mixed_log_levels.html +1 -0
data/test/fixtures/html/mixed_types.html +3 -0
data/test/helper.rb +116 -16
data/test/html/mixed_type_test.rb +14 -20
data/test/html/parser/parse_comment_test.rb +4 -4
data/test/html/parser/parse_dtd_test.rb +7 -7
data/test/html/parser/parse_script_tag_test.rb +21 -14
data/test/html/parser/parse_with_auto_close_tag_test.rb +12 -10
data/test/html/parser/parse_with_diff_case_test.rb +8 -9
data/test/html/parser/parse_with_emtpy_test.rb +5 -3
data/test/html/parser/parse_with_multi_children_test.rb +4 -4
data/test/html/parser/parse_with_multi_line_test.rb +5 -5
data/test/html/parser/parse_with_prop_test.rb +10 -10
data/test/html/parser/parse_with_script_tag_test.rb +4 -4
data/test/html/parser/parse_with_selfclosing_test.rb +11 -11
data/test/html/parser/parse_with_simple_tag_test.rb +7 -7
data/test/html/parser/parse_with_simple_tree_test.rb +6 -6
data/test/html/parser/parse_with_style_tag_test.rb +4 -4
data/test/html/parser/parse_with_text_test.rb +7 -7
data/test/html/parser_test.rb +19 -19
data/test/html/query_test.rb +18 -18
data/test/html/rule/check_block_level_element_test.rb +22 -24
data/test/html/rule/check_button_test.rb +9 -9
data/test/html/rule/check_css_in_head_test.rb +11 -32
data/test/html/rule/check_dtd_test.rb +15 -11
data/test/html/rule/check_form_element_name_test.rb +10 -9
data/test/html/rule/check_head_contain_meta_and_title_test.rb +28 -34
data/test/html/rule/check_hyperlink_with_target_test.rb +23 -17
data/test/html/rule/check_hyperlink_with_title_test.rb +13 -20
data/test/html/rule/check_id_n_class_downcase_test.rb +8 -19
data/test/html/rule/check_img_with_alt_prop_test.rb +11 -12
data/test/html/rule/check_no_import_css_test.rb +20 -20
data/test/html/rule/check_prop_have_value_test.rb +9 -13
data/test/html/rule/check_prop_seperator_test.rb +9 -13
data/test/html/rule/check_style_prop_test.rb +7 -12
data/test/html/rule/check_tag_closed_test.rb +15 -40
data/test/html/rule/check_tag_downcase_test.rb +31 -28
data/test/html/rule/check_unescape_char_test.rb +17 -17
data/test/html/rule/check_unique_import_test.rb +15 -33
data/test/html/rule_test.rb +2 -6
data/test/js/expr/expr.rb +1 -1
data/test/js/expr/left_hand.rb +1 -1
data/test/js/expr/operate.rb +1 -1
data/test/js/expr/primary.rb +1 -1
data/test/js/parser_test.rb +3 -6
data/test/js/rule/alert_check_test.rb +5 -19
data/test/js/rule/base_test.rb +5 -19
data/test/js/rule/jq_check_test.rb +26 -58
data/test/js/rule/nest_try_catch_test.rb +26 -43
data/test/js/rule/new_object_and_new_array_test.rb +5 -21
data/test/js/rule/no_eval_test.rb +3 -19
data/test/js/rule/no_global_test.rb +34 -73
data/test/js/rule/private_method_check_test.rb +14 -43
data/test/js/rule/semicolon_test.rb +18 -47
data/test/js/rule/stat_if_with_brace_test.rb +30 -53
data/test/js/rule/stat_if_with_muti_else_test.rb +36 -53
data/test/js/rule/use_strict_equal_test.rb +16 -29
data/test/js/rule_test.rb +2 -4
data/test/js/stat/if.rb +1 -1
data/test/js/stat/iter.rb +1 -1
data/test/js/stat/stat.rb +1 -1
data/test/js/stat/switch.rb +1 -1
data/test/js/stat/try.rb +1 -1
data/test/js/stat/var.rb +1 -1
data/test/parser_visitable_test.rb +14 -36
data/test/position_info_test.rb +4 -5
data/test/runner/log_level_test.rb +30 -25
metadata +11 -14
data/lib/fdlint/file_validator.rb +0 -38
data/lib/fdlint/parser/html/rule/check_tag_rule.rb +0 -80
data/test/css/rule/compression_test.rb +0 -53
data/test/html/rule/check_class_count_test.rb +0 -36
data/test/html/rule/check_html_template_test.rb +0 -103
data/test/js/rule/all_test.rb +0 -23
data/test/js/rule/file_checker_test.rb +0 -131
data/test/rule_dsl/dsl_basic_test.rb +0 -91
data/test/rule_dsl/importing_test.rb +0 -48
data/test/test_helper.rb +0 -9

data/test/html/rule/check_html_template_test.rb DELETED Viewed

@@ -1,103 +0,0 @@
-# encoding: utf-8
-require_relative '../../helper'
-require 'html/rule/check_tag_rule'
-module XRayTest
-  module HTML
-    module Rule
-      class CheckHTMLTemplateTest < Test::Unit::TestCase
-        include XRay::HTML
-        def setup
-          @rule = XRay::HTML::Rule::CheckTagRule.new
-          @head = %Q(<head>
-                  <meta charset="gbk"/>
-                  <title>阿里巴巴</title>
-                  <mea name="description" content="阿里巴巴批发大市场"/>
-                  <meta name="keywords" content="阿里巴巴,采购批发,1688,行业门户,网上贸易,b2b,电子商务"/>
-                  <link href="产品线merge.css" rel="stylesheet"/>
-                  <link href="页面merge.css" rel="stylesheet"/>
-                  <script src="产品线merge.js"></script>
-                  <base target="_blank"/>
-              </head>)
-          @doc = %Q(<div id="doc">
-                      <div id="alibar">alibar</div>
-                      <div id="header" class="w952">header</div>
-                      <div id="content" class="w952">content</div>
-                      <div id="footer">footer</div>
-                  </div>)
-          @body = %Q(<body>
-                  #{@doc}
-                  <script src="页面merge.js"></script>
-              </body>)
-          @html = %Q(<html lang="zh-CN">
-              #{@head}
-              #{@body}
-          </html>)
-        end
-        def test_check_right_tag
-          tag = parse(@html)
-          assert_equal [], @rule.check_html_tag(tag)
-        end
-        def test_check_missing_desc
-          tag = parse(@head.sub(/<meta name="description".*?\/>/m, ''))
-          assert_equal [["新页面按库中的HTML基本结构模板书写基本页面结构", :warn]], @rule.check_html_tag(tag)
-        end
-        def test_check_missing_keywords
-          tag = parse(@head.sub(/<meta name="keywords".*?\/>/m, ''))
-          assert_equal [["新页面按库中的HTML基本结构模板书写基本页面结构", :warn]], @rule.check_html_tag(tag)
-        end
-        def test_check_missing_doc
-          tag = parse(@body.sub(/<div id="doc"/m, '<div id="_doc"'))
-          assert_equal [["新页面按库中的HTML基本结构模板书写基本页面结构", :warn]], @rule.check_html_tag(tag)
-        end
-        def test_check_missing_alibar
-          tag = parse(@body.sub(/<div id="alibar"/m, '<div id="_alibar"'))
-          assert_equal [], @rule.check_html_tag(tag)
-          tag = parse(@doc.sub(/<div id="alibar"/m, '<div id="_alibar"'))
-          assert_equal [["新页面按库中的HTML基本结构模板书写基本页面结构", :warn]], @rule.check_html_tag(tag)
-        end
-        def test_check_missing_content
-          tag = parse(@body.sub(/<div id="content"/m, '<div id="_content"'))
-          assert_equal [], @rule.check_html_tag(tag)
-          tag = parse(@doc.sub(/<div id="content"/m, '<div id="_content"'))
-          assert_equal [["新页面按库中的HTML基本结构模板书写基本页面结构", :warn]], @rule.check_html_tag(tag)
-        end
-        def test_check_missing_footer
-          tag = parse(@body.sub(/<div id="footer"/m, '<div id="_footer"'))
-          assert_equal [], @rule.check_html_tag(tag)
-          tag = parse(@doc.sub(/<div id="footer"/m, '<div id="_footer"'))
-          assert_equal [["新页面按库中的HTML基本结构模板书写基本页面结构", :warn]], @rule.check_html_tag(tag)
-        end
-        def test_check_missing_header
-          tag = parse(@body.sub(/<div id="header"/m, '<div id="_header"'))
-          assert_equal [], @rule.check_html_tag(tag)
-          tag = parse(@doc.sub(/<div id="header"/m, '<div id="_header"'))
-          assert_equal [["新页面按库中的HTML基本结构模板书写基本页面结构", :warn]], @rule.check_html_tag(tag)
-        end
-        private
-        def parse(src)
-          XRay::HTML::Parser.parse(src)
-        end
-      end
-    end
-  end
-end

data/test/js/rule/all_test.rb DELETED Viewed

@@ -1,23 +0,0 @@
-require_relative '../../helper'
-require 'js/rule/all'
-module XRayTest
-  module JS
-    module Rule
-      class AllTest < Test::Unit::TestCase
-        def test_initialize
-          all = XRay::JS::Rule::All.new
-          assert all.respond_to?(:each)
-          assert all.size > 0
-          assert all.size == all.rules.size
-        end
-      end
-    end
-  end
-end

data/test/js/rule/file_checker_test.rb DELETED Viewed

@@ -1,131 +0,0 @@
-# encoding: utf-8
-require_relative 'base_test'
-require 'js/rule/file_checker'
-module XRayTest
-  module JS
-    module Rule
-      class FileCheckerTest < BaseTest
-        def setup
-          @checker = XRay::JS::Rule::FileChecker.new
-        end
-        def test_merge_file?
-          assert @checker.merge_file?('abc-merge.js')
-          assert @checker.merge_file?('abc-merge-12345.js')
-          assert @checker.merge_file?('abc-merge12345.js')
-          assert !@checker.merge_file?('abc-merge.css')
-          assert !@checker.merge_file?('abc-merge.jss')
-          assert !@checker.merge_file?('-merge.js')
-          assert !@checker.merge_file?('abc-mergeabc.js')
-          assert !@checker.merge_file?('abc-merge-.js')
-        end
-        def test_min_file?
-          assert @checker.min_file?('abc-min.js')
-          assert !@checker.min_file?('abc-min.jss')
-          assert !@checker.min_file?('-min.js')
-          assert !@checker.min_file?('abc-min1.js')
-        end
-        def test_grep_import_js_path
-          pathes = @checker.grep_import_js_path fixture_01
-          assert_equal 6, pathes.length
-          assert_equal %w(
-            http://style.china.alibaba.com/js/common/aliclick.js
-            http://style.china.alibaba.com/js/detail/xpclick.js
-            http://style.china.alibaba.com/js/lib/fdev-v4/widget/util/debug-min.js
-            http://style.china.alibaba.com/js/lib/fdev-v4/widget/web/alitalk-min.js
-            http://style.china.alibaba.com/js/lib/fdev-v4/widget/web/sweet-min.js
-            http://style.china.alibaba.com/js/lib/fdev-v4/widget/web/sweet-min.js
-          ), pathes.collect { |path| path[:url] }
-        end
-        def test_check_one_line_one_import
-          pathes = @checker.grep_import_js_path fixture_01
-          ret = []
-          pathes.each { |import|
-            r = @checker.check_js_merge_importing import, pathes, ""
-            ret.concat r
-          }
-          assert_equal [
-              ["merge文件需要引用压缩版的js, 如a-min.js", :warn, 12, 63],
-              ["merge文件需要引用压缩版的js, 如a-min.js", :warn, 13, 62],
-              ["一行只能有一个import文件", :error, 18, 96],
-              ["merge文件格式不正确", :error, 19, 1],
-              ["merge文件格式不正确", :error, 20, 1]
-            ], ret
-        end
-        def test_has_doc_comment
-          js = '
-            /**
-             * 功能文件头必须要有文档注释
-             * 现在没有对doc格式进行规范
-             * 所以暂时不做文档注释内容检查
-             * 只检则有注释
-             */
-            i++;
-          '
-          assert @checker.has_doc_comment?(js)
-          js = '
-            i++;
-          '
-          assert !@checker.has_doc_comment?(js)
-          js = '
-            /*
-             * 多行注释不属于文档注释
-             * 文档注释需要以/*开头
-             */
-          '
-          assert !@checker.has_doc_comment?(js)
-        end
-        def test_check_import_js_scope
-          #not implements
-        end
-        def test_check_import_js_exist_and_min
-          # not implements
-        end
-        def fixture_01
-<<END
-(function(){
-    ImportJavscript = {
-        url:function(url){
-            document.write('<script type="text/javascript" src="'+url+'"></scr'+'ipt>');
-        }
-    };
-})();
-/**
- * 打点依赖库
- */
-ImportJavscript.url('http://style.china.alibaba.com/js/common/aliclick.js');
-ImportJavscript.url(http://style.china.alibaba.com/js/detail/xpclick.js);
-/**
- * 旺铺基础JS
- */
-ImportJavscript.url("http://style.china.alibaba.com/js/lib/fdev-v4/widget/util/debug-min.js"); ImportJavscript.url("http://style.china.alibaba.com/js/lib/fdev-v4/widget/web/alitalk-min.js");
-ImportJavscript.url( 'http://style.china.alibaba.com/js/lib/fdev-v4/widget/web/sweet-min.js' ) ;
-ImportJavscript.url('http://style.china.alibaba.com/js/lib/fdev-v4/widget/web/sweet-min.js')
-END
-        end
-      end
-    end
-  end
-end

data/test/rule_dsl/dsl_basic_test.rb DELETED Viewed

@@ -1,91 +0,0 @@
-# encoding: utf-8
-require_relative '../helper'
-module XRayTest
-  module Rule
-    class DSLBasicTest < Test::Unit::TestCase
-      include ::XRay::Rule
-      def setup
-        @rule = Proc.new do |file|
-          @called = true
-          ["it's just a test", :warn]
-        end
-        @called = false
-        clear_all_rules
-        common
-      end
-      def test_add_file_checker
-        check_file &@rule
-        assert_contains file_rules, "available in common rules"
-        assert_contains css_rules, "common rules available in css rules too"
-        assert_contains css_file_rules, "common rules available in css file rules too"
-        assert_not_contains only_css_file_rules, "not available in css rules only"
-      end
-      def test_add_css_file_checker
-        css {
-          check_file &@rule
-        }
-        assert_not_contains file_rules, "not available in common rules"
-        assert_contains css_file_rules, "available in css rules"
-        assert_contains only_css_file_rules, "available in css only rules"
-      end
-      def test_check
-        check_file &@rule
-        assert_equal check_file("test"), [["it's just a test", :warn]]
-        assert @called
-      end
-      def test_named_checker
-        msg = ['we suggest use "-" instead', :info]
-        html {
-          check_file_with_underline do |file|
-            msg if file =~ /_/
-          end
-        }
-        results = check_file_with_underline 'a_b.html'
-        assert_equal msg, results
-      end
-      def test_normal_plus_named_checker
-        case_warn = ['must use downcase filename', :error]
-        check_file { |file|
-          case_warn if file =~ /[A-Z]/
-        }
-        msg = ['we suggest use "-" instead', :info]
-        html {
-          check_file_with_underline do |file|
-            msg if file =~ /_/
-          end
-        }
-        results = check_html_file 'a_B.html'
-        assert_equal [case_warn, msg], results
-      end
-      def assert_contains( rules, *msg )
-        assert has_rule?(rules), *msg
-      end
-      def assert_not_contains( rules, *msg)
-        assert !has_rule?(rules), *msg
-      end
-      def has_rule?( rules )
-        rules.any? {|r| r[:block] == @rule }
-      end
-    end
-  end
-end

data/test/rule_dsl/importing_test.rb DELETED Viewed

@@ -1,48 +0,0 @@
-# encoding: utf-8
-require_relative '../helper'
-module XRayTest
-  module Rule
-    class ImportingTest < Test::Unit::TestCase
-      include ::XRay::Rule
-      def setup
-        clear_all_rules
-      end
-      def test_import_with_symbol
-        import :css
-        assert css_rules.size > 0
-      end
-      def test_import_with_symbol_twice
-        assert_equal 0, css_rules.size
-        import :css
-        size = css_rules.size
-        assert size > 0
-        import :css
-        assert_equal size, css_rules.size
-      end
-      def test_import_all_twice
-        assert_equal 0, css_rules.size
-        import_all
-        size = css_rules.size
-        assert size > 0
-        import_all
-        assert_equal size, css_rules.size
-      end
-    end
-  end
-end

data/test/test_helper.rb DELETED Viewed

@@ -1,9 +0,0 @@
-require 'test/unit'
-# Add test libraries you want to use here, e.g. mocha
-class Test::Unit::TestCase
-  # Add global extensions to the test case class here
-end