fc-reminder 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 46f8b9493f347fb82cd5b4c1b564fae30bf9dec2
-  data.tar.gz: 99d6eba3ca72a76bb1ad00f25dee554955a9e564
+  metadata.gz: cca159110a9959b8f055afa009ff97423fb341ea
+  data.tar.gz: 6609136ee279419659d6a0418412b10c6e56737d
 SHA512:
-  metadata.gz: 2df74391defed1413c731f4f43119ecf6bff31b602e4ca94a9e749f0df1848fc028630df1d4364a6a30f188717e4c107fd92fd74c27fe10244a9bb76b6aa7304
-  data.tar.gz: 0a2af39818d43b8c228ee91abf1779156887a8c15ff829cfda93f3830adcaf246d4c707ae5d1b735a6e86a19fe61e1e12ce57344862630ba93efbc09fde45f67
+  metadata.gz: 0fe3acfc2161d6b9e401202077c8cc0b7ba1adb7411ca19a1f8139204ab387e22e63db429035ebe0c0156d20b89cd5f8c24f5923240ed99e7d7cc24e0c6cf915
+  data.tar.gz: 344c80303c1c06a00bf1d5ab77a6404524c9acde24160ed584dc9fda7c69f7f9eb01a38a3c2ac6ce6a776b438b2e6afdfb0a8039503f773e4306434181dc56e7

data/.travis.yml

@@ -1,4 +1,10 @@
 language: ruby
 rvm:
   - 2.0.0
-  - 2.1.0-preview1
+  - 2.1.0
+  - ruby-head
+  - rbx
+matrix:
+  allow_failures:
+    - rvm: ruby-head
+  fast_finish: true

data/Gemfile

@@ -1,3 +1,14 @@
 source 'http://rubygems.org'
 
+gem  'rake'
+
+group :test do
+  gem 'rspec', '~> 3.0.0.beta1'
+  gem 'fakeweb'
+end
+
+platforms :rbx do
+  gem 'rubysl', '~> 2.0'
+end
+
 gemspec

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2013, Kamil Kieliszczyk
+Copyright (c) 2013-2014, Kamil Kieliszczyk
 All rights reserved.
 
 Redistribution and use in source and binary forms, with or without modification,

data/README.md

@@ -72,6 +72,6 @@ Usage: fc-reminder [options] start|stop|restart|run
 
 ## Copyright and License
 
-Copyright (c) 2013, Kamil Kieliszczyk and Contributors. All Rights Reserved.
+Copyright (c) 2013-2014, Kamil Kieliszczyk and Contributors. All Rights Reserved.
 
 This project is licenced under the [BSD 3-Clause License](LICENSE).

data/Rakefile

@@ -1,9 +1,5 @@
 require 'rubygems'
 require 'bundler/gem_tasks'
-
-Bundler.setup(:default, :development)
-
-require 'rspec/core'
 require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec) do |spec|

data/fc-reminder.gemspec

@@ -7,7 +7,7 @@ Gem::Specification.new do |spec|
   spec.authors      = ['Kamil Kieliszczyk']
   spec.email        = ['kamil@kieliszczyk.net']
   spec.description  = 'Simple reminder about an upcoming football game'
-  spec.summary      = 'Simple reminder about an upcoming football game'
+  spec.summary      = spec.description
   spec.homepage     = 'https://github.com/kiela/fc-reminder'
 
   spec.platform = Gem::Platform::RUBY
@@ -25,7 +25,4 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'clockwork', '~> 0.7.0'
 
   spec.add_development_dependency 'bundler', '~> 1.3'
-  spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'rspec', '~> 3.0.0.beta1'
-  spec.add_development_dependency 'fakeweb'
 end

data/lib/fc-reminder/gateways/base.rb

@@ -3,7 +3,7 @@ module FCReminder
     class Base
       attr_accessor :config
 
-      def send(recipient: _, data: _)
+      def send(recipient, data)
       end
     end
   end

data/lib/fc-reminder/gateways/twilio.rb

@@ -3,7 +3,7 @@ require 'twilio-ruby'
 module FCReminder
   module Gateways
     class Twilio < Base
-      def send(recipient: recipient, data: data)
+      def send(recipient, data)
         client = ::Twilio::REST::Client.new(
           config[:account_sid],
           config[:auth_token]

data/lib/fc-reminder/providers/base.rb

@@ -15,7 +15,7 @@ module FCReminder
         ""
       end
 
-      def run(team_name: _)
+      def run(team_name)
         Hash.new
       end
     end

data/lib/fc-reminder/providers/livescore.rb

@@ -7,14 +7,14 @@ module FCReminder
         "#{BASE_URL}/soccer/#{Time.now.strftime("%Y-%m-%d")}"
       end
 
-      def run(team_name: team_name)
-        cell = search(page: client.get(url), team_name: team_name.downcase)
+      def run(team_name)
+        cell = search(client.get(url), team_name.downcase)
         cell.nil? ? super : prepare_output_from(cell)
       end
 
       private
 
-        def search(page: page, team_name: team_name)
+        def search(page, team_name)
           page.search(".content table.league-table td").find do |td|
             has_team?(td) and team_match?(td, team_name)
           end
@@ -30,12 +30,12 @@ module FCReminder
 
         def prepare_output_from(cell)
           r = Hash.new
-          r.merge!(fetch(attrs: league_attrs, source: cell.parent.parent))
-          r.merge!(fetch(attrs: match_attrs, source: cell.parent))
+          r.merge!(fetch(league_attrs, cell.parent.parent))
+          r.merge!(fetch(match_attrs, cell.parent))
           r
         end
 
-        def fetch(attrs: attrs, source: source)
+        def fetch(attrs, source)
           attrs.inject({}) { |h,(k,v)| h[k] = source.search(v).text.strip; h }
         end
 

data/lib/fc-reminder/reminder.rb

@@ -10,7 +10,7 @@ module FCReminder
     end
 
     def provider=(obj)
-      if obj.kind_of? Providers::Base
+      if obj.kind_of? FCReminder::Providers::Base
         @provider = obj
       else
         raise 'Provider should inherits from FCReminder::Providers::Base'
@@ -18,7 +18,7 @@ module FCReminder
     end
 
     def gateway=(obj)
-      if obj.kind_of? Gateways::Base
+      if obj.kind_of? FCReminder::Gateways::Base
         @gateway = obj
       else
         raise 'Gateway should inherits from FCReminder::Gateways::Base'
@@ -27,8 +27,8 @@ module FCReminder
 
     def run(&customization_block)
       eval_block &customization_block
-      result = provider.run(team_name: team_name)
-      gateway.send(recipient: recipient, data: result) unless result.empty?
+      result = provider.run(team_name)
+      gateway.send(recipient, result) unless result.empty?
     end
 
     private

data/lib/fc-reminder/runner.rb

@@ -48,9 +48,10 @@ module FCReminder
       end
 
       def process_name(options)
-        arr = [PROCESS_NAME]
-        arr.push(options[:identifier] ? options[:identifier] : options[:team])
-        arr.join('.')
+        [
+          PROCESS_NAME,
+          (options[:identifier] ? options[:identifier] : options[:team])
+        ].join('.')
       end
 
       def daemonize_options(options)

data/lib/fc-reminder/version.rb

@@ -1,3 +1,3 @@
 module FCReminder
-  VERSION = '0.1.1'
+  VERSION = '0.1.2'
 end

data/spec/fc-reminder/gateways/base_spec.rb

@@ -5,7 +5,7 @@ describe FCReminder::Gateways::Base do
 
   context "setters" do
     it "allows to set config attribute" do
-      config = {foo: 'bar'}
+      config = { foo: 'bar' }
       expect(gateway.config).to be_nil
       gateway.config = config
       expect(gateway.config).to eq(config)

data/spec/fc-reminder/providers/base_spec.rb

@@ -22,8 +22,8 @@ describe FCReminder::Providers::Base do
 
   context "#run" do
     it "returns empty instance of Hash" do
-      expect(provider.run(team_name: team_name)).to be_instance_of(Hash)
-      expect(provider.run(team_name: team_name)).to be_empty
+      expect(provider.run(team_name)).to be_instance_of(Hash)
+      expect(provider.run(team_name)).to be_empty
     end
   end
 end

data/spec/fc-reminder/providers/livescore_spec.rb

@@ -18,25 +18,25 @@ describe FCReminder::Providers::LiveScore do
 
   context "#run" do
     context "there is no match that day" do
-      before(:each) { fake_page_without_match(provider.url) }
+      before { fake_page_without_match(provider.url) }
 
       it "returns default value" do
-        default_value = FCReminder::Providers::Base.new.run(team_name: team_name)
-        expect(provider.run(team_name: team_name)).to eq(default_value)
+        default_value = FCReminder::Providers::Base.new.run(team_name)
+        expect(provider.run(team_name)).to eq(default_value)
       end
     end
 
     context "there is a match that day" do
-      before(:each) { fake_page_with_match(provider.url) }
+      before { fake_page_with_match(provider.url) }
 
       it "returns non-empty instance of Hash" do
-        expect(provider.run(team_name: team_name)).to be_an_instance_of(Hash)
-        expect(provider.run(team_name: team_name)).not_to be_empty
+        expect(provider.run(team_name)).to be_an_instance_of(Hash)
+        expect(provider.run(team_name)).not_to be_empty
       end
 
       %w(country league time team1 team2).each do |attr|
         it "has return value which includes #{attr}" do
-          expect(provider.run(team_name: team_name)).to have_key(attr.to_sym)
+          expect(provider.run(team_name)).to have_key(attr.to_sym)
         end
       end
     end

data/spec/fc-reminder/reminder_spec.rb

@@ -74,8 +74,8 @@ describe FCReminder::Reminder do
 
   context "#run" do
     subject(:reminder) { FCReminder.build }
-    before(:each) { fake_page_with_match(reminder.provider.url) }
-    before(:each) { reminder.gateway.stub(:send) {} }
+    before { fake_page_with_match(reminder.provider.url) }
+    before { allow(reminder.gateway).to receive(:send) }
 
     it "allows to set consumer data by using a block" do
       expect(reminder.team_name).to be_nil
@@ -92,8 +92,8 @@ describe FCReminder::Reminder do
     end
 
     it "calls provider for data" do
-      reminder.provider.stub(:run) { Hash.new }
-      expect(reminder.provider).to receive(:run).with(team_name: team_name)
+      allow(reminder.provider).to receive(:run).and_return(Hash.new)
+      expect(reminder.provider).to receive(:run).with(team_name)
 
       reminder.team_name = team_name
       reminder.recipient = recipient
@@ -102,11 +102,8 @@ describe FCReminder::Reminder do
 
     it "calls gateway for sending message" do
       result = {foo: 'bar'}
-      reminder.provider.stub(:run) { result }
-      expect(reminder.gateway).to receive(:send).with(
-        recipient: recipient,
-        data: result
-      )
+      allow(reminder.provider).to receive(:run).and_return(result)
+      expect(reminder.gateway).to receive(:send).with(recipient, result)
 
       reminder.team_name = team_name
       reminder.recipient = recipient

data/spec/fc-reminder/runner_spec.rb

@@ -29,32 +29,32 @@ describe FCReminder::Runner do
 
   context "#start" do
     it "sets reminder" do
-      options = {daemon: false}
+      options = { daemon: false }
       runner = FCReminder::Runner.new(options)
 
-      Clockwork.stub(:every) { |&block| block.call }
-      runner.reminder.stub(:run) {}
-      runner.stub(:run) {}
+      allow(Clockwork).to receive(:every) { |&block| block.call }
+      allow(runner.reminder).to receive(:run)
+      allow(runner).to receive(:run)
 
       expect(runner.reminder).to receive(:run)
       runner.start
     end
 
     it "starts normal process" do
-      options = {daemon: false}
+      options = { daemon: false }
       runner = FCReminder::Runner.new(options)
 
-      runner.stub(:run) {}
+      allow(runner).to receive(:run)
 
       expect(runner).to receive(:run)
       runner.start
     end
 
     it "starts daemon process" do
-      options = {daemon: true}
+      options = { daemon: true }
       runner = FCReminder::Runner.new(options)
 
-      runner.stub(:daemonize) {}
+      allow(runner).to receive(:daemonize)
 
       expect(runner).to receive(:daemonize)
       runner.start

data/spec/spec_helper.rb

@@ -4,3 +4,11 @@ $:.unshift File.join(GEM_ROOT, "lib")
 require 'fc-reminder'
 Dir[File.join(GEM_ROOT, "spec", "support", "**/*.rb")].each { |f| require f }
 
+RSpec.configure do |config|
+  config.expect_with :rspec do |c|
+    c.syntax = :expect
+  end
+
+  config.filter_run focus: true
+  config.run_all_when_everything_filtered = true
+end

metadata

@@ -1,141 +1,99 @@
 --- !ruby/object:Gem::Specification
 name: fc-reminder
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Kamil Kieliszczyk
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-03 00:00:00.000000000 Z
+date: 2014-02-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mechanize
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 2.7.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 2.7.3
 - !ruby/object:Gem::Dependency
   name: twilio-ruby
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 3.11.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 3.11.4
 - !ruby/object:Gem::Dependency
   name: mixlib-cli
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.3.0
 - !ruby/object:Gem::Dependency
   name: daemons
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.1.9
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 1.1.9
 - !ruby/object:Gem::Dependency
   name: clockwork
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.7.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.7.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 3.0.0.beta1
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 3.0.0.beta1
-- !ruby/object:Gem::Dependency
-  name: fakeweb
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
 description: Simple reminder about an upcoming football game
 email:
 - kamil@kieliszczyk.net
@@ -144,9 +102,9 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .travis.yml
+- ".gitignore"
+- ".rspec"
+- ".travis.yml"
 - Gemfile
 - LICENSE
 - README.md
@@ -182,17 +140,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.11
+rubygems_version: 2.2.0
 signing_key: 
 specification_version: 4
 summary: Simple reminder about an upcoming football game