fbe 0.8.0 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 485d65ab1a72472bc118062f665516e8092e0f35b6b566acf567cad26259944c
-  data.tar.gz: c558708f7897da86b6c2133154cfb5861aa6fd1aeef8686eb109290de43b7b03
+  metadata.gz: bdf5c399cce9ed9558af9ad5ae54c5acc4da5a0461bbe6e7b09d430cba4dd481
+  data.tar.gz: 99a06827b9b501288146d1ce2e2d65169ca57e8f292ca1e9c481d935e5475cec
 SHA512:
-  metadata.gz: 684d4072dbe3ae3fc6043abbeddf6e0cce131948516df23a64b784777fa6a9a63e11e9eb09880116a4376be7d5292b2df983d472ae8d12bed00ea75c434a7c62
-  data.tar.gz: 56469e2fa299e1b411415b787b2edd3d19e75a7850a7a737dfb427505e8ec1c924a9e7935709d6bb05d13247e453eec25a5c5da84b7df15e9a5f4f29bf6f2dbf
+  metadata.gz: da68e83a59fe793f173802db1df9e13f0c2a5a6845bec43023416769b3a8d41672a06b176508dc20ff2f0d841a9a0e2e55c551101cfd18ecf65edc1e6ca78af7
+  data.tar.gz: e8a9db23f68d6f368db568a66b3461e21402ee971a2d1620377a1605ab2b5883c70f8057a178ba57325447a47efd1027d0b34f8f54d6b6acbf59f9ac9e31d80f

data/.rubocop.yml

@@ -54,4 +54,3 @@ Metrics/ParameterLists:
   Enabled: false
 Layout/MultilineAssignmentLayout:
   Enabled: true
-require: []

data/Gemfile.lock

@@ -58,7 +58,7 @@ GEM
     bigdecimal (3.1.9)
     builder (3.3.0)
     concurrent-ruby (1.3.5)
-    connection_pool (2.5.0)
+    connection_pool (2.5.1)
     crack (1.0.0)
       bigdecimal
       rexml
@@ -99,7 +99,7 @@ GEM
     fiber-storage (1.0.1)
     gli (2.22.2)
       ostruct
-    graphql (2.5.3)
+    graphql (2.5.4)
       base64
       fiber-storage
       logger
@@ -111,7 +111,7 @@ GEM
       concurrent-ruby (~> 1.0)
     iri (0.10.0)
     json (2.10.2)
-    judges (0.39.2)
+    judges (0.41.0)
       backtrace (~> 0)
       baza.rb (~> 0)
       concurrent-ruby (~> 1.2)
@@ -143,13 +143,13 @@ GEM
     multipart-post (2.4.1)
     net-http (0.6.0)
       uri
-    nokogiri (1.18.7-arm64-darwin)
+    nokogiri (1.18.8-arm64-darwin)
       racc (~> 1.4)
-    nokogiri (1.18.7-x64-mingw-ucrt)
+    nokogiri (1.18.8-x64-mingw-ucrt)
       racc (~> 1.4)
-    nokogiri (1.18.7-x86_64-darwin)
+    nokogiri (1.18.8-x86_64-darwin)
       racc (~> 1.4)
-    nokogiri (1.18.7-x86_64-linux-gnu)
+    nokogiri (1.18.8-x86_64-linux-gnu)
       racc (~> 1.4)
     obk (0.3.2)
     octokit (9.2.0)
@@ -175,7 +175,7 @@ GEM
     regexp_parser (2.10.0)
     retries (0.0.5)
     rexml (3.4.1)
-    rubocop (1.75.2)
+    rubocop (1.75.3)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)

data/assets/bylaws/code-contribution-was-rewarded.liquid

@@ -46,10 +46,17 @@
     (let comments_k {{ 0.1 | times: anger }})
     (let comments_max -16)
     (let comments_min -4)
-    (set bonus_for_comments (times comments (times -1 comments_k)))
+    (let comments_threshold {{ 16 | divided_by: paranoia }})
+    (set bonus_for_comments
+      (if
+        (gt comments comments_threshold)
+        (times comments (times -1 comments_k))
+        0
+      )
+    )
     (set bonus_for_comments (between bonus_for_comments comments_min comments_max))
-    (give bonus_for_comments "for too many (${comments}) comments that were made during review")
-    "deduct ${comments_k} points for every comment made during review, but not more than ${comments_max} points")
+    (give bonus_for_comments "for too many (${comments} > ${comments_threshold}) comments that were made during review")
+    "deduct ${comments_k} points for every comment above ${comments_threshold} made during review, but not more than ${comments_max} points")
 
   (aka
     (let few_hoc_fee {{ 4 | times: anger }})

data/lib/fbe/award.rb

@@ -91,7 +91,9 @@ class Fbe::Award
           raise "Failure in #{o}: #{e.message}"
         end
       when :let, :set
-        bill.set(@operands[0], to_val(@operands[1], bill))
+        v = to_val(@operands[1], bill)
+        raise "Can't #{@op.inspect} #{@operands[0].inspect} to nil" if v.nil?
+        bill.set(@operands[0], v)
       when :give
         text = @operands[1]
         text = '' if text.nil?
@@ -108,7 +110,7 @@ class Fbe::Award
         any.calc(bill)
       elsif any.is_a?(Symbol)
         v = bill.vars[any]
-        raise "Unknown name '#{any}' among [#{bill.vars.keys.join(', ')}]" if v.nil?
+        raise "Unknown name #{any.inspect} among: #{bill.vars.keys.map(&:inspect).join(', ')}" if v.nil?
         v
       else
         any

data/lib/fbe/octo.rb

@@ -96,13 +96,16 @@ def Fbe.octo(options: $options, global: $global, loog: $loog)
         end
 
         def user_name_by_id(id)
+          raise 'The ID of the user is nil' if id.nil?
+          raise 'The ID of the user must be an Integer' unless id.is_a?(Integer)
           json = @origin.user(id)
-          name = json[:login]
+          name = json[:login].downcase
           @loog.debug("GitHub user ##{id} has a name: @#{name}")
           name
         end
 
         def repo_id_by_name(name)
+          raise 'The name of the repo is nil' if name.nil?
           json = @origin.repository(name)
           id = json[:id]
           @loog.debug("GitHub repository #{name.inspect} has an ID: ##{id}")
@@ -110,8 +113,10 @@ def Fbe.octo(options: $options, global: $global, loog: $loog)
         end
 
         def repo_name_by_id(id)
+          raise 'The ID of the repo is nil' if id.nil?
+          raise 'The ID of the repo must be an Integer' unless id.is_a?(Integer)
           json = @origin.repository(id)
-          name = json[:full_name]
+          name = json[:full_name].downcase
           @loog.debug("GitHub repository ##{id} has a name: #{name}")
           name
         end

data/lib/fbe.rb

@@ -10,5 +10,5 @@
 # License:: MIT
 module Fbe
   # Current version of the gem (changed by +.rultor.yml+ on every release)
-  VERSION = '0.8.0' unless const_defined?(:VERSION)
+  VERSION = '0.9.0' unless const_defined?(:VERSION)
 end

data/test/fbe/test_octo.rb

@@ -51,6 +51,28 @@ class TestOcto < Fbe::Test
     assert_equal(100, o.rate_limit.remaining)
   end
 
+  def test_reads_nickname_by_id
+    WebMock.disable_net_connect!
+    global = {}
+    o = Fbe.octo(loog: Loog::NULL, global:, options: Judges::Options.new)
+    stub_request(:get, 'https://api.github.com/user/42').to_return(
+      body: { login: 'Dude56' }.to_json, headers: { 'Content-Type': 'application/json' }
+    )
+    nick = o.user_name_by_id(42)
+    assert_equal('dude56', nick)
+  end
+
+  def test_reads_repo_name_by_id
+    WebMock.disable_net_connect!
+    global = {}
+    o = Fbe.octo(loog: Loog::NULL, global:, options: Judges::Options.new)
+    stub_request(:get, 'https://api.github.com/repositories/42').to_return(
+      body: { full_name: 'Foo/bar56-Ff' }.to_json, headers: { 'Content-Type': 'application/json' }
+    )
+    nick = o.repo_name_by_id(42)
+    assert_equal('foo/bar56-ff', nick)
+  end
+
   def test_caching
     WebMock.disable_net_connect!
     global = {}

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: fbe
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.9.0
 platform: ruby
 authors:
 - Yegor Bugayenko
 bindir: bin
 cert_chain: []
-date: 2025-04-18 00:00:00.000000000 Z
+date: 2025-04-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: backtrace